Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
I'm using a stock download of 2.0.3. Oh how I dream of finding the missing manual for Maven 2 command line options :( -- James Mitchell On Apr 6, 2006, at 1:25 AM, Wendy Smoak wrote: On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: I was pleasantly surprised (after making my chan

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > I was pleasantly surprised (after making my changes to the 4 or 5 > tests in core) to run 'mvn install' in struts/action/build/ and see > the reactor kick off and fully build/test/install all/some of SAF. > Same for compile, test, and a few ot

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > Why 2.0.4? Building from source?!? Jeez! At least I'm not _that_ > bad ;) Because 2.0.3 had some serious regressions, and it was just as easy to grab the 2.0.4 release candidate as to go back to 2.0.2. It's the plugins I'm building from so

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
Why 2.0.4? Building from source?!? Jeez! At least I'm not _that_ bad ;) I'm more inclined to work on a Maven 2 build and just remove whatever is in our way (e.g. failing tests, bad reports due to incomplete plugins, etc) to get to a distributable release. What do you think? -- James Mi

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
That is probably what we would have done if we hadn't had to deal with the {subproject}/build having to be svn:externals-ized into each one. I was pleasantly surprised (after making my changes to the 4 or 5 tests in core) to run 'mvn install' in struts/action/build/ and see the reactor ki

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > Notice the console outputs "FAILURE !!", which make it pretty easy to > spot ;) I notice it, I'm just not seeing it here. FWIW, I'm using a snapshot of Maven 2.0.4 and quite a few plugins built from source. Maven 2 is still a work in progre

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
Before my changes, they fail for me on maven 1, when instrumented for jcoverage (which is the case for the 'dist' target) and maven 2 when run normally (mvn install). Maven 1 --- ... ... [junit] Running org.apache.struts.action.TestActionRedirect [junit] Tests run: 5, Failures:

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, James Mitchell <[EMAIL PROTECTED]> wrote: > Also, I'm about to start another thread related to our build...it is > (more or less) notes as I go through the various project.xml, > pom.xml, etc, etc for each of the pieces of the action1 puzzle. What do you think about moving the build fi

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Wendy Smoak
On 4/5/06, Don Brown <[EMAIL PROTECTED]> wrote: > Weird, so your Maven thinks that the tests fail? The tests pass for me, for > the core module anyways. The tests don't fail for me, either. They're just noisy with stack traces. Don, 'maven nightly' continues to work fine here. I deleted org.

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Don Brown
James Mitchell wrote: Funny you should mention this now. About 10 minutes ago I (locally) commented the failing tests out (actually, I put 'no' in front of the failing testFoo methods, so it looks like 'notestFoo') so I could 'mvn eclipse:eclipse' core, taglib, and extras. I'm not sure why t

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
Funny you should mention this now. About 10 minutes ago I (locally) commented the failing tests out (actually, I put 'no' in front of the failing testFoo methods, so it looks like 'notestFoo') so I could 'mvn eclipse:eclipse' core, taglib, and extras. I'm not sure why the output of the tes

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread Don Brown
The "nightly" maven goal isn't working for me. It doesn't seem to be correctly executing the jar:install goal, causing other artifact builds to fail due to missing dependencies. Perhaps someone seems something I'm missing from this snippet from a nightly build: +--

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-05 Thread James Mitchell
.current is now .gone and so now I just need to fix the good one to actually work correctly and we'll have our nightlies back. -- James Mitchell On Apr 4, 2006, at 1:01 PM, James Mitchell wrote: I believe the .current one is an older copy. I'll clean that up shortly. -- James Mitchell

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-04 Thread James Mitchell
I believe the .current one is an older copy. I'll clean that up shortly. -- James Mitchell On Apr 3, 2006, at 6:26 PM, Wendy Smoak wrote: On 4/3/06, James Mitchell <[EMAIL PROTECTED]> wrote: The 'actual' shell script that gets run nightly via cron is not under svn. Since we run nightli

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-03 Thread Wendy Smoak
On 4/3/06, James Mitchell <[EMAIL PROTECTED]> wrote: > The 'actual' shell script that gets run nightly via cron is not under > svn. Since we run nightlies on our zone, it is merely a copy of the > one under svn and as changes come in, I review and then update my > copy. It's probably an unnecessa

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-03 Thread Don Brown
James Mitchell wrote: Once we iron out action1 directories, I'll get that back online, but I'd like to wait till the dust settles before I pick up incubator/action2 nightly builds. If you are referring to the webwork2 incubated code, the only question mark in my mind relating to the build is

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-03 Thread James Mitchell
The 'actual' shell script that gets run nightly via cron is not under svn. Since we run nightlies on our zone, it is merely a copy of the one under svn and as changes come in, I review and then update my copy. It's probably an unnecessary level of security, but as long as my name and ASF

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-03 Thread Wendy Smoak
On 4/3/06, Don Brown <[EMAIL PROTECTED]> wrote: > Also, I'm hoping the nightly build scripts will be unaffected, although > I'd kinda be surprised. Let me know any way I can help fix them, if > they are indeed broken. It looks like Craig's are okay, but not the Maven-built ones. I made a change

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-03 Thread Don Brown
To add to that, I'll update the website to reflect the changes as soon as they are all done. The only major one pending is the scripting move, which I want to give a day or two to get any possible feedback. Also, I'm hoping the nightly build scripts will be unaffected, although I'd kinda be s

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-02 Thread Wendy Smoak
To summarize the reorganization, (thanks, Don!) the 'current' svn:externals definition now contains: action, scripting, sandbox, shale, tiles and site. (I believe Don will also be moving scripting underneath action at some point.) Action builds several jars: struts-core, struts-extras, strut

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-04-01 Thread Wendy Smoak
On 4/1/06, Don Brown <[EMAIL PROTECTED]> wrote: > I don't think anything. If you are happy with it, I can make the > changes tomorrow. The structure in the test repo looks fine to me. > I'd like to get a test release for Struts Action by > Sunday, even if it isn't a voted on one. I'm aiming fo

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Don Brown
Wendy Smoak wrote: Did you get what's in the test repo to build for you? It ('maven nightly') works fine for me. I wasn't able to get it working at work. I'll try again tomorrow from this computer. * http://svn.apache.org/repos/test/action1 What else needs to be done? I don't think

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Wendy Smoak
On 3/31/06, Don Brown <[EMAIL PROTECTED]> wrote: > Oh, one other thing - what about tiles? I noticed tiles has its own build > now, so can I then assume it is standalone? The Struts Tiles build is separate. I did that when I changed the groupId, in anticipation of this reorg. However, struts-

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Don Brown
Ok, moving to struts-action. I tried changing paths, but the jars still aren't installing themselves, making it so only action will build. I'll keep trying, but I have this suspicion that you could fix this in about 5 minutes when you get home :) Overall, I'm happy with the way it looks and s

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Wendy Smoak
On 3/31/06, Don Brown <[EMAIL PROTECTED]> wrote: > I suppose the directory could be called 'action', but it seems > kinda silly to have 'action/trunk/action'. 'core' seems to be > what other projects like Cocoon, MyFaces, Shale, etc., are using, I'm fine with 'core', as long as the directory na

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Wendy Smoak
On 3/31/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: > Is it going to be struts-core.jar, then? It seems confusing to have a > directory called 'core' build an artifact called 'struts-action'. {sees Don svn mv core/* ../ in r151397} No, that's not what I meant. I was only commenting on the name

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Don Brown
Wendy Smoak wrote: Is it going to be struts-core.jar, then? It seems confusing to have a directory called 'core' build an artifact called 'struts-action'. I suppose the directory could be called 'action', but it seems kinda silly to have 'action/trunk/action'. 'core' seems to be what other p

Re: Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Wendy Smoak
On 3/31/06, Don Brown <[EMAIL PROTECTED]> wrote: > Ok, you asked for it... :) I put my first cut at > https://svn.apache.org/repos/test/action1 I moved the subprojects under > action1, action as core, and adjusted the builds so that they all shared the > same version. Oh, sure, do it now whi

Action 1 consolidation testing (was Towards a stable 1.3 release)

2006-03-31 Thread Don Brown
Wendy Smoak wrote: There were no objections to your proposed reorganization, so IMO the thing to do is try it and see what happens. Preferably in the test repo. :) We don't need history for this, so svn export/svn import should do it. (https://svn.apache.org/repos/test) If not, maybe Sean can