Re: Moving struts assembly to a profile

2009-04-24 Thread Wes Wannemacher
Rene, I went ahead and did it yesterday. Now, if you want to build everything except mirror the wiki and zip up everything, just do - mvn clean install -DskipAssembly I know in my case, it shaves off 10 minutes from a 15 minute build. -Wes On Fri, Apr 24, 2009 at 11:57 AM, Rene Gielen wrote:

Re: Moving struts assembly to a profile

2009-04-24 Thread Rene Gielen
+42.5 at least ... Rainer Hermanns schrieb: > Wes, > > +42, please do so... that was disturbing me as well a lot :) > The build takes currently "forever", just to download all the docs. > > Thanks, > Rainer > >> Hey guys, >> >> Unless someone can raise a decent reason not to do it, I'd like to

Re: Moving struts assembly to a profile

2009-04-24 Thread Rene Gielen
Great, I built a few times yesterday and wasn't aware of the already existing change. This is a real time (and nerve..) saver! BTW, did not know that property inversion with ! works. Always good to have a Maven guru on board *wavingHandsTowardsWendy* Wes Wannemacher schrieb: > Rene, > > I went a

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
That's perfect, I have added a profile and look for a property called skipAssembly... I'm going to check the wiki and see where to put info on it. Once I update the doco, I'll commit it. -Wes On Thu, Apr 23, 2009 at 2:02 PM, Wendy Smoak wrote: > On Thu, Apr 23, 2009 at 10:53 AM, Musachy Barroso

Re: Moving struts assembly to a profile

2009-04-23 Thread Wendy Smoak
On Thu, Apr 23, 2009 at 10:53 AM, Musachy Barroso wrote: > The easiest thing we can do is to keep everything in by default, so > releases are easy. And just add a profile that excludes assembly, that > should work for everyone. If it's in the list of modules in the default build, you can't get ri

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
yep, agreed, I'll do it right now -Wes On Thu, Apr 23, 2009 at 1:53 PM, Musachy Barroso wrote: > The easiest thing we can do is to keep everything in by default, so > releases are easy. And just add a profile that excludes assembly, that > should work for everyone. > > musachy > > On Thu, Apr 23

Re: Moving struts assembly to a profile

2009-04-23 Thread Musachy Barroso
The easiest thing we can do is to keep everything in by default, so releases are easy. And just add a profile that excludes assembly, that should work for everyone. musachy On Thu, Apr 23, 2009 at 1:24 PM, Wes Wannemacher wrote: > I can live with that, but you might have to help set it up... I d

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
I can live with that, but you might have to help set it up... I don't know how to do an activation outside of a profile. Right now, assembly is a module invoked when you run 'mvn install' from the top-level. Do you mind setting it up so that we have a property, when defined, skips the assembly phas

Re: Moving struts assembly to a profile

2009-04-23 Thread Wendy Smoak
On Thu, Apr 23, 2009 at 9:42 AM, Wes Wannemacher wrote: > I'm not moving it to a plugin, I was going to move it to a profile. Sorry, typo. :) I meant 'profile'. > I was testing a simple change (you can see below). Basically, 'mvn clean > install' will build everything and install it all into yo

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
I'm not moving it to a plugin, I was going to move it to a profile. I was testing a simple change (you can see below). Basically, 'mvn clean install' will build everything and install it all into your ~/.m2/repo But, if you do 'mvn -Pall,assembly clean install' it will also build the zips. The pr

Re: Moving struts assembly to a profile

2009-04-23 Thread Musachy Barroso
that's an excellent idea. musachy On Thu, Apr 23, 2009 at 12:32 PM, Wendy Smoak wrote: > On Thu, Apr 23, 2009 at 5:52 AM, Wes Wannemacher wrote: > >> Unless someone can raise a decent reason not to do it, I'd like to >> move the assembly in the struts2 build into it's own profile. I don't >> mi

Re: Moving struts assembly to a profile

2009-04-23 Thread Wendy Smoak
On Thu, Apr 23, 2009 at 5:52 AM, Wes Wannemacher wrote: > Unless someone can raise a decent reason not to do it, I'd like to > move the assembly in the struts2 build into it's own profile. I don't > mind Hudson and Bamboo creating the zips through the assembly module, > but I like to keep up-to-d

Re: Moving struts assembly to a profile

2009-04-23 Thread Musachy Barroso
yeah that is fine Wes. When we re-organized the poms to make it easier to build, we said we could add profiles later. When you change it, please update the wiki that describes the release process. musachy On Thu, Apr 23, 2009 at 9:41 AM, Wes Wannemacher wrote: > On Thu, Apr 23, 2009 at 9:30 AM,

Re: Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
On Thu, Apr 23, 2009 at 9:30 AM, Rainer Hermanns wrote: > Wes, > > +42, please do so... that was disturbing me as well a lot :) > The build takes currently "forever", just to download all the docs. > > Thanks, > Rainer > Yeah, when it's hudson pulling docs from apache hardware to apache hardware,

Re: Moving struts assembly to a profile

2009-04-23 Thread Rainer Hermanns
Wes, +42, please do so... that was disturbing me as well a lot :) The build takes currently "forever", just to download all the docs. Thanks, Rainer > Hey guys, > > Unless someone can raise a decent reason not to do it, I'd like to > move the assembly in the struts2 build into it's own profile.

Moving struts assembly to a profile

2009-04-23 Thread Wes Wannemacher
Hey guys, Unless someone can raise a decent reason not to do it, I'd like to move the assembly in the struts2 build into it's own profile. I don't mind Hudson and Bamboo creating the zips through the assembly module, but I like to keep up-to-date and running mvn clean install -Pall on my machine t