Re: Override interceptors in struts-default from plugin

2007-08-09 Thread Nils-Helge Garli
Only the workflow interceptors. The problem is that when switching portlet modes with portlet controls, the render state sticks between the requests (it's a part of the JSR168 spec I've never understood why). So if there were a validation error on the previous request, the workflow interceptor

Re: Override interceptors in struts-default from plugin

2007-08-09 Thread Ted Husted
Hmmm, should what be skipped? Any interceptor? Java request-scope attribute or HTTP request parameter? In Struts 1, we had a boolean HTTP request parameter (generated by a tag) that allowed validation to be skipped, which we later designated a security issue, since anyone who learned the magic wor

Re: Override interceptors in struts-default from plugin

2007-08-08 Thread Nils-Helge Garli
YikesSounds like there's more than a simple fix needed... Maybe it's safer (for now, I'm pretty sure that I will bump into this problem later) to just modify the workflow interceptors? What I need is a simple check for a Boolean request attribute indicating if it should be skipped or not. It's

Re: Override interceptors in struts-default from plugin

2007-08-07 Thread Don Brown
Ok, here is the wierdness - yes, you can override interceptor stacks, kinda, only it doesn't work how you might expect. If you define an override in a subpackage, it not only overrides it for that subpackage (and its children), but overrides it in the parent as well. This is kinda a pain in Confl

Re: Override interceptors in struts-default from plugin

2007-08-07 Thread Nils-Helge Garli
I might have, if it's still hosted at opensymphony? If implemented, what do you feel would be the best way to do it? Override by default if there's an interceptor with the same name in a sub-package, or add an attribute to the xml configuration syntax (which I assume would require a new schema/DTD)

Re: Override interceptors in struts-default from plugin

2007-08-07 Thread James Holmes
Having the ability to override makes sense to me. I haven't looked into how complicated this would be to implement though. It will probably have to occur at the XWork level. Do you have committer access there? James On Tue Aug 7 10:07 , 'Nils-Helge Garli' <[EMAIL PROTECTED]> sent: >Hm...that w

Re: Override interceptors in struts-default from plugin

2007-08-07 Thread Nils-Helge Garli
Hm...that was not the answer I wanted ;) That's unecessary duplication of xml, and it requires manual synchronization of the interceptor stacks... It might be that the portlet plugin is the only plugin with this need, but to me it seems like a good feature to be able to override interceptors, maybe

Re: Override interceptors in struts-default from plugin

2007-08-07 Thread Don Brown
Yes, I'd say you will need to redefine the stacks users of the portlet plugin can use. Don On 8/7/07, Nils-Helge Garli <[EMAIL PROTECTED]> wrote: > Hi! > > In the portlet plugin, I need to customize the workflow interceptors. > So I have extended them, and added them to the struts-plugin file wit