Re: XWork test failures

2009-03-17 Thread Lukasz Lenart
I committed pom.xml with excluded URUtilTest, that solved all the problems and also updated Surefire plugin to version 2.4.2 Regards -- Lukasz http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.or

Re: XWork test failures

2009-03-14 Thread Lukasz Lenart
2009/3/13 Wes Wannemacher : > On Thursday 12 March 2009 19:35:37 Musachy Barroso wrote: >> Yeah, I have to find a better way to test those dumb URLs with weird >> protocols. Is there a problem running with "pertest"? > I don't see a problem with it, so long as we know why we're doing it. The key >

Re: XWork test failures

2009-03-13 Thread Lukasz Lenart
2009/3/13 Musachy Barroso : > Me forgetting something? pfft, what are we talking about again? :D:D:D:D Regards -- Lukasz http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional comm

Re: XWork test failures

2009-03-12 Thread Musachy Barroso
On Thu, Mar 12, 2009 at 8:06 PM, Wes Wannemacher wrote: > It'd probably be sufficient to file a JIRA against it, just so that we don't > forget in the future that we should fix it up. Me forgetting something? pfft, what are we talking about again? musachy -- "Hey you! Would you help me to carry

Re: XWork test failures

2009-03-12 Thread Wes Wannemacher
On Thursday 12 March 2009 19:35:37 Musachy Barroso wrote: > Yeah, I have to find a better way to test those dumb URLs with weird > protocols. Is there a problem running with "pertest"? > > musachy > I don't see a problem with it, so long as we know why we're doing it. The key seems to be in the j

Re: XWork test failures

2009-03-12 Thread Musachy Barroso
Yeah, I have to find a better way to test those dumb URLs with weird protocols. Is there a problem running with "pertest"? musachy On Thu, Mar 12, 2009 at 6:26 PM, Lukasz Lenart wrote: > 2009/3/1 Lukasz Lenart : >> I found solution, just set fork mode to pretest, like below >> >> pertest >> >> b

Re: XWork test failures

2009-03-12 Thread Lukasz Lenart
2009/3/1 Lukasz Lenart : > I found solution, just set fork mode to pretest, like below > > pertest > > but I think it isn't a real solution. The real problem is with URLUtilTest.setUp(), in such method URL.setURLStreamHandlerFactory() is called to setup some test factory, which always return null.

Re: XWork test failures

2009-02-27 Thread Wes Wannemacher
On Friday 27 February 2009 02:37:39 Lukasz Lenart wrote: > > ehhh... sorry but I don't understand, I have already account in JIRA > or you are talking about something else? Another thing, I sent my CLA > months ago to apache.org and didn't get any answer, what can I do > else? > Sorry Lukasz, I th

Re: XWork test failures

2009-02-27 Thread Lukasz Lenart
When I updated my local copy, such tests below are failing, before that, there wasn't any problem testGetSnippetNoPadding(com.opensymphony.xwork2.util.location.LocationImplTest) testGetSnippet(com.opensymphony.xwork2.util.location.LocationImplTest) testParserWithBadXML(com.opensymphony.xwork2.vali

Re: XWork test failures

2009-02-27 Thread Musachy Barroso
AM > Subject: Re: XWork test failures > To: Lukasz Lenart > > > That build ran without any forkmode setting... Here is how Hudson ran it - > > [xwork] $ /home/hudson/tools/java/latest1.6/bin/java -Xms128m -Xmx768m > -XX:MaxPermSize=256m -XX:PermSize=128m [-cp classpath snip

Fwd: XWork test failures

2009-02-27 Thread Wes Wannemacher
Ooops, only replied to Lukasz the first time, here's some additional info - -- Forwarded message -- From: Wes Wannemacher Date: Fri, Feb 27, 2009 at 9:39 AM Subject: Re: XWork test failures To: Lukasz Lenart That build ran without any forkmode setting... Here is how H

Re: XWork test failures

2009-02-27 Thread Lukasz Lenart
2009/2/27 Wes Wannemacher : > http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/ > > There are some new tests failing :( > > It appears related, I'll check into it, if I don't fall asleep first. Could you remove the setting for forkMode? I think this can be related to (from [1]): Chec

Re: XWork test failures

2009-02-26 Thread Lukasz Lenart
2009/2/27 Wes Wannemacher : > http://hudson.zones.apache.org/hudson/view/Struts/job/xwork2/5/ > > There are some new tests failing :( > > It appears related, I'll check into it, if I don't fall asleep first. They base on additional jar files added to classpath with Surefire and it looks like that

Re: XWork test failures

2009-02-26 Thread Lukasz Lenart
2009/2/27 Wes Wannemacher : >> Jared means xwork config files in JAR files ;-) I changed the name to >> be more readable. > > I was just messing around... You know, being a spelling nazi, I assumed you > meant jarred files.  :) I understand and that's good, thanks for your point ;-) > I'll kick o

Re: XWork test failures

2009-02-26 Thread Wes Wannemacher
On Thursday 26 February 2009 17:27:09 Lukasz Lenart wrote: > 2009/2/26 Wes Wannemacher : > > testJaredFiles is still failing... (Who is Jared? Maybe we should ask > > him what is up with his files... j/k). It's the only test still > > failing on Hudson. > > Jared means xwork config files in JAR fil

Re: XWork test failures

2009-02-26 Thread Wes Wannemacher
On Thursday 26 February 2009 17:27:09 Lukasz Lenart wrote: > 2009/2/26 Wes Wannemacher : > > testJaredFiles is still failing... (Who is Jared? Maybe we should ask > > him what is up with his files... j/k). It's the only test still > > failing on Hudson. > > Jared means xwork config files in JAR fil

Re: XWork test failures

2009-02-26 Thread Musachy Barroso
It is working for me after your last change. Thanks :) musachy On Thu, Feb 26, 2009 at 5:36 PM, Lukasz Lenart wrote: > 2009/2/26 Musachy Barroso : >> It has something to do with forking in the surefire plugin, running >> the tests without forking works(for me at least): >> >> mvn test -DforkMode

Re: XWork test failures

2009-02-26 Thread Lukasz Lenart
2009/2/26 Musachy Barroso : > It has something to do with forking in the surefire plugin, running > the tests without forking works(for me at least): > > mvn test -DforkMode=none If my change don't solve the problem, I think we should switch back the fork mode. Regards -- Lukasz http://www.lena

Re: XWork test failures

2009-02-26 Thread Lukasz Lenart
2009/2/26 Wes Wannemacher : > testJaredFiles is still failing... (Who is Jared? Maybe we should ask > him what is up with his files... j/k). It's the only test still > failing on Hudson. Jared means xwork config files in JAR files ;-) I changed the name to be more readable. I think I solved the p

Re: XWork test failures

2009-02-26 Thread Musachy Barroso
testJaredFiles could be related to the FileManager changes, that line: FileManager.setReloadingConfigs(true); is suspicious. It works for me on Windows XP (/cry). On Thu, Feb 26, 2009 at 11:14 AM, Wes Wannemacher wrote: > On Thu, Feb 26, 2009 at 11:05 AM, Musachy Barroso wrote: >> It has some

Re: XWork test failures

2009-02-26 Thread Wes Wannemacher
On Thu, Feb 26, 2009 at 11:05 AM, Musachy Barroso wrote: > It has something to do with forking in the surefire plugin, running > the tests without forking works(for me at least): > > mvn test -DforkMode=none > > musachy I added that to Hudson and it appears to be working better... >> >>> testJar

Re: XWork test failures

2009-02-26 Thread Musachy Barroso
It has something to do with forking in the surefire plugin, running the tests without forking works(for me at least): mvn test -DforkMode=none musachy On Thu, Feb 26, 2009 at 2:38 AM, Lukasz Lenart wrote: > 2009/2/25 Lukasz Lenart : >> Problems with testWildCardInclude and testFinder are relate

Re: XWork test failures

2009-02-25 Thread Lukasz Lenart
2009/2/25 Lukasz Lenart : > Problems with testWildCardInclude and testFinder are related to new > Surefire plugin version, with 2.4 they fail, but passed with 2.3 (both > will pass under IDEA) I've been playing with testFinder but no idea what is wrong, when I launch it from command line the finde

Re: XWork test failures

2009-02-25 Thread Wes Wannemacher
On Wed, Feb 25, 2009 at 11:14 AM, Musachy Barroso wrote: > Yeah, I overloaded a constructor and used it in Convention. > I don't think it's the change that killed it, just the fact that the XWork snapshot isn't in Bamboo's repo because it's build is failing. -Wes -- Wes Wannemacher Author -

Re: XWork test failures

2009-02-25 Thread Musachy Barroso
Yeah, I overloaded a constructor and used it in Convention. On Wed, Feb 25, 2009 at 11:08 AM, Wes Wannemacher wrote: > On Wed, Feb 25, 2009 at 10:58 AM, Rene Gielen wrote: >> Same here. Is the failing Hudson snapshot build also the reason why the >> S2.1 Bamboo build is still failing? Bamboo bui

Re: XWork test failures

2009-02-25 Thread Wes Wannemacher
On Wed, Feb 25, 2009 at 10:58 AM, Rene Gielen wrote: > Same here. Is the failing Hudson snapshot build also the reason why the > S2.1 Bamboo build is still failing? Bamboo build isn't able to get the > XWork update with Musachy's latest XW commit, needed for S2 build. > > Am Mi, 25.02.2009, 16:34,

Re: XWork test failures

2009-02-25 Thread Rene Gielen
Same here. Is the failing Hudson snapshot build also the reason why the S2.1 Bamboo build is still failing? Bamboo build isn't able to get the XWork update with Musachy's latest XW commit, needed for S2 build. Am Mi, 25.02.2009, 16:34, schrieb Musachy Barroso: > The overflow test might be related

Re: XWork test failures

2009-02-25 Thread Lukasz Lenart
Problems with testWildCardInclude and testFinder are related to new Surefire plugin version, with 2.4 they fail, but passed with 2.3 (both will pass under IDEA) testJaredFiles - is strange for me, there wasn't problem, but I will double-check testOverflows - this can be related to conversion bug,

Re: XWork test failures

2009-02-25 Thread Musachy Barroso
The overflow test might be related to a bug Lucasz fixed about double conversion on negative numbers. The others pass in IntelliJ and fail with maven, so yeah something is up. musachy On Wed, Feb 25, 2009 at 10:12 AM, Wes Wannemacher wrote: > Now that we are depending on the xwork snapshot, I we

XWork test failures

2009-02-25 Thread Wes Wannemacher
Now that we are depending on the xwork snapshot, I went ahead and setup an XWork build in Hudson, just like the struts2 builds. The test failures are showing up there, but I can't reproduce them... Well, I can, they fail when you run the build with Maven, but if you run the tests individually, lik