Re: [PATCH] Issue 1199: Delete from multiple repos at one time

2010-07-23 Thread Hyrum K. Wright
On Fri, Jul 23, 2010 at 7:49 PM, C. Michael Pilato wrote: > On 07/23/2010 08:40 PM, Hyrum K. Wright wrote: >>  * I don't know if this added issue 3242-like problems.  The approach >> is to parent the session at the repos_root, and then operate on all >> the paths relative to that.  In theory, I do

Re: [PATCH] Issue 1199: Delete from multiple repos at one time

2010-07-23 Thread C. Michael Pilato
On 07/23/2010 08:40 PM, Hyrum K. Wright wrote: > * I don't know if this added issue 3242-like problems. The approach > is to parent the session at the repos_root, and then operate on all > the paths relative to that. In theory, I don't think this should be a > problem. In practice, I'm not so s

[PATCH] Issue 1199: Delete from multiple repos at one time

2010-07-23 Thread Hyrum K. Wright
Attached is a patch for issue 1199: http://subversion.tigris.org/issues/show_bug.cgi?id=1199 In spite of the 'bite-sized' keyword, this patch took a fair amount of work, and I'm not yet certain that it is ready for commit, so I'm sending it here for review first. The questions I have are: * The

Re: Partial working copy relocation

2010-07-23 Thread C. Michael Pilato
On 07/23/2010 03:43 PM, Bob Archer wrote: > Are there any plans to have some way to indicate a "project root" in svn > 1.7? Or, will it work the same way... we will know the working copy root but > not necessarily the project/repository root. Having this might help with > sub-tree merges as well as

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > I'd say get the basics right first, before worrying about features > like this. In my opinion that means that it needs to produce the same > output as svnadmin dump does. (I'm planning to revert r965892 soon, > so you don't need to worry about the Prop-content-

svnrdump: New unittest

2010-07-23 Thread Ramkumar Ramachandra
Hi, Here's a patch for a simple unittest I wrote out- the zeroth revision of the ASF repository passes with no issues. Since this is outside my area, I need a +1 to commit this. Thanks! Index: subversion/tests/cmdline/svnrdump_tests.py

spam in svn google group

2010-07-23 Thread Hyrum K. Wright
I don't know if anybody here manages this group, but it needs some spam removal: http://groups.google.com/group/subversion-svn -Hyrum

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 02:26:47 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Good question. > > > > I'd probably say "last revision successfully dumped was rN" and then exit > > with > > a non-zero code, leaving it to the admin to clean up the mess (i.e., to > >

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Good question. > > I'd probably say "last revision successfully dumped was rN" and then exit with > a non-zero code, leaving it to the admin to clean up the mess (i.e., to > truncate > the dumpfile after the end of rN's data). > > Unfortunately, since you dump

RE: Partial working copy relocation

2010-07-23 Thread Bob Archer
> On Fri, Jul 23, 2010 at 22:38, C. Michael Pilato > wrote: > > Over in another thread[1], a question was raised about the > behavior of 'svn > > switch --relocate' today.  Namely, if you run 'svn switch -- > relocate' on a > > subdirectory of a working copy (that is, *not* a "working copy > root"

Re: svn commit: r966841 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-23 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Fri, Jul 23, 2010 at 23:50:00 +0530: > > > + /* Fake properties from svnsync ### what about svn:date? */ > > > + apr_hash_set(encoded_prophash, SVNSYNC_PROP_FROM_URL, > > > + APR_HASH_KEY_STRING, svn_string_create(url, pool)); > > > + a

Re: svn commit: r967212 - in /subversion/branches/atomic-revprop/subversion: include/svn_repos.h libsvn_repos/deprecated.c libsvn_repos/fs-wrap.c

2010-07-23 Thread C. Michael Pilato
On 07/23/2010 03:13 PM, danie...@apache.org wrote: > Author: danielsh > Date: Fri Jul 23 19:13:52 2010 > New Revision: 967212 [...] > * subversion/libsvn_repos/deprecated.c > (svn_repos_fs_change_rev_prop3): > Reimplement as wrapper around svn_repos_fs_change_rev_prop3().

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Fri, Jul 23, 2010 at 23:56:57 +0530: > Hi Daniel, > > Daniel Shahaf writes: > > Or, you could have svnrdump report the highest revision it dumped, and the > > admin can remember that and invoke svnrdump -r N+1:HEAD next time. (Much > > cheaper than parsing the entire

Re: Partial working copy relocation

2010-07-23 Thread Ivan Zhakov
On Fri, Jul 23, 2010 at 22:38, C. Michael Pilato wrote: > Over in another thread[1], a question was raised about the behavior of 'svn > switch --relocate' today.  Namely, if you run 'svn switch --relocate' on a > subdirectory of a working copy (that is, *not* a "working copy root"), what > should

Re: FW: Generating a dump file using a powershell script

2010-07-23 Thread C. Michael Pilato
On 06/22/2010 10:58 AM, Bert Huijben wrote: >> -Original Message- >> From: Geoff Worboys [mailto:ge...@telesiscomputing.com.au] >> Sent: dinsdag 22 juni 2010 16:37 >> To: us...@subversion.apache.org >> Subject: Generating a dump file using a powershell script >> > > > >> Q2: When writin

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Stefan Sperling
On Fri, Jul 23, 2010 at 11:56:57PM +0530, Ramkumar Ramachandra wrote: > Hi Daniel, > > Daniel Shahaf writes: > > Or, you could have svnrdump report the highest revision it dumped, and the > > admin can remember that and invoke svnrdump -r N+1:HEAD next time. (Much > > cheaper than parsing the ent

Re: [PATCH] fsfs: add two "format new enough" checks

2010-07-23 Thread Daniel Shahaf
Committed r967194 with minor modifications. Daniel Shahaf wrote on Sun, Jul 18, 2010 at 15:47:40 +0300: > This script: > > [[[ > #!/bin/sh > svnadmin=subversion/svnadmin/svnadmin > rm -rf r > $svnadmin create --pre-1.6-compatible r > ./subversion/svnrdump/svnrdump file://`pwd`/r -r1:2

Partial working copy relocation

2010-07-23 Thread C. Michael Pilato
Over in another thread[1], a question was raised about the behavior of 'svn switch --relocate' today. Namely, if you run 'svn switch --relocate' on a subdirectory of a working copy (that is, *not* a "working copy root"), what should the behavior be? The behavior today is that the subdir and its c

Re: svn commit: r966822 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/merge_tests.py

2010-07-23 Thread C. Michael Pilato
On 07/22/2010 05:56 PM, Paul Burba wrote: > On Thu, Jul 22, 2010 at 5:04 PM, Bert Huijben wrote: >> Shouldn't this be fixed in the ra layer implementations then? > > From what Mike told me in > http://subversion.tigris.org/issues/show_bug.cgi?id=3657#desc9 I > didn't think so. I assumed that som

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Or, you could have svnrdump report the highest revision it dumped, and the > admin can remember that and invoke svnrdump -r N+1:HEAD next time. (Much > cheaper than parsing the entire dumpfile --- which you would have to do in > order to figure how many revision

Re: svn commit: r966851 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-23 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > >SVN_ERR(svn_stream_printf(stdout_stream, pool, > > SVN_REPOS_DUMPFILE_REVISION_NUMBER > > -": %d\n", start_revision)); > > +": %ld\n", start_revision)); > >

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Fri, Jul 23, 2010 at 23:41:21 +0530: > Hi Stefan, > > Stefan Sperling writes: > > Can you explain what you mean by "resume support"? > > svnadmin dump has no such feature AFAIK. > > I like to think of svnrdump as a combination of `svnsync` and > `svnadmin dump`. To i

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > Can you explain what you mean by "resume support"? > svnadmin dump has no such feature AFAIK. I like to think of svnrdump as a combination of `svnsync` and `svnadmin dump`. To illustrate resume support, consider the following scenario: Suppose a server adminis

Re: segfault around svn_commit_callback2_t

2010-07-23 Thread Daniel Shahaf
Hyrum K. Wright wrote on Fri, Jul 23, 2010 at 17:23:30 +: > On Fri, Jul 23, 2010 at 2:35 PM, Hyrum K. Wright > wrote: > > On Fri, Jul 23, 2010 at 1:26 PM, Daniel Shahaf > > wrote: > >> When running my standard "create a Greek tree repos+wc to experiment in" > >> wc, I get a segfault: > >> >

Re: hotcopy fails on fsfs.conf that has never been created

2010-07-23 Thread Stefan Sperling
On Fri, Jul 23, 2010 at 07:39:22PM +0300, Daniel Shahaf wrote: > Old repositories don't have a fsfs.conf file. I think we should either make > 'hotcopy' tolerate the absence of that file, or make 'svnadmin upgrade' create > it; otherwise, > > svnadmin1.5 create foo > svnadmin1.7 hotco

Re: hotcopy fails on fsfs.conf that has never been created

2010-07-23 Thread Philip Martin
Daniel Shahaf writes: > Old repositories don't have a fsfs.conf file. I think we should either make > 'hotcopy' tolerate the absence of that file, or make 'svnadmin upgrade' create > it; otherwise, > > svnadmin1.5 create foo > svnadmin1.7 hotcopy foo bar > > will fail with the error

Re: segfault around svn_commit_callback2_t

2010-07-23 Thread Hyrum K. Wright
On Fri, Jul 23, 2010 at 2:35 PM, Hyrum K. Wright wrote: > On Fri, Jul 23, 2010 at 1:26 PM, Daniel Shahaf > wrote: >> When running my standard "create a Greek tree repos+wc to experiment in" wc, >> I get a segfault: >> >> #1  0xb7629b6a in deltify_etc (commit_info=0xb5abdbc8, baton=0x80ddba0, >

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Stefan Sperling
On Fri, Jul 23, 2010 at 09:39:46PM +0530, Ramkumar Ramachandra wrote: > Hi Stefan, > > Stefan Sperling writes: > > svnrdump is something entirely different to svnsync. > > svnrdump is analogous to 'svnadmin dump', which does not create any > > svn:sync-* properties itself. It just dumps them if th

Re: 1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

2010-07-23 Thread C. Michael Pilato
On 06/17/2010 09:47 AM, Daniel Shahaf wrote: > Julian Foad wrote on Thu, 17 Jun 2010 at 14:53 +0100: >> On Wed, 2010-06-16, C. Michael Pilato wrote: >>> If we decide that we need to rev this API, though, then let's do the sane >> >> (Did you mean "rev this API" or merely "change it in any way"?) >>

hotcopy fails on fsfs.conf that has never been created

2010-07-23 Thread Daniel Shahaf
Next time please use a subject line. Александр Букреев wrote on Fri, Jul 23, 2010 at 10:43:29 +0400: > I use Visual SVN Server 2.1.3. (included Subversion 1.6.12). > When you try to execute the command: > > svnadmin" hotcopy D:\Repositories\AllProjects\ e:\a\ > > I get an error message: > svnad

Re: community guide

2010-07-23 Thread C. Michael Pilato
On 05/14/2010 09:58 PM, Greg Stein wrote: > Hey Mike, > > What's with linking between sections of the community guide? There are > links like href="#log-messages", but that really should be > href="conventions.html#log-messages". But that might mess up the > one-big-document approach, right? > >

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > svnrdump is something entirely different to svnsync. > svnrdump is analogous to 'svnadmin dump', which does not create any > svn:sync-* properties itself. It just dumps them if they are already > there. So if you dump a repository which was mirrored using svnsy

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Isn't it passed to apply_textdelta()? Oops, looks like I missed that earlier :p Fixed now. Thanks. -- Ram

Re: segfault around svn_commit_callback2_t

2010-07-23 Thread Hyrum K. Wright
On Fri, Jul 23, 2010 at 1:26 PM, Daniel Shahaf wrote: > When running my standard "create a Greek tree repos+wc to experiment in" wc, > I get a segfault: > > #1  0xb7629b6a in deltify_etc (commit_info=0xb5abdbc8, baton=0x80ddba0, > pool=0x80b29f8) at subversion/libsvn_ra_local/ra_plugin.c:351 > 3

Re: A patch that erroneus causes a text conflict

2010-07-23 Thread Daniel Näslund
On Fri, Jul 23, 2010 at 04:13:44PM +0200, Stefan Sperling wrote: > On Fri, Jul 23, 2010 at 04:06:09PM +0200, Daniel Näslund wrote: > > Hi Stefan! > > > > The patch below fails to apply. I'm investigating why. > > > > Content of the file 'new': > > - > > [[[ > > #!/

A patch that erroneus causes a text conflict

2010-07-23 Thread Daniel Näslund
Hi Stefan! The patch below fails to apply. I'm investigating why. Content of the file 'new': - [[[ #!/bin/sh IFS=@ read name address echo "A mail to $name at $address" read subject echo "Subject: $subject" The script is fed its input through standa

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Stefan Sperling
On Fri, Jul 23, 2010 at 06:11:06PM +0530, Ramkumar Ramachandra wrote: > Hi again, > > With the latest fixes, I thought I'd follow up on this. > > Stefan Sperling writes: > > - svnrdump doesn't dump revision 0. > >It should dump revision 0, because that revision can contain important > >r

Re: segfault around svn_commit_callback2_t

2010-07-23 Thread Daniel Shahaf
Daniel Shahaf wrote on Fri, Jul 23, 2010 at 16:26:02 +0300: > The full script is attached new.sh Description: Bourne shell script

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Fri, Jul 23, 2010 at 18:11:06 +0530: > >Text-delta-base-md5 > > I dug deeper, but it seems like I don't get this information over the > wire: to actually implement this, I'll have to fetch the file to which > the delta is being applied along with its md5sum. If th

segfault around svn_commit_callback2_t

2010-07-23 Thread Daniel Shahaf
When running my standard "create a Greek tree repos+wc to experiment in" wc, I get a segfault: #1 0xb7629b6a in deltify_etc (commit_info=0xb5abdbc8, baton=0x80ddba0, pool=0x80b29f8) at subversion/libsvn_ra_local/ra_plugin.c:351 351 err1 = (*db->callback)(commit_info, db->callback_baton, p

Re: svnrdump: Faking revision 0

2010-07-23 Thread Ramkumar Ramachandra
Hi Daniel, Daniel Shahaf writes: > Philip Martin wrote on Fri, Jul 23, 2010 at 12:03:01 +0100: > > Like Stefan I don't understand why svnrdump is inventing revsion > > properties. It should simply dump those that exist, it should not add > > anything that does not exist. > > > > +1. Folks can

Re: [PATCH v2] Add svnrdump

2010-07-23 Thread Ramkumar Ramachandra
Hi again, With the latest fixes, I thought I'd follow up on this. Stefan Sperling writes: > - svnrdump doesn't dump revision 0. >It should dump revision 0, because that revision can contain important >revprops such as metadata for svnsync (svn:sync-last-merge-rev etc.) Fixed. After a fe

Re: svnrdump: Faking revision 0

2010-07-23 Thread Daniel Shahaf
Philip Martin wrote on Fri, Jul 23, 2010 at 12:03:01 +0100: > Like Stefan I don't understand why svnrdump is inventing revsion > properties. It should simply dump those that exist, it should not add > anything that does not exist. > +1. Folks can use 'svnsync init --allow-non-empty' later (or

Re: svnrdump: Faking revision 0

2010-07-23 Thread Ramkumar Ramachandra
Hi Philip, Philip Martin writes: > They are all the same (REAL?), they are all just unversioned revision > properties. I probably misunderstood something somewhere- I'm making deductions simply based on my limited observation. I've used the word "real" in the context that those are the only prope

Re: svnrdump: Faking revision 0

2010-07-23 Thread Philip Martin
Ramkumar Ramachandra writes: > Ramkumar Ramachandra writes: >> svn:sync-from-url - it's clear why svnsync needs this. After the >> `init`, subsequent calls to `sync` needs this information, but isn't >> given it explicitly. > > We can keep this. > >> svn:sync-currently-copying and svn:sync-last-m

Re: svnrdump: Faking revision 0

2010-07-23 Thread Ramkumar Ramachandra
Hi again, Ramkumar Ramachandra writes: > svn:sync-from-url - it's clear why svnsync needs this. After the > `init`, subsequent calls to `sync` needs this information, but isn't > given it explicitly. We can keep this. > svn:sync-currently-copying and svn:sync-last-merged-rev - `sync` needs > to

svnrdump: Faking revision 0

2010-07-23 Thread Ramkumar Ramachandra
Hi Stefan, Stefan Sperling writes: > If these revision properties aren't set on the original repository, > you should not include them in the dump. > > synsync creates these revision properties, but svnrdump should not. > > I think you should query the actual revprop values using the RA API > (

Re: svn commit: r966851 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-23 Thread Daniel Shahaf
artag...@apache.org wrote on Thu, Jul 22, 2010 at 20:43:38 -: > Author: artagnon > Date: Thu Jul 22 20:43:38 2010 > New Revision: 966851 > > URL: http://svn.apache.org/viewvc?rev=966851&view=rev > Log: > * subversion/svnrdump/svnrdump.c (main): Error out if UPPER refers to > a non-existent r

Re: svn commit: r966841 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-23 Thread Daniel Shahaf
artag...@apache.org wrote on Thu, Jul 22, 2010 at 20:18:17 -: > Author: artagnon > Date: Thu Jul 22 20:18:16 2010 > New Revision: 966841 > > URL: http://svn.apache.org/viewvc?rev=966841&view=rev > Log: > * subversion/svnrdump/svnrdump.c (replay_range, main, usage): Fake a > revision 0 like s