Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Philipp Marek
Hello Hyrum! On Thursday 14 October 2010, Hyrum K. Wright wrote: > The following is a somewhat naïve implementation, but does it jive > with your suggestion? ... > inline const char *c_str() const > { > if (isNull) > return NULL; > else > return std::string::c_s

RE: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Mark Reibert
> Original Message > Subject: RE: object-model: Return by value, reference or pointer? (or > something else?) > From: "Bolstridge, Andrew" > Date: Thu, October 14, 2010 5:24 am > To: [snip] > Personally, I would stick to just returning a string, or if it is > essential to retu

Re: PATCH: Replace Tigris URLs within webdav-usage.html

2010-10-14 Thread C. Michael Pilato
On 10/14/2010 04:00 PM, Andrew Roughan wrote: > Hi, > I was searching for documentation on subversion from google and landed > on this page but discovered the URLs were broken. So here's a patch. Sendinghttp-and-webdav/webdav-usage.html Transmitting file data . Committed revision

PATCH: Replace Tigris URLs within webdav-usage.html

2010-10-14 Thread Andrew Roughan
Hi, I was searching for documentation on subversion from google and landed on this page but discovered the URLs were broken. So here's a patch. (I'm not subscribed to the mailing list.) Regards, Andrew [[[ Corrected URLs within webdav-usage.html * subversion\notes\http-and-webdav\webdav-usage.htm

Re: [PATCH] Simplify WC DB function start_directory_update_txn()

2010-10-14 Thread Greg Stein
Seems fine. On Thu, Oct 14, 2010 at 18:32, Julian Foad wrote: > Hi Bert. > > Any objection to me simplifying start_directory_update_txn(), as in the > attached patch?  It appears that it's doing relatively a lot of work > every time just to decide whether the repos_relpath is going to be the > sa

[PATCH] Simplify WC DB function start_directory_update_txn()

2010-10-14 Thread Julian Foad
Hi Bert. Any objection to me simplifying start_directory_update_txn(), as in the attached patch? It appears that it's doing relatively a lot of work every time just to decide whether the repos_relpath is going to be the same as before, and thus decide whether to use a different update statement t

Re: svn commit: r1022707 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2010-10-14 Thread Stefan Sperling
On Thu, Oct 14, 2010 at 09:00:44PM -, hwri...@apache.org wrote: > Author: hwright > Date: Thu Oct 14 21:00:43 2010 > New Revision: 1022707 > > URL: http://svn.apache.org/viewvc?rev=1022707&view=rev > Log: > Merge r985472 from the performance branch, which see for more information. > > This re

Re: svn commit: r984984 - /subversion/branches/performance/subversion/libsvn_repos/reporter.c

2010-10-14 Thread Hyrum K. Wright
On Thu, Aug 12, 2010 at 4:25 PM, wrote: > Author: stefan2 > Date: Thu Aug 12 21:25:11 2010 > New Revision: 984984 > > URL: http://svn.apache.org/viewvc?rev=984984&view=rev > Log: > Eliminate redundant revprop lookups: Exports / checkouts often > contain multiple nodes from the same revision. Ther

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Steinar Bang
> Branko Čibej : > All right. Then derive svn::string from std::string, and add a .null() > method. You get to use all the standard string alogorithm > specializations, plus you get what you want. There is one known objection to this: std::string doesn't have a virtual destructor, so if you h

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2010-10-14 Thread Ramkumar Ramachandra
Hi Philip, [sorry about the delayed reply: I had a bad internet connection] Philip Martin writes: > If we are going to use the APR atomic interface then the two reads > should use apr_atomic_read32. > > It would be better to use svn_atomic__init_once. It's a clear > indication that we are doing

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Hyrum K. Wright
On Thu, Oct 14, 2010 at 5:22 AM, Branko Čibej wrote: >  On 13.10.2010 16:10, Hyrum K. Wright wrote: >> On Tue, Oct 12, 2010 at 5:06 PM, Branko Čibej wrote: >>>  On 12.10.2010 22:30, Hyrum K. Wright wrote: On Tue, Oct 12, 2010 at 2:40 PM, Branko Čibej wrote: >  On 12.10.2010 20:35, Hyrum

RE: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Bolstridge, Andrew
-Original Message- > From: Steinar Bang [mailto:s...@dod.no] > Sent: 13 October 2010 21:16 > To: dev@subversion.apache.org > Subject: Re: object-model: Return by value, reference or pointer? (or something else?) > Do you need the distrinction between an empty string and a NULL? > If not

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Branko Čibej
On 13.10.2010 22:05, Steinar Bang wrote: > I'm divided on whether I would move the delete of the RefCounter object > into the dec_ref method, or leave it where it is. On one hand it feels > like good encapsulation to put it together with the dec_ref, on the > other hand, I've always been wary of

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Branko Čibej
On 13.10.2010 16:10, Hyrum K. Wright wrote: > On Tue, Oct 12, 2010 at 5:06 PM, Branko Čibej wrote: >> On 12.10.2010 22:30, Hyrum K. Wright wrote: >>> On Tue, Oct 12, 2010 at 2:40 PM, Branko Čibej wrote: On 12.10.2010 20:35, Hyrum K. Wright wrote: > 1) Return everything by value >

Re: svn commit: r1022250 - /subversion/site/publish/packages.html

2010-10-14 Thread Stefan Sperling
On Thu, Oct 14, 2010 at 05:24:36AM -0400, Greg Stein wrote: > On Wed, Oct 13, 2010 at 16:20, C. Michael Pilato wrote: > > On 10/13/2010 04:13 PM, Blair Zajac wrote: > >> On 10/13/2010 12:26 PM, hwri...@apache.org wrote: > >>> Author: hwright > >>> Date: Wed Oct 13 19:26:49 2010 > >>> New Revision:

Re: svn commit: r1022250 - /subversion/site/publish/packages.html

2010-10-14 Thread Greg Stein
On Wed, Oct 13, 2010 at 16:20, C. Michael Pilato wrote: > On 10/13/2010 04:13 PM, Blair Zajac wrote: >> On 10/13/2010 12:26 PM, hwri...@apache.org wrote: >>> Author: hwright >>> Date: Wed Oct 13 19:26:49 2010 >>> New Revision: 1022250 >>> >> >>> +http://www.wandisco.com/subversion/os/downloads";>

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Steinar Bang
> "Hyrum K. Wright" : > I don't want the caller to have to depend upon the lifetime of the > source object, hence the desire to return something by value or a > newly allocated pointer. > Additionally, it still wouldn't work, since references have to point > to some object, hence there is no

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread eg
On 10/13/2010 12:51 PM, Hyrum K. Wright wrote: At this point, it's my turn to get confused. I'm speaking specifically of cases where we return STL classes. Brane's earlier suggestion to create an implicit bool conversion works fine for our custom classes. The problem I'm trying to solve is "

RE: object-model: Return by value, reference or pointer? (or something else?)

2010-10-14 Thread Mark Reibert
After following this thread with some interest, I cannot help but remark it is amazing the lengths we all go through because std::string is anemic. I work on a Qt application and we debate all the time whether to use STL or the equivalent 'Q' class (e.g., std::vector versus QValueVector). I almost

Re: sasl mechanisms order

2010-10-14 Thread Victor Sudakov
Stefan Sperling wrote: > > This time it has compiled, but does not work. > > > > "svn list svn://admin/test/" works OK (IMHO because the ANONYMOUS > > mechanism is sufficient for that) but "svn co svn://admin/test/" > > dumps core immediately. > > > I hope I have found the problem. Does the patc