Re: Fix for issue 3609 - ls command

2010-11-09 Thread Noorul Islam K M
Julian Foad writes: > On Tue, 2010-11-09, Kamesh Jayachandran wrote: > >> On 11/08/2010 11:59 AM, Noorul Islam K M wrote: >> > [[[ >> > Canonicalize paths before passing them to svn_client_list2. >> > >> > * subversion/svn/list-cmd.c >> >(svn_cl__list): Canonicalize url or dirent before passi

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-09 Thread C. Michael Pilato
On 11/09/2010 10:30 PM, Noorul Islam K M wrote: > I think I can have similar approach for issue 3713. If you are not > already on it then I will try implementing the same for 3713. Nope, I'm not "on it". -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Dema

Re: svn commit: r1033228 - in /subversion/branches/1.6.x: ./ CHANGES STATUS subversion/svnserve/main.c subversion/tests/cmdline/merge_tests.py

2010-11-09 Thread Blair Zajac
On Nov 9, 2010, at 1:03 PM, hwri...@apache.org wrote: > Author: hwright > Date: Tue Nov 9 21:03:16 2010 > New Revision: 1033228 > > URL: http://svn.apache.org/viewvc?rev=1033228&view=rev > Log: > Merge r1022675 from trunk: > > * r1022675 (r982355 from ^subversion/branches/performance) > Limi

Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c

2010-11-09 Thread Blair Zajac
On Aug 4, 2010, at 11:43 AM, stef...@apache.org wrote: > Author: stefan2 > Date: Wed Aug 4 18:43:29 2010 > New Revision: 982355 > > URL: http://svn.apache.org/viewvc?rev=982355&view=rev > Log: > Fix an issue with fulltext caching already present in production SVN: > APR pools often won't reuse

Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c

2010-11-09 Thread Blair Zajac
On Aug 4, 2010, at 11:43 AM, stef...@apache.org wrote: > Author: stefan2 > Date: Wed Aug 4 18:43:29 2010 > New Revision: 982355 > > URL: http://svn.apache.org/viewvc?rev=982355&view=rev > Log: > Fix an issue with fulltext caching already present in production SVN: > APR pools often won't reuse

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-09 Thread Noorul Islam K M
cmpil...@apache.org writes: > Author: cmpilato > Date: Wed Nov 10 01:44:35 2010 > New Revision: 1033320 > > URL: http://svn.apache.org/viewvc?rev=1033320&view=rev > Log: > Fix issue #3622 ("svn should exit with exit code 1 if updating > externals fails"). > > * subversion/include/svn_error_codes.h

1.5.8 release, Dec. 1

2010-11-09 Thread Hyrum K. Wright
In light of some of the recent activity on the 1.5.x branch, together with the policy that we still maintain that branch, I'm planning on rolling a 1.5.8 release. Next week will be 1.6.14, the week following is the Thanksgiving holidays in the States, so I'll push it to Dec. 1, if nobody has any o

Re: backporting r964349

2010-11-09 Thread Hyrum K. Wright
If you feel you've resolved the conflicts appropriately, go ahead and commit. -Hyrum On Tue, Nov 9, 2010 at 7:05 PM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Tue, Nov 09, 2010 at 20:09:53 -: >> * STATUS: Add note to the r964349 group. > >> @@ -350,6 +350,8 @@ Approved changes: >>  

'svn diff --git' doesn't diff svn:mergeinfo

2010-11-09 Thread Daniel Shahaf
% cd src/svn/16x/ ### --record-only should suffice % $svn merge -q -c r964349 --accept=postpone ../trunk/ % $svn ps -q k v ./ % $svn di --git --depth empty Index: . === diff --git a/subversion/branches/1.6.x b/subversion/branches/1.6.x

backporting r964349

2010-11-09 Thread Daniel Shahaf
hwri...@apache.org wrote on Tue, Nov 09, 2010 at 20:09:53 -: > * STATUS: Add note to the r964349 group. > @@ -350,6 +350,8 @@ Approved changes: > Create fails.log files for test runs. > Justification: > Developer convenience. > + Notes: > + Somewhat non-trivial merge confli

Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c

2010-11-09 Thread Blair Zajac
On Nov 9, 2010, at 3:38 PM, Stefan Fuhrmann wrote: > On 09.11.2010 17:52, Blair Zajac wrote: >> On Aug 4, 2010, at 11:43 AM, stef...@apache.org wrote: >> >>> Author: stefan2 >>> Date: Wed Aug 4 18:43:29 2010 >>> New Revision: 982355 >>> >>> URL: http://svn.apache.org/viewvc?rev=982355&view=rev

performance branch; review of r1033040;

2010-11-09 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Wed, Nov 10, 2010 at 00:32:14 +0100: > On 09.11.2010 23:37, Daniel Shahaf wrote: >> stef...@apache.org wrote on Tue, Nov 09, 2010 at 15:51:54 -: >>> +{ >>> + svn_error_t* err = svn_file_handle_cache__create_cache(&cache, >>> + cache_

Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c

2010-11-09 Thread Stefan Fuhrmann
On 09.11.2010 17:52, Blair Zajac wrote: On Aug 4, 2010, at 11:43 AM, stef...@apache.org wrote: Author: stefan2 Date: Wed Aug 4 18:43:29 2010 New Revision: 982355 URL: http://svn.apache.org/viewvc?rev=982355&view=rev Log: Fix an issue with fulltext caching already present in production SVN: AP

Re: svn commit: r1033040 - /subversion/branches/performance/subversion/libsvn_fs_util/caching.c

2010-11-09 Thread Stefan Fuhrmann
On 09.11.2010 23:37, Daniel Shahaf wrote: stef...@apache.org wrote on Tue, Nov 09, 2010 at 15:51:54 -: Author: stefan2 Date: Tue Nov 9 15:51:54 2010 New Revision: 1033040 URL: http://svn.apache.org/viewvc?rev=1033040&view=rev Log: Fix error leaks in cache creation code. Also, having a NULL

Re: svn_tristate_t Re: svn commit: r1033006 - /subversion/trunk/subversion/include/svn_types.h

2010-11-09 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Nov 10, 2010 at 00:31:11 +0200: > I see us someday pcalloc()'ing one of these and forgetting to reset it > to the 'svn_tristate_unknown' value. Actually, svn_log_changed_path2_create() does exactly this. Right now.

Re: Announcing reposurgeon, and requesting fast-import support.

2010-11-09 Thread Ramkumar Ramachandra
Hi, [+CC: Daniel, for making me notice this email in the first place] Eric Raymond writes: > My interest in tools for repository surgery has continued, and I recently > spotted an opportunity in the increasing use of git-fast-import streams > as a history-interchange format. I have written what

Re: svn commit: r1033040 - /subversion/branches/performance/subversion/libsvn_fs_util/caching.c

2010-11-09 Thread Daniel Shahaf
stef...@apache.org wrote on Tue, Nov 09, 2010 at 15:51:54 -: > Author: stefan2 > Date: Tue Nov 9 15:51:54 2010 > New Revision: 1033040 > > URL: http://svn.apache.org/viewvc?rev=1033040&view=rev > Log: > Fix error leaks in cache creation code. Also, having a NULL > file handle cache is not al

svn_tristate_t Re: svn commit: r1033006 - /subversion/trunk/subversion/include/svn_types.h

2010-11-09 Thread Daniel Shahaf
stef...@apache.org wrote on Tue, Nov 09, 2010 at 15:07:48 -: > /** Generic three-state property to represent an unknown value for values > * that are just like booleans. The values have been set deliberately to > - * make tristates mainly compatible with #svn_boolean_t. > + * make tristates

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 3)

2010-11-09 Thread Daniel Shahaf
[ @dtrebbien, please read the whole email before starting to reply or act on the feedback; some of the earlier comments are mooted by the later ones ] [ @all, I have a question about the cost of creating subpools; search for #subpool_question to find it ] Daniel Trebbien wrote on Sun, Nov 07,

Re: svn commit: r997026 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2010-11-09 Thread C. Michael Pilato
On 11/09/2010 03:00 PM, Stefan Sperling wrote: > Hi Mike, > > I'm reviewing this for 1.6.14. I have two questions (see below). > >> * subversion/mod_dav_svn/repos.c >> (do_walk): Replace a decade-old TODO about checking authorization on >> a directory's children with, you know, code that ch

Re: svn commit: r997026 - /subversion/trunk/subversion/mod_dav_svn/repos.c

2010-11-09 Thread Stefan Sperling
On Tue, Sep 14, 2010 at 06:08:59PM -, cmpil...@apache.org wrote: > Author: cmpilato > Date: Tue Sep 14 18:08:59 2010 > New Revision: 997026 > > URL: http://svn.apache.org/viewvc?rev=997026&view=rev > Log: > For issue #3709 ("Inconsistency between "svn list" and "svn > checkout"), teach the mod

Re: Announcing reposurgeon, and requesting fast-import support.

2010-11-09 Thread Eric Raymond
Julian Foad : > Very cool. I wonder how practical it will be for doing various > "obliterate" tasks on large repositories. The main overhead is, as you might imagine, the parse time for the .fi file. And, I admit, it can be painfully slow. Loading up the git repository takes 40 minutes on my PC

Re: Announcing reposurgeon, and requesting fast-import support.

2010-11-09 Thread Julian Foad
On Tue, 2010-11-09, Eric Raymond wrote: > Some months back I contributed svncutter to Subversion. This was a tool > for doing surgery on dumpfiles intended to remove artifacts associated with > conversions from older VCSes. > > My interest in tools for repository surgery has continued, and I rece

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-09 Thread Julian Foad
On Tue, 2010-11-09 at 20:20 +0200, Daniel Shahaf wrote: > Julian Foad wrote on Tue, Nov 09, 2010 at 12:07:16 +: > > (We like to be able to copy and paste and run the displayed command.) > > I recall two oddities (at least in -v mode) in the Python tests: > > * Sometimes they gave to absolute

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-09 Thread Daniel Shahaf
Julian Foad wrote on Tue, Nov 09, 2010 at 12:07:16 +: > (We like to be able to copy and paste and run the displayed command.) I recall two oddities (at least in -v mode) in the Python tests: * Sometimes they gave to absolute path to atomic-ra-revprop-change (the compiled helper) and sometim

1.6.14 tarballs rolling next week (11/17)

2010-11-09 Thread Hyrum K. Wright
There's been a couple of high-profile bugs found and fixed, so I'd like to go ahead and roll 1.6.14 next week. Please nominate, review, vote, etc. -Hyrum

Re: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-09 Thread Stefan Küng
On 09.11.2010 18:47, Stefan Sperling wrote: On Tue, Nov 09, 2010 at 09:15:24AM -0800, Branko Čibej wrote: On 09.11.2010 08:42, C. Michael Pilato wrote: (Honestly, when was the last time any of us got excited about some new technical thing because we read a press release about it?) "Oh my, a

Re: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-09 Thread Stefan Sperling
On Tue, Nov 09, 2010 at 09:15:24AM -0800, Branko Čibej wrote: > On 09.11.2010 08:42, C. Michael Pilato wrote: > > (Honestly, when was the last time any of us got excited about some new > > technical thing because we read a press release about it?) > > "Oh my, another Apple Event has been announce

[PATCH]: Doc clarification for svn_wc__acquire_write_lock()

2010-11-09 Thread Julian Foad
Can someone check this doc clarification for me? The condition that @a local_abspath must be a versioned directory if @a lock_anchor is false was hidden away in a sub-condition. This promotes it to an unconditional condition. :-) [[[ Index: subversion/include/private/svn_wc_private.h ==

Re: Trouble building trunk: Undefined references to svn_repos_load_fs3() and svn_repos_get_fs_build_parser3()

2010-11-09 Thread Daniel Shahaf
Daniel Trebbien wrote on Sun, Nov 07, 2010 at 12:18:33 -0800: > On Sun, Nov 7, 2010 at 12:04 PM, Daniel Trebbien wrote: > > Weird. It seems that `subversion/libsvn_repos/load-fs-vtable.c` was > > the only C file in `subversion/libsvn_repos` that wasn't being > > compiled. So, I modified the CC lin

Re: [Patch] Make svn_tristate_t compatible with svn_boolean_t

2010-11-09 Thread Daniel Shahaf
I would +1 everything you said... if Julian had changed svn_boolean_t. He changed svn_tristate_t, which is used exactly once in trunk, so I don't see the need to be as careful with it. The caveat? This assumes that --- as we ought to --- we not act on feedback differently because it comes after

Announcing reposurgeon, and requesting fast-import support.

2010-11-09 Thread Eric Raymond
Some months back I contributed svncutter to Subversion. This was a tool for doing surgery on dumpfiles intended to remove artifacts associated with conversions from older VCSes. My interest in tools for repository surgery has continued, and I recently spotted an opportunity in the increasing use

Re: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-09 Thread Branko Čibej
On 09.11.2010 08:42, C. Michael Pilato wrote: > (Honestly, when was the last time any of us got excited about some new > technical thing because we read a press release about it?) "Oh my, another Apple Event has been announced! Whatsisname will tell us why we need to buy all those revolutionary n

Re: Backport request for svnmucc propsetf fix

2010-11-09 Thread Geoff Rowell
On Tue, Nov 9, 2010 at 10:30 AM, Hyrum K. Wright wrote: > On Tue, Nov 9, 2010 at 8:53 AM, Geoff Rowell wrote: >> Instead of waiting for the last minute, I'd like to propose this >> "svnmucc propsetf" fix for 1.6 backport. >> >> http://svn.apache.org/viewvc?view=revision&revision=1005446 > > It's

Re: Fix for issue 3609 - ls command

2010-11-09 Thread Julian Foad
On Tue, 2010-11-09, Kamesh Jayachandran wrote: > On 11/08/2010 11:59 AM, Noorul Islam K M wrote: > > [[[ > > Canonicalize paths before passing them to svn_client_list2. > > > > * subversion/svn/list-cmd.c > >(svn_cl__list): Canonicalize url or dirent before passing over to API. > > > > * subver

Re: svn commit: r982355 - /subversion/branches/performance/subversion/svnserve/main.c

2010-11-09 Thread Blair Zajac
On Aug 4, 2010, at 11:43 AM, stef...@apache.org wrote: > Author: stefan2 > Date: Wed Aug 4 18:43:29 2010 > New Revision: 982355 > > URL: http://svn.apache.org/viewvc?rev=982355&view=rev > Log: > Fix an issue with fulltext caching already present in production SVN: > APR pools often won't reuse

Re: "svn blame -g" causing svnserve to hang & mem usage to hit 2GB

2010-11-09 Thread Paul Burba
On Mon, Nov 8, 2010 at 10:01 PM, Paul Burba wrote: > On Mon, Nov 8, 2010 at 9:09 PM, Chris Tashjian wrote: >> >> On 11/8/2010 8:54 PM, Paul Burba wrote: >>> >>> On Mon, Nov 8, 2010 at 8:28 PM, Chris Tashjian  wrote: Paul - 1 more question.  What happens when you run additional blame -g

Re: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-09 Thread C. Michael Pilato
On 11/09/2010 10:35 AM, Hyrum K. Wright wrote: > On Mon, Nov 8, 2010 at 9:39 AM, Bolstridge, Andrew > wrote: >> I'm sure evangelical missions are still important - mainly to counter >> the "SVN is crap at merging, Mercurial/Git/a.n.otherDVCS is the ultimate >> SCM that fixes all your problems" typ

Re: Fix for issue 3609 - ls command

2010-11-09 Thread Kamesh Jayachandran
On 11/08/2010 11:59 AM, Noorul Islam K M wrote: Followup to r1030010 Log [[[ Canonicalize paths before passing them to svn_client_list2. * subversion/svn/list-cmd.c (svn_cl__list): Canonicalize url or dirent before passing over to API. * subversion/tests/cmdline/basic_tests.py (ls_url_

Re: SVN on z/OS

2010-11-09 Thread Greg Ames
Hi Cristiano, I did not finish porting svn to z/OS using EBCDIC. The subversion source code intermixes native strings and characters with real UTF-8 and assumes any random combination of those results in UTF-8. It would take maybe a month of coding and testing to untangle it. But there is no po

Re: [PATCH] Fix for issue 3609 - cat command

2010-11-09 Thread Kamesh Jayachandran
On 11/08/2010 11:40 AM, Noorul Islam K M wrote: Followup to r1030010 Log [[[ Canonicalize paths before passing them to svn_client_cat2. * subversion/svn/cat-cmd.c (svn_cl__cat): Canonicalize url or dirent before passing over to API. * subversion/tests/cmdline/cat_tests.py (cat_url_spec

Re: How to get the message out (or: why there were only 6 people at the ApacheCon meetup)

2010-11-09 Thread Hyrum K. Wright
On Mon, Nov 8, 2010 at 9:39 AM, Bolstridge, Andrew wrote: > >> -Original Message- >> From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf > Of Hyrum K. Wright >> Sent: 07 November 2010 02:34 >> To: Subversion Development >> Subject: How to get the message out (or: why there

Re: Backport request for svnmucc propsetf fix

2010-11-09 Thread Hyrum K. Wright
On Tue, Nov 9, 2010 at 8:53 AM, Geoff Rowell wrote: > Instead of waiting for the last minute, I'd like to propose this > "svnmucc propsetf" fix for 1.6 backport. > > http://svn.apache.org/viewvc?view=revision&revision=1005446 It's actually already in the 1.6.x STATUS file, proposed by C-Mike in r

Backport request for svnmucc propsetf fix

2010-11-09 Thread Geoff Rowell
Instead of waiting for the last minute, I'd like to propose this "svnmucc propsetf" fix for 1.6 backport. http://svn.apache.org/viewvc?view=revision&revision=1005446 Thank you. -- Geoff Rowell geoff.row...@gmail.com

Re: Branching 1.7.x by Dec-31

2010-11-09 Thread Hyrum K. Wright
On Tue, Nov 9, 2010 at 4:50 AM, Stefan Sperling wrote: > On Tue, Nov 09, 2010 at 09:40:31AM +, Philip Martin wrote: >> Stefan Sperling writes: >> >> > Is the op-depth stuff ready for release? >> > The only other big ticket item to be tackled is the conflict store, right? >> >> Currently op-de

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-09 Thread Julian Foad
On Tue, 2010-11-09, Philip Martin wrote: > Paul Burba writes: > > > File "C:\SVN\src-trunk-2\subversion\tests\cmdline\svntest\main.py", > > line 433, in spawn_process > > subprocess.list2cmdline(varargs))) > > File "C:\Python26\lib\subprocess.py", line 541, in list2cmdline > > needquo

Re: Branching 1.7.x by Dec-31

2010-11-09 Thread Philip Martin
Stefan Sperling writes: > Thanks for the info. Are the items in the issue tracker corresponding > to the above two points? I don't know if we have issues. We have regression tests for revert-base that are failing and currently marked XFAIL. -- Philip

Re: Branching 1.7.x by Dec-31

2010-11-09 Thread Stefan Sperling
On Tue, Nov 09, 2010 at 09:40:31AM +, Philip Martin wrote: > Stefan Sperling writes: > > > Is the op-depth stuff ready for release? > > The only other big ticket item to be tackled is the conflict store, right? > > Currently op-depth is using just two depths, 0 and 2, for base and > working.

Re: Branching 1.7.x by Dec-31

2010-11-09 Thread Philip Martin
Stefan Sperling writes: > Is the op-depth stuff ready for release? > The only other big ticket item to be tackled is the conflict store, right? Currently op-depth is using just two depths, 0 and 2, for base and working. There is code protected by SVN_WC__OP_DEPTH that enables the full op-depth

Re: [PATCH] Fix Windows test failures - Python test suite bug in quoting a trailing backslash

2010-11-09 Thread Philip Martin
Paul Burba writes: > File "C:\SVN\src-trunk-2\subversion\tests\cmdline\svntest\main.py", > line 433, in spawn_process > subprocess.list2cmdline(varargs))) > File "C:\Python26\lib\subprocess.py", line 541, in list2cmdline > needquote = (" " in arg) or ("\t" in arg) or ("|" in arg) or n