Re: [Issue 3941] svn:ignore on an svn:externals directory

2011-06-28 Thread Chris A Mattmann
Hi Daniel, On Jun 28, 2011, at 4:45 PM, Daniel Shahaf wrote: >> >> Yeah something like this is what I was thinking about with Greg. Like >> wouldn't >> it be nice if I could define something like: >> >> property: svn:external-ignores:foodir >> value: *.pyc >> >> Then when pulling in an svn:ex

Re: [PATCH] Re: Implement support for 'make check' variants

2011-06-28 Thread Daniel Shahaf
Reads fine. I'd like to test this patch (perhaps later this week?). Would make davautocheck ENVVAR=short_circuit be a better interface? Noorul Islam K M wrote on Tue, Jun 28, 2011 at 12:03:36 +0530: > Index: Makefile.in > === >

Re: [sqlite] PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-28 Thread Greg Stein
I see that 3.7.7.1 has just been released with this bugfix. Thanks!! On Mon, Jun 27, 2011 at 14:01, Roger Binns wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/26/2011 03:52 PM, Richard Hipp wrote: >> The bug is that it is returning >> SQLITE_SCHEMA instead of SQLITE_OK.  If y

Re: [Issue 3941] svn:ignore on an svn:externals directory

2011-06-28 Thread Daniel Shahaf
[ I tried to add a comment to the issue but the site timed out on submitting the form ] chrismattm...@tigris.org wrote on Tue, Jun 28, 2011 at 13:53:08 -0700: > http://subversion.tigris.org/issues/show_bug.cgi?id=3941 > > > > > > > --- Additional comments from chrismattm...@tigris.org Tu

Re: svn commit: r1140861 - /subversion/trunk/subversion/svnadmin/main.c

2011-06-28 Thread Daniel Shahaf
hwri...@apache.org wrote on Tue, Jun 28, 2011 at 21:47:06 -: > Author: hwright > Date: Tue Jun 28 21:47:06 2011 > New Revision: 1140861 > > URL: http://svn.apache.org/viewvc?rev=1140861&view=rev > Log: > * subversion/svnadmin/main.c > (parse_args): Fix a theoretical bug by ensure we only att

Re: svn commit: r1140825 - /subversion/trunk/subversion/mod_dav_svn/reports/update.c

2011-06-28 Thread Ivan Zhakov
On Wed, Jun 29, 2011 at 00:39, Greg Stein wrote: > On Tue, Jun 28, 2011 at 16:21,   wrote: >>... >> +++ subversion/trunk/subversion/mod_dav_svn/reports/update.c Tue Jun 28 >> 20:21:03 2011 >> @@ -353,8 +353,8 @@ add_helper(svn_boolean_t is_dir, >>                              "copyfrom-path=\"%s\

Re: svn commit: r1140825 - /subversion/trunk/subversion/mod_dav_svn/reports/update.c

2011-06-28 Thread Greg Stein
On Tue, Jun 28, 2011 at 16:21, wrote: >... > +++ subversion/trunk/subversion/mod_dav_svn/reports/update.c Tue Jun 28 > 20:21:03 2011 > @@ -353,8 +353,8 @@ add_helper(svn_boolean_t is_dir, >                              "copyfrom-path=\"%s\" copyfrom-rev=\"%ld\">" >                              D

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-28 Thread Justin Erenkrantz
On Tue, Jun 28, 2011 at 4:43 PM, Greg Stein wrote: > As I recall, the problem is that we have to continually tweak things. > Over and over and over. Edge cases never stop with libtool. It creates > a continual maintenance nightmare. Right. libtool constantly requires lots of handholding to get i

Re: Static code analysis (cppcheck)

2011-06-28 Thread Hyrum K Wright
Philipp, Thanks for the analysis. I've made several commits which address the issues in your log. Feel free to re-run to ensure that they were fixed. Thanks, -Hyrum On Tue, Jun 28, 2011 at 12:31 PM, Philipp Kloke wrote: > Hi, > > I checked the sourcecode of subversion (r1140736) with cppcheck.

Re: svn commit: r1140622 - /subversion/site/publish/docs/community-guide/releasing.part.html

2011-06-28 Thread Hyrum K Wright
On Tue, Jun 28, 2011 at 11:42 AM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Tue, Jun 28, 2011 at 13:56:03 -: >> +Before a release is officially made public, it must receive three +1 >> votes >> +from members of the Subversion PMC.  In addition, as a matter of project >> +policy, we r

Re: svn commit: r1140512 - in /subversion/trunk/subversion/mod_dav_svn: dav_svn.h liveprops.c

2011-06-28 Thread Ivan Zhakov
On Tue, Jun 28, 2011 at 21:01, Greg Stein wrote: > On Tue, Jun 28, 2011 at 06:26,   wrote: >> Author: ivan >> Date: Tue Jun 28 10:26:47 2011 >> New Revision: 1140512 >> >> URL: http://svn.apache.org/viewvc?rev=1140512&view=rev >> Log: >> Reduce memory used by processing PROPFIND requests for specf

Re: svn commit: r1140406 - /subversion/site/publish/docs/community-guide/releasing.part.html

2011-06-28 Thread Hyrum K Wright
On Tue, Jun 28, 2011 at 11:20 AM, Daniel Shahaf wrote: > hwri...@apache.org wrote on Tue, Jun 28, 2011 at 02:46:36 -: >> +Subversion extends the APR guidelines to cover client/server >> +compatibility questions: >> + >> + >> + >> +A patch or minor number release of a server (or client) never >

Static code analysis (cppcheck)

2011-06-28 Thread Philipp Kloke
Hi, I checked the sourcecode of subversion (r1140736) with cppcheck. Please have a look on the result file in the attachement. [SVN\subversion\bindings\javahl\native\JNIThreadData.cpp:40]: (warning) Member variable 'JNIThreadData::m_formatBuffer' is not initialized in the constructor. [SVN\sub

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-28 Thread Philip Martin
Philip Martin writes: > Greg Stein writes: > >> What *does* seem to be undisputed is that OpenSUSE has a broken >> libtool installation that doesn't handle C++. Why are we working >> around that? > > Subversion requires C++ support and APR doesn't. C++ support in libtool > is optional. Can Sub

Re: API review - svn_ra_get_mergeinfo2()

2011-06-28 Thread C. Michael Pilato
On 06/28/2011 01:37 PM, Paul Burba wrote: > Hi Julian, > > I hadn't realized using in-out parameters was considered such bad > form. At a minimum, they force an API divergence in our bindings layers. +1 to separate and explicit in and out parameters. -- C. Michael Pilato CollabNet <> www.

Re: API review - svn_ra_get_mergeinfo2()

2011-06-28 Thread Paul Burba
On Tue, Jun 28, 2011 at 12:46 PM, Julian Foad wrote: > I'm curious about the new 'validate_inherited_mergeinfo' parameter of > svn_ra_get_mergeinfo2(), which is the public API that calls > svn_ra__vtable_t.get_mergeinfo(). > > /* ... >  * If the mergeinfo for any path is inherited and >  * @a *val

Re: svn commit: r1140512 - in /subversion/trunk/subversion/mod_dav_svn: dav_svn.h liveprops.c

2011-06-28 Thread Greg Stein
On Tue, Jun 28, 2011 at 06:26, wrote: > Author: ivan > Date: Tue Jun 28 10:26:47 2011 > New Revision: 1140512 > > URL: http://svn.apache.org/viewvc?rev=1140512&view=rev > Log: > Reduce memory used by processing PROPFIND requests for specfici > properties (not allprop). > > * subversion/mod_dav_sv

Re: svn commit: r1140718 - /subversion/site/publish/docs/community-guide/releasing.part.html

2011-06-28 Thread Greg Stein
what's wrong with $EDITOR ? :-) On Tue, Jun 28, 2011 at 12:40, wrote: > Author: danielsh > Date: Tue Jun 28 16:40:32 2011 > New Revision: 1140718 > > URL: http://svn.apache.org/viewvc?rev=1140718&view=rev > Log: > * docs/community-guide/releasing.part.html >  (release-stabilization): Fix E20500

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-28 Thread Philip Martin
Greg Stein writes: > What *does* seem to be undisputed is that OpenSUSE has a broken > libtool installation that doesn't handle C++. Why are we working > around that? Subversion requires C++ support and APR doesn't. C++ support in libtool is optional. Can Subversion expect APR's libtool to sup

API review - svn_ra_get_mergeinfo2()

2011-06-28 Thread Julian Foad
I'm curious about the new 'validate_inherited_mergeinfo' parameter of svn_ra_get_mergeinfo2(), which is the public API that calls svn_ra__vtable_t.get_mergeinfo(). /* ... * If the mergeinfo for any path is inherited and * @a *validate_inherited_mergeinfo is TRUE, then request that the server *

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-28 Thread Greg Stein
On Tue, Jun 28, 2011 at 10:48, Stefan Sperling wrote: > On Tue, Jun 28, 2011 at 10:22:09AM -0400, C. Michael Pilato wrote: >> Issue #3930 [1] ("build system assumes that APR libtool supports C++") is >> marked as a 1.7.0 blocker, but is currently being held up by difference of >> opinions about th

Re: svn commit: r1139766 - /subversion/trunk/subversion/svn/main.c

2011-06-28 Thread Philip Martin
Stefan Sperling writes: > When I upgraded a 1.6.x working copy of 2GB size, it took more than one hour. > I eventually just aborted the upgrade. A checkout completes within > a couple of minutes. > > The repository is remote and the bottleneck should be my 16MB/s downstream > link (the server is

Re: svn commit: r1140622 - /subversion/site/publish/docs/community-guide/releasing.part.html

2011-06-28 Thread Daniel Shahaf
hwri...@apache.org wrote on Tue, Jun 28, 2011 at 13:56:03 -: > +Before a release is officially made public, it must receive three +1 votes > +from members of the Subversion PMC. In addition, as a matter of project > +policy, we require testing and signatures from PMC members on each > +of the

Re: svn commit: r1140406 - /subversion/site/publish/docs/community-guide/releasing.part.html

2011-06-28 Thread Daniel Shahaf
hwri...@apache.org wrote on Tue, Jun 28, 2011 at 02:46:36 -: > +Subversion extends the APR guidelines to cover client/server > +compatibility questions: > + > + > + > +A patch or minor number release of a server (or client) never > + breaks compatibility with a client (or server) in the s

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Jun 28, 2011 at 13:45:11 +0200: > On Tue, Jun 28, 2011 at 03:36:32PM +0530, Arwin Arni wrote: > > On Tuesday 28 June 2011 03:13 PM, Stefan Sperling wrote: > > > 1) the working copy has no local mods > > > 2) the working copy has no switched subtrees > > > 3) the wor

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Peter Samuelson
[Daniel Shahaf] > I believe some third-party implementations are GPL'd --- meaning that we > can't borrow code from them --- so one should be careful in what parts > of what implementations one chooses to read. Indeed, my script is GPL, mostly because although I rewrote almost the entire thing, i

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
Arwin Arni wrote on Tue, Jun 28, 2011 at 15:45:04 +0530: > On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote: > >Stefan Sperling writes: > > > >>On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > >> > >>>On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: > >+svn bisect

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
Hyrum K Wright wrote on Tue, Jun 28, 2011 at 10:24:29 -0500: > On Tue, Jun 28, 2011 at 10:16 AM, Daniel Shahaf > wrote: > > [ Haven't read the whole thread yet, quick response only to this sentence ] > > > > Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: > >> This is why you should

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Hyrum K Wright
On Tue, Jun 28, 2011 at 10:16 AM, Daniel Shahaf wrote: > [ Haven't read the whole thread yet, quick response only to this sentence ] > > Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: >> This is why you should read the existing third-party implementations. > > I believe some third-p

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Daniel Shahaf
[ Haven't read the whole thread yet, quick response only to this sentence ] Peter Samuelson wrote on Tue, Jun 28, 2011 at 10:11:45 -0500: > This is why you should read the existing third-party implementations. I believe some third-party implementations are GPL'd --- meaning that we can't borrow c

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Peter Samuelson
> On Tuesday 28 June 2011 05:15 PM, Stefan Sperling wrote: > >You'll need to figure out the old and new URL before you update > >to a new revision, and perform aswitch from/to the old/new URL > >instead of an update incase the URLs don't match. [Arwin Arni] > Whoa! Didn't think of this at all. Wi

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 10:22:09AM -0400, C. Michael Pilato wrote: > Issue #3930 [1] ("build system assumes that APR libtool supports C++") is > marked as a 1.7.0 blocker, but is currently being held up by difference of > opinions about the correct path forward. The complaint involves some code >

Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-06-28 Thread C. Michael Pilato
Issue #3930 [1] ("build system assumes that APR libtool supports C++") is marked as a 1.7.0 blocker, but is currently being held up by difference of opinions about the correct path forward. The complaint involves some code that was removed from the codebase some time ago. We have no record as to

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 06:07:00PM +0530, Arwin Arni wrote: > Considering all these points,it should work this way: > > svn bisect --start -rN:M > > check for mixed rev, switched subtrees and local mods and error out > if it is. > Initialize the bisect env. > > svn bisect --run script > > --->

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
On Tuesday 28 June 2011 05:15 PM, Stefan Sperling wrote: On Tue, Jun 28, 2011 at 03:36:32PM +0530, Arwin Arni wrote: On Tuesday 28 June 2011 03:13 PM, Stefan Sperling wrote: 1) the working copy has no local mods 2) the working copy has no switched subtrees 3) the working copy is at a unif

Re: svn commit: r1139766 - /subversion/trunk/subversion/svn/main.c

2011-06-28 Thread Stefan Sperling
On Mon, Jun 27, 2011 at 02:03:18PM +0100, Philip Martin wrote: > Stefan Sperling writes: > > > Maybe we should tell people that they should only use update if > > they have local mods, and perform a checkout otherwise. > > This rule of thumb is probably going to yield the best overall results. >

Re: [PATCH] Followup to r1140505 - Fix indentation.

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 04:30:41PM +0530, Noorul Islam K M wrote: > I found some more and here is the patch. Thanks, r1140543.

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 03:36:32PM +0530, Arwin Arni wrote: > On Tuesday 28 June 2011 03:13 PM, Stefan Sperling wrote: > > 1) the working copy has no local mods > > 2) the working copy has no switched subtrees > > 3) the working copy is at a uniform revision > > > >These are also enforced by mer

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
On Tuesday 28 June 2011 03:36 PM, Noorul Islam K M wrote: Stefan Sperling writes: On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: +svn bisect start [-rN[:M]] + When we discussed you had a concern that above syntax is dif

Re: svn commit: r1140505 - /subversion/trunk/subversion/libsvn_subr/io.c

2011-06-28 Thread Greg Stein
On Jun 28, 2011 5:55 AM, wrote: > > Author: stsp > Date: Tue Jun 28 09:55:04 2011 > New Revision: 1140505 > > URL: http://svn.apache.org/viewvc?rev=1140505&view=rev > Log: > stats++ > * subversion/libsvn_subr/io.c > (svn_io_get_dir_filenames, temp_file_create): Fix indentation fallout from > th

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
On Tuesday 28 June 2011 03:32 PM, Stefan Sperling wrote: On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: +svn bisect start [-rN[:M]] + When we discussed you had a concern that above syntax is different from the normal svn su

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
Stefan Sperling writes: > On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > >> On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: >> >>+svn bisect start [-rN[:M]] >> >>+ >> >When we discussed you had a concern that above syntax is different from >> >the normal svn sub command s

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Arwin Arni
On Tuesday 28 June 2011 03:13 PM, Stefan Sperling wrote: On Tue, Jun 28, 2011 at 08:43:40AM -, ar...@apache.org wrote: Author: arwin Date: Tue Jun 28 08:43:40 2011 New Revision: 1140482 URL: http://svn.apache.org/viewvc?rev=1140482&view=rev Log: Added a branch readme. * BRANCH-README : New

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 03:12:22PM +0530, Arwin Arni wrote: > On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: > >>+svn bisect start [-rN[:M]] > >>+ > >When we discussed you had a concern that above syntax is different from > >the normal svn sub command syntax. Is this finalized? > > > >

[Arwin Arni] Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
This mail missed dev@ list. Forwarding it. --- Begin Message --- On Tuesday 28 June 2011 03:01 PM, Noorul Islam K M wrote: > ar...@apache.org writes: > >> Author: arwin >> Date: Tue Jun 28 08:43:40 2011 >> New Revision: 1140482 >> >> URL: http://svn.apache.org/viewvc?rev=1140482&view=rev >> Log:

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Stefan Sperling
On Tue, Jun 28, 2011 at 08:43:40AM -, ar...@apache.org wrote: > Author: arwin > Date: Tue Jun 28 08:43:40 2011 > New Revision: 1140482 > > URL: http://svn.apache.org/viewvc?rev=1140482&view=rev > Log: > Added a branch readme. > * BRANCH-README : New file. > > Added: > subversion/branches/

Re: svn commit: r1140482 - /subversion/branches/svn-bisect/BRANCH-README

2011-06-28 Thread Noorul Islam K M
ar...@apache.org writes: > Author: arwin > Date: Tue Jun 28 08:43:40 2011 > New Revision: 1140482 > > URL: http://svn.apache.org/viewvc?rev=1140482&view=rev > Log: > Added a branch readme. > * BRANCH-README : New file. > > Added: > subversion/branches/svn-bisect/BRANCH-README > > Added: subver

Re: svn commit: r1140388 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2011-06-28 Thread Johan Corveleyn
On Tue, Jun 28, 2011 at 3:57 AM, Hyrum K Wright wrote: > On Mon, Jun 27, 2011 at 7:25 PM,   wrote: >> Author: jcorvel >> Date: Tue Jun 28 00:25:57 2011 >> New Revision: 1140388 >> >> URL: http://svn.apache.org/viewvc?rev=1140388&view=rev >> Log: >> Fix a spurious failure of diff-diff3-test 2: '2-w