Re: Fwd: Build problems in Subversion (in Chinese)

2011-06-30 Thread vijay
On Thursday 30 June 2011 07:04 AM, Daniel Shahaf wrote: The problem is that the prototype of ap_log_rerror() in httpd-2.3.12-beta, [[[ AP_DECLARE(void) ap_log_rerror(const char *file, int line, int module_index, int level, apr_status_t status,

RE: Static code analysis (cppcheck)

2011-06-30 Thread Bolstridge, Andrew
-Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: 29 June 2011 17:39 To: Julian Foad Cc: Philipp Kloke; Hyrum K Wright; dev@subversion.apache.org Subject: Re: Static code analysis (cppcheck) Julian Foad julian.f...@wandisco.com writes:

Re: Static code analysis (cppcheck)

2011-06-30 Thread Julian Foad
On Wed, 2011-06-29 at 17:39 +0100, Philip Martin wrote: Julian Foad julian.f...@wandisco.com writes: [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:203]: (style) Variable 'app' is assigned a value that is never used [SVN\subversion\libsvn_auth_kwallet\kwallet.cpp:273]: (style)

Re: Static code analysis (cppcheck)

2011-06-30 Thread Philip Martin
Julian Foad julian.f...@wandisco.com writes: To remove the warning I suppose we could drop the app variable, i.e. new QCoreApplication(...) instead of app = new QCoreApplication(...) but that might prompt other warnings. The existing code creates the object and

Re: Static code analysis (cppcheck)

2011-06-30 Thread Julian Foad
Philip Martin wrote: Julian Foad julian.f...@wandisco.com writes: To remove the warning I suppose we could drop the app variable, i.e. new QCoreApplication(...) instead of app = new QCoreApplication(...) but that might prompt other warnings. The existing

API review - svn_wc_is_wc_root2()

2011-06-30 Thread Julian Foad
Should we rename this function to something like is_wc_root_or_switched? I think it's confusing that its notion of a WC root doesn't correspond to mine. /** Set @a *wc_root to @c TRUE if @a local_abspath represents a working copy * root, @c FALSE otherwise. Here, @a local_abspath is a working

Re: Fwd: Build problems in Subversion (in Chinese)

2011-06-30 Thread Daniel Shahaf
Thanks for the pointer. Do we support httpd 2.3+ in 1.6.x? -- Daniel, trying to determine whether a backport is necessary vijay wrote on Thu, Jun 30, 2011 at 12:07:07 +0530: On Thursday 30 June 2011 07:04 AM, Daniel Shahaf wrote: The problem is that the prototype of ap_log_rerror() in

Re: Static code analysis (cppcheck)

2011-06-30 Thread Daniel Shahaf
Bolstridge, Andrew wrote on Thu, Jun 30, 2011 at 08:44:41 +: (all in chapter 6 of the manual) Nonetheless, thanks for summarizing that here. I for one don't read the manual of every tool mentioned on the list :-)

Property handling in mailer.py's commit messages

2011-06-30 Thread Mathias Weinert
Hi, a long time ago (OMG it's almost 5 years) I added property handling to mailer.py's commit messages. Due to various (reasonable) reasons cmpilato reverted these changes (see archives here: http://svn.haxx.se/dev/archive-2006-09/0978.shtml). As Subversion 1.7 introduces 'svn patch' and

Re: Fwd: Build problems in Subversion (in Chinese)

2011-06-30 Thread vijay
On Thursday 30 June 2011 05:38 PM, Daniel Shahaf wrote: Thanks for the pointer. Do we support httpd 2.3+ in 1.6.x? This is from our INSTALL file in our source tree. snip Subversion tries to compile against the latest released version of Apache httpd 2.X. /snip I think we need to

Re: svn commit: r1141447 - /subversion/branches/svn-bisect/BRANCH-MILESTONES

2011-06-30 Thread C. Michael Pilato
On 06/30/2011 04:58 AM, ar...@apache.org wrote: Author: arwin Date: Thu Jun 30 08:58:11 2011 New Revision: 1141447 URL: http://svn.apache.org/viewvc?rev=1141447view=rev Log: Added branch milestones document. * BRANCH-MILESTONES : New file. Why a second branch-specific file? Put this

Final WC format bump before branch

2011-06-30 Thread Hyrum K Wright
We're almost ready to branch 1.7.x, and there remains the business of cleaning up the database schema from columns introduced in the 1.7 development cycle. This has historically be labelled 'format 99', and is found at the bottom of wc-metadata.sql. It feels that the current schema is stable, so

Re: svn commit: r1141291 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

2011-06-30 Thread Daniel Shahaf
C. Michael Pilato wrote on Thu, Jun 30, 2011 at 10:43:14 -0400: On 06/29/2011 06:25 PM, danie...@apache.org wrote: Author: danielsh Date: Wed Jun 29 22:25:35 2011 New Revision: 1141291 [...] + else +{ + return Unknown value for SVNPathAuthz directive; +}

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Philip Martin
kmra...@rockwellcollins.com writes: I know using traditional server backup software has never been recommended on fsfs repositories. However, since the server never rewrote any files after the transaction was finalized, the only previous issues with using a snapshot based backup mechanism

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Mark Phippard
On Thu, Jun 30, 2011 at 11:30 AM, kmra...@rockwellcollins.com wrote: Is there a way to disable fsfs revprop packing, or at least have it function in an atomic way like the regular rev packing? My understanding is that this is an opt-in feature. Don't you have to run the svnadmin pack command

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread kmradke
Philip Martin philip.mar...@wandisco.com wrote on 06/30/2011 11:53:54 AM: I know using traditional server backup software has never been recommended on fsfs repositories. However, since the server never rewrote any files after the transaction was finalized, the only previous issues with

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Mark Phippard
On Thu, Jun 30, 2011 at 2:06 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: You can't currently pack revision shards unless you also pack revprop shards.  (but that's easy to change) FWIW, that was my assumption. I do not personally think that is a big deal. To me the key is that revprops

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread kmradke
Philip Martin philip.mar...@wandisco.com wrote on 06/30/2011 12:43:54 PM: - since 1.6, if FSFS rep-sharing is not disabled there is the problem of copying the rep-sharing SQLite database. rep-cache.db? I thought that could be easily regenerated. Is there another .db file I

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
kmra...@rockwellcollins.com wrote on Thu, Jun 30, 2011 at 13:15:39 -0500: What I don't know is if the revprop SQLite db in 1.7 is essential to the operation of the repo. It's essential. It stores the only copy of revision properties of revisions [0, ffd-min_unpacked_rev). If it can't be

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
Mark Phippard wrote on Thu, Jun 30, 2011 at 14:22:59 -0400: On Thu, Jun 30, 2011 at 2:21 PM, kmra...@rockwellcollins.com wrote: Mark Phippard markp...@gmail.com wrote on 06/30/2011 01:08:52 PM: On Thu, Jun 30, 2011 at 2:06 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: You can't

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Mark Phippard
On Thu, Jun 30, 2011 at 2:31 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: The reason SQLite was used is that rev props can be edited via svn prop*--revprop So you could also disable the pre-revprop-change hook during a backup and that should make you safe.  And if you have not enabled it

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
Mark Phippard wrote on Thu, Jun 30, 2011 at 14:36:40 -0400: On Thu, Jun 30, 2011 at 2:31 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: The reason SQLite was used is that rev props can be edited via svn prop*--revprop So you could also disable the pre-revprop-change hook during a

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread kmradke
Daniel Shahaf d...@daniel.shahaf.name wrote on 06/30/2011 01:41:51 PM: The reason SQLite was used is that rev props can be edited via svn prop*--revprop So you could also disable the pre-revprop-change hook during a backup and that should make you safe. And if you have not enabled

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
kmra...@rockwellcollins.com wrote on Thu, Jun 30, 2011 at 13:46:46 -0500: Daniel Shahaf d...@daniel.shahaf.name wrote on 06/30/2011 01:41:51 PM: The reason SQLite was used is that rev props can be edited via svn prop*--revprop So you could also disable the pre-revprop-change hook

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Philip Martin
Daniel Shahaf d...@daniel.shahaf.name writes: Or asked a different way, does a new commit update the revprop.db or does it just create files like 1.6 did and things are only added to the db during svnadmin pack... The latter. Only is wrong, revprop editing updates the db. -- Philip

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread kmradke
Philip Martin philip.mar...@wandisco.com wrote on 06/30/2011 01:54:15 PM: Daniel Shahaf d...@daniel.shahaf.name writes: Or asked a different way, does a new commit update the revprop.db or does it just create files like 1.6 did and things are only added to the db during svnadmin pack...

Re: recover_body() ### What if rNNN legitimately has no revprops? was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Philip Martin
Daniel Shahaf danie...@elego.de writes: Philip Martin wrote on Thu, Jun 30, 2011 at 19:48:25 +0100: for i in $(seq 0 $(svnlook youngest repo)) ; do sqlite3 repo/db/revprops/revprops.db insert into revprop values ($i, '()' done From recover_body(): /* No file? Hrm... maybe

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Ivan Zhakov
On Thu, Jun 30, 2011 at 22:22, Mark Phippard markp...@gmail.com wrote: On Thu, Jun 30, 2011 at 2:21 PM,  kmra...@rockwellcollins.com wrote: Mark Phippard markp...@gmail.com wrote on 06/30/2011 01:08:52 PM: On Thu, Jun 30, 2011 at 2:06 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: You

Re: recover_body() ### What if rNNN legitimately has no revprops? was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
Philip Martin wrote on Thu, Jun 30, 2011 at 20:07:45 +0100: Daniel Shahaf danie...@elego.de writes: Philip Martin wrote on Thu, Jun 30, 2011 at 19:48:25 +0100: for i in $(seq 0 $(svnlook youngest repo)) ; do sqlite3 repo/db/revprops/revprops.db insert into revprop values ($i, '()'

Re: recover_body() ### What if rNNN legitimately has no revprops? was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Jun 30, 2011 at 22:48:27 +0300: Philip Martin wrote on Thu, Jun 30, 2011 at 20:07:45 +0100: Daniel Shahaf danie...@elego.de writes: Philip Martin wrote on Thu, Jun 30, 2011 at 19:48:25 +0100: for i in $(seq 0 $(svnlook youngest repo)) ; do sqlite3

Re: Apache Subversion 1.7.0-alpha2 Released

2011-06-30 Thread Hyrum K Wright
On Thu, Jun 30, 2011 at 3:08 PM, Barry Scott ba...@barrys-emacs.org wrote: On 23 Jun 2011, at 23:13, Hyrum Wright wrote: I'm happy to announce Apache Subversion 1.7.0-alpha2, the next public pre-release of the 1.7.x series, is now available.  Please choose the closest mirror to you by

Re: svn commit: r1141683 - /subversion/branches/svn_mutex/

2011-06-30 Thread Hyrum K Wright
With such a tantalizing name, I look forward to seeing the BRANCH-README more fully explaining this branches purpose. -Hyrum On Thu, Jun 30, 2011 at 2:43 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Jun 30 19:43:31 2011 New Revision: 1141683 URL:

Re: recover_body() ### What if rNNN legitimately has no revprops? was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Daniel Shahaf
A consequence of this thread is r1141699, which documents the All revisions must have rows rule and enforces it at database read time. Daniel Shahaf wrote on Thu, Jun 30, 2011 at 22:48:27 +0300: Philip Martin wrote on Thu, Jun 30, 2011 at 20:07:45 +0100: Daniel Shahaf danie...@elego.de writes:

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Peter Samuelson
[Ivan Zhakov] It should be easy to implement editing revprops without using SQLite: in case someone modify revprop non-packed revprop file is created, in read operation non-packed revprop file should be considered as more up-to-date. In next svnadmin pack operation these non-packed files

Re: svn commit: r1141683 - /subversion/branches/svn_mutex/

2011-06-30 Thread C. Michael Pilato
I was thinking *exactly* the same thing! On 06/30/2011 04:21 PM, Hyrum K Wright wrote: With such a tantalizing name, I look forward to seeing the BRANCH-README more fully explaining this branches purpose. -Hyrum On Thu, Jun 30, 2011 at 2:43 PM, stef...@apache.org wrote: Author: stefan2

revprop packing: why aren't _all_ revprops packed?

2011-06-30 Thread Peter Samuelson
[kmra...@rockwellcollins.com] I would love to have revprop packing, but not at the cost of potentially disabling the use of traditional backup software. Is there a way to disable fsfs revprop packing, or at least have it function in an atomic way like the regular rev packing? Hijacking the

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Hyrum K Wright
On Thu, Jun 30, 2011 at 3:27 PM, Peter Samuelson pe...@p12n.org wrote: [Ivan Zhakov] It should be easy to implement editing revprops without using SQLite: in case someone modify revprop non-packed revprop file is created, in read operation non-packed revprop file should be considered as more

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Erik Huelsmann
Hi Hyrum, On Thu, Jun 30, 2011 at 11:33 PM, Hyrum K Wright hy...@hyrumwright.orgwrote: On Thu, Jun 30, 2011 at 3:27 PM, Peter Samuelson pe...@p12n.org wrote: [Ivan Zhakov] It should be easy to implement editing revprops without using SQLite: in case someone modify revprop non-packed

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Peter Samuelson
[Hyrum K Wright] I like this idea, but it would seem to introduce an additional stat() call* for every attempt to fetch a revprop, because you'd first have to check the old location, and then the packed one. Technically not an extra stat(), but an extra open(). Not the same. Especially since

Re: svn commit: r1141683 - /subversion/branches/svn_mutex/

2011-06-30 Thread Greg Stein
Right. How will svn_mutex be better than APR's? Gotta understand the motivation. On Jun 30, 2011 4:22 PM, Hyrum K Wright hy...@hyrumwright.org wrote: With such a tantalizing name, I look forward to seeing the BRANCH-README more fully explaining this branches purpose. -Hyrum On Thu, Jun 30,

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-06-30 Thread Ivan Zhakov
On Fri, Jul 1, 2011 at 02:57, Peter Samuelson pe...@p12n.org wrote: [Hyrum K Wright] I like this idea, but it would seem to introduce an additional stat() call* for every attempt to fetch a revprop, because you'd first have to check the old location, and then the packed one. In simple