Checkout a working copy that contains versioned directories from a
server using v1 and serf. The network traffic includes
lp2:md5-checksum###error###/lp2:md5-checksum
for each directory. It turns out that dav_svn__insert_all_liveprops
doesn't distinguish between files and directories and
On Mon, Jan 30, 2012 at 12:00, Philip Martin philip.mar...@wandisco.com wrote:
...
opeartions may trigger this code. Should dav_svn__insert_all_liveprops
be determining the node type before requesting a checksum?
Yes, I believe that makes sense. The dav plugin should not define a
checksum
On Wed, Feb 01, 2012 at 12:12:39PM -0800, Alexey Neyman wrote:
Hi Stefan,
Oops, I forgot to send it out after applying the feedback comments. Nothing
to
be sorry about. Here it is, updated to apply to r1239239.
Thanks! Committed in r1239553.
I'll make some more follow-up tweaks, but
Greg Stein gst...@gmail.com writes:
On Mon, Jan 30, 2012 at 12:00, Philip Martin philip.mar...@wandisco.com
wrote:
...
opeartions may trigger this code. Should dav_svn__insert_all_liveprops
be determining the node type before requesting a checksum?
Yes, I believe that makes sense. The dav
Okay, maybe I wasn't clear enough. :-)
RFC:
Create a role account on svn-qavm.apache.org and have it run
backport.pl once a day, at 4am UTC, _and commit the resulting
merges_.
Impact on the backport process:
- The RM still needs to verify that STATUS is empty before rolling
a
Philip Martin wrote on Thu, Feb 02, 2012 at 12:07:54 +:
Greg Stein gst...@gmail.com writes:
On Mon, Jan 30, 2012 at 12:00, Philip Martin philip.mar...@wandisco.com
wrote:
...
opeartions may trigger this code. Should dav_svn__insert_all_liveprops
be determining the node type
Daniel Shahaf wrote:
Create a role account on svn-qavm.apache.org and have it run
backport.pl once a day, at 4am UTC, _and commit the resulting
merges_.
Sounds good to me. +1.
[...]
- Approved STATUS entries that are not to be auto-merged will need to
be designated as
Julian Foad wrote:
hwri...@apache.org wrote:
URL: http://svn.apache.org/viewvc?rev=1208833view=rev
Log:
In libsvn_wc, when fetching props for the Ev2 shims, add a flag to the
baton so we can fetch the proper kind of props, either actual or base,
depending on the application.
That
On Thu, Feb 2, 2012 at 5:35 AM, s...@apache.org wrote:
Author: stsp
Date: Thu Feb 2 11:35:09 2012
New Revision: 1239553
URL: http://svn.apache.org/viewvc?rev=1239553view=rev
Log:
Add --no-diff-properties and --patch options to 'svn diff'.
The --patch option implies --no-diff-properties
Julian Foad wrote on Thu, Feb 02, 2012 at 12:53:38 +:
Daniel Shahaf wrote:
Create a role account on svn-qavm.apache.org and have it run
backport.pl once a day, at 4am UTC, _and commit the resulting
merges_.
Sounds good to me. +1.
Thanks.
[...]
- Approved
On Thu, Feb 2, 2012 at 7:03 AM, Julian Foad julianf...@btopenworld.com wrote:
Julian Foad wrote:
hwri...@apache.org wrote:
URL: http://svn.apache.org/viewvc?rev=1208833view=rev
Log:
In libsvn_wc, when fetching props for the Ev2 shims, add a flag to the
baton so we can fetch the proper
On Wed, Jan 25, 2012 at 2:47 PM, Hyrum K Wright
hyrum.wri...@wandisco.com wrote:
On Wed, Jan 25, 2012 at 5:27 PM, Hyrum K Wright
hyrum.wri...@wandisco.com wrote:
This mail is very non-committal, but from the looks of CHANGES and
STATUS there are number of items which could potentially make up
On Thu, Feb 02, 2012 at 07:13:46AM -0600, Hyrum K Wright wrote:
Bikeshed: since the fact that we are using diff is implied by the
subcommand, would it be reasonable to use a more generic option name,
such as '--ignore-props' instead of '--no-diff-properties'. It is
shorter firstly, and second
Hi, Johan,
Von: Johan Corveleyn [mailto:jcor...@gmail.com]
Perhaps this issue can be deferred if the API would allow you to get / cache
all the inheritable props, up to the repository root (since they are always
readable anyway, regardless of authz). Not only up to the nearest path-wise
On Thu, Feb 2, 2012 at 7:46 AM, s...@apache.org wrote:
Author: stsp
Date: Thu Feb 2 13:46:11 2012
New Revision: 1239617
URL: http://svn.apache.org/viewvc?rev=1239617view=rev
Log:
Rename the new --no-diff-properties option to --ignore-properties.
This allows the option to be re-used by
If I have passwords stored in the GNOME keyring and the keyring is
unlocked Subversion will read the passwords even when --non-interactive
is passed. However if I have passwords stored in the KDE wallet and the
wallet is open Subversion will not read the stored passwords when
--non-interactive is
Philip Martin wrote:
I can fix kwallet with this patch:
[...]
Great.
Without the patch:
* Non-interactive commands will not try to authenticate from the
kwallet, and instead attempt the next authentication method which will
typically fail, leaving the user puzzled because the same command
[Hiroaki Nakamura]
In option (2), we do n12n on all clients on all platforms, and we
include web_dav_svn in clients. So we convert all input paths to
the server encoding, which is NFC.
Indeed. But the very concept of a server encoding means we are
involving the server side. Which invokes a
CC += dev@
Stefan Sperling wrote on Thu, Feb 02, 2012 at 19:43:12 +0100:
On Thu, Feb 02, 2012 at 07:57:58PM +0200, Daniel Shahaf wrote:
Neels J Hofmeyr wrote on Thu, Feb 02, 2012 at 17:51:01 +0100:
+becomes possible. Note that your hook scripts must then
+
On Thu, Feb 02, 2012 at 09:23:26PM +0200, Daniel Shahaf wrote:
CC += dev@
Stefan Sperling wrote on Thu, Feb 02, 2012 at 19:43:12 +0100:
On Thu, Feb 02, 2012 at 07:57:58PM +0200, Daniel Shahaf wrote:
Neels J Hofmeyr wrote on Thu, Feb 02, 2012 at 17:51:01 +0100:
+becomes
On 02.02.2012 17:58, Philip Martin wrote:
However I am worried about the TOCTOU race. There is a small window
between isOpen and the subsequent readPassword during which the wallet
may get closed. This might cause --non-interactive to attempt to prompt
the user for a password.
So ...
2012/2/3 Peter Samuelson pe...@p12n.org:
[Hiroaki Nakamura]
In option (2), we do n12n on all clients on all platforms, and we
include web_dav_svn in clients. So we convert all input paths to
the server encoding, which is NFC.
Indeed. But the very concept of a server encoding means we are
Stefan Sperling wrote on Thu, Feb 02, 2012 at 20:45:06 +0100:
On Thu, Feb 02, 2012 at 09:23:26PM +0200, Daniel Shahaf wrote:
CC += dev@
Stefan Sperling wrote on Thu, Feb 02, 2012 at 19:43:12 +0100:
On Thu, Feb 02, 2012 at 07:57:58PM +0200, Daniel Shahaf wrote:
Neels J Hofmeyr wrote
On Thu, Feb 02, 2012 at 10:01:23PM +0200, Daniel Shahaf wrote:
Actually I was referring to the former: if admins may want to change
their hooks for UTF-8 support, then people who write generic hooks will
want to have an if() in their code.
What for?
The easiest thing we could so is to set
On 02.02.2012 20:59, Hiroaki Nakamura wrote:
So we need to change servers too. When servers read filenames from
repositories, they first convert to NFC and then process commands.
That won't work. You have to do the initial lookup in a
normalization-agnostic way, and neither BDB nor FSFS makes
Julian Foad wrote on Thu, Feb 02, 2012 at 18:46:23 +:
Seems like this fix is a big improvement already, and even better if
we can make it more consistent with the Gnome-keyring behaviour. If
we care about the races, we can see about fixing them later, if there
is any feasible way to do
Stefan Sperling wrote on Thu, Feb 02, 2012 at 21:04:26 +0100:
On Thu, Feb 02, 2012 at 10:01:23PM +0200, Daniel Shahaf wrote:
Actually I was referring to the former: if admins may want to change
their hooks for UTF-8 support, then people who write generic hooks will
want to have an if() in
On Thu, Feb 02, 2012 at 09:04:26PM +0100, Stefan Sperling wrote:
On Thu, Feb 02, 2012 at 10:01:23PM +0200, Daniel Shahaf wrote:
What guarantees that an English locale is installed?
Hmmm... you're right. These names aren't standardized at all.
Bummer. We'd have to let users pass a locale
Branko Čibej wrote on Thu, Feb 02, 2012 at 21:03:47 +0100:
On 02.02.2012 20:22, Peter Samuelson wrote:
[Hiroaki Nakamura]
In option (2), we do n12n on all clients on all platforms, and we
include web_dav_svn in clients. So we convert all input paths to
the server encoding, which is NFC.
2012/2/3 Branko Čibej br...@xbc.nu:
On 02.02.2012 20:59, Hiroaki Nakamura wrote:
So we need to change servers too. When servers read filenames from
repositories, they first convert to NFC and then process commands.
That won't work. You have to do the initial lookup in a
[Hiroaki Nakamura]
Existing repositories, I think it would be better to convert them too using
svndump/svnload. And we change svnload to convert filenames to NFC.
However in reality we cannot force users to convert every existing repository.
Also note that if you convert a repository (via
2012/2/3 Daniel Shahaf danie...@elego.de:
Branko Čibej wrote on Thu, Feb 02, 2012 at 21:03:47 +0100:
On 02.02.2012 20:22, Peter Samuelson wrote:
[Hiroaki Nakamura]
In option (2), we do n12n on all clients on all platforms, and we
include web_dav_svn in clients. So we convert all input
On 02.02.2012 20:22, Peter Samuelson wrote:
By proposing a client-only solution, I hope to avoid _all_ those
questions.
[Branko Cibej]
Can't see how that works, unless you either make the client-side
solution optional, create a mapping table, or make name lookup on the
server agnostic to
On Thu, Feb 02, 2012 at 10:17:23PM +0200, Daniel Shahaf wrote:
So that people can use the hooks regardless of their SVNUseUTF8 setting.
I mean, I didn't invent the concept that people write hooks and publish
it for the world to use. And such hooks need to be robust --- work with
a wide
Stefan Sperling wrote on Thu, Feb 02, 2012 at 21:37:53 +0100:
On Thu, Feb 02, 2012 at 10:17:23PM +0200, Daniel Shahaf wrote:
So that people can use the hooks regardless of their SVNUseUTF8 setting.
I mean, I didn't invent the concept that people write hooks and publish
it for the world
Hiroaki Nakamura wrote on Fri, Feb 03, 2012 at 05:33:02 +0900:
2012/2/3 Daniel Shahaf danie...@elego.de:
Branko Čibej wrote on Thu, Feb 02, 2012 at 21:03:47 +0100:
On 02.02.2012 20:22, Peter Samuelson wrote:
[Hiroaki Nakamura]
In option (2), we do n12n on all clients on all platforms,
On 02.02.2012 21:28, Hiroaki Nakamura wrote:
2012/2/3 Branko Čibej br...@xbc.nu:
On 02.02.2012 20:59, Hiroaki Nakamura wrote:
So we need to change servers too. When servers read filenames from
repositories, they first convert to NFC and then process commands.
That won't work. You have to do
On 02.02.2012 21:46, Daniel Shahaf wrote:
Stefan Sperling wrote on Thu, Feb 02, 2012 at 21:37:53 +0100:
But what do authors gain? Apart from assurance that they may write
UTF-8 characters in error messages I don't see any advantage.
If repos_path, or an fspath argument, isn't ASCII, can hook
2012/2/3 Peter Samuelson pe...@p12n.org:
[Hiroaki Nakamura]
Existing repositories, I think it would be better to convert them too using
svndump/svnload. And we change svnload to convert filenames to NFC.
However in reality we cannot force users to convert every existing
repository.
Also
On Thu, Feb 02, 2012 at 10:26:58PM +0100, Branko Čibej wrote:
On 02.02.2012 21:46, Daniel Shahaf wrote:
Stefan Sperling wrote on Thu, Feb 02, 2012 at 21:37:53 +0100:
But what do authors gain? Apart from assurance that they may write
UTF-8 characters in error messages I don't see any
On Thu, Feb 2, 2012 at 5:13 PM, danie...@apache.org wrote:
Author: danielsh
Date: Thu Feb 2 16:13:20 2012
New Revision: 1239695
URL: http://svn.apache.org/viewvc?rev=1239695view=rev
Log:
Merge the r1207555 group from trunk:
* r1207555, r1207808
mod_dontdothat: contrib/ - tools/ and
On Feb 2, 2012, at 23:18 , Johan Corveleyn wrote:
On Thu, Feb 2, 2012 at 5:13 PM, danie...@apache.org wrote:
Author: danielsh
Date: Thu Feb 2 16:13:20 2012
New Revision: 1239695
URL: http://svn.apache.org/viewvc?rev=1239695view=rev
Log:
Merge the r1207555 group from trunk:
*
On Thu, Feb 2, 2012 at 11:22 PM, Stephen Butler sbut...@elego.de wrote:
On Feb 2, 2012, at 23:18 , Johan Corveleyn wrote:
On Thu, Feb 2, 2012 at 5:13 PM, danie...@apache.org wrote:
Author: danielsh
Date: Thu Feb 2 16:13:20 2012
New Revision: 1239695
URL:
-Original Message-
From: Johan Corveleyn [mailto:jcor...@gmail.com]
Sent: donderdag 2 februari 2012 14:36
To: Stephen Butler
Cc: dev@subversion.apache.org; rhuij...@apache.org; Stefan Sperling; C.
Michael Pilato
Subject: Re: svn commit: r1239695 - in /subversion/branches/1.7.x: ./
On 02/02/2012 03:29 PM, s...@apache.org wrote:
Author: stsp
Date: Thu Feb 2 23:29:11 2012
New Revision: 1239926
URL: http://svn.apache.org/viewvc?rev=1239926view=rev
Log:
Add a public libsvn_repos API to set the environment of hook scripts.
Modified:
Blair Zajac wrote on Thu, Feb 02, 2012 at 15:41:48 -0800:
On 02/02/2012 03:29 PM, s...@apache.org wrote:
+/** Set the environment that @ repos's hooks will inherit.
+ * If this function is not called, hooks will run in an empty environment.
+ * @since New in 1.8. */
Is NULL OK? How is the
On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote:
It doesn't look like it's multithreaded safe to set, but should it be?
I am not sure.
Note that this isn't changing the environment of the currently running
process. It takes effect in the child process that runs a hook.
The intended
On 02/02/2012 05:07 PM, Stefan Sperling wrote:
On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote:
It doesn't look like it's multithreaded safe to set, but should it be?
I am not sure.
Note that this isn't changing the environment of the currently running
process. It takes effect in
48 matches
Mail list logo
