On Thu, May 31, 2012 at 12:43 AM, Vladimir Berezniker
wrote:
> Patch 01 - Introduce macro
>
> [[[
> JavaHL: Added CPPADDR_NULL_PTR macro to reduce amount of duplicate code
> checking C++ pointer extracted from the java object
>
> [ in subversion/bindings/javahl/native ]
>
> * JNIUtil.h
> (CPPADD
On Thu, May 31, 2012 at 3:35 AM, Greg Stein wrote:
>...
> Fix the above three problems, and I'm +1 for you to commit just patch #1.
To clarify: I trust you to make the three changes, and you're free to
commit with my +1. I don't need another round of review.
(if something is missing, then we can
On Wed, May 30, 2012 at 8:52 PM, wrote:
> Author: rhuijben
> Date: Wed May 30 16:52:36 2012
> New Revision: 1344347
>
> URL: http://svn.apache.org/viewvc?rev=1344347&view=rev
> Log:
> Remove about 15% of the cpu overhead of svnserve and httpd while running the
> test suite by introducing a very s
On Thu, May 31, 2012 at 3:41 AM, Ivan Zhakov wrote:
> On Wed, May 30, 2012 at 8:52 PM, wrote:
>> Author: rhuijben
>> Date: Wed May 30 16:52:36 2012
>> New Revision: 1344347
>>
>> URL: http://svn.apache.org/viewvc?rev=1344347&view=rev
>> Log:
>> Remove about 15% of the cpu overhead of svnserve an
On Thu, May 31, 2012 at 11:49 AM, Greg Stein wrote:
> On Thu, May 31, 2012 at 3:41 AM, Ivan Zhakov wrote:
>> On Wed, May 30, 2012 at 8:52 PM, wrote:
>>> Author: rhuijben
>>> Date: Wed May 30 16:52:36 2012
>>> New Revision: 1344347
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1344347&view=rev
>
> -Original Message-
> From: Greg Stein [mailto:gst...@gmail.com]
> Sent: donderdag 31 mei 2012 9:49
> To: Ivan Zhakov
> Cc: dev@subversion.apache.org; Bert Huijben
> Subject: Re: svn commit: r1344347 -
> /subversion/trunk/subversion/libsvn_subr/config_file.c
>
> On Thu, May 31, 2012 at
Ivan Zhakov writes:
> Config files are also used for authz settings and they can be even
> more than 100 MB in real world scenarios.
Yes, particularly for setups that use SVNParentPath but not the new
AuthzSVNReposRelativeAccessFile.
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.c
On Thu, May 31, 2012 at 4:39 AM, Philip Martin
wrote:
> Ivan Zhakov writes:
>
>> Config files are also used for authz settings and they can be even
>> more than 100 MB in real world scenarios.
>
> Yes, particularly for setups that use SVNParentPath but not the new
> AuthzSVNReposRelativeAccessFil
- Original Message -
> From: Greg Stein
> To: Vladimir Berezniker
> Cc: dev@subversion.apache.org
> Sent: Thursday, 31 May 2012, 8:35
> Subject: Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check
> C++ pointer extracted from the java object
>
> On Thu, May 31, 2012 at
Greg Stein writes:
> On Thu, May 31, 2012 at 4:39 AM, Philip Martin
> wrote:
>> Ivan Zhakov writes:
>>
>>> Config files are also used for authz settings and they can be even
>>> more than 100 MB in real world scenarios.
>>
>> Yes, particularly for setups that use SVNParentPath but not the new
>
On Thu, May 31, 2012 at 1:27 PM, Greg Stein wrote:
> On Thu, May 31, 2012 at 4:39 AM, Philip Martin
> wrote:
>> Ivan Zhakov writes:
>>
>>> Config files are also used for authz settings and they can be even
>>> more than 100 MB in real world scenarios.
>>
>> Yes, particularly for setups that use
On Thu, May 10, 2012 at 2:13 PM, wrote:
> Author: rhuijben
> Date: Thu May 10 19:13:11 2012
> New Revision: 1336833
>
> URL: http://svn.apache.org/viewvc?rev=1336833&view=rev
> Log:
> Make the text and property merge handling of 'svn merge' of a single file an
> atomic operation by moving the han
On Thu, May 31, 2012 at 02:27:28PM -, hwri...@apache.org wrote:
> Author: hwright
> Date: Thu May 31 14:27:28 2012
> New Revision: 1344741
>
> URL: http://svn.apache.org/viewvc?rev=1344741&view=rev
> Log:
> When running diff, determine the depth capability *before* using it.
>
> * subversion/
[moving this thread from users@ to dev@]
On Thu, May 31, 2012 at 05:22:41PM +0200, Stefan Sperling wrote:
> On Thu, May 31, 2012 at 02:36:56PM +0100, neil.tu...@rwe.com wrote:
> > I would like to confirm this issue in v 1.6.17 - using binary files
> > via TortoiseSVN. Test scenario was to create
On Wed, May 30, 2012 at 07:55:34AM +0100, Julian Foad wrote:
> If you're using _lexically on these paths, please explain this in a comment,
> otherwise this will be confusing to readers.
Bert expanded the docstring of svn_sort_compare_items_lexically
in r1344158. I guess that addresses your conce
Stefan Sperling wrote:
> [moving this thread from users@ to dev@]
>
> On Thu, May 31, 2012 at 05:22:41PM +0200, Stefan Sperling wrote:
>> On Thu, May 31, 2012 at 02:36:56PM +0100, neil.tu...@rwe.com wrote:
>> > I would like to confirm this issue in v 1.6.17 - using binary files
>> > via Tortoi
Stefan Sperling wrote:
> On Wed, May 30, 2012 at 07:55:34AM +0100, Julian Foad wrote:
>> If you're using _lexically on these paths, please explain this in a
>> comment, otherwise this will be confusing to readers.
>
> Bert expanded the docstring of svn_sort_compare_items_lexically
> in r1344158
On Thu, May 31, 2012 at 07:12:08PM +0100, Julian Foad wrote:
> Stefan Sperling wrote:
>
> > On Wed, May 30, 2012 at 07:55:34AM +0100, Julian Foad wrote:
> >> If you're using _lexically on these paths, please explain this in a
> >> comment, otherwise this will be confusing to readers.
> >
> > Be
The point of this diff is to ensure that "svnadmin dump" lists the deleted nodes
in a consistent order between runs. At this point in the code, we're just
dealing with a list of strings, so it really doesn't matter, we just need them
in a consistent ordering. lexically looks simpler and fast
On May 31, 2012 1:30 PM, wrote:
>...
> +++ subversion/trunk/tools/dev/mergegraph/save_as_sh.py Thu May 31
17:30:17 2012
>...
> +def command(out, cmd, *args):
> + """Write the shell command CMD with the arguments ARGS to the file-like
> + object OUT."""
Please review my earlier comments about
Hi Team,
I hereby attached a patch to add a question in FAQ section. I am hoping
it helps some end users who encounters this client side 'Error
validating server' issue.
I believe the attached patch and log message is self explanatory. Please
let me know if I have missed something important.
On Thu, May 31, 2012 at 02:31:01PM -0400, Dustin Lang wrote:
>
> The point of this diff is to ensure that "svnadmin dump" lists the
> deleted nodes in a consistent order between runs. At this point in
> the code, we're just dealing with a list of strings, so it really
> doesn't matter, we just ne
I think we'd also like to get output that is similar to what happened
with ARP-1.4.5 (i.e. before the hash table randomness change in APR-1.4.6).
I believe that was equivalent to lexical sort. The entries are hash keys,
and the hash function in APR didn't result in the kind of ordering that
svn_
On May 31, 2012 2:52 PM, "Stefan Sperling" wrote:
>
> On Thu, May 31, 2012 at 02:31:01PM -0400, Dustin Lang wrote:
> >
> > The point of this diff is to ensure that "svnadmin dump" lists the
> > deleted nodes in a consistent order between runs. At this point in
> > the code, we're just dealing wit
On Thu, May 31, 2012 at 03:09:01PM -0400, Greg Stein wrote:
> Why ever would we want to rely in any way on a hash table iterator's order?
> What!?
You misunderstood what I wrote. I'm not suggesting we do so.
I was just assuming that the APR-1.4.5 resulted in lexically sorted
output (and apparent
On Fri, Jun 01, 2012 at 12:20:23AM +0530, Jeyanthan wrote:
> Hi Team,
>
> I hereby attached a patch to add a question in FAQ section. I am
> hoping it helps some end users who encounters this client side
> 'Error validating server' issue.
>
> I believe the attached patch and log message is self e
On Thu, May 31, 2012 at 2:35 AM, Greg Stein wrote:
> On Thu, May 31, 2012 at 12:43 AM, Vladimir Berezniker
> wrote:
>> Patch 01 - Introduce macro
>>
>> [[[
>> JavaHL: Added CPPADDR_NULL_PTR macro to reduce amount of duplicate code
>> checking C++ pointer extracted from the java object
>>
>> [ in
On Thu, May 31, 2012 at 4:36 AM, Julian Foad wrote:
>
>
>
>
> - Original Message -
>> From: Greg Stein
>> To: Vladimir Berezniker
>> Cc: dev@subversion.apache.org
>> Sent: Thursday, 31 May 2012, 8:35
>> Subject: Re: [PATCH] JavaHL: Reduce amount of duplicate code used to check
>> C++ po
Greg Stein wrote:
>On May 31, 2012 1:30 PM, wrote:
>>...
>> +++ subversion/trunk/tools/dev/mergegraph/save_as_sh.py Thu May 31 17:30:17
>> 2012
>>...
>> +def command(out, cmd, *args):
>> + """Write the shell command CMD with the arguments ARGS to the file-like
>> + object OUT."""
>Please re
I (Julian Foad) wrote:
> Greg Stein wrote:
>>> +def command(out, cmd, *args):
>>> + """Write the shell command CMD with the arguments ARGS to the file-like
>>> + object OUT."""
>> Please review my earlier comments about standard docstring formatting in
>> Python. More specifically, PEP 8.
On May 31, 2012 4:45 PM, "Julian Foad" wrote:
>
> I (Julian Foad) wrote:
>
> > Greg Stein wrote:
> >>> +def command(out, cmd, *args):
> >>> + """Write the shell command CMD with the arguments ARGS to the
file-like
> >>> + object OUT."""
> >> Please review my earlier comments about standard
On Thu, May 31, 2012 at 3:35 AM, Greg Stein wrote:
> On Thu, May 31, 2012 at 12:43 AM, Vladimir Berezniker
> wrote:
> > Patch 01 - Introduce macro
> >
> > [[[
> > JavaHL: Added CPPADDR_NULL_PTR macro to reduce amount of duplicate code
> > checking C++ pointer extracted from the java object
> >
>
I applied the patch to the javahl-ra branch instead of the trunk by
mistake, is
it ok if a cherry pick it onto trunk?
Sorry about that,
Vladimir
On Thu, May 31, 2012 at 3:37 AM, Greg Stein wrote:
> On Thu, May 31, 2012 at 3:35 AM, Greg Stein wrote:
> >...
> > Fix the above three problems, and
Attached please find a followup patch that fixes issues you have raised for
CPPADDR_NULL_PTR for other macros in JNIUtil.h, so that they become
consistent.
[[[
JavaHL: Make handling of expr and whitespace after ret_val parameters
consistent accross macros
[ in subversion/bindings/javahl/native ]
+1
On May 31, 2012 11:25 PM, "Vladimir Berezniker" wrote:
> I applied the patch to the javahl-ra branch instead of the trunk by
> mistake, is
> it ok if a cherry pick it onto trunk?
>
> Sorry about that,
>
> Vladimir
>
> On Thu, May 31, 2012 at 3:37 AM, Greg Stein wrote:
>
>> On Thu, May 31, 201
On May 31, 2012 11:07 PM, "Vladimir Berezniker" wrote:
> On Thu, May 31, 2012 at 3:35 AM, Greg Stein wrote:
>>...
>> (sorry, but the patch doesn't inline into this response, so let's just
>> be flexible here...)
>>
> Sorry, I cannot figure out how to get gmail to inline attachments, I'll
setup
>
+1 for trunk. Thanks.
On May 31, 2012 11:28 PM, "Vladimir Berezniker" wrote:
> Attached please find a followup patch that fixes issues you have raised
> for
> CPPADDR_NULL_PTR for other macros in JNIUtil.h, so that they become
> consistent.
>
> [[[
> JavaHL: Make handling of expr and whitespace a
37 matches
Mail list logo
