Re: [PATCH] minor change to mailer.py for subject formatting

> And thanks, Janos, for the contribution and patient survival of our > iterative patch review process. :-) It would have been a shorter process if I had got it right in the first place ;-) And you're totally welcome! Janos On Mon, Jan 28, 2013 at 8:23 PM, Daniel Shahaf wrote: > C. Michael Pil

Re: [PATCH] minor change to mailer.py for subject formatting

C. Michael Pilato wrote on Mon, Jan 28, 2013 at 13:21:55 -0500: > On 01/28/2013 12:29 PM, Daniel Shahaf wrote: > > I'll commit with cmpilato's tweaks (indentation and varname) as I agree > > with them both. > > r1439592. @Greg - ACK, but 'repos' _is_ consistent with the naming scheme of just abo

Re: problems with merging

Stefan Sperling wrote: > On Sun, Jan 27, 2013 at 04:06:09PM +0100, Stefan Küng wrote: >> using a build from the svn trunk (as of r1439016), I've discovered a >> few problems when merging. >> >> svn co -r23862 >> https://tortoisesvn.googlecode.com/svn/branches/1.7.x/src tsvnsrc >> cd tsvnsrc

Re: [PATCH] minor change to mailer.py for subject formatting

On 01/28/2013 12:29 PM, Daniel Shahaf wrote: > Ben Reser wrote on Mon, Jan 28, 2013 at 09:25:30 -0800: >> On Mon, Jan 28, 2013 at 5:59 AM, C. Michael Pilato >> wrote: >>> My only remaining minor nit is the variable name itself. First, other >>> variable names in this script use underscores to se

Re: Svn Update Bug

On Mon, Jan 28, 2013 at 2:11 AM, Lionel Loy wrote: > I currently have a bug in svn with coda 1 and 2. > When I do an update, the updated files are not transferred to the list of > files to publish. > The problem is servenu in a svn update 1.6.x to 1.7.x > Only my machine is in svn 1.7.x my colleag

Re: [PATCH] minor change to mailer.py for subject formatting

On Jan 28, 2013 3:59 AM, "C. Michael Pilato" wrote: > > On 01/27/2013 10:02 AM, Janos Gyerik wrote: > > If it helps, here's a last try: > > - wrapped the 3 long lines to 80 columns > > - PEP8 fixes (only on these 3 lines), such as removed space after "{", > > before ":", before "}" > > > > The onl

Re: [PATCH] minor change to mailer.py for subject formatting

Ben Reser wrote on Mon, Jan 28, 2013 at 09:25:30 -0800: > On Mon, Jan 28, 2013 at 5:59 AM, C. Michael Pilato > wrote: > > My only remaining minor nit is the variable name itself. First, other > > variable names in this script use underscores to separate words: for_repos, > > label_from, etc. S

Re: [PATCH] minor change to mailer.py for subject formatting

On Mon, Jan 28, 2013 at 5:59 AM, C. Michael Pilato wrote: > My only remaining minor nit is the variable name itself. First, other > variable names in this script use underscores to separate words: for_repos, > label_from, etc. Secondly, it's really only the basename of the directory > that's be

Re: [PATCH] Introduce AuthzSVNGroupsFile configuration option for mod_authz_svn

On Mon, Jan 28, 2013 at 3:10 AM, Philip Martin wrote: > Evgeny Kotkov writes: >> * With includes in the configuration files an evil-doer could perform >> cross-repository configuration includes. That theoretically allows >> examininig the authorization rules for restricted repositories

Re: [PATCH] Introduce AuthzSVNGroupsFile configuration option for mod_authz_svn

On Fri, Jan 25, 2013 at 2:30 AM, Philip Martin wrote: > Are administrators going to want both relative path and absolute path > versions of this directive? If you want repo unique groups you can just put it in authz file and not use this directive. So I kinda doubt there's a use for the repos re

Re: [PATCH] minor change to mailer.py for subject formatting

Maybe you're right. I don't mind whichever way you name that variable, please do as you see fit. Cheers, Janos On Mon, Jan 28, 2013 at 2:59 PM, C. Michael Pilato wrote: > On 01/27/2013 10:02 AM, Janos Gyerik wrote: >> If it helps, here's a last try: >> - wrapped the 3 long lines to 80 columns >

Re: [PATCH] minor change to mailer.py for subject formatting

On 01/27/2013 10:02 AM, Janos Gyerik wrote: > If it helps, here's a last try: > - wrapped the 3 long lines to 80 columns > - PEP8 fixes (only on these 3 lines), such as removed space after "{", > before ":", before "}" > > The only PEP8 violation that remain on these lines is "continuation > line

Re: [RFC] Deprecate Berkelety DB filesystem backend

On 2013-01-05 10:35:52 +, Philip Martin wrote: > Branko Čibej writes: > > > * The BDB backend is an order of magnitude slower on trunk than FSFS > > o timing parallel "make check" on my 4x4-core i7+ssd mac: > > + FSFS: real 7m33.213s, user 19m8.075s, sys 10m54.739s > >

Re: [PATCH] Introduce AuthzSVNGroupsFile configuration option for mod_authz_svn

Evgeny Kotkov writes: > * With includes in the configuration files an evil-doer could perform > cross-repository configuration includes. That theoretically allows > examininig the authorization rules for restricted repositories (e.g. via > bruteforce). Are you claiming the evil-do

Svn Update Bug

Hello, I currently have a bug in svn with coda 1 and 2. When I do an update, the updated files are not transferred to the list of files to publish. The problem is servenu in a svn update 1.6.x to 1.7.x Only my machine is in svn 1.7.x my colleagues stayed in 1.6.x. I am the only one to have this p

Re: [PATCH] Introduce AuthzSVNGroupsFile configuration option for mod_authz_svn

Philip, sorry for the delay in response (I was out of office). I have carefully considered the include-based approach for this feature, however, there probably are some drawbacks compared to the approach with the groups file directive: - Potential security issues in certain delegation scenarios.