Re: client side workaround for svnserve iprops bug

2014-03-19 Thread Daniel Shahaf
Philip Martin wrote on Wed, Mar 19, 2014 at 13:17:08 +: > Daniel Shahaf writes: > > > I would vote "+1 to backport" right here and now, but I'm a bit confused > > by the patch: it seems the client and server send and expect a bare > > boolean, whereas libsvn_ra_svn/protocol calls for a boolea

Re: 1.9.0-alpha2 up for testing/signing

2014-03-19 Thread Johan Corveleyn
On Tue, Mar 4, 2014 at 10:23 AM, Ben Reser wrote: > The 1.9.0-alpha2 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. There's no particular schedule to this it's > ready w

RE: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: woensdag 19 maart 2014 16:27 > To: Bert Huijben; 'Branko Čibej'; dev@subversion.apache.org > Subject: Re: r1577170 - remove wildcard handling from some .exe's on > Windows > > On 03/19/2014 11:12 AM, Bert

Re: 1.9.0-alpha2 up for testing/signing

2014-03-19 Thread Ben Reser
On 3/19/14, 3:50 AM, Julian Foad wrote: > The point of an alpha is it's up for testing despite having *known and > unknown* bugs. It would be absurd to wait for a non-show-stopper bug to be > fixed. Agreed, no reason to hold up for the SASL issue. The https certificate thing was a different mat

Re: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread C. Michael Pilato
On 03/19/2014 11:12 AM, Bert Huijben wrote: > Just to name a few: to set our binary properties, which we documented to just > allow '*' > > svn:needs-lock > svn:executable This is a kinda soft one, since we automatically normalize the values of these properties: $ svn pset svn:executable '' io

RE: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: woensdag 19 maart 2014 15:50 > To: Bert Huijben; 'C. Michael Pilato'; dev@subversion.apache.org > Subject: Re: r1577170 - remove wildcard handling from some .exe's on > Windows > > On 19.03.2014 14:59, Bert Hui

Re: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Branko Čibej
On 19.03.2014 14:59, Bert Huijben wrote: > > The problem is that you can’t quote… > > > > So while from python you can pass ‘*’ as an argument on unix, you > can’t do this on Windows… > And when, pray tell, do you ever have to pass a literal asterisk as an argument to Subversion? Give me one exa

RE: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Bert Huijben
The problem is that you can’t quote… So while from python you can pass ‘*’ as an argument on unix, you can’t do this on Windows… For a tool like ‘svnmucc’ which doesn’t have any ‘*’ handling of its own this makes the tool work less like on *nix, not work more like on Unix. I’m quit

Re: client side workaround for svnserve iprops bug

2014-03-19 Thread Philip Martin
Branko Čibej writes: >> We could declare want-iprops to be an error and remove it, that also >> risks breaking third party client. We could change the documentation >> of the protocol to match the released implementation, but that would >> mean accepting the "? foo" form rather than "(? foo)" and

Re: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread C. Michael Pilato
On 03/19/2014 09:00 AM, Branko Čibej wrote: > I disagree. It's more important that the tools behave similarly across > different platforms. Making some tools behave differently for others > to save people some argument quoting woes is just silly. +1. Uniformity across platforms was a major design

Re: client side workaround for svnserve iprops bug

2014-03-19 Thread Philip Martin
Philip Martin writes: > How do we fix this mess? We could change the server implementation of > the protocol to match the documentation, but that would risk breaking > third party clients. That's not right, it would likely break all clients. I don't think we can do that. I think we either cha

Re: client side workaround for svnserve iprops bug

2014-03-19 Thread Branko Čibej
On 19.03.2014 14:17, Philip Martin wrote: > How do we fix this mess? We could change the server implementation of > the protocol to match the documentation, but that would risk breaking > third party clients. A protocol implementation bug is still a bug. We fix it and describe the fix in the relea

Re: client side workaround for svnserve iprops bug

2014-03-19 Thread Philip Martin
Daniel Shahaf writes: > I would vote "+1 to backport" right here and now, but I'm a bit confused > by the patch: it seems the client and server send and expect a bare > boolean, whereas libsvn_ra_svn/protocol calls for a boolean wrapped in a > tuple. > > (i.e., '( foo bar true ) ' vs '( foo bar (

Re: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Branko Čibej
On 19.03.2014 12:29, Bert Huijben wrote: > Normal Windows applications don't expand '*' directly when passed on the > commandline (and neither does the Windows default shell). So before this > patch *all* our applications were special in their handling of '*' and '?', > while after this patch only

Re: 1.9.0-alpha2 up for testing/signing

2014-03-19 Thread Johan Corveleyn
On Tue, Mar 18, 2014 at 9:42 PM, Ben Reser wrote: > On 3/18/14, 9:52 AM, Johan Corveleyn wrote: >> I get one failure when testing with FSX: >> >> [[[ >> svn_tests: E160057: Node revision index 26 exceeds container size 26 >> FAIL: fs-x-pack-test.exe 3: read from a packed FSX filesystem >> ]]] >>

RE: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Bert Huijben
> -Original Message- > From: Julian Foad [mailto:julianf...@btopenworld.com] > Sent: woensdag 19 maart 2014 11:44 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: r1577170 - remove wildcard handling from some .exe's on > Windows > > > URL: http://svn.apache.org/r1577170

Re: 1.9.0-alpha2 up for testing/signing

2014-03-19 Thread Philip Martin
Summary: +1 to release Platform: Linux (Debian/wheezy) 64-bit Tested: (local, svn, svn/sasl, serf, serf/v1) x (fsfs, fsfs/pack/shard, bdb, fsx) swig-pl, swig-py, swig-rb, ctypes-python javahl x (fsfs, bdb, fsx) Results: getopt_tests.py 2 and 4 FAIL with KWallet enabled. svnserv

Re: 1.9.0-alpha2 up for testing/signing

2014-03-19 Thread Julian Foad
Stefan Fuhrmann wrote: > Philip Martin wrote: >> svnserve's SASL support is broken, see r1579080. > > It's a good to see that this alpha already uncovered > > a few feature breakages that we would usually not > see before the first beta. > >> How important is working SASL support? > > Hm. I don

Re: r1577170 - remove wildcard handling from some .exe's on Windows

2014-03-19 Thread Julian Foad
> URL: http://svn.apache.org/r1577170 > Log: > Following up on r1577164, remove the special '*' argument handling from all > Subversion .exe's except the few that really need this. > > After this patch > $ svnmucc.exe propset svn:special "*" URL -m "set svn:special" > > will work on Windows, whi

Re: Remove tools/buildbot from tarballs?

2014-03-19 Thread Julian Foad
Philip Martin wrote: > Is it worth stripping tools/buildbot from the tarball?  The files are no > real use in the tarball but they are not very big either, perhaps 12KB > in the tarball and 248KB unpacked. It seems a bit ugly to be selectively including and excluding parts of the 'tools' directo

Re: Remove tools/buildbot from tarballs?

2014-03-19 Thread Stefan Sperling
On Wed, Mar 19, 2014 at 12:51:40AM +, Philip Martin wrote: > Ben Reser writes: > > > The 1.9.0-alpha2 release artifacts are now available for testing/signing. > > Is it worth stripping tools/buildbot from the tarball? +1 I don't think anyone compiling from a tarball needs these files. Ind

Re: 1.9.0-alpha2 up for testing/signing

2014-03-19 Thread Stefan Sperling
On Wed, Mar 19, 2014 at 12:27:34AM +0100, Stefan Fuhrmann wrote: > On Wed, Mar 19, 2014 at 12:09 AM, Philip Martin > > svnserve's SASL support is broken, see r1579080. > > It's a good to see that this alpha already uncovered > a few feature breakages that we would usually not > see before the firs