Cleanup 1.14.x STATUS vote for back ports

2022-03-24 Thread Mark Phippard
I am inching closer to taking on the RM duties so it would be good if people started to clean up the STATUS file and get things merged. Looking at what is in there ... these items all seem Bindings related so don't they just need the 2 votes? Did someone just forget to move them to the Approved se

Re: Questions on Release Management Process

2022-03-24 Thread Daniel Shahaf
Mark Phippard wrote on Wed, 23 Mar 2022 11:36 +00:00: > On Tue, Mar 22, 2022 at 11:51 PM Daniel Shahaf > wrote: >> >> Mark Phippard wrote on Mon, Mar 21, 2022 at 16:46:55 -0400: >> > On Mon, Mar 21, 2022 at 4:31 PM Stefan Sperling wrote: >> > > On Mon, Mar 21, 2022 at 12:44:44PM -0400, Mark Phip

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
Finished and committed: https://svn.apache.org/r1899173 . This looks and feels much better to me now. Example: $ svn revert -R subversion/ Fetching text bases ..done Reverted 'subversion/svn/cat-cmd.c' Reverted 'subversion/svn/diff-cmd.c' Reverted [...] - Julian

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
Updated and cleaned-up patch 'hydrating-notifications-2.patch' attached, for interest. Still TODO: update test expectations. hydrating-notifications-2.patch Description: Binary data

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
Daniel Sahlberg wrote: > How does svn cat handle any other informative or warning messages? I don't think 'svn cat' prints any other informative or warning messages. It occurs to me now that anything on stderr is generally assumed to indicate an error, in tests in the test suite. We need to updat

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Daniel Sahlberg
Den tors 24 mars 2022 kl 11:34 skrev Julian Foad : > For 'svn diff' especially, if we don't print the notifications, then we > miss out on informing the user during one of the times when it could be > particularly valuable to them. (They are waiting for diff output, which > previously in svn used

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
For 'svn diff' especially, if we don't print the notifications, then we miss out on informing the user during one of the times when it could be particularly valuable to them. (They are waiting for diff output, which previously in svn used to come quickly.) It would be ugly to print these notificat

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Daniel Sahlberg
Den tors 24 mars 2022 kl 09:53 skrev Julian Foad : > Daniel Sahlberg wrote: > >> I'll put it on my todo list, but I can't promise when I find time to > >> to that. > > I only meant to ask you to clarify what you meant: whether you are > reporting for TSVN 1.14 or a TSVN 1.15-dev build (based on th

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
I made a mistake in: > 'svn cat' already suppresses these notifications. CORRECTION: 'svn cat' currently prints these notifications. 'svn diff' currently prints these notifications. --> TODO: stop printing them here. It seems the only change needed here is to make both 'svn diff' AND 'svn cat'

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
Daniel Sahlberg wrote: >> I'll put it on my todo list, but I can't promise when I find time to >> to that. I only meant to ask you to clarify what you meant: whether you are reporting for TSVN 1.14 or a TSVN 1.15-dev build (based on the pristines-on-demand branch or otherwise; I don't know if anyo

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Daniel Sahlberg
Den tors 24 mars 2022 kl 09:04 skrev Julian Foad : > Daniel, can you confirm if you mean you are using a 1.14-based TSVN, on > a 1.15 working copy, and it is showing bytes-transferred feedback during > the hydrating? I had assumed it would need to be rebuilt and modified to > do that. If that part

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Julian Foad
Marl Phippard wrote: > Yes, and I agree --quiet should suppress. [...TSVN] hooked into our > notifications to be providing an update on bytes transferred. [...] I > just assumed they would work ... maybe they still do? Daniel Sahlberg wrote: >> Yes, I like this very much. The more feedback [...] t

Re: Pristines-on-demand: printing progress notifications

2022-03-24 Thread Daniel Sahlberg
Den ons 23 mars 2022 kl 23:58 skrev Mark Phippard : > On Wed, Mar 23, 2022 at 5:51 PM Julian Foad wrote: > > > I thought maybe we would like to show this detail by default, and > > suppress it when '--quiet' is passed. (Not implemented in this demo > patch.) > > > > I was also mildly surprised to