Re: svn commit: r1869868 - /subversion/trunk/INSTALL

2019-11-15 Thread Daniel Shahaf
hartmannat...@apache.org wrote on Fri, Nov 15, 2019 at 16:21:00 -: > +++ subversion/trunk/INSTALL Fri Nov 15 16:20:59 2019 > @@ -120,17 +120,17 @@ I.INTRODUCTION > assembler modules of OpenSSL. As of OpenSSL 1.1.0 NASM is the > only supported assembler. > > + * Ber

Re: svn commit: r1869856 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-15 Thread Daniel Shahaf
hartmannat...@apache.org wrote on Fri, Nov 15, 2019 at 14:52:50 -: > Author: hartmannathan > Date: Fri Nov 15 14:52:50 2019 > New Revision: 1869856 > > URL: http://svn.apache.org/viewvc?rev=1869856&view=rev > Log: > In 'staging': 1.14 release notes: Explain when/how Python is required > > * d

Re: svn commit: r1869851 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/revert.c

2019-11-15 Thread Daniel Shahaf
julianf...@apache.org wrote on Fri, Nov 15, 2019 at 12:34:58 -: > +++ subversion/trunk/subversion/include/svn_client.h Fri Nov 15 12:34:57 2019 > @@ -4479,6 +4479,9 @@ svn_client_relocate(const char *dir, > * removed from the working copy. Otherwise, all items are reverted and > * their on-

Re: svn commit: r1869849 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-15 Thread Daniel Shahaf
julianf...@apache.org wrote on Fri, Nov 15, 2019 at 11:46:31 -: > +++ subversion/site/staging/docs/release-notes/1.14.html Fri Nov 15 11:46:31 > 2019 > @@ -219,7 +219,7 @@ users. We'll cover those in this sectio > -Subversion's SWIG Python bindings and automated test suite now > +Subversion's

Re: svn commit: r1869776 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-15 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Nov 15, 2019 at 00:40:08 -0500: > [[[ > Python is optional. > > Subversion does not require Python for its basic operation. In general, if > you are not using Subversion's SWIG Python bindings, hook scripts coded in > Python, or other tools that require Python, then th

Re: svn commit: r1869776 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-14 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 14 Nov 2019 18:14 +00:00: > On Thu, Nov 14, 2019 at 10:33 AM Daniel Shahaf > wrote: > > hartmannat...@apache.org wrote on Thu, 14 Nov 2019 05:26 +00:00: > > > + > > > +Python is Optional. > > > + > > > +Note that

Re: svn commit: r1869776 - /subversion/site/staging/docs/release-notes/1.14.html

2019-11-14 Thread Daniel Shahaf
hartmannat...@apache.org wrote on Thu, 14 Nov 2019 05:26 +00:00: > + > +Python is Optional. > + > +Note that Subversion does not require Python for its basic > +operation. If you are not using Subversion's SWIG Python bindings, > +automated test suite, or other Python-coded tools that ship with > +

Re: Issue tracker cleanup: SVN-807

2019-11-12 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 12 Nov 2019 15:13 +00:00: > Daniel, thanks for testing this and documenting how. Please, could > you add that as a comment in the issue tracker? Or, if you'd like, > I'll be happy to do that and attribute it to you. Go ahead. > I agree that this issue should be closed

Re: [offlist] Re: Merging branches/swig-py3 to trunk

2019-11-12 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, 12 Nov 2019 11:45 +00:00: > Nathan Hartman wrote on Mon, Nov 11, 2019 at 22:13:54 -0500: > > On Fri, Nov 8, 2019 at 3:13 AM Julian Foad wrote: > > > svn 1.9 Py 2.7 supported, Py 3.x not working > > > svn 1.10 Py 2.7 supported, Py 3.x+ supp

Re: Merging branches/swig-py3 to trunk

2019-11-12 Thread Daniel Shahaf
Julian Foad wrote on Tue, 12 Nov 2019 11:59 +00:00: > A thought about supporting older Python versions... Somewhere in the > pipeline between community inputs and project outputs, should we > distinguish between "we will not support ..." and "we will be glad to > accept contributions that enable

Re: [Patch] Supported SWIG version(Re: Supported SWIG version on swig-py3)

2019-11-12 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Nov 11, 2019 at 21:37:44 -0500: > * In the swig-x.y.z, directory, run ./configure (where x.y.z is > the SWIG version, e.g. 3.0.12). There should be a comma after "e.g.". Cheers, Daniel

Re: [offlist] Re: Merging branches/swig-py3 to trunk

2019-11-12 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Nov 11, 2019 at 22:13:54 -0500: > On Fri, Nov 8, 2019 at 3:13 AM Julian Foad wrote: > > > Nathan Hartman wrote: > > > Question: Some Python scripts have not been updated for Python 3.x > > > yet. Should those be listed in the release notes under "Known Issues"? > > >

Re: Issue tracker cleanup: SVN-807

2019-11-11 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, Nov 11, 2019 at 10:38:31 -0500: > Speaking of testing, is this related to last week's issue, SVN-2079, > which is unresolved, "SVN-2079 "utf8_tests.py should be made non- > iso8859-1 specific" and if one is solved, would that (help) solve the > other? The two issues ar

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-08 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, 07 Nov 2019 17:15 +00:00: > +++ subversion/tests/cmdline/info_tests.py(working copy) > @@ -644,6 +644,10 @@ def info_item_simple(sbox): > + svntest.actions.run_and_verify_svn( > +['1\tdir'], [], > +'info', '-

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Daniel Shahaf
Julian Foad wrote on Fri, 08 Nov 2019 13:00 +00:00: > Nathan Hartman wrote: > > > Friday% svn st -q > > > --- Changelist 'foo': > > > M       iota > > > Friday% vi A/mu > > > Friday% svn commit -mm --cl foo > > > Sending        iota > > > Sending        A/mu > > > # ... "Revert accidental c

Re: [offlist] Re: Merging branches/swig-py3 to trunk

2019-11-08 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Nov 08, 2019 at 01:39:46 -0500: > Since you wrote "Any other opinions?" I assume you intended to send > this to the list... (My reply follows below.) Yes, that's correct. I'd intended to reply offlist but changed my mind partway through drafting and neglected to chang

Re: [offlist] Re: Merging branches/swig-py3 to trunk

2019-11-08 Thread Daniel Shahaf
Julian Foad wrote on Fri, Nov 08, 2019 at 08:13:20 +: > If I did my search correctly, there is nothing about Python 3 in any of the > 1.10 through 1.14 release notes. Haven't we got something to say about > limited support (for build and test?) in some version before 1.14? All I > could find

Re: svn status should not show unmodified files in changelists

2019-11-08 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Nov 08, 2019 at 00:58:29 -0500: > Daniel suggested to leave the behavior of 'svn status' as-is, unless > 'svn status' is run with both -v and -q. That's not what I suggested. I suggested to modify the behaviour if -q is passed, *regardless* of whether -v is passed or

'svn info --show-item' doesn't print defaulted values

2019-11-07 Thread Daniel Shahaf
Consider this: [[[ % svn info INSTALL | grep Depth % svn info --show-item=depth INSTALL % ]]] Should the second command print "infinity" instead? Cheers, Daniel P.S. Aside: --show-item=schedule doesn't exist. Haven't checked whether any other fields are not selectable by --show-item..

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 07 Nov 2019 20:01 +00:00: > On 07.11.2019 20:25, Daniel Shahaf wrote: > >> We might want to allow using multiple options, like "--show-item=revision > >> --show-item=kind" in addition to comma-separated values. > > I don't think

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Daniel Shahaf
Julian Foad wrote on Thu, Nov 07, 2019 at 17:53:43 +: > We have said the outputs (except XML) simply are not intended to be parsed. We've said that? I think what we said is that the non-XML outputs _may_ be parsed, but with care, since they may change in minor releases as functionality gets a

Re: svn status tabbed output [was: Re: svn status should not show unmodified files in changelists]

2019-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Nov 07, 2019 at 17:28:35 +0100: > Not with a new option. Instead --show-item should accept a > comma-separated list of keywords. You mean, like this? [[[ % subversion/svn/svn info wc/foo --show-item=kind,schedule,relative-url dir add ^/foo % ]]] That's not a

Re: svn commit: r93535 - /pmc/subversion/machines/svn-qavm/notes.txt

2019-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 07 Nov 2019 11:57 +00:00: > On 07.11.2019 11:39, danie...@apache.org wrote: > > +++ pmc/subversion/machines/svn-qavm/notes.txt Thu Nov 7 10:39:27 2019 > > @@ -74,4 +74,12 @@ sudo update-rc.d wayita defaults > > +% ssh svn-qavm3.apache.org > > I thought the name of the V

Re: svn status should not show unmodified files in changelists

2019-11-07 Thread Daniel Shahaf
Julian Foad wrote on Wed, Nov 06, 2019 at 16:07:23 +: > Perhaps one aspect of being in a mature and stable phase of a project's life > means that if we are going to change how an existing feature works, we > should not change it one little bit at a time like we did in early > development phases

Re: svn status should not show unmodified files in changelists

2019-11-07 Thread Daniel Shahaf
Julian Foad wrote on Wed, Nov 06, 2019 at 10:36:10 +: > Demo: > [[[ > $ touch a b c d; svn add a b c d; svn ci -m ""; svn up > ... > $ echo hello > b > $ echo hello > d > $ svn cl foo c d > A [foo] c > A [foo] d > $ svn status -v > 11 julianfoad . > 1

Re: Commits not being reported?

2019-11-07 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, Nov 05, 2019 at 11:04:12 -0500: > Ok. Infra fixed the issue and we have the retroactive commit emails. Thanks for chasing that down. > Now, who runs our #svn-dev IRC bot that reports commits? Is that also > infra? Because that's still broken. ASFBot is run by Infra.

Re: Merging branches/swig-py3 to trunk

2019-11-04 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 05 Nov 2019 04:48 +00:00: > Support for Python 3.x: > > Python 3.x and newer are now supported by Subversion's swig-py bindings > and automated test suite. Python 2.7 is still supported. > > Support for Python 2.7 to be phased out: > > As of 1 January 2020, Python 2

Re: Commits not being reported?

2019-11-04 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 05 Nov 2019 04:56 +00:00: > I don't see commits being reported on IRC. > > Also earlier I made a commit and did not see a message to commits@ either. > > What broke? The post-commit hook or the mail server, probably. Either way, ask Infra to look into it: https://w

Re: Issue tracker housecleaning: SVN-1804

2019-11-04 Thread Daniel Shahaf
Nathan Hartman wrote on Mon, 04 Nov 2019 20:56 +00:00: > So before I rush to change the 'raise .. from' lines, I'll wait until > we decide which way to go with the required Python version. That's certainly one option, though personally, I'd suggest to first comment out the «from detail» part of th

Re: Merging branches/swig-py3 to trunk

2019-11-03 Thread Daniel Shahaf
Branko Čibej wrote on Tue, Oct 22, 2019 at 21:39:23 +0200: > 1. we release 1.13.0 as planned next week when the soak period ends > (pending any last-minute critical bugs found, of course); > > 2. immediately after the 1.13.0 release, we merge the swig-py3 branch > to trunk; and, Anyone

Re: Issue tracker housecleaning: SVN-1804

2019-11-03 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Mon, Nov 04, 2019 at 11:13:38 +0900: > On 2019/11/04 8:16, Nathan Hartman wrote: > > On Sun, Nov 3, 2019 at 12:56 AM Nathan Hartman > > wrote: > > > It seems there's another problem. > > > > Apparently the 'raise .. from' construct is Python 3+. Which means > > this b

Re: Issue tracker housecleaning: SVN-1804

2019-10-30 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 31 Oct 2019 03:24 +00:00: > > SVN-1804: "mailer.py doesn't catch SMTPRecipientsRefused in finish()" > > The fix for SVN-1804 is committed in r1869194. > > Thanks to all for your feedback (and patience!) You're welcome, and here's my +0 for backport to 1.13.x. Cheers

Re: svn commit: r1869134 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread Daniel Shahaf
James McCoy wrote on Wed, 30 Oct 2019 02:03 +00:00: > On Tue, Oct 29, 2019 at 11:21:04PM -, danie...@apache.org wrote: > > +abort >--^ > Left over debug code? Yes, thanks. Fixed in r1869139.

Re: svn commit: r1869118 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread Daniel Shahaf
Julian Foad wrote on Tue, 29 Oct 2019 20:54 +00:00: > Daniel Shahaf wrote: > > release_date = time.strptime(args.news_release_date, "-mm-dd") if > > args.news_release_date else datetime.date.today() > > … { 'date': release_date.strftime("mmdd&

Re: svn commit: r1869118 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread Daniel Shahaf
julianf...@apache.org wrote on Tue, 29 Oct 2019 17:22 +00:00: > +++ subversion/trunk/tools/dist/release.py Tue Oct 29 17:22:40 2019 > @@ -1188,8 +1188,9 @@ def move_to_dist(args): > def write_news(args): > 'Write text for the Subversion website.' > -data = { 'date' : datetime.date.today()

Re: Issue tracker housecleaning: SVN-1804

2019-10-29 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, Oct 29, 2019 at 11:11:58 -0400: > [[[ > def finish(self): ⋮ > except smtplib.SMTPRecipientsRefused as detail: > sys.stderr.write("mailer.py: SMTP recipient(s) refused: %s: %s\n" >% (self.to_addrs, detail,)) > raise MessageSe

Re: Issue tracker housecleaning: SVN-1804

2019-10-28 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, Oct 27, 2019 at 23:14:55 -0400: > [[[ > Per SVN-1804, any SMTP error terminates mailer.py with an unhandled > exception. The impact is that emails which would have been sent after > the exception are silently lost. *lightbulb* > Found by: rzigweid >

error-test.c false positive when building tarballs in maintainer mode

2019-10-25 Thread Daniel Shahaf
Investigating this failure: /tmp/svn-dist/subversion-1.13.0//./subversion/tests/libsvn_subr/error-test.c:224: (apr_err=SVN_ERR_TEST_FAILED) svn_tests: E26: Strings not equal Expected: 'ENOENT' Found:'(null)' at /tmp/svn-dist/subversion-1.13.0//./subversion/test

Re: Merging branches/swig-py3 to trunk

2019-10-23 Thread Daniel Shahaf
Branko Čibej wrote on Tue, 22 Oct 2019 19:39 +00:00: > 1. we release 1.13.0 as planned next week when the soak period ends > (pending any last-minute critical bugs found, of course); Speaking of which, do we have time to get the changes currently in STATUS into .0, or will they need to wait f

Re: 1.13.x and swig-py3

2019-10-23 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, Oct 23, 2019 at 01:11:19 -0400: > James McCoy wrote: > > FWIW, since we switched to the new release model, I (in my capacity as > > packager for Debian) basically ignore non-LTS releases. It's easier to > > ignore them, since I know I only want an LTS release in Debian

Re: Issue tracker housecleaning: SVN-1804

2019-10-23 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, Oct 23, 2019 at 11:48:28 -0400: > On Sun, Oct 20, 2019 at 2:16 AM Yasuhito FUTATSUKI > wrote: > > With this approach, I think the script should exit with code > > other than 0 if an exception raised, to notify error occured to hook > > scripts. Python script exits with

Re: Merging branches/swig-py3 to trunk

2019-10-23 Thread Daniel Shahaf
Julian Foad wrote on Wed, 23 Oct 2019 13:23 +00:00: > Branko Čibej wrote: > > $ svn info --show-item=relative-url > > ^/subversion/branches/swig-py3 > > $ svn log --stop-on-copy | egrep '^r\d+ \|' | cut -d '|' -f 2 | sort -u > > cmpilato > > danielsh > > futatuki > > luke1410 > > troycurt

Re: 1.13.x and swig-py3 (was: Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October)))

2019-10-19 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 20 Oct 2019 01:49 +00:00: > I support this idea even if the soak must restart or be extended. Brainstorming: How about letting the soak continue but documenting in the release notes, release announcements, etc., that we'll be adding swig- py3 support in a patch release

1.13.x and swig-py3 (was: Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October)))

2019-10-18 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, Oct 18, 2019 at 23:09:19 +0900: > On 2019/10/16 21:12, Johan Corveleyn wrote: > > This makes me wonder: should that be fixed specifically on trunk, and > > nominated for backport to 1.13, so we can possibly claim basic support > > for Python 3 in our build and test

Re: svn commit: r1868571 - /subversion/trunk/build/run_tests.py

2019-10-18 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Oct 18, 2019 at 10:30:09 -0400: > Done in r1868596. Thanks, Nathan.

Re: svn commit: r1868561 - /subversion/trunk/subversion/tests/cmdline/diff_tests.py

2019-10-17 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Oct 18, 2019 at 00:08:48 -0400: > On Thu, Oct 17, 2019 at 5:48 PM Daniel Shahaf > wrote: > > > Good morning Nathan, > > > > Good morning! Or whatever time it happens to be in your part of the world > :-) <https://en.wik

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-17 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Thu, 17 Oct 2019 22:57 +00:00: > I'm sorry, I missed to answer to these questions. > > On 2019/10/16 16:55, Daniel Shahaf wrote: > > Good catch. Yes, we should update INSTALL to reflect that Python 3 is > > supported for the build and test

Re: svn commit: r1868561 - /subversion/trunk/subversion/tests/cmdline/diff_tests.py

2019-10-17 Thread Daniel Shahaf
Good morning Nathan, hartmannat...@apache.org wrote on Thu, Oct 17, 2019 at 16:23:21 -: > +++ subversion/trunk/subversion/tests/cmdline/diff_tests.py Thu Oct 17 > 16:23:21 2019 > @@ -5253,6 +5253,83 @@ def diff_git_format_copy(sbox): > +def diff_nonexistent_in_wc(sbox): > + "nonexistent in w

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Oct 17, 2019 at 22:56:29 +0200: > On 17.10.2019 22:37, Daniel Shahaf wrote: > > Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: > >> On 16.10.2019 10:01, Daniel Shahaf wrote: > >>> Which reminds me: it'd be nice to set up a build

Re: Issue tracker housecleaning: SVN-1722

2019-10-17 Thread Daniel Shahaf
Branko Čibej wrote on Thu, 17 Oct 2019 06:49 +00:00: > On 16.10.2019 10:01, Daniel Shahaf wrote: > > Which reminds me: it'd be nice to set up a buildbot to run the build and > > test process under Python 3. Any committer can edit the buildbot > > scripts[1], but th

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-16 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 16 Oct 2019 12:12 +00:00: > This makes me wonder: should that be fixed specifically on trunk, and > nominated for backport to 1.13, so we can possibly claim basic support > for Python 3 in our build and test processes (in at least one released > version) before the end

Re: Issue tracker housecleaning: SVN-1722

2019-10-16 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 16 Oct 2019 04:47 +00:00: > Is it sensible to add a regression test? Yes, unless other tests already cover this. Such tests would probably be either in diff_tests.py or in subversion/tests/libsvn_diff/. In general, Python tests may be tagged with «@Issue(1722)» deco

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-16 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Wed, 16 Oct 2019 04:40 +00:00: > On 2019/10/16 10:36, Daniel Shahaf wrote: > > Yasuhito FUTATSUKI wrote on Tue, Oct 15, 2019 at 16:19:46 +0900: > >> On 2019-10-15 07:04, Daniel Shahaf wrote: > >>> Yasuhito FUTATSUKI wrote on Sun, 13 Oct 201

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-15 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Oct 16, 2019 at 01:07:32 +0200: > I did have some trouble testing it with Python 3.7 though: > > - First, I had to try it on the swig-py3 branch, because on trunk I > get this when trying to run any test with py 3.7: ⋮ > I guess that's one of the issues fixed by the s

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-15 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Tue, Oct 15, 2019 at 16:19:46 +0900: > On 2019-10-15 07:04, Daniel Shahaf wrote: > > Yasuhito FUTATSUKI wrote on Sun, 13 Oct 2019 04:01 +00:00: > > > On 2019/10/13 7:24, Daniel Shahaf wrote: > > > > I see. Now I agree it would suffi

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-14 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sun, 13 Oct 2019 04:01 +00:00: > On 2019/10/13 7:24, Daniel Shahaf wrote: > > Yasuhito FUTATSUKI wrote on Sat, 12 Oct 2019 03:01 +00:00: > >> If textual comparison is sufficient here, it is right to open file > >> text mode (with suitabl

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-12 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, 12 Oct 2019 03:01 +00:00: > If textual comparison is sufficient here, it is right to open file > text mode (with suitable, unified set of `encoding', `errors', and `newline' > parameter). Otherwise, if strict comparison is needed, we must avoid unwanted, > not one-o

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-11 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Oct 11, 2019 at 12:53:23 -0400: > (2) Once this is more-or-less under control, I'd like to start actively > looking for volunteers, hackathon events, and any other opportunities > to get more involvement. This might be easier to do on an ASF-wide scale. comdev¹ would

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-11 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, Oct 11, 2019 at 16:50:39 -0400: > On Fri, Oct 11, 2019 at 4:32 PM Yasuhito FUTATSUKI > wrote: > > This is caused by mixing bytes object drived from file contents and str > > object to construct log message. > > Does something like this answer help: > > https://stack

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-11 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, Oct 12, 2019 at 05:31:53 +0900: > Yes, it will fix local_missing_dir_endless_loop() itself correctly. > But the stack trace before fix indicate there is at least one problem > in svntest.verify.compare_and_display_lines(). > > Assume the file contents is broken her

Re: Subversion semantics: no no-op changes

2019-10-11 Thread Daniel Shahaf
Julian Foad wrote on Fri, Oct 11, 2019 at 15:56:31 +0100: > Hello Eric. Not to preëmpt Eric, but may I share my thoughts too? > In conclusion, I consider svn would be a better system -- more predictable, > testable, composable, etc.; more generally dependable -- and would lose no > significant va

Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))

2019-10-11 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Fri, Oct 11, 2019 at 16:35:19 +0900: > On 2019-10-11 06:45, Daniel Shahaf wrote: > ... > > From autogen.sh to 'make check', all steps pass with > > PYTHON=/usr/bin/python3. > > There were two failures in 1.11 on tests. > &

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-10 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 10 Oct 2019 21:12 +00:00: > On Thu, Oct 10, 2019 at 4:54 PM Daniel Shahaf wrote: > > > > Nathan Hartman wrote on Thu, Oct 10, 2019 at 16:28:21 -0400: > > > If we have to pull that item out (not saying we do yet, just IF), then > >

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-10 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, Oct 10, 2019 at 16:28:21 -0400: > If we have to pull that item out (not saying we do yet, just IF), then that > leaves us with no Python tasks. I'd like to have something Python-related > on the list because there's a good chance that a 700+ member university > hackatho

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-10 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Oct 10, 2019 at 20:47:05 +: > Nathan Hartman wrote on Thu, Oct 10, 2019 at 16:12:01 -0400: > > On Thu, Oct 10, 2019 at 1:48 PM Daniel Shahaf > > wrote: > > > > Should these be re-merged into one item, as you had it before? > >

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-10 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, Oct 10, 2019 at 16:12:01 -0400: > On Thu, Oct 10, 2019 at 1:48 PM Daniel Shahaf wrote: > > > Should these be re-merged into one item, as you had it before? > > > > That depends. _Do_ the Windows build scripts support libmagic? > > I thi

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-10 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, 10 Oct 2019 17:36 +00:00: > On Thu, Oct 10, 2019 at 1:15 PM Daniel Shahaf wrote: > > > > Nathan Hartman wrote on Thu, Oct 10, 2019 at 10:24:28 -0400: > > > * Documentation: > > > > > > - SVN-3914 - INSTALL: document how to

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-10 Thread Daniel Shahaf
Nathan Hartman wrote on Thu, Oct 10, 2019 at 10:24:28 -0400: > * Documentation: > > - SVN-3914 - INSTALL: document how to compile with libmagic on > Windows. > https://issues.apache.org/jira/browse/SVN-3914?issueNumber=3914 This is a subtask of the next one, isn't it? > * Python progra

Re: SVN-4065 - server should enforce LF normalization for svn:eol-style=native

2019-10-09 Thread Daniel Shahaf
Branko Čibej wrote on Wed, Oct 09, 2019 at 15:45:32 +0200: > On 09.10.2019 15:00, Johan Corveleyn wrote: > > During that entire discussion thread the only objections raised were > > about "enforcing it in the repos layer / server directly". No-one > > objected to the proposal(s) to solve the issue

Re: SVN-4065 - server should enforce LF normalization for svn:eol-style=native

2019-10-09 Thread Daniel Shahaf
Julian Foad wrote on Wed, 09 Oct 2019 15:13 +00:00: > * [SVN-4065] Redefine as: >"Write a pre-commit hook to reject non-conforming eol-style=native." >Put it in 'tools/hook-scripts/'. ... > The redefined SVN-4065 could be a suitable hackathon task. Isn't writing `svnlook changed -t $TXN |

Re: PMCs: any Hackathon requests? (deadline 11 October)

2019-10-08 Thread Daniel Shahaf
Nathan Hartman wrote on Tue, 08 Oct 2019 15:09 +00:00: > Now can we please have some more suggestions for a "byte size" > issue and a Python-related task? SVN-4781 - expose svn_fs_change_rev_prop2() to swig. SVN-4568 - expose svn_fs_set_warning_func() to swig. SVN-4343 - "svnadmin verify" should

Re: Link to KEYS file on our download page

2019-10-02 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, 02 Oct 2019 15:41 +00:00: > Nathan Hartman wrote: > > The ASF committer keys list (https://people.apache.org/keys/committer/) > > is showing my key as "key not found." Not really sure what to do about > > that. > > I checked again and my key is found now. :-) I can re

Re: Link to KEYS file on our download page

2019-10-02 Thread Daniel Shahaf
Daniel Shahaf wrote on Mon, Sep 30, 2019 at 17:00:23 +: > Julian Foad wrote on Mon, 30 Sep 2019 16:34 +00:00: > > Nothing happened there. > > > > I have now manually added a copy > > of https://people.apache.org/keys/group/subversion.asc > > to https://ww

Re: Link to KEYS file on our download page

2019-09-30 Thread Daniel Shahaf
Julian Foad wrote on Mon, 30 Sep 2019 16:34 +00:00: > Nothing happened there. > > I have now manually added a copy > of https://people.apache.org/keys/group/subversion.asc > to https://www.apache.org/dist/subversion/KEYS > via https://dist.apache.org/repos/dist/release/subversion/KEYS (r36130) > a

Re: [ANNOUNCE] Apache Subversion 1.13.0-rc1 released

2019-09-30 Thread Daniel Shahaf
Julian Foad wrote on Mon, Sep 30, 2019 at 12:05:36 +0100: > Daniel Shahaf wrote: > > > Nathan Hartman (CODE SIGNING KEY) [4096R/583F00ADF981C39F] with > > > fingerprint: > > > 3F8E 467C B336 6E30 13E1 120D 583F 00AD F981 C39F > > > > Nathan, ha

Re: [ANNOUNCE] Apache Subversion 1.13.0-rc1 released

2019-09-30 Thread Daniel Shahaf
Julian Foad wrote on Mon, 30 Sep 2019 09:45 +00:00: > For this release, the following people have provided PGP signatures: > >Julian Foad [4096R/1FB064B84EECC493] with fingerprint: > 6011 63CF 9D49 9FD7 18CF 582D 1FB0 64B8 4EEC C493 >Nathan Hartman (CODE SIGNING KEY) [4096R/583F00ADF9

Re: Simplifying our documentation

2019-09-29 Thread Daniel Shahaf
Nathan Hartman wrote on Sun, 29 Sep 2019 15:48 +00:00: > html5boilerplate is under a MIT license: > https://github.com/h5bp/html5-boilerplate/blob/master/LICENSE.txt > > Can this (or snippets from it) be used for Subversion's website? Yes. https://www.apache.org/legal/resolved#category-a

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-28 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, 28 Sep 2019 09:20 +00:00: > https://svn.apache.org/viewvc?view=revision&revision=876281 > > Unfortunately I can't find any reason or discussion about this decision, yet. Are you aware of the "+ 840074" revision number offset that needs to be applied to old revisio

Re: svn commit: r1867639 - /subversion/site/publish/docs/community-guide/releasing.part.html

2019-09-27 Thread Daniel Shahaf
julianf...@apache.org wrote on Fri, Sep 27, 2019 at 15:36:07 -: > +++ subversion/site/publish/docs/community-guide/releasing.part.html Fri Sep > 27 15:36:07 2019 > @@ -1494,22 +1494,28 @@ A.B with the version you're preparing, e > +The following steps are not automated: > + > + > Ask some

Re: Subversion 1.13.0-rc1 up for testing/signing

2019-09-27 Thread Daniel Shahaf
Julian Foad wrote on Fri, 27 Sep 2019 15:54 +00:00: > > Also, some ASF help page (that I can't seem to locate now) said I need > > to add my key to a KEYS file. Not sure where that is. > > You should add them in https://id.apache.org ; you probably already > have. AFAIK the KEYS file(s) are auto

Re: Subversion 1.13.0-rc1 up for testing/signing

2019-09-27 Thread Daniel Shahaf
Nathan Hartman wrote on Fri, 27 Sep 2019 14:46 +00:00: > $ TZ=UTC bash -c 'svn export > https://svn.apache.org/repos/asf/subversion/tags/1.13.0-rc1' For future reference, «TZ=UTC svn export https://…» would work too. The environment variable setting syntax works for any external command ☺

Re: Subversion 1.13.0-rc1 up for testing/signing

2019-09-27 Thread Daniel Shahaf
Julian Foad wrote on Fri, 27 Sep 2019 14:42 +00:00: > IMO, things that don't belong in a tarball don't belong in trunk. There must be exceptions to this, since autogen.sh belongs in trunk and isn't expected to be run in tarball builds either. The same goes for the 'extraclean' makefile target, an

Re: Subversion 1.13.0-rc1 up for testing/signing

2019-09-27 Thread Daniel Shahaf
Johan Corveleyn wrote on Fri, 27 Sep 2019 07:41 +00:00: > And unfortunately on Windows symlinks are not supported, so I get > "link .../nominate.pl" on the exported side vs. nominate.pl> on the other side. But I'm quite used to scrolling > through that one. On *nix that won't be a problem I'm sure

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-19 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00: > On 2019/09/19 8:21, Johan Corveleyn wrote: > > On Wed, Sep 18, 2019 at 12:08 PM Branko Čibej wrote: > >> You do *not* need a definition of 'struct foo' in order to use a 'struct > >> foo*' pointer. So, no, that's not the problem. > > Ac

Re: svn commit: r1867063 - /subversion/site/staging/docs/community-guide/releasing.part.html

2019-09-18 Thread Daniel Shahaf
Julian Foad wrote on Wed, 18 Sep 2019 10:01 +00:00: > Daniel Shahaf wrote: > > However, as written, this change could be taken as saying that the rule > > of "one +1 and one +0" does not apply to bindings changes to non-LTS > > lines. (It's not clear wheth

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 18 Sep 2019 07:44 +00:00: > On Wed, Sep 18, 2019 at 9:31 AM Daniel Shahaf wrote: > > > > Johan Corveleyn wrote on Wed, 18 Sep 2019 00:48 +00:00: > > > No problem, after downloading py3c from Github, and adding > > > --with-py3c, I ca

Re: Python3 work [was: The run up to Subversion 1.13.0]

2019-09-18 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, 18 Sep 2019 00:48 +00:00: > No problem, after downloading py3c from Github, and adding > --with-py3c, I can start building it. What version of py3c did you download? HEAD or a release?

Re: svn commit: r1867063 - /subversion/site/staging/docs/community-guide/releasing.part.html

2019-09-17 Thread Daniel Shahaf
julianf...@apache.org wrote on Tue, 17 Sep 2019 14:49 +00:00: > +++ subversion/site/staging/docs/community-guide/releasing.part.html Tue Sep > 17 14:49:51 2019 > @@ -687,7 +687,7 @@ it. > > For a non-LTS ("regular") release line > > -A change is approved if it receives one +1 vote and no veto

Re: [PATCH] test-deps += svnmover

2019-09-05 Thread Daniel Shahaf
Bert Huijben wrote on Thu, 05 Sep 2019 11:45 +00:00: > I think it can just be added to the [__ALL_TESTS__] group instead of > hardcoding it in python. That wouldn't add it to the test-deps target. > svnauthz is probably an exception as it is related to a symlink. svnauthz is not a symlink. It'

Re: [PATCH] test-deps += svnmover

2019-09-02 Thread Daniel Shahaf
Julian Foad wrote on Mon, 02 Sep 2019 14:23 +00:00: > Daniel Shahaf wrote: > > In current master, «./autogen.sh && ./configure && make davautocheck» fails > > all svnmover tests. > > By default, 'make davautocheck' expects to find > 'tools

[PATCH] test-deps += svnmover

2019-08-31 Thread Daniel Shahaf
In current master, «./autogen.sh && ./configure && make davautocheck» fails all svnmover tests. I think the following will fix it, but haven't verified: Index: build/generator/gen_base.py === --- build/generator/gen_base.py (revisio

Re: Change to Subversion PMC rule for approving backports

2019-08-30 Thread Daniel Shahaf
Julian Foad wrote on Fri, 30 Aug 2019 06:54 +00:00: > Daniel Shahaf wrote: > > I think that section as it stands (before your change) is pretty hard to > > follow: it jumps back and forth between different topics. I might take > > a shot at clarifying it (without semantic ch

Re: Change to Subversion PMC rule for approving backports

2019-08-29 Thread Daniel Shahaf
Julian Foad wrote on Thu, 29 Aug 2019 15:36 +00:00: > To all devs: > > Proposal for a permanent change to our backport rules [1]: > >* For non-LTS releases, each backport nomination only requires one +1 > vote (instead of three). > > Specific diff to the text of [1]: > > - A change needs t

Re: svn commit: r1865987 - /subversion/trunk/subversion/libsvn_fs_fs/verify.c

2019-08-28 Thread Daniel Shahaf
br...@apache.org wrote on Tue, 27 Aug 2019 12:10 +00:00: > +++ subversion/trunk/subversion/libsvn_fs_fs/verify.c Tue Aug 27 12:10:43 2019 > @@ -694,8 +694,9 @@ compare_p2l_to_rev(svn_fs_t *fs, > return svn_error_createf(SVN_ERR_FS_INDEX_CORRUPTION, >

Re: svn commit: r1865841 - in /subversion/trunk/subversion: libsvn_wc/diff_local.c tests/cmdline/changelist_tests.py

2019-08-28 Thread Daniel Shahaf
julianf...@apache.org wrote on Sat, 24 Aug 2019 10:50 +00:00: > Author: julianfoad > Date: Sat Aug 24 10:50:44 2019 > New Revision: 1865841 > > URL: http://svn.apache.org/viewvc?rev=1865841&view=rev > Log: > Fix issue #4822, "svn diff --changelist ARG" broken in subdirectories. Should this be bac

Re: Security release procedures

2019-08-28 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, 29 Aug 2019 00:44 +00:00: > I do concede that if we had just a single release format, tarballs, > that'd be easier on downstreams, but I do not accept that releasing > patches would place an unreasonable burden on downstreams. Forgot one thing: the

Re: Security release procedures

2019-08-28 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, 28 Aug 2019 12:07 +00:00: > Also, users would have a much harder time trying to verify what they > are actually running. Did you see the part where I specifically proposed to release a patch that fixes the issue _and_ bumps SVN_VER_PATCH? (The patch can also add a ne

Re: Security release procedures

2019-08-28 Thread Daniel Shahaf
Julian Foad wrote on Wed, 28 Aug 2019 11:41 +00:00: > * Drop the CVE? (steps 8, 15, 16) > >For cases that are not looking like a very high severity, we could > omit the CVE process and much of the formal description associated with > it. CVEs are a Good Thing, but they do require extra effor

Re: svn commit: r1865929 - /subversion/trunk/subversion/tests/cmdline/changelist_tests.py

2019-08-26 Thread Daniel Shahaf
Julian Foad wrote on Mon, 26 Aug 2019 15:05 +00:00: > Daniel Shahaf wrote: > > Is this something temporary while you work on this, or meant to remain in > > the code longer-term? > > > > (If the former, ignore the rest of this email.) > > I already changed i

Re: svn commit: r1865929 - /subversion/trunk/subversion/tests/cmdline/changelist_tests.py

2019-08-26 Thread Daniel Shahaf
julianf...@apache.org wrote on Mon, 26 Aug 2019 11:36 +00:00: > Add a test for issue #4826, diff repos-wc non-infinite depth uses wrong depth. > > +++ subversion/trunk/subversion/tests/cmdline/changelist_tests.py Mon Aug 26 > 11:35:55 2019 > @@ -553,31 +580,20 @@ def diff_with_changelists(sbox):

<    2   3   4   5   6   7   8   9   10   11   >