t.install == "bdb-test":
return True
+
+ if os.name == 'nt':
+def errno_filter(self, codes):
+ """From errno_filter() in gen_win.py"""
+ return [code for code in codes if not (1 <= code <= 10100)]
]]]
--
Jun Omae (大前 潤)
r\src\subversion\subversion.git\out\db-test.vcxproj" (default
targets) -- FAILED.
32>Done Building Project
"C:\usr\src\subversion\subversion.git\out\conflicts-test.vcxproj"
(default targets) -- FAILED.
31>Done Building Project
"C:\usr\src\subversion\subversion.git\out\conflict-data-test.vcxproj"
(default targets) -- FAILED.
1>Done Building Project
"C:\usr\src\subversion\subversion.git\out\ALL_BUILD.vcxproj" (default
targets) -- FAILED.
]]]
--
Jun Omae (大前 潤)
_win_depends` and
`get_linked_win_depends` in `gen_win.py`? Have you got success to
build on your Windows environment with cmake?
--
Jun Omae (大前 潤)
e configuration file provided by "expat" with any of
the following names:
expatConfig.cmake
expat-config.cmake
Add the installation prefix of "expat" to CMAKE_PREFIX_PATH or set
"expat_DIR" to a directory containing one of the above files. If "expat"
provides a separate development package or SDK, be sure it has been
installed.
-- Configuring incomplete, errors occurred!
]]]
--
Jun Omae (大前 潤)
if the changeno_end is
> negative.
> * subversion/tests/cmdline/diff_tests.py
> (diff_invalid_change_arg): New test.
> (test_list): Run new test.
> ]]]
>
> Additionally, I am thinking about moving the code, which parses a
> change revision, into a function in the opt.c file, like
> svn_opt_parse_revision_to_range.
>
> Thanks!
Found another similar issue in -c option.
The following works correctly:
$ ~/svn/1.14.3/bin/svn diff -c '0-1' file:///tmp/svnrepos
svn: E205000: There is no change 0
However, the following aborts:
$ ~/svn/1.14.3/bin/svn diff -c '1-0' file:///tmp/svnrepos
svn: E235000: In file 'subversion/libsvn_client/ra.c' line 692: assertion
failed (SVN_IS_VALID_REVNUM(start_revnum))
Aborted
--
Jun Omae (大前 潤)
dvars('$HOME/.subversion/config')
However, the following registry or file is used in Windows.
* HKEY_CURRENT_USER\Software\Tigris.org\Subversion\Config
* %USERPROFILE%\AppData\Roaming\Subversion\config
To make the script compatible with Windows needs to change the reading
configurations.
--
Jun Omae (大前 潤)
regards,
> Daniel
In my opinion, yes. Python users have no workaround for the issue
except downgrading to 1.14.2. I think it happens if Python is a
long-running process like a daemon or with large repositories.
At least, I'm considering to report it with the patch to distributors
(Debian, Ubuntu, FreeBSD, etc.).
--
Jun Omae (大前 潤)
On Tue, Jan 30, 2024 at 9:42 PM Daniel Sahlberg
wrote:
>
> Den tis 30 jan. 2024 kl 01:39 skrev Jun Omae :
>>
>> On 2024/01/30 6:15, Daniel Sahlberg wrote:
>> > Good catch! How about:
>> >
>> > [
us, _("Can't accept client connection"));
}
/* Add a reference to CONNECTION, i.e. keep it and it's pool valid unless
]]]
--
Jun Omae (大前 潤)
serve: E04: Can't accept client connection: Interrupted system call
.svnserve: E04: Can't accept client connection: Interrupted system call
.svnserve: E04: Can't accept client connection: Interrupted system call
]]]
I think we should prevent the messages even if the system call is interrupted
.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at org.apache.subversion.javahl.RunTests.main(RunTests.java:119)
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 90 out of bounds for
length 80
... 19 more
FAILURES!!!
Tests run: 148, Failures: 0, Errors: 1
m
'--quiet', action='store_true',
help='Print only unexpected results (not with --verbose)')
parser.add_option('-p', '--parallel', action='store_const',
]]]
--
Jun Omae (大前 潤)
\$', line_contents[3]):
]]]
However, in attached patch, correct the escape sequences because "make check"
requires at least Python 3.0.
[[[
- if not re.match(b'.*\$LastChangedRevision:\s*\d+\s*\$', line_contents[3]):
+ if not re.match(b'.*\\$LastChangedRevision:\\s*\\d+\\s*\\$',
l
splayed since Python 3.12, even without
-Wdefault option.
$ python3.12 -c '"\$"'
:1: SyntaxWarning: invalid escape sequence '\$'
$ python3.11 -c '"\$"' # no warnings
$ python3.11 -Wdefault -c '"\$"'
:1: DeprecationWarning: invalid escape sequence '\$'
See also:
https://docs.python.org/3.12/whatsnew/3.12.html?highlight=backslash-character#other-language-changes
--
Jun Omae (大前 潤)
dir
]]]
See attached dav-fails.log.
--
Jun Omae (大前 潤)
dav-fails.log
Description: Binary data
xproj]
D:\a\subversion\subversion\Release\subversion\tests\libsvn_wc\wc-queries-test.exe
: fatal error LNK1120: 2 unresolved externals
[D:\a\subversion\subversion\build\win32\vcnet-vcproj\wc-queries-test.vcxproj]
]]]
--
Jun Omae (大前 潤)
de/private/svn_wc_private.h in order to export the
symbol.
--
Jun Omae (大前 潤)
WIG < 4.0.0")
+ print("WARNING: Subversion Python bindings for Python 2 require SWIG
1.3.24 or newer")
return
- opts = "-python -classic"
+ if self.swig_version < (4, 0, 0):
+opts = "-python -nofastunpack -classic"
+ else:
+opts = "-python -nofastunpack"
+if show_warnings and self.swig_version > (4, 0, 2):
+ print("WARNING: Subversion Python bindings may work,\n"
+"but we didn't check with this SWIG version.")
self.user_macros.append(UserMacro("SWIG_PY_OPTS", opts))
self._libraries['python'] = SVNCommonLibrary('python', inc_dir, lib_dir,
None,
diff --git a/subversion/bindings/swig/include/proxy.swg
b/subversion/bindings/swig/include/proxy.swg
index 7d2d0dd03..5949c52e0 100644
--- a/subversion/bindings/swig/include/proxy.swg
+++ b/subversion/bindings/swig/include/proxy.swg
@@ -75,7 +75,7 @@
_set_instance_attr =
_swig_setattr_nondynamic_instance_variable(object.__setattr__)
%}
-#elif defined(SWIGPYTHON_PY3)
+#elif !defined(SWIG_PYTHON_CLASSIC)
%pythoncode %{
# SWIG classes generated with -modern do not define this variable
try:
]]]
--
Jun Omae (大前 潤)
e \c at position 32 (line 1, column 33)
> FAIL: diff_tests.py 48: svn diff --diff-cmd provides the correct arguments
> ]]]
I've posted patch for the failure.
See https://lists.apache.org/thread/2o0xtqfzy9xg8wzxscj2wb641p2kyo9c
--
Jun Omae (大前 潤)
ts\cmdline\httpd\log file in your
environment.
--
Jun Omae (大前 潤)
er, I get 2 failures from 1.14.x/win-tests.py on Windows
(tests for swig-py, swig-pl and javahl pass).
FAIL: mod_authz_svn_tests.py 10: repos-relative access file
FAIL: mod_authz_svn_tests.py 11: repos-relative access file with bad
repository URL
It seems to be necessary to merge r1884474
file unless you know what you are doing--modify
# the SWIG interface file instead.
$ tar xaf ~/arc/subversion-1.14.1.tar.bz2 -O
subversion-1.14.1/subversion/bindings/swig/python/core.c | head -5
/*
* This file was automatically generated by SWIG (http://www.swig.org).
* Version 3.0.12
*
* This file is not intended to be easily readable and contains a number of
]]]
--
Jun Omae (大前 潤)
On Fri, Mar 18, 2022 at 12:01 PM Daniel Shahaf wrote:
>
> Jun Omae wrote on Fri, Mar 18, 2022 at 11:27:16 +0900:
> > Hi,
> >
> > On Fri, Mar 18, 2022 at 9:44 AM Daniel Shahaf
> > wrote:
> > >
> > > Could someone test this on Windows, please? I su
bundled lz4 1.7.5
Using bundled utf8proc 2.1.0
]]]
--
Jun Omae (大前 潤)
dav-fails.log
Description: Binary data
;,
"-L\n",
r"iota\t\(working copy\)\n",
-os.path.abspath(svntest.main.get_admin_name()) + '.*' + "\n",
-os.path.abspath("iota") + "\n"])
+re.escape(os.path.abspath(svntest.main.get_admin_name())) + '.*' + "\n",
+re.escape(os.path.abspath("iota")) + "\n"])
# Check that the output of diff corresponds with the expected arguments,
# in the correct order.
]]]
--
Jun Omae (大前 潤)
Hi,
On 2022/02/19 21:27, Daniel Shahaf wrote:
Daniel Shahaf wrote on Tue, Feb 08, 2022 at 11:47:47 +:
Jun Omae wrote on Sat, Feb 05, 2022 at 00:28:51 +0900:
After r1897443, prop_tests.py 12 is failing on Windows.
svntest.Failure: Repository diskpath in stderr: [
"svn: E175008:
'@echo pre-revprop-change %* 1>&2\n'
- '@exit 1\n')
+ 'sys.exit(1)\n')
def create_failing_post_commit_hook(repo_dir):
"""Create a post-commit hook script in the repository at REPO_DIR that always
]]]
--
Jun Omae (大前 潤)
ter r1887641 on Windows (and perhaps on macOS).
>
> To reproduce it, in non UTF-8 CodePage/locale, set SVN_EDITOR to
> non existent path which contains non-ascii character and
The patch looks good to me and verified with the following environments:
* Windows 10 (cp932)
* Linux (ja_JP.eucj
t; r1866588 and above.
It seems that r1866587 in the message is incorrect. It might be
actually r1865987.
--
Jun Omae (大前 潤)
e.
>
> Also, suggest to generate future patches with hunk titles enabled («svn
> diff -x-p»). That tends to improve reviewability.
Thanks for the testing and suggestions.
Committed in r1889487.
--
Jun Omae (大前 潤)
tCase): Add tests for pools referred from circular reference.
}}}
--
Jun Omae (大前 潤)
pools-in-circular-ref.diff
Description: Binary data
On Tue, Nov 17, 2020 at 7:42 PM Branko Čibej wrote:
> On 17.11.2020 04:09, Jun Omae wrote:
> > On Tue, Nov 17, 2020 at 2:33 AM Daniel Shahaf
> > wrote:
> >> Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100:
> >>> On 16.11.2020 04:16, Jun Omae wrote:
&g
On Tue, Nov 17, 2020 at 2:33 AM Daniel Shahaf wrote:
>
> Branko Čibej wrote on Mon, 16 Nov 2020 09:19 +0100:
> > On 16.11.2020 04:16, Jun Omae wrote:
> > > The attached patch adds #pragma warning to make C4204 a warning
> > > instead of an
> > > error only
-py with Visual Studio.
--
Jun Omae (大前 潤)
Fix C4204 errors while building swig-py with Python 3.9 on Windows.
* subversion/bindings/swig/include/svn_global.swg:
Add #pragma to make C4204 a warning instead of an errors from Python.h
in Python 3.9 with Visual Studio.
* subversion/bindings/swig
stem('C:\usr\tmp\�G�f�B�^\editor-stub.cmd "svn-prop.tmp"')
returned 1
]]]
--
Jun Omae (大前 潤)
On Mon, May 18, 2020 at 8:25 AM Yasuhito FUTATSUKI wrote:
>
> On 2020/05/18 2:51, Johan Corveleyn wrote:
> > On Sun, May 17, 2020 at 3:43 PM Jun Omae wrote:
>
> >> Assertion for negative ref count is raised from test_conflict
> >> (client.SubversionClientTestCase
n/bindings/swig/python/svn_client.c:26916 object at
0x7fe73b53a150 has negative ref count -2604246222170760230
--
Jun Omae (大前 潤)
On Wed, May 13, 2020 at 5:56 PM Jun Omae wrote:
At least, I think we should use python_d.exe when debug configuration.
...
Python bindings with debug configuration for Python 3.x has something wrong.
[[[
-- Running Swig Python tests --
Traceback (most recent call last):
File "C:\us
16, in swig_import_helper
return importlib.import_module('_core')
File "C:\usr\apps\python37\lib\importlib\__init__.py", line 127, in
import_module
return _bootstrap._gcd_import(name[level:], package, level)
ModuleNotFoundError: No module named '_core'
[Test runner reported failure]
]]]
--
Jun Omae (大前 潤)
contain). Therefore, the Python bindings will only
compile in Release mode. (This is due to pyconfig.h using the
_DEBUG flag too and setting a #pragma comment(lib) value.)
]]]
--
Jun Omae (大前 潤)
Thanks for the reviewing.
On 2020/05/11 0:57, Daniel Shahaf wrote:
Jun Omae wrote on Sun, 10 May 2020 13:27 +0900:
+def _dll_paths():
+import os
+if hasattr(os, 'add_dll_directory'): # Python 3.8+ on Windows
+cookies = []
+for path in os.environ.get('PATH', '').split
On Sun, May 10, 2020 at 1:27 PM Jun Omae wrote:
> I created patch to resolve the issue using moduleimport option of %module
> directive.
> After attached patch, *.pyd file is successfully loaded and tests for Python
> bindings pass.
Tested with the following environments:
- (
.i
* subversion/bindings/swig/svn_repos.i
* subversion/bindings/swig/svn_wc.i
Add moduleimport option with SVN_PYTHON_MODULEIMPORT to %module directive for
Python.
]]]
[1] https://docs.python.org/3/whatsnew/3.8.html#bpo-36085-whatsnew
--
Jun Omae (大前 潤)
* subversion/bindings/swig/include/svn_
): Use LoggingStdoutHandler() instead of
StreamHandler(sys.stdout).
]]]
Tested with the following environments:
* Python 3.8.2 and Python 2.7.18 on Windows 10
* Python 3.8.2 on Linux
--
Jun Omae (大前 潤)
* build/run_tests.py
(open_logfile): New function returning file-like object which
s) -- FAILED.
...
87 Warning(s)
102 Error(s)
Time Elapsed 00:01:26.67
Investigating the issue, I noticed generated SWIG_PY_OPTS differs between Unix
and Windows.
-python -py3
should be "-python -py3 -nofastunpack" when SWIG 4 is used.
After attached patch, no di
ble declarations are not at start of block.
The declarations lead the syntax errors with Visual Studio 2008.
After attached patch, the errors go away.
--
Jun Omae (大前 潤)
* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
Move variable declarations at start of block to fix syntax errors
vcnet_vcproj.ezt is incorrect. The line is
introduced in r873230.
ProgramDataBaseFileName="$(IntDir)/[sources.reldir]/[target.proj_name]-[sources.reldir].pdb"/>
After attached patch, the error goes away and build successfully.
--
Jun Omae (大前 潤)
* build/generator/vcnet_vcproj.e
(Posting to dev list, again...)
On Thu, Nov 14, 2019 at 1:47 AM Julian Foad wrote:
> Nathan wrote in another thread:
> > Note: If the patch contributed by Jun Omae a little earlier is
> > committed, the text regarding SWIG 4.0.0+ in INSTALL will need to be
> > adjuste
/swig/include/proxy.swg
(_get_instance_attr): New function to get an instance attribute
without metadata for new-style and old-style classes.
(_set_instance_attr): New function to set an instance attribute for
new-style and old-style classes.
]]]
--
Jun Omae (大前 潤)
diff --git a/build/ac
.
START OF PATCH
commit e9662e8e284f778de13559a61ee3c081c96652d9
Author: Jun Omae
Date: Wed Oct 30 15:56:09 2019 +0900
On branch swig-py3: Remove .swig_{pl,py,rb}_checked files on reconfiguration
and distclean task.
* Makefile.in
(clean-swig-pl, clean-swig-py, clean-swig-rb
installed correctly, run "swig -version"
- from the command line. SWIG should report that it is version 1.3.24
+ from the command line. SWIG should report that it is version 3.0.9
or newer.
Step 1a: Install py3c library if building Python SWIG bindings.
]]]
--
Jun Omae (大前 潤)
in
svn_swig_py_make_stream(),
I think the code is redundant. Using svn_swig_py_convert_ptr() would simplify
the converting the given py_io parameter to a svn_stream_t pointer.
Thoughts?
START OF PATCH
commit f857f1f529cc0e621a074a48e7c689a0b32d18cf
Author: Jun Omae
Date: Tue Dec 11 19:41:25 2018
52 matches
Mail list logo
