On Wed, 28 Nov 2012 11:27:54 +0530
vijay vi...@collab.net wrote:
Thanks everyone! It was a great learning opportunity for me!
Come back anytime for more learning opportunities!
I've had committer access for four years now and am still on a
learning curve... :)
~Neels
signature.asc
Thanks Julian.
This updated patch has all the changes.
I have removed some redundant portion of code in print_dirent() and
print_dirent_xml() in svn/list-cmd.c.
Thanks Regards,
Vijayaguru
On Tuesday 27 November 2012 03:19 AM, Julian Foad wrote:
vijay vi...@collab.net wrote:
On Tuesday
vijay vi...@collab.net wrote:
This updated patch has all the changes.
I have removed some redundant portion of code in print_dirent() and
print_dirent_xml() in svn/list-cmd.c.
Thanks Vijay. That looks great. I've committed it in r1414304. Nice log
message by the way.
- Julian
On Tuesday 27 November 2012 11:52 PM, Julian Foad wrote:
vijay vi...@collab.net wrote:
This updated patch has all the changes.
I have removed some redundant portion of code in print_dirent() and
print_dirent_xml() in svn/list-cmd.c.
Thanks Vijay. That looks great. I've committed it in
vijay vi...@collab.net wrote:
On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
The two extra list_func() calls has gone away!
Attaching the updated patch that addresses your review comments.
Hi Vijay. I read through the patch and it looks good, I just have a few minor
On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
Attached the updated patch and log message.
+ /* Notify that we're about to handle an external. */
+ SVN_ERR(list_func(baton, NULL, NULL, NULL, NULL,
+externals_parent_url,
+
On Thursday 15 November 2012 08:10 PM, C. Michael Pilato wrote:
On 11/15/2012 03:47 AM, Bert Huijben wrote:
Can't you just add the new argument to every call to list_func() that
applies to an external?
There is no separate list_func() call to list external items. We are
just calling
On Friday 16 November 2012 04:41 PM, Neels J Hofmeyr wrote:
Hi Vijay,
I gave that patch a spin (after all I was the one who brought
--include-externals upon us), and found stuff. Using current trunk + your
patch v3.
I was looking at your code 'commit --include-externals' before working
on
Hi Vijay,
I gave that patch a spin (after all I was the one who brought
--include-externals upon us), and found stuff. Using current trunk + your
patch v3.
BTW, I'm sorry to have to drag this patch submission out; countless times I
myself tried to just quickly fix a small externals quirk and it
On 2012-11-08 15:42, Stefan Sperling wrote:
With the benefit of hindsight, it seems allowing externals to be configured
on any ancestor directory was a big mistake in the design that complicates
things for no good reason. But that's neither your nor my fault :)
Word! So many things are
-Original Message-
From: vijay [mailto:vi...@collab.net]
Sent: donderdag 15 november 2012 08:53
To: Bert Huijben
Cc: 'Subversion Development'
Subject: Re: [PATCH] Implement '--include-externals' option to 'svn list'
On Tuesday 13 November 2012 06:45 PM, Bert Huijben wrote
On 11/15/2012 03:47 AM, Bert Huijben wrote:
Can't you just add the new argument to every call to list_func() that
applies to an external?
There is no separate list_func() call to list external items. We are
just calling svn_client_list3() recursively for each external, which in
turn calls
On Tuesday 13 November 2012 06:45 PM, Bert Huijben wrote:
-Original Message-
From: vijay [mailto:vi...@collab.net]
Sent: dinsdag 13 november 2012 14:06
To: Subversion Development
Subject: Re: [PATCH] Implement '--include-externals' option to 'svn list'
On Tuesday 13 November 2012 03
On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
Attached the updated patch and log message.
+ /* Notify that we're about to handle an external. */
+ SVN_ERR(list_func(baton, NULL, NULL, NULL, NULL,
+externals_parent_url,
+
On Sat, Nov 10, 2012 at 07:11:02PM +0530, vijay wrote:
I have removed the two boolean parameters notify_external_start and
notify_external_end from svn_client_list_func2 implementation. Now,
the callback keeps track of last seen external information and print
details based on the change. I
On Thu, Nov 8, 2012 at 12:34 PM, vijay vi...@collab.net wrote:
On Wednesday 07 November 2012 08:57 PM, Stefan Fuhrmann wrote:
On Wed, Nov 7, 2012 at 3:02 PM, vijay vi...@collab.net
mailto:vi...@collab.net wrote:
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote:
On
On Thursday 08 November 2012 04:10 PM, vijay wrote:
On Wednesday 07 November 2012 08:19 PM, Stefan Sperling wrote:
On Wed, Nov 07, 2012 at 07:54:33PM +0530, vijay wrote:
Thanks stefan for your detailed review.
I will keep in mind all your review comments. I will correct my
mistakes in future
On Wednesday 07 November 2012 08:19 PM, Stefan Sperling wrote:
On Wed, Nov 07, 2012 at 07:54:33PM +0530, vijay wrote:
Thanks stefan for your detailed review.
I will keep in mind all your review comments. I will correct my
mistakes in future patches.
Attached the updated patch and log message.
On Wednesday 07 November 2012 08:57 PM, Stefan Fuhrmann wrote:
On Wed, Nov 7, 2012 at 3:02 PM, vijay vi...@collab.net
mailto:vi...@collab.net wrote:
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote:
On Mon, Nov 5, 2012 at 5:24 PM, vijay vi...@collab.net
On Thu, Nov 08, 2012 at 05:04:35PM +0530, vijay wrote:
On Wednesday 07 November 2012 08:57 PM, Stefan Fuhrmann wrote:
* result of ls on a sub-folder results in less output
$svn ls $URL/sub1 -R --include-externals
fileA
fileB
Desired output:
fileA
fileB
subsub
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote:
On Mon, Nov 5, 2012 at 5:24 PM, vijay vi...@collab.net
mailto:vi...@collab.net wrote:
Hi,
This patch implements '--include-externals' option to 'svn list'
[Issue #4225] [1].
All tests pass with 'make check' 'make
Thanks stefan for your detailed review.
I will keep in mind all your review comments. I will correct my mistakes
in future patches.
Attached the updated patch and log message.
Thanks Regards,
Vijayaguru
On Tuesday 06 November 2012 07:31 PM, Stefan Sperling wrote:
On Mon, Nov 05, 2012 at
On Wed, Nov 07, 2012 at 07:54:33PM +0530, vijay wrote:
Thanks stefan for your detailed review.
I will keep in mind all your review comments. I will correct my
mistakes in future patches.
Attached the updated patch and log message.
This patch looks fine to me overall.
I have one more
On Wed, Nov 7, 2012 at 3:02 PM, vijay vi...@collab.net wrote:
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote:
On Mon, Nov 5, 2012 at 5:24 PM, vijay vi...@collab.net
mailto:vi...@collab.net wrote:
Hi,
This patch implements '--include-externals' option to 'svn list'
On Mon, Nov 05, 2012 at 09:54:56PM +0530, vijay wrote:
Hi,
This patch implements '--include-externals' option to 'svn list'
[Issue #4225] [1].
All tests pass with 'make check' 'make davautocheck'.
Attached the patch and log message.
Please review this patch and share your thoughts.
On Mon, Nov 5, 2012 at 5:24 PM, vijay vi...@collab.net wrote:
Hi,
This patch implements '--include-externals' option to 'svn list' [Issue
#4225] [1].
All tests pass with 'make check' 'make davautocheck'.
Attached the patch and log message.
Please review this patch and share your
Hi,
This patch implements '--include-externals' option to 'svn list' [Issue
#4225] [1].
All tests pass with 'make check' 'make davautocheck'.
Attached the patch and log message.
Please review this patch and share your thoughts.
Thanks in advance for your time.
Thanks Regards,
Vijayaguru
27 matches
Mail list logo
