On Wed, Feb 01, 2012 at 12:12:39PM -0800, Alexey Neyman wrote:
> Hi Stefan,
>
> Oops, I forgot to send it out after applying the feedback comments. Nothing
> to
> be sorry about. Here it is, updated to apply to r1239239.
Thanks! Committed in r1239553.
I'll make some more follow-up tweaks, but
Hi Stefan,
Oops, I forgot to send it out after applying the feedback comments. Nothing to
be sorry about. Here it is, updated to apply to r1239239.
[[[
* subversion/svn/cl.h
* subversion/svn/main.c
New options, --no-diff-properties and --patch for svn diff.
* subversion/include/svn_client.h
Alexey,
are you still working on this patch?
Since your last submission there has been some feedback and I think
we've reached consensus. I am sorry that our discussion flip-flopped
a little and mislead you.
I would very much like to see a version of your patch which
incorporates the feedback yo
Stefan Sperling wrote:
> Alexey Neyman wrote:
>> Stefan Sperling wrote:
>>> I'd prefer keeping --no-diff-properties and add a --patch option
>>> later which implies --no-diff-properties and maybe other options.
>>
>> I was explicitly asked by Julian Foad to avoid adding more
>> low-level opti
On 12/21/2011 02:32 PM, Alexey Neyman wrote:
> I am a bit confused here. The comment for svn_client_diff6 says "New in 1.8",
> and 1.8 is not released yes, is it? I thought that non-released API is
> subject
> to change. If it is not the case, I'll create another wrapper.
You are correct. If t
On Wed, Dec 21, 2011 at 11:32:43AM -0800, Alexey Neyman wrote:
> Hi Stefan,
>
> Thanks for a review. A few questions:
>
> On Wednesday, December 21, 2011 03:44:07 am Stefan Sperling wrote:
> > I'd prefer keeping --no-diff-properties and add a --patch option later
> > which implies --no-diff-prope
Hi Stefan,
Thanks for a review. A few questions:
On Wednesday, December 21, 2011 03:44:07 am Stefan Sperling wrote:
> I'd prefer keeping --no-diff-properties and add a --patch option later
> which implies --no-diff-properties and maybe other options.
I was explicitly asked by Julian Foad to avoi
On Wed, Nov 16, 2011 at 04:09:51PM -0800, Alexey Neyman wrote:
> On Sunday, November 06, 2011 10:27:01 am Daniel Shahaf wrote:
> > Perhaps the solution is to make 'svn diff' use --diff-cmd for propdiffs
> > too? It seems that currently --diff-cmd is only used for file content
> > diffs.
>
> I gue
Alexey Neyman wrote on Wed, Nov 16, 2011 at 16:09:51 -0800:
> On Sunday, November 06, 2011 10:27:01 am Daniel Shahaf wrote:
> > Perhaps the solution is to make 'svn diff' use --diff-cmd for propdiffs
> > too? It seems that currently --diff-cmd is only used for file content
> > diffs.
>
> I guess
On Sunday, November 06, 2011 10:27:01 am Daniel Shahaf wrote:
> Perhaps the solution is to make 'svn diff' use --diff-cmd for propdiffs
> too? It seems that currently --diff-cmd is only used for file content
> diffs.
I guess this is sort of a feature. As Julian pointed out, the property diffs
ar
10 matches
Mail list logo
