> -Original Message-
> From: Daniel Shahaf [mailto:d...@daniel.shahaf.name]
> Sent: dinsdag 20 september 2016 11:11
> To: b...@qqmail.nl
> Cc: dev@subversion.apache.org
> Subject: Re: [PATCH] Re: ra_local doesn't report post-commit errors
>
> b...@qqmail.nl
b...@qqmail.nl wrote on Mon, Sep 19, 2016 at 09:37:35 +0200:
> -1 on just returning non errors from the commit info callback and
> making callers suffer. I added that comment after finding that all
> callers suffer and there is no way to see the difference, causing all
> kinds of problems. You can
: Daniel Shahaf
Sent: maandag 19 september 2016 09:01
To: dev@subversion.apache.org
Subject: Re: [PATCH] Re: ra_local doesn't report post-commit errors
Daniel Shahaf wrote on Sat, Sep 17, 2016 at 06:52:44 +:
> What concerns me at the moment is that the patch makes deltify_etc()
> retu
Daniel Shahaf wrote on Sat, Sep 17, 2016 at 06:52:44 +:
> What concerns me at the moment is that the patch makes deltify_etc()
> return an error in situations where previously it did not. I think
> there are three possible solutions to this: revv the API deltify_etc()
> implements; make the ch
On Sat, Sep 17, 2016 at 06:52:44AM +, Daniel Shahaf wrote:
> I think end-users do care about the error code. We print it out in the
> command-line tools too and one of the reasons for that is so scripts can
> parse it.
>
> Moreover, as per the TODO's in the patch, this is groundwork for passi
Stefan Sperling wrote on Fri, Sep 16, 2016 at 09:09:08 +0200:
> On Fri, Sep 16, 2016 at 03:42:58AM +, Daniel Shahaf wrote:
> > Daniel Shahaf wrote on Fri, Sep 09, 2016 at 06:44:51 +:
> > > 3. Add to svn_commit_info_t an svn_error_t representation of the error
> > > chain that svn_commit_cal
On Fri, Sep 16, 2016 at 03:42:58AM +, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Fri, Sep 09, 2016 at 06:44:51 +:
> > 3. Add to svn_commit_info_t an svn_error_t representation of the error
> > chain that svn_commit_callback_t::post_commit_err summarizes,
>
> Patch attached.
>
> The new
Daniel Shahaf wrote on Fri, Sep 09, 2016 at 06:44:51 +:
> 3. Add to svn_commit_info_t an svn_error_t representation of the error
> chain that svn_commit_callback_t::post_commit_err summarizes,
Patch attached.
The new test fails over ra_svn; I haven't investigated that yet.
Does the approach
8 matches
Mail list logo