Hello Daniel
Could you comment the updated patch?
I prefer that someone else review the semantics, i.e., the actual
feature being added.
Does anybody comment for the feature?
--
Masaru Tsuchiyama m.tma...@gmail.com
masaru tsuchiyama wrote:
You still have several places where
masaru tsuchiyama m.tma...@gmail.com writes:
+ if (!fb-adding_file)
+{
+ if (fb-use_commit_times fb-changed_date)
+{
+ SVN_ERR(svn_io_set_file_affected_time(fb-changed_date,
+fb-local_abspath,
+
Philip Martin wrote:
masaru tsuchiyama m.tma...@gmail.com writes:
+ if (!fb-adding_file)
+{
+ if (fb-use_commit_times fb-changed_date)
+{
+ SVN_ERR(svn_io_set_file_affected_time(fb-changed_date,
+fb-local_abspath,
+
Masaru Tsuchiyama wrote on Thu, Aug 22, 2013 at 23:20:14 +0900:
Could you comment the updated patch?
As I said, I review the style but not the actual feature. Other devs
are far more familiar than I am with the client layer so I prefer to let
someone else do the review. Indeed Philip has now
You still have several places where your code exceeds 80 characters.
Fixed at attached patch.
Encoding problem? I see a Yen symbol where a backslash should be.
What do you see in the attached file? I use Google web mailer.
2013/8/8 Daniel Shahaf danie...@elego.de
Masaru Tsuchiyama wrote
+/** The value to force the executable property to when set.
+ *
+ * @deprecated Provided for backward compatibility with the 1.4 API.
+ * Use @c SVN_PROP_BOOLEAN_TRUE instead.
removed this.
Fix line breaks, wrap to 80 columns.
fixed this.
Please make the comments say more than the struct
Masaru Tsuchiyama wrote on Thu, Aug 08, 2013 at 23:13:54 +0900:
before it is modified. Makes the working copy file
read-only¥n
when it is not locked. Use 'svn propdel svn:needs-lock
PATH...'¥n
to clear.¥n
+ svn:use-commit-times - If present,
A review mostly of the code formatting (whitespace etc). In particular
I'm not reviewing the feature being added:
Index: subversion/include/svn_props.h
===
--- subversion/include/svn_props.h(revision 1509957)
+++
Hi, Martin,
Von: Philip Martin [mailto:philip.mar...@wandisco.com]
Masaru Tsuchiyama m.tma...@gmail.com writes:
[svn:use_commit_times property]
Perhaps this property should be inheritable? Then it could be set on a
directory and apply to the whole tree? I imagine users will want that but
On Wed, Jul 31, 2013 at 11:19 PM, Markus Schaber m.scha...@codesys.com wrote:
Using another property is not compatible with inheritance, as it will be
difficult to override the setting again in deeper nested directories.
What about disabling the feature when the property contains the test
Philip Martin wrote on Wed, Jul 31, 2013 at 15:09:10 +0100:
Perhaps this property should be inheritable? Then it could be set on a
directory and apply to the whole tree?
Even if yes, can't inheritability be implemented in a future patch?
i.e., maybe we should commit this patch and then think
Could you generate patches with
svn diff -x-p
, please? That makes review easier.
Thanks.
Daniel Shahaf danie...@elego.de writes:
Philip Martin wrote on Wed, Jul 31, 2013 at 15:09:10 +0100:
Perhaps this property should be inheritable? Then it could be set on a
directory and apply to the whole tree?
Even if yes, can't inheritability be implemented in a future patch?
i.e., maybe
Masaru Tsuchiyama m.tma...@gmail.com writes:
Index: subversion/include/svn_props.h
===
--- subversion/include/svn_props.h(revision 1507762)
+++ subversion/include/svn_props.h(working copy)
@@ -412,6 +412,14 @@
*/
Hi.
I attache new patch.
[[[
add 'svn:use-commit-times' property. If a file has 'svn:use-commit-times'
property,
the timestamp of the file is modified to commit time.
* subversion/include/svn_props.h
(): add SVN_PROP_USE_COMMIT_TIMES and SVN_PROP_USE_COMMIT_TIMES_VALUE
Hi.
Does anybody comment my patch?
--
Masaru Tsuchiyama m.tma...@gmail.com
Masaru Tsuchiyama m.tma...@gmail.com writes:
Index: subversion/include/svn_props.h
===
--- subversion/include/svn_props.h(revision 1505676)
+++ subversion/include/svn_props.h(working copy)
@@ -449,6 +449,9 @@
/**
Hi.
I attach a patch to add 'svn:use-commit-times' property and
a perl script to test it.
.
If a file has the property, the timestamp of the file is modified to commit time
when checkout, export, update.
The script is tested on Windows, not on UNIX/Linux.
(I think it works on UNIX/Linux too)
18 matches
Mail list logo