Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-07 Thread Jonathan Nieder
Daniel Shahaf wrote: > Jonathan Nieder wrote on Mon, Nov 07, 2011 at 12:45:19 -0600: >> [[[ >> * Makefile.in >> (swig-pl, $(SWIG_PY_DIR)/libsvn): Depend on mkdir-init. > > Does the swig-rb target need to grow a similar dependency on mkdir-init? > Makefile.in doesn't seem to already contain such

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-07 Thread Daniel Shahaf
Jonathan Nieder wrote on Mon, Nov 07, 2011 at 12:45:19 -0600: > >> (swig-pl): Likewise. > > Needed. > > cd . && /usr/bin/python > ../build/generator/swig/checkout_swig_header.py > /tmp/svn-test/BUILD/../build.conf /usr/bin/swig common.swg > Traceback (most recent call la

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-07 Thread Jonathan Nieder
Daniel Shahaf wrote: > Jonathan Nieder wrote on Sat, Nov 05, 2011 at 22:57:55 -0500: >> +++ Makefile.in (working copy) [...] >> # recursive targets to handle external projects (e.g. APR, Neon) >> -external-all external-install: >> +external-all external-install: mkdir-init >> @target=`e

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-07 Thread Daniel Shahaf
Jonathan Nieder wrote on Sat, Nov 05, 2011 at 22:57:55 -0500: > Greg Stein wrote: > > On Nov 5, 2011 6:06 AM, "Philip Martin" wrote: > > >> We have a mkdir-init target in the Makefile that is supposed to create > >> the build directories. > > > > Right. It creates what is needed rather than a sca

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-05 Thread Jonathan Nieder
Daniel Shahaf wrote: > And thirdly, with this fix 'make extraclean-swig; make extraclean-swig' > will still fail :-) Seemed to work for me. > Perhaps then you'd resend a patch that fixes the bug differently? Gladly --- the mkdir-init method does seem nicer. Thanks for your review and kind advi

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-05 Thread Jonathan Nieder
Greg Stein wrote: > On Nov 5, 2011 6:06 AM, "Philip Martin" wrote: >> We have a mkdir-init target in the Makefile that is supposed to create >> the build directories. > > Right. It creates what is needed rather than a scattershot hope. Thanks for the pointer. Running "make mkdir-init" works fin

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-05 Thread Greg Stein
On Nov 5, 2011 6:06 AM, "Philip Martin" wrote: > > Jonathan Nieder writes: > > > Index: configure.ac > > === > > --- configure.ac (revision 1197804) > > +++ configure.ac (working copy) > > @@ -1374,6 +1374,15 @@ > > > > AC

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-05 Thread Philip Martin
Jonathan Nieder writes: > Index: configure.ac > === > --- configure.ac (revision 1197804) > +++ configure.ac (working copy) > @@ -1374,6 +1374,15 @@ > > AC_OUTPUT > > +if test "$abs_srcdir" != "$abs_builddir" > +then >

Re: [PATCH] configure: pre-create build directories for VPATH builds

2011-11-05 Thread Daniel Shahaf
On Friday, November 04, 2011 5:41 PM, "Jonathan Nieder" wrote: > With r1197804, I tried: > > svn export ~/src/subversion svn-test > cd svn-test > ./autogen.sh > mkdir BUILD > cd BUILD > ../configure --prefix=$HOME/opt/subversion > make extraclean-swig

[PATCH] configure: pre-create build directories for VPATH builds

2011-11-04 Thread Jonathan Nieder
With r1197804, I tried: svn export ~/src/subversion svn-test cd svn-test ./autogen.sh mkdir BUILD cd BUILD ../configure --prefix=$HOME/opt/subversion make extraclean-swig The result: for d in /tmp/svn-test/BUILD/subversion/bindings/