On Mon, 2010-11-29, Danny Trebbien wrote:
[...]
My conclusion from all of this is that regardless of the value of
`repair`, my changes do not appear to decrease the performance of
svn_subst_translate_string() as long as svn_subst_translate_string2()
is called directly.
Hi Danny. (I notice
Julian Foad wrote on Tue, Nov 30, 2010 at 10:40:59 +:
On Mon, 2010-11-29, Danny Trebbien wrote:
[...]
My conclusion from all of this is that regardless of the value of
`repair`, my changes do not appear to decrease the performance of
svn_subst_translate_string() as long as
Re-reading my original review comment, I think it sounds more requiring
than I intended it to be. My fault.
Also, this thread (and in particular Danny's last mail) nicely demonstrate
another aspect of our patch submission process: namely, that patch reviews
are nothing but the start of a
Attached is a benchmark and Makefile that I used to test the speed of
svn_subst_translate_string() from trunk versus the new
svn_subst_translate_string2(). The program reads a text file named
`2600.txt` in the current working directory and repeatedly calls
svn_subst_translate_string() on the
I timed 'svn export' of a 146MB subdirectory of a format-21 working
copy to a linux tmpfs. Below, 't1' is pristine tr...@head and 't2' is
tr...@head plus the patch at the top of this thread:
% cd /tmp/ram
% mount | grep $PWD
tmpfs on /tmp/ram type tmpfs (rw,nosuid,nodev,noatime)
% rm -f
(btw, the firstnames distribution in COMMITTERS is... interesting.)
You piqued my curiosity. Here is a frequency table of first names of
the active full committers:
...
That's a lot of Daniels.
Also, many names start with J --- and not one of the J's repeats :-).
I hope you aren't discouraged from working on the patch.
Nah :)
To the point, I originally asked if your changes affected the performance
of checkout/export. That is not a reason to stop the patch in its tracks;
it's a question that should be answered (either way) and the patch then
On Thu, Nov 25, 2010 at 3:21 AM, Daniel Shahaf d...@daniel.shahaf.name wrote:
(btw, the firstnames distribution in COMMITTERS is... interesting.)
It will probably be a long time before 'Hyrum' isn't an outlier. :)
-Hyrum
Hi Daniel (T),
Since in your earlier post you mentioned that you didn't mind a friendly
reminder...
I thought I would return this thread to the top of the list - Just i case you
had missed Daniel (Shahaf) 's comments.
Gavin Beau Baumanis
On 02/11/2010, at 12:35 AM, Daniel Shahaf wrote:
On Wed, Nov 24, 2010 at 3:43 AM, Gavin Beau Baumanis
gav...@thespidernet.com wrote:
Hi Daniel (T),
Since in your earlier post you mentioned that you didn't mind a friendly
reminder...
I thought I would return this thread to the top of the list - Just i case
you had missed Daniel (Shahaf)
Gavin Beau Baumanis wrote on Mon, Oct 18, 2010 at 21:06:31 +1100:
Ping. This patch submission has received no comments.
Thanks, Gavin. @Daniel, sorry for the delay.
On 04/10/2010, at 5:55 AM, Daniel Trebbien wrote:
On Fri, Oct 1, 2010 at 3:57 AM, Julian Foad julian.f...@wandisco.com
Ping. This patch submission has received no comments.
Gavin Beau Baumanis
On 04/10/2010, at 5:55 AM, Daniel Trebbien wrote:
On Fri, Oct 1, 2010 at 3:57 AM, Julian Foad julian.f...@wandisco.com wrote:
Adds a public API function, svn_subst_translate_string2(), an extension of
Daniel, sorry I haven't looked at this yet, and won't be able to today.
- Julian
On Sun, 2010-10-03 at 11:55 -0700, Daniel Trebbien wrote:
On Fri, Oct 1, 2010 at 3:57 AM, Julian Foad julian.f...@wandisco.com wrote:
Adds a public API function, svn_subst_translate_string2(), an extension of
On Fri, Oct 1, 2010 at 3:57 AM, Julian Foad julian.f...@wandisco.com wrote:
Adds a public API function, svn_subst_translate_string2(), an extension of
svn_subst_translate_string(), that has two, additional output parameters for
determining whether re-encoding and/or line ending translation were
14 matches
Mail list logo
