Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-27 Thread Lieven Govaerts
On Sun, Feb 27, 2011 at 3:38 PM, Noorul Islam K M wrote: > Lieven Govaerts writes: > > > On Sun, Feb 27, 2011 at 6:02 AM, Noorul Islam K M > wrote: > > > >> Noorul Islam K M writes: > >> > >> Since svntest.main.run_tests already run "svnadmin create" and "svn > >> import", in this particular c

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-27 Thread Noorul Islam K M
Lieven Govaerts writes: > On Sun, Feb 27, 2011 at 6:02 AM, Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> >> Since svntest.main.run_tests already run "svnadmin create" and "svn >> import", in this particular case of input_validation_tests we don't need >> to create wc. So I passed cre

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-27 Thread Lieven Govaerts
On Sun, Feb 27, 2011 at 6:02 AM, Noorul Islam K M wrote: > Noorul Islam K M writes: > > Since svntest.main.run_tests already run "svnadmin create" and "svn > import", in this particular case of input_validation_tests we don't need > to create wc. So I passed create_wc = False to sbox.build() and

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-26 Thread Noorul Islam K M
Noorul Islam K M writes: > Noorul Islam K M writes: > >> Lieven Govaerts writes: >> >>> On Mon, Feb 21, 2011 at 11:32 AM, Noorul Islam K M wrote: >>> Noorul Islam K M writes: > Stefan Sperling writes: > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wro

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-25 Thread Noorul Islam K M
Noorul Islam K M writes: > Lieven Govaerts writes: > >> On Mon, Feb 21, 2011 at 11:32 AM, Noorul Islam K M wrote: >> >>> Noorul Islam K M writes: >>> >>> > Stefan Sperling writes: >>> > >>> >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >>> >> >>> >>> >>> >>> This patch r

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-24 Thread Noorul Islam K M
Lieven Govaerts writes: > On Mon, Feb 21, 2011 at 11:32 AM, Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> >> > Stefan Sperling writes: >> > >> >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >> >> >> >>> >> >>> This patch reduces checkout by around 23 times. >> >

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-23 Thread Lieven Govaerts
On Mon, Feb 21, 2011 at 11:32 AM, Noorul Islam K M wrote: > Noorul Islam K M writes: > > > Stefan Sperling writes: > > > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: > >> > >>> > >>> This patch reduces checkout by around 23 times. > >> > >> On my system the difference is

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-23 Thread Noorul Islam K M
t: maandag 21 februari 2011 13:19 >>>> To: Philip Martin >>>> Cc: dev@subversion.apache.org >>>> Subject: Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple >>>> checkouts. >>> >>>> You could argue that tiny tests that

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Johan Corveleyn
Martin >>> Cc: dev@subversion.apache.org >>> Subject: Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple >>> checkouts. >> >>> You could argue that tiny tests that do not modify a sandbox can be >>> merged together. Of course, if there

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
"Bert Huijben" writes: >> -Original Message- >> From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej >> Sent: maandag 21 februari 2011 13:19 >> To: Philip Martin >> Cc: dev@subversion.apache.org >> Subject: Re: [PATCH] input_va

RE: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej > Sent: maandag 21 februari 2011 13:19 > To: Philip Martin > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple > ch

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Branko Čibej
On 21.02.2011 13:12, Philip Martin wrote: > Branko Čibej writes: > >> We should not be optimising tests for performance over clarity, ever. In >> other words -- don't combine them. Anyone who has trouble with tests >> taking too long can use a RAMdisk, --bdb-txn-nosync, and other tweaks to >> make

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Philip Martin
Branko Čibej writes: > We should not be optimising tests for performance over clarity, ever. In > other words -- don't combine them. Anyone who has trouble with tests > taking too long can use a RAMdisk, --bdb-txn-nosync, and other tweaks to > make the tests run faster. I do that. The time to r

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Branko Čibej
On 21.02.2011 12:04, Philip Martin wrote: > Stefan Sperling writes: > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >>> This patch reduces checkout by around 23 times. >> On my system the difference is 43 seconds vs. 30 seconds. > On my low-end Linux desktop it's 7.5 seconds

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Branko Čibej
On 21.02.2011 11:32, Noorul Islam K M wrote: > Noorul Islam K M writes: > >> Stefan Sperling writes: >> >>> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >>> This patch reduces checkout by around 23 times. >>> On my system the difference is 43 seconds vs. 30 seconds. >>>

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Philip Martin
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >> >> This patch reduces checkout by around 23 times. > > On my system the difference is 43 seconds vs. 30 seconds. On my low-end Linux desktop it's 7.5 seconds and 3.5 seconds, run sequentially on a SAT

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
Noorul Islam K M writes: > Stefan Sperling writes: > >> On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: >> >>> >>> This patch reduces checkout by around 23 times. >> >> On my system the difference is 43 seconds vs. 30 seconds. >> >> We lose the ability to easily spot which of

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
Stefan Sperling writes: > On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: > >> >> This patch reduces checkout by around 23 times. > > On my system the difference is 43 seconds vs. 30 seconds. > > We lose the ability to easily spot which of the subtest is failing > if we do this

Re: [PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Stefan Sperling
On Mon, Feb 21, 2011 at 01:44:35PM +0530, Noorul Islam K M wrote: > > This patch reduces checkout by around 23 times. On my system the difference is 43 seconds vs. 30 seconds. We lose the ability to easily spot which of the subtest is failing if we do this. I.e. instead of: ... PASS: input_val

[PATCH] input_validation_tests.py: Reduce overhead of multiple checkouts.

2011-02-21 Thread Noorul Islam K M
This patch reduces checkout by around 23 times. Log [[[ Combine input validation tests to reduce the overhead of multiple checkouts. * subversion/tests/cmdline/input_validation_tests.py: (invalid_targets): Build sandbox once and make following methods local. (invalid_wcpath_add, invalid_wc