On Fri, Dec 28, 2018 at 8:20 AM Yasuhito FUTATSUKI
wrote:
> On 12/28/18 4:09 AM, Troy Curtis wrote:
> > LGTM, committed as r1849804, but without the unnecessary gymnastics to
> continue supporting str() in those two cases mentioned above. I also
> tweaked the log message to use complete sentences
On 12/28/18 4:09 AM, Troy Curtis wrote:
LGTM, committed as r1849804, but without the unnecessary gymnastics to continue
supporting str() in those two cases mentioned above. I also tweaked the log
message to use complete sentences (and removed references to the code that I
didn't include).
Th
On 12/27/18 12:42 PM, Yasuhito FUTATSUKI wrote:
On 12/27/18 1:01 PM, Troy Curtis wrote:
> The only real functionality changes I'm concerned with on the
changes are dropping str() conversion on a couple of the API inputs
since previously providing any object with a suitable __str__ method
wou
On 12/27/18 1:01 PM, Troy Curtis wrote:
> The only real functionality changes I'm concerned with on the changes are dropping
str() conversion on a couple of the API inputs since previously providing any object with a
suitable __str__ method would work, but would now be broken. But a simple way
On 12/26/18 11:51 AM, futat...@poem.co.jp wrote:
On 12/25/18 12:20, Troy Curtis Jr wrote:
On Mon, Dec 24, 2018 at 1:11 PM Yasuhito FUTATSUKI
wrote:
Awesome! I'm really glad you are helping work on this, helps to keep me
motivated as well ;)
I'm glad if I could some help, too :)
I've comm
On 12/25/18 12:20, Troy Curtis Jr wrote:
On Mon, Dec 24, 2018 at 1:11 PM Yasuhito FUTATSUKI
wrote:
Awesome! I'm really glad you are helping work on this, helps to keep me
motivated as well ;)
I'm glad if I could some help, too :)
So I wonder, as a guiding principle if we could support ei
Troy Curtis Jr wrote on Mon, Dec 24, 2018 at 22:20:40 -0500:
> On Mon, Dec 24, 2018 at 1:11 PM Yasuhito FUTATSUKI
> wrote:
> @@ -1321,7 +1321,7 @@ svn_swig_py_unwrap_string(PyObject *source,
> >void *baton)
> >
>
> Requiring "source" to be a Bytes object, makes this fu
On Mon, Dec 24, 2018 at 1:11 PM Yasuhito FUTATSUKI
wrote:
> On 12/17/18 5:50 AM, Yasuhito FUTATSUKI wrote:
> > On 12/17/18 2:08 AM, Troy Curtis Jr wrote:
>
[snip]
> Status update: I've done to make patch that default to map bytes
> from char *, svn_string_t, and svn_stringbuf_t, for swig-py3@1
On 12/17/18 05:50, Yasuhito FUTATSUKI wrote:
I found exception error messages isn't unified for
('a bytes', 'a bytes object', 'a Bytes object'),
and nothing but these.
I've updated the patch including fix above (unified to
'a bytes objects') and type casting between signed and
unsigned for len
On 12/17/18 18:35, Daniel Shahaf wrote:
Yasuhito FUTATSUKI wrote on Mon, Dec 17, 2018 at 05:50:03 +0900:
On 12/17/18 2:08 AM, Troy Curtis Jr wrote:
On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf
wrote:
Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500:
But there was one item I wanted to
Yasuhito FUTATSUKI wrote on Mon, Dec 17, 2018 at 05:50:03 +0900:
> On 12/17/18 2:08 AM, Troy Curtis Jr wrote:
> > On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf
> > wrote:
> >
> > > Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500:
> > > > But there was one item I wanted to talk about related
On 12/17/18 2:08 AM, Troy Curtis Jr wrote:
On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf
wrote:
Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500:
But there was one item I wanted to talk about related to the patch. I
agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is
On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf
wrote:
> Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500:
> > But there was one item I wanted to talk about related to the patch. I
> > agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is
> the
> > right general path,
>
> Are
Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500:
> But there was one item I wanted to talk about related to the patch. I
> agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is the
> right general path,
Are you sure about this? Property values can be binary data (so not
rep
On Wed, Nov 28, 2018 at 10:40 AM Daniel Shahaf
wrote:
> Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900:
> > I've revised typemaps and APIs using svn_stringbuf_t *, then I found
> > almost all those APIs include svn_stream_readline() use svn_stringbuf_t
> > for file contents. So
On Wed, Nov 28, 2018, 10:40 AM Daniel Shahaf Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900:
> > I've revised typemaps and APIs using svn_stringbuf_t *, then I found
> > almost all those APIs include svn_stream_readline() use svn_stringbuf_t
> > for file contents. So I've modifie
Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900:
> I've revised typemaps and APIs using svn_stringbuf_t *, then I found
> almost all those APIs include svn_stream_readline() use svn_stringbuf_t
> for file contents. So I've modified typemaps again so that those APIs
> use bytes for
I've revised typemaps and APIs using svn_stringbuf_t *, then I found
almost all those APIs include svn_stream_readline() use svn_stringbuf_t
for file contents. So I've modified typemaps again so that those APIs
use bytes for svn_stringbuf_t interface.
The patch below destined for branches/swig-p
Yasuhito FUTATSUKI wrote on Fri, Nov 23, 2018 at 16:43:24 +0900:
> On 11/23/18 11:21 AM, Daniel Shahaf wrote:
> > Thanks for the patch. I'm afraid I'm a bit disoriented, though; could
> > you kindly clarify a few things?
> >
> > Is the patch destined for trunk, for branches/swig-py3@HEAD, or for
On 11/23/18 11:21 AM, Daniel Shahaf wrote:
Thanks for the patch. I'm afraid I'm a bit disoriented, though; could
you kindly clarify a few things?
Is the patch destined for trunk, for branches/swig-py3@HEAD, or for
branches/swig-py3 after a sync-merge from trunk?
It's destined for branches/swi
Yasuhito FUTATSUKI wrote on Thu, 22 Nov 2018 20:16 +0900:
> Now ViewVC (un-official branch) works with swig-py on py3 :-)
> (https://github.com/futatuki/viewvc/tree/python3_support_with_altsvn)
Ah, so _that's_ why Mike asked about py3 support the other day :-)
> By the way, while I've read header
Thank you to respond to me.
It seems svn_stream_readline() works as I expected, eol argment accept
bytes, and returns bytes. (the patch below contains fix for
svn_stream_write() which is incomplete in my previous patch)
On 11/22/18 9:57 AM, Daniel Shahaf wrote:
Yasuhito FUTATSUKI wrote on Thu,
Yasuhito FUTATSUKI wrote on Thu, 22 Nov 2018 08:05 +0900:
> On 11/22/18 3:22 AM, Yasuhito FUTATSUKI wrote:
> > Here is a patch against typemap file core.i, try to change
> > svn_stream_read*() and svn_stream_write() interface to use
> > bytes object.
>
> Even with this patch, svn_stream_readline()
On 11/22/18 3:22 AM, Yasuhito FUTATSUKI wrote:
Here is a patch against typemap file core.i, try to change
svn_stream_read*() and svn_stream_write() interface to use
bytes object.
Even with this patch, svn_stream_readline() doesn't work well.
It claims 2nd argment is not bytes object, and return
Hi,
I've read BRANCH-README on swig-py3 branch and thead starting from
https://mail-archives.apache.org/mod_mbox/subversion-dev/201803.mbox/%3c20180323081026.cqgbhdzfxv2lwm24@tarpaulin.shahaf.local2%3e
so I've tried to fix it.
Here is a patch against typemap file core.i, try to change
svn_strea
25 matches
Mail list logo
