Re: Case-only renames on Windows (issue #3702)

2011-04-21 Thread Daniel Shahaf
:-)). So, for fixing issue #3702 (case-only renames on Windows), if we take into account the rest that's been discussed in this thread, we only need to do something special: - If there are exactly 2 targets - If those targets are paths, rather than uris. - If normalized dst_path == normalized

RE: Case-only renames on Windows (issue #3702)

2011-04-21 Thread Bert Huijben
: Daniel Shahaf Sent: donderdag 21 april 2011 17:33 To: Johan Corveleyn Cc: Philip Martin; Branko Čibej; dev@subversion.apache.org Subject: Re: Case-only renames on Windows (issue #3702) Johan Corveleyn wrote on Thu, Apr 14, 2011 at 23:49:16 +0200: On Tue, Apr 12, 2011 at 11:14 PM, Johan Corveleyn jcor

Re: Case-only renames on Windows (issue #3702)

2011-04-14 Thread Johan Corveleyn
that case-only renames (or renames in general) only come into play when there are exactly 2 targets of the move command: the source and the destination (ok, I'm a bit slow, I know :-)). So, for fixing issue #3702 (case-only renames on Windows), if we take into account the rest that's been discussed

RE: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Bolstridge, Andrew
-Original Message- From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej Sent: 24 March 2011 15:32 To: dev@subversion.apache.org Subject: Re: Case-only renames on Windows (issue #3702) [snip] In short, things aren't /that/ tricky as far as renames go. They're a lot

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Branko Čibej
On 25.03.2011 11:09, Bolstridge, Andrew wrote: (after all, the http transport should be case-insensitive too, I get to the same place typing in www.apache.com or www.APACHE.com, but not when it comes to the svn repo url). Oops. Host names are are case-insensitive by definition. Paths in URLs

RE: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Bert Huijben
-Original Message- From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej Sent: vrijdag 25 maart 2011 11:50 To: Bolstridge, Andrew Cc: dev@subversion.apache.org Subject: Re: Case-only renames on Windows (issue #3702) On 25.03.2011 11:09, Bolstridge, Andrew wrote

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread John Beranek
On 25/03/11 10:09, Bolstridge, Andrew wrote: -Original Message- From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej Sent: 24 March 2011 15:32 To: dev@subversion.apache.org Subject: Re: Case-only renames on Windows (issue #3702) [snip] In short, things aren't

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Philip Martin
Johan Corveleyn jcor...@gmail.com writes: C:\Temp\testdir /B ToDo C:\Temp\testmove todo todo C:\Temp\testdir /B todo So svn mv todo todo will be a case-only rename, I guess that's OK if it is what users expect. What if the file is already lower-case todo? Subversion is happy to do

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Johan Corveleyn
On Fri, Mar 25, 2011 at 1:43 PM, Philip Martin philip.mar...@wandisco.com wrote: Johan Corveleyn jcor...@gmail.com writes: C:\Temp\testdir /B ToDo C:\Temp\testmove todo todo C:\Temp\testdir /B todo So svn mv todo todo will be a case-only rename, I guess that's OK if it is what users

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Johan Corveleyn
On Sun, Mar 20, 2011 at 9:32 PM, Johan Corveleyn jcor...@gmail.com wrote: Some thoughts: - There is only a problem if the dst_path gets case-normalized to one of the source paths. Otherwise, the case-normalization really does need to happen. Hm, this thought may be incorrect (or at least

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Philip Martin
Johan Corveleyn jcor...@gmail.com writes: I'm looking at issue #3702 (svn ren TODO todo not work on windows). It's a bit tricky :) Consider a mixed-case node Foo. It's seems obvious that svn mv Foo foo is a case-only rename. But what about svn mv FOO foo or svn mv foo foo It's

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Branko Čibej
On 24.03.2011 15:22, Philip Martin wrote: Johan Corveleyn jcor...@gmail.com writes: I'm looking at issue #3702 (svn ren TODO todo not work on windows). It's a bit tricky :) Consider a mixed-case node Foo. It's seems obvious that svn mv Foo foo is a case-only rename. But what about

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Johan Corveleyn
2011/3/24 Branko Čibej br...@e-reka.si: On 24.03.2011 15:22, Philip Martin wrote: Johan Corveleyn jcor...@gmail.com writes: I'm looking at issue #3702 (svn ren TODO todo not work on windows). It's a bit tricky :)  Consider a mixed-case node Foo.  It's seems obvious that    svn mv Foo foo

Re: Case-only renames on Windows (issue #3702)

2011-03-23 Thread Johan Corveleyn
On Tue, Mar 22, 2011 at 1:08 AM, Hyrum K Wright hy...@hyrumwright.org wrote: On Sun, Mar 20, 2011 at 3:32 PM, Johan Corveleyn jcor...@gmail.com wrote: Hi, I'm looking at issue #3702 (svn ren TODO todo not work on windows). Although this is marked as 1.7-consider, I'd really like this to be

Re: Case-only renames on Windows (issue #3702)

2011-03-21 Thread Hyrum K Wright
On Sun, Mar 20, 2011 at 3:32 PM, Johan Corveleyn jcor...@gmail.com wrote: Hi, I'm looking at issue #3702 (svn ren TODO todo not work on windows). Although this is marked as 1.7-consider, I'd really like this to be fixed before release, since this is pretty important for me and my user base.

Case-only renames on Windows (issue #3702)

2011-03-20 Thread Johan Corveleyn
Hi, I'm looking at issue #3702 (svn ren TODO todo not work on windows). Although this is marked as 1.7-consider, I'd really like this to be fixed before release, since this is pretty important for me and my user base. So I'd like to take a stab, but being relatively inexperienced, I'd like some