Daniel Shahaf wrote:
> I'm a bit hesitant about disabling notifications _entirely_ in cat-cmd.c
> and diff-cmd.c. Disabling all notifications (as opposed to only
> hydration-related notifications which we focus on right now) seems like
> it could easily have unintended consequences. Do we do
Karl Fogel wrote on Wed, Mar 30, 2022 at 17:58:55 -0500:
> On 30 Mar 2022, Julian Foad wrote:
> > Karl Fogel wrote:
> > > I think printing these messages to stderr makes the most sense.
> > > There are plenty of programs out there that parse the stdout of
> > > 'svn'; we don't want to interfere
On 30 Mar 2022, Julian Foad wrote:
Karl Fogel wrote:
I think printing these messages to stderr makes the most sense.
There are plenty of programs out there that parse the stdout of
'svn'; we don't want to interfere with them.
As you point out, it's especially important for 'svn diff' and
On Wed, Mar 30, 2022 at 9:02 AM Julian Foad wrote:
>
> Karl Fogel wrote:
> > I think printing these messages to stderr makes the most sense.
> > There are plenty of programs out there that parse the stdout of
> > 'svn'; we don't want to interfere with them.
> >
> > As you point out, it's
Karl Fogel wrote:
> I think printing these messages to stderr makes the most sense.
> There are plenty of programs out there that parse the stdout of
> 'svn'; we don't want to interfere with them.
>
> As you point out, it's especially important for 'svn diff' and
> 'svn cat' that stdout remain
On 24 Mar 2022, Julian Foad wrote:
For 'svn diff' especially, if we don't print the notifications,
then we
miss out on informing the user during one of the times when it
could be
particularly valuable to them. (They are waiting for diff output,
which
previously in svn used to come quickly.)
Finished and committed: https://svn.apache.org/r1899173 .
This looks and feels much better to me now.
Example:
$ svn revert -R subversion/
Fetching text bases ..done
Reverted 'subversion/svn/cat-cmd.c'
Reverted 'subversion/svn/diff-cmd.c'
Reverted [...]
- Julian
Updated and cleaned-up patch 'hydrating-notifications-2.patch' attached,
for interest. Still TODO: update test expectations.
hydrating-notifications-2.patch
Description: Binary data
Daniel Sahlberg wrote:
> How does svn cat handle any other informative or warning messages?
I don't think 'svn cat' prints any other informative or warning messages.
It occurs to me now that anything on stderr is generally assumed to
indicate an error, in tests in the test suite. We need to
Den tors 24 mars 2022 kl 11:34 skrev Julian Foad :
> For 'svn diff' especially, if we don't print the notifications, then we
> miss out on informing the user during one of the times when it could be
> particularly valuable to them. (They are waiting for diff output, which
> previously in svn used
For 'svn diff' especially, if we don't print the notifications, then we
miss out on informing the user during one of the times when it could be
particularly valuable to them. (They are waiting for diff output, which
previously in svn used to come quickly.)
It would be ugly to print these
Den tors 24 mars 2022 kl 09:53 skrev Julian Foad :
> Daniel Sahlberg wrote:
> >> I'll put it on my todo list, but I can't promise when I find time to
> >> to that.
>
> I only meant to ask you to clarify what you meant: whether you are
> reporting for TSVN 1.14 or a TSVN 1.15-dev build (based on
I made a mistake in:
> 'svn cat' already suppresses these notifications.
CORRECTION:
'svn cat' currently prints these notifications.
'svn diff' currently prints these notifications.
--> TODO: stop printing them here.
It seems the only change needed here is to make both 'svn diff' AND 'svn
cat'
Daniel Sahlberg wrote:
>> I'll put it on my todo list, but I can't promise when I find time to
>> to that.
I only meant to ask you to clarify what you meant: whether you are
reporting for TSVN 1.14 or a TSVN 1.15-dev build (based on the
pristines-on-demand branch or otherwise; I don't know if
Den tors 24 mars 2022 kl 09:04 skrev Julian Foad :
> Daniel, can you confirm if you mean you are using a 1.14-based TSVN, on
> a 1.15 working copy, and it is showing bytes-transferred feedback during
> the hydrating? I had assumed it would need to be rebuilt and modified to
> do that. If that
Marl Phippard wrote:
> Yes, and I agree --quiet should suppress. [...TSVN] hooked into our
> notifications to be providing an update on bytes transferred. [...] I
> just assumed they would work ... maybe they still do?
Daniel Sahlberg wrote:
>> Yes, I like this very much. The more feedback [...]
Den ons 23 mars 2022 kl 23:58 skrev Mark Phippard :
> On Wed, Mar 23, 2022 at 5:51 PM Julian Foad wrote:
>
> > I thought maybe we would like to show this detail by default, and
> > suppress it when '--quiet' is passed. (Not implemented in this demo
> patch.)
> >
> > I was also mildly surprised
On Wed, Mar 23, 2022 at 5:51 PM Julian Foad wrote:
> I thought maybe we would like to show this detail by default, and
> suppress it when '--quiet' is passed. (Not implemented in this demo patch.)
>
> I was also mildly surprised to see that the fetches are not necessarily
> all grouped together
The notifications are printed for any command. Let's please pretend I
didn't use 'update' as an example. I don't want us to mix up this
discussion with the discussion about how 'update' shouldn't hydrate.
Let's pretend I used 'diff' or 'revert' as the example, like this:
[[[
$ svn revert -R
I thought it would be useful to let users know why Subversion is pausing
for a long time where previously it would not have done. I think if I
were that user, I would want to know. So I tried the attached patch,
printing notifications when it is fetching text-bases.
The result looks like this.
20 matches
Mail list logo
