Make ra_serf handle 408 Request Timeout response (was Re: Random serf checkout failures)

2012-11-08 Thread Lieven Govaerts
On Wed, Nov 7, 2012 at 10:28 PM, Lieven Govaerts l...@apache.org wrote: Hi, we seem to be raising and discussing a few different issues in this thread. I've tried to summarize current status with some added observations. I propose to start up separate mail threads when discussing one of

AW: Random serf checkout failures

2012-11-08 Thread Markus Schaber
Hi, Lieven, Von: lieven.govae...@gmail.com [] 5. In one of Philip error-reporting mails, there was mention of a 408 Request Time-out response. (http://svn.haxx.se/dev/archive-2012-11/0076.shtml). No idea if the server sends this response because one of the above issues, or if this has a

ra_serf: truncated responses by low Timeout are not handled graceful (was Re: Random serf checkout failures)

2012-11-08 Thread Lieven Govaerts
Philip, On Tue, Nov 6, 2012 at 11:20 PM, Philip Martin philip.mar...@wandisco.com wrote: Lieven Govaerts l...@mobsol.be writes: Philip or Ben, can you test that with this patch svn will always stop with a communication error? Using serf 1.1.x patched and Subversion 1406366 I get this new

Re: Random serf checkout failures

2012-11-08 Thread Lieven Govaerts
Hi Markus, On Thu, Nov 8, 2012 at 12:02 PM, Markus Schaber m.scha...@codesys.com wrote: Hi, Lieven, Von: lieven.govae...@gmail.com [] 5. In one of Philip error-reporting mails, there was mention of a 408 Request Time-out response. (http://svn.haxx.se/dev/archive-2012-11/0076.shtml).

AW: Random serf checkout failures

2012-11-08 Thread Markus Schaber
Hi, Lieven, Von: lieven.govae...@gmail.com [mailto:lieven.govae...@gmail.com] Im On Thu, Nov 8, 2012 at 12:02 PM, Markus Schaber m.scha...@codesys.com wrote: Von: lieven.govae...@gmail.com [] 5. In one of Philip error-reporting mails, there was mention of a 408 Request Time-out

Re: Random serf checkout failures

2012-11-07 Thread Philip Martin
Justin Erenkrantz jus...@erenkrantz.com writes: Sure sounds like an early TCP close causing a lost response. httpd shouldn't be closing the TCP connection in the middle of the response as that's not when httpd would evaluate the Timeout directive...but, if you are going over a loopback

Re: Random serf checkout failures

2012-11-07 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: Could please test attached serf patch. This patch should fix problem with reading one connection for long time without reading from other connections. I still see assertions with your patch and Lieven's patch together. -- Certified Supported Apache

Re: Random serf checkout failures

2012-11-06 Thread C. Michael Pilato
On 11/05/2012 08:30 PM, Justin Erenkrantz wrote: On Mon, Nov 5, 2012 at 1:33 PM, C. Michael Pilato cmpil...@collab.net wrote: My debugging indicates that when close_all_dirs() is called, there are a slew of unclosed directories which each have a non-zero ref_count. Save for the root directory

Re: Random serf checkout failures

2012-11-06 Thread Ben Reser
I worked with Philip today and was able to reproduce the exact problem he's been seeing. I ended up having to get his full httpd.conf to figure it out.. Ultimately the problem proved to be that he had this directive: Timeout 3 Which would mean if we don't tend a connection for 3 seconds Apache

Re: Random serf checkout failures

2012-11-06 Thread C. Michael Pilato
On 11/06/2012 08:29 AM, C. Michael Pilato wrote: On 11/05/2012 08:30 PM, Justin Erenkrantz wrote: On Mon, Nov 5, 2012 at 1:33 PM, C. Michael Pilato cmpil...@collab.net wrote: My debugging indicates that when close_all_dirs() is called, there are a slew of unclosed directories which each have

Re: Random serf checkout failures

2012-11-06 Thread Lieven Govaerts
Hi, On Tue, Nov 6, 2012 at 4:50 PM, Lieven Govaerts l...@mobsol.be wrote: Ben, On Tue, Nov 6, 2012 at 4:09 PM, Ben Reser b...@reser.org wrote: I worked with Philip today and was able to reproduce the exact problem he's been seeing. I ended up having to get his full httpd.conf to figure it

Re: Random serf checkout failures

2012-11-06 Thread Ivan Zhakov
On Tue, Nov 6, 2012 at 9:13 PM, Lieven Govaerts l...@mobsol.be wrote: Hi, On Tue, Nov 6, 2012 at 4:50 PM, Lieven Govaerts l...@mobsol.be wrote: Ben, On Tue, Nov 6, 2012 at 4:09 PM, Ben Reser b...@reser.org wrote: I worked with Philip today and was able to reproduce the exact problem he's

Re: Random serf checkout failures

2012-11-06 Thread Ivan Zhakov
On Tue, Nov 6, 2012 at 10:24 PM, Ivan Zhakov i...@visualsvn.com wrote: On Tue, Nov 6, 2012 at 9:13 PM, Lieven Govaerts l...@mobsol.be wrote: Hi, On Tue, Nov 6, 2012 at 4:50 PM, Lieven Govaerts l...@mobsol.be wrote: Ben, On Tue, Nov 6, 2012 at 4:09 PM, Ben Reser b...@reser.org wrote: I

Re: Random serf checkout failures

2012-11-06 Thread C. Michael Pilato
On 11/06/2012 10:15 AM, C. Michael Pilato wrote: On 11/06/2012 08:29 AM, C. Michael Pilato wrote: I recall this patch of yours -- I even asked you about it post-Berlin. I'll take a look at it now and see if it can help us out. Not seeing the active_dir_propfinds list corruption you

Re: Random serf checkout failures

2012-11-06 Thread Lieven Govaerts
patch attached On Tue, Nov 6, 2012 at 10:45 PM, Lieven Govaerts l...@mobsol.be wrote: Hi, On Tue, Nov 6, 2012 at 6:13 PM, Lieven Govaerts l...@mobsol.be wrote: Hi, On Tue, Nov 6, 2012 at 4:50 PM, Lieven Govaerts l...@mobsol.be wrote: Ben, On Tue, Nov 6, 2012 at 4:09 PM, Ben Reser

Re: Random serf checkout failures

2012-11-06 Thread Philip Martin
Lieven Govaerts l...@mobsol.be writes: Philip or Ben, can you test that with this patch svn will always stop with a communication error? Using serf 1.1.x patched and Subversion 1406366 I get this new error: Awc/1.3.0-rc1/subversion/libsvn_subr/config.c

Re: Random serf checkout failures

2012-11-06 Thread Justin Erenkrantz
On Tue, Nov 6, 2012 at 3:22 PM, C. Michael Pilato cmpil...@collab.net wrote: On 11/06/2012 10:15 AM, C. Michael Pilato wrote: On 11/06/2012 08:29 AM, C. Michael Pilato wrote: I recall this patch of yours -- I even asked you about it post-Berlin. I'll take a look at it now and see if it can

Re: Random serf checkout failures

2012-11-06 Thread Justin Erenkrantz
On Tue, Nov 6, 2012 at 4:41 PM, Ivan Zhakov i...@visualsvn.com wrote: Another problem is how serf reads data from network in case of multiple connections: it reads data from one connection until EAGAIN. But if data comes from network really fast (from local server for example) it continue

Re: Random serf checkout failures

2012-11-06 Thread Ivan Zhakov
On Wed, Nov 7, 2012 at 1:41 AM, Ivan Zhakov i...@visualsvn.com wrote: On Tue, Nov 6, 2012 at 10:24 PM, Ivan Zhakov i...@visualsvn.com wrote: On Tue, Nov 6, 2012 at 9:13 PM, Lieven Govaerts l...@mobsol.be wrote: Hi, On Tue, Nov 6, 2012 at 4:50 PM, Lieven Govaerts l...@mobsol.be wrote: Ben,

Re: Random serf checkout failures

2012-11-05 Thread Philip Martin
Philip Martin phi...@codematters.co.uk writes: I've been experimenting checking out subversion/tags from my local mirror of the Subversion repository using a client and mod_dav_svn from trunk. I'm getting several different errors seemingly at random, I suspect they may be related to some

Re: Random serf checkout failures

2012-11-05 Thread Lieven Govaerts
On Mon, Nov 5, 2012 at 11:33 AM, Philip Martin philip.mar...@wandisco.com wrote: Philip Martin phi...@codematters.co.uk writes: I've been experimenting checking out subversion/tags from my local mirror of the Subversion repository using a client and mod_dav_svn from trunk. I'm getting

Re: Random serf checkout failures

2012-11-05 Thread Philip Martin
Lieven Govaerts l...@mobsol.be writes: From your previous report I noticed the 406 response that serf isn't handling, at least serf doesn't support a response coming in while the matching request wasn't completely sent yet. I guess that 406 response was for a REPORT request not flushed fast

Re: Random serf checkout failures

2012-11-05 Thread Lieven Govaerts
On Mon, Nov 5, 2012 at 12:41 PM, Lieven Govaerts l...@mobsol.be wrote: On Mon, Nov 5, 2012 at 11:33 AM, Philip Martin philip.mar...@wandisco.com wrote: Philip Martin phi...@codematters.co.uk writes: I've been experimenting checking out subversion/tags from my local mirror of the Subversion

Re: Random serf checkout failures

2012-11-05 Thread C. Michael Pilato
On 11/05/2012 11:49 AM, Lieven Govaerts wrote: On Mon, Nov 5, 2012 at 12:41 PM, Lieven Govaerts l...@mobsol.be wrote: On Mon, Nov 5, 2012 at 11:33 AM, Philip Martin philip.mar...@wandisco.com wrote: Philip Martin phi...@codematters.co.uk writes: I've been experimenting checking out

Re: Random serf checkout failures

2012-11-05 Thread C. Michael Pilato
On 11/05/2012 01:33 PM, C. Michael Pilato wrote: On 11/05/2012 11:49 AM, Lieven Govaerts wrote: My current test with svn trunk apache+mod_dav_svn 1.6.12 does not reproduce this issue. What I am seeing is that svn is using a lot of memory, up to 1GB. Currently looking at the root cause

Re: Random serf checkout failures

2012-11-05 Thread Lieven Govaerts
Hi Mike On Mon, Nov 5, 2012 at 9:39 PM, C. Michael Pilato cmpil...@collab.net wrote: On 11/05/2012 01:33 PM, C. Michael Pilato wrote: On 11/05/2012 11:49 AM, Lieven Govaerts wrote: My current test with svn trunk apache+mod_dav_svn 1.6.12 does not reproduce this issue. What I am seeing is

Re: Random serf checkout failures

2012-11-05 Thread C. Michael Pilato
On 11/05/2012 04:21 PM, Lieven Govaerts wrote: Do you plan on patching this issue? If yes I can continue looking at Philip's original issue in this thread - assuming it is not caused by the memory leak. Thanks for the helpful cross-checking! Yes, I plan to continue looking into this issue.

Re: Random serf checkout failures

2012-11-05 Thread Justin Erenkrantz
On Mon, Nov 5, 2012 at 1:33 PM, C. Michael Pilato cmpil...@collab.net wrote: My debugging indicates that when close_all_dirs() is called, there are a slew of unclosed directories which each have a non-zero ref_count. Save for the root directory of the edit (/tags), fetch_props == TRUE,

Re: Random serf checkout failures

2012-11-02 Thread Lieven Govaerts
Philip, On Thu, Nov 1, 2012 at 1:29 PM, Philip Martin phi...@codematters.co.uk wrote: I've been experimenting checking out subversion/tags from my local mirror of the Subversion repository using a client and mod_dav_svn from trunk. I'm getting several different errors seemingly at random, I

Random serf checkout failures

2012-11-01 Thread Philip Martin
I've been experimenting checking out subversion/tags from my local mirror of the Subversion repository using a client and mod_dav_svn from trunk. I'm getting several different errors seemingly at random, I suspect they may be related to some common underlying problem. Sometimes I see a checksum