Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-24 Thread Gavin Beau Baumanis
Hi Everyone, I thought I would use this thread to solicit a few opinions about threads like this one and the Patch Manager's role with them. In a previous thread Hyrum noted that because the discussion was between full-committers there wasn't necessarily a role for the PM to play within the

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-24 Thread C. Michael Pilato
Gavin, you're a volunteer, offering a service we very much appreciate but which we realize is offered only out of your free and good will. We've already established the minimum expectations of someone serving in the Patch Manager role. So IMO, if you *want* to contribute to threads such as this

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-24 Thread Stefan Sperling
On Wed, Nov 24, 2010 at 08:57:22AM -0500, C. Michael Pilato wrote: Gavin, you're a volunteer, offering a service we very much appreciate but which we realize is offered only out of your free and good will. We've already established the minimum expectations of someone serving in the Patch

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-10 Thread Julian Foad
On Wed, 2010-11-10, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Nov 10 01:44:35 2010 New Revision: 1033320 URL: http://svn.apache.org/viewvc?rev=1033320view=rev Log: Fix issue #3622 (svn should exit with exit code 1 if updating externals fails). *

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-10 Thread C. Michael Pilato
On 11/10/2010 05:21 AM, Julian Foad wrote: I'm wondering about the wrapper function approach - did you feel it's important to separate this error detection from the notification function? I wonder if it would be simpler overall to get svn's existing notifier code to track the presence of

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-09 Thread Noorul Islam K M
cmpil...@apache.org writes: Author: cmpilato Date: Wed Nov 10 01:44:35 2010 New Revision: 1033320 URL: http://svn.apache.org/viewvc?rev=1033320view=rev Log: Fix issue #3622 (svn should exit with exit code 1 if updating externals fails). * subversion/include/svn_error_codes.h

Re: svn commit: r1033320 - in /subversion/trunk/subversion: include/svn_error_codes.h svn/cl.h svn/export-cmd.c svn/notify.c svn/switch-cmd.c svn/update-cmd.c tests/cmdline/externals_tests.py

2010-11-09 Thread C. Michael Pilato
On 11/09/2010 10:30 PM, Noorul Islam K M wrote: I think I can have similar approach for issue 3713. If you are not already on it then I will try implementing the same for 3713. Nope, I'm not on it. -- C. Michael Pilato cmpil...@collab.net CollabNet www.collab.net Distributed