Re: notification output bottleneck

2012-08-28 Thread Johan Corveleyn
On Wed, Aug 29, 2012 at 1:33 AM, Johan Corveleyn jcor...@gmail.com wrote: On Wed, Aug 29, 2012 at 1:22 AM, Johan Corveleyn jcor...@gmail.com wrote: [[[ C:\Temp\svnperftimeit svn export https://playsvn/repos export1 ... snip output ... start: 2012-29-08 00:48:49,06 end : 2012-29-08 00:53

Re: notification output bottleneck

2012-08-30 Thread Johan Corveleyn
On Wed, Aug 29, 2012 at 4:22 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: On Tue, Aug 28, 2012 at 7:22 PM, Johan Corveleyn jcor...@gmail.com wrote: Yep, redirecting to a file eliminates the bottleneck (almost the same as redirecting to NUL) (I ran it a couple of times to make sure

Re: notification output bottleneck

2012-08-30 Thread Johan Corveleyn
On Thu, Aug 30, 2012 at 12:19 PM, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On 8/30/12, Johan Corveleyn jcor...@gmail.com wrote: On Wed, Aug 29, 2012 at 4:22 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: On Tue, Aug 28, 2012 at 7:22 PM, Johan Corveleyn jcor...@gmail.com wrote

Re: Inline added-item properties in REPORT response

2012-09-03 Thread Johan Corveleyn
On Fri, Aug 31, 2012 at 2:03 PM, Ivan Zhakov i...@visualsvn.com wrote: On Thu, Aug 30, 2012 at 10:43 PM, C. Michael Pilato cmpil...@collab.net wrote: On 08/30/2012 10:45 AM, Ivan Zhakov wrote: On Thu, Aug 30, 2012 at 4:56 PM, C. Michael Pilato cmpil...@collab.net wrote: Theoretically,

Re: [PATCH] subversion issue #4174 - serf: checkout / export over https errors out with svn: E730053: Error retrieving REPORT (730053)

2012-09-03 Thread Johan Corveleyn
On Sat, Sep 1, 2012 at 11:36 AM, Lieven Govaerts svn...@mobsol.be wrote: Johan, On Mon, Aug 27, 2012 at 9:15 PM, Johan Corveleyn jcor...@gmail.com wrote: On Mon, Aug 27, 2012 at 8:48 PM, Lieven Govaerts svn...@mobsol.be wrote: Hi Johan, On Mon, Aug 27, 2012 at 2:44 PM, Johan Corveleyn jcor

Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

2012-09-09 Thread Johan Corveleyn
On Thu, Sep 6, 2012 at 11:30 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Sep 6 21:30:40 2012 New Revision: 1381766 URL: http://svn.apache.org/viewvc?rev=1381766view=rev Log: Many strings we need to convert to UTF-8 (paths, even log messages) contain large ASCII chars only

Case-only renames on Windows (issue #3702)

2011-03-20 Thread Johan Corveleyn
Hi, I'm looking at issue #3702 (svn ren TODO todo not work on windows). Although this is marked as 1.7-consider, I'd really like this to be fixed before release, since this is pretty important for me and my user base. So I'd like to take a stab, but being relatively inexperienced, I'd like some

Re: Case-only renames on Windows (issue #3702)

2011-03-23 Thread Johan Corveleyn
On Tue, Mar 22, 2011 at 1:08 AM, Hyrum K Wright hy...@hyrumwright.org wrote: On Sun, Mar 20, 2011 at 3:32 PM, Johan Corveleyn jcor...@gmail.com wrote: Hi, I'm looking at issue #3702 (svn ren TODO todo not work on windows). Although this is marked as 1.7-consider, I'd really like

Re: Case-only renames on Windows (issue #3702)

2011-03-24 Thread Johan Corveleyn
2011/3/24 Branko Čibej br...@e-reka.si: On 24.03.2011 15:22, Philip Martin wrote: Johan Corveleyn jcor...@gmail.com writes: I'm looking at issue #3702 (svn ren TODO todo not work on windows). It's a bit tricky :)  Consider a mixed-case node Foo.  It's seems obvious that    svn mv Foo foo

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Johan Corveleyn
On Fri, Mar 25, 2011 at 1:43 PM, Philip Martin philip.mar...@wandisco.com wrote: Johan Corveleyn jcor...@gmail.com writes: C:\Temp\testdir /B ToDo C:\Temp\testmove todo todo C:\Temp\testdir /B todo So svn mv todo todo will be a case-only rename, I guess that's OK if it is what users

Re: Case-only renames on Windows (issue #3702)

2011-03-25 Thread Johan Corveleyn
On Sun, Mar 20, 2011 at 9:32 PM, Johan Corveleyn jcor...@gmail.com wrote: Some thoughts: - There is only a problem if the dst_path gets case-normalized to one of the source paths. Otherwise, the case-normalization really does need to happen. Hm, this thought may be incorrect (or at least

Re: Performance benchmarks

2011-03-28 Thread Johan Corveleyn
Hi Mark, Here is another data point, for my old (t)rusty Windows XP (32-bit) this time, on a system with a pretty slow hard disk (5.4k rpm), 1.83 GHz Intel T2400 cpu, 3 GB RAM. I must say the results look very good for 1.7 (r1086021) compared to 1.6.16 on this system. Especially for the Folder

Re: Performance benchmarks

2011-03-29 Thread Johan Corveleyn
Forgot to add: this was with the repository via svnserve on localhost. Johan On Tue, Mar 29, 2011 at 12:16 AM, Johan Corveleyn jcor...@gmail.com wrote: Hi Mark, Here is another data point, for my old (t)rusty Windows XP (32-bit) this time, on a system with a pretty slow hard disk (5.4k rpm

Re: Performance benchmarks-1.5 results show significant regression in 1.6

2011-04-04 Thread Johan Corveleyn
On Thu, Mar 31, 2011 at 7:11 PM, Stefan Sperling s...@elego.de wrote: On Thu, Mar 31, 2011 at 01:04:20PM -0400, Mark Phippard wrote: On Thu, Mar 31, 2011 at 1:01 PM, Stefan Sperling s...@elego.de wrote: Yes, I believe so.  That was also the thread on users@ that made me add this scenario

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Johan Corveleyn
On Tue, Apr 12, 2011 at 3:14 PM, Hyrum Wright hwri...@apache.org wrote: On Tue, Apr 12, 2011 at 8:00 AM, C. Michael Pilato cmpil...@collab.net wrote: You are looking at changelists as a way to learn how to move operations into wc_db properly, but just like that temp table for notifications I

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Johan Corveleyn
On Tue, Apr 12, 2011 at 3:40 PM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: dinsdag 12 april 2011 15:27 To: Hyrum Wright Cc: C. Michael Pilato; Bert Huijben; Greg Stein; dev@subversion.apache.org Subject: Re: svn

Re: Case-only renames on Windows (issue #3702)

2011-04-14 Thread Johan Corveleyn
On Tue, Apr 12, 2011 at 11:14 PM, Johan Corveleyn jcor...@gmail.com wrote: On Fri, Mar 25, 2011 at 2:21 PM, Johan Corveleyn jcor...@gmail.com wrote: On Sun, Mar 20, 2011 at 9:32 PM, Johan Corveleyn jcor...@gmail.com wrote: Some thoughts: - There is only a problem if the dst_path gets case

Re: [svnbench] Revision: 1091976 compiled Apr 14 2011, 00:21:28

2011-04-15 Thread Johan Corveleyn
On Fri, Apr 15, 2011 at 10:22 AM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: Johan Corveleyn [mailto:jcor...@gmail.com] Sent: donderdag 14 april 2011 23:23 To: Neels Hofmeyr Cc: dev Subject: Re: [svnbench] Revision: 1091976 compiled Apr 14 2011, 00:21:28 On Thu

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-16 Thread Johan Corveleyn
2011/4/16 Branko Čibej br...@e-reka.si: On 16.04.2011 10:17, Johan Corveleyn wrote: Hi, Following discussion in [1], I tried to write a patch for issue #3702 (svn ren TODO todo not work on windows). As mentioned by Bert in comment to the issue [2], we need to avoid letting 'svn move' convert

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-17 Thread Johan Corveleyn
2011/4/16 Branko Čibej br...@e-reka.si: On 16.04.2011 16:14, Johan Corveleyn wrote: Do I have to worry about differences between on-disk casing and wc-db casing of a path? Is that possible? I guess it is by using non-svn commands, but I bet that's an invalid state of the wc (I know

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-18 Thread Johan Corveleyn
On Sat, Apr 16, 2011 at 10:17 AM, Johan Corveleyn jcor...@gmail.com wrote: Hi, Following discussion in [1], I tried to write a patch for issue #3702 (svn ren TODO todo not work on windows). As mentioned by Bert in comment to the issue [2], we need to avoid letting 'svn move' convert

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-20 Thread Johan Corveleyn
2011/4/18 Branko Čibej br...@e-reka.si: On 18.04.2011 20:01, Johan Corveleyn wrote: BUT it raises some additional questions/issues: - How to commit such a move? Committing the parent directory recursively works fine, but if you try to specify only the move targets (src and dst paths), commit

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-22 Thread Johan Corveleyn
On Thu, Apr 21, 2011 at 3:07 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Mon, Apr 18, 2011 at 20:01:20 +0200: - In fact: the same problem holds true for other commands as well: how to revert both sides of this move? Ok, one can revert in two steps ... - Maybe

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-24 Thread Johan Corveleyn
On Wed, Apr 20, 2011 at 11:22 PM, Johan Corveleyn jcor...@gmail.com wrote: 2011/4/18 Branko Čibej br...@e-reka.si: On 18.04.2011 20:01, Johan Corveleyn wrote: BUT it raises some additional questions/issues: - How to commit such a move? Committing the parent directory recursively works fine

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-24 Thread Johan Corveleyn
On Sat, Apr 23, 2011 at 11:13 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: On Sat, 23 Apr 2011 11:55 +0300, Daniel Shahaf d...@daniel.shahaf.name wrote: On Fri, 22 Apr 2011 23:07 +0200, Johan Corveleyn jcor...@gmail.com wrote: On Thu, Apr 21, 2011 at 3:07 PM, Daniel Shahaf d

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-25 Thread Johan Corveleyn
On Mon, Apr 25, 2011 at 4:56 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Mon, Apr 25, 2011 at 01:08:24 +0200: 2011/4/22 Branko Čibej br...@e-reka.si: Meh. For now, just hack a special case so that committing one half of a case-only rename will automagically

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-04-25 Thread Johan Corveleyn
On Mon, Apr 25, 2011 at 5:03 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Mon, Apr 25, 2011 at 01:08:24 +0200: 2011/4/22 Branko Čibej br...@e-reka.si: Meh. For now, just hack a special case so that committing one half of a case-only rename will automagically

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-05-03 Thread Johan Corveleyn
On Tue, May 3, 2011 at 10:17 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Tue, May 03, 2011 at 21:49:48 +0200: On Mon, Apr 25, 2011 at 11:26 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Mon, Apr 25, 2011 at 23:10:21 +0200: On Mon

[RFC] Case-only renames on Windows - how to proceed?

2011-05-03 Thread Johan Corveleyn
Hi all, After the discussions in [1] and [2], I'd like to know if and how to proceed with making case-only renames work on Windows (or case-insensitive filesystems in general). Following my attempted patch ([1]), I got some good feedback from brane and danielsh, but I'd like some more opinions,

Re: Feature wish/request: [--externals MODE] switch on update

2011-05-08 Thread Johan Corveleyn
On Fri, May 6, 2011 at 3:03 PM, Roman Kellner muzu...@gmx.net wrote: Hi Did some more testing and found the following: Setup. folder withexternals has prop svn:externals with a number of revisioned and un-revisioned externals files. What happens: checkout folder withexternals - all

Re: [RFC] Case-only renames on Windows - how to proceed?

2011-05-08 Thread Johan Corveleyn
On Thu, May 5, 2011 at 11:48 PM, Greg Stein gst...@gmail.com wrote: On Thu, May 5, 2011 at 16:10, Johan Corveleyn jcor...@gmail.com wrote: On Thu, May 5, 2011 at 8:34 PM, Stefan Küng tortoise...@gmail.com wrote: On 03.05.2011 23:53, Greg Stein wrote: I suggest (1). Fix issue 3865 with a new

Re: [PATCH] WC DB verification 1

2011-05-10 Thread Johan Corveleyn
On Tue, May 10, 2011 at 1:28 PM, Bert Huijben b...@qqmail.nl wrote: ... But there are *a lot* of users who think of svn cleanup as a tool to update their recorded_size and recorded_mod time after they unleashed some tool on their working copy. Or after they moved their working copy from A to B

Re: Further diff optimization ideas

2011-05-12 Thread Johan Corveleyn
Ok, to wrap this up for now: r1102471 finally put these thoughts into notes/diff-optimizations.txt, with some of Stefan2's feedback/ideas integrated into it. I also added another, previously mentioned idea into the notes file, which I forgot to mention in this mailthread: --- 8 --- Avoid some

Re: svn commit: r1102502 - /subversion/trunk/subversion/libsvn_client/externals.c

2011-05-13 Thread Johan Corveleyn
On Fri, May 13, 2011 at 12:53 AM, rhuij...@apache.org wrote: Author: rhuijben Date: Thu May 12 22:53:02 2011 New Revision: 1102502 URL: http://svn.apache.org/viewvc?rev=1102502view=rev Log: * subversion/libsvn_client/externals.c  (svn_client__do_external_status): Fix typo in comment.

Re: svn commit: r1104309 - in /subversion/trunk/subversion: libsvn_repos/reporter.c tests/cmdline/lock_tests.py tests/cmdline/update_tests.py

2011-05-17 Thread Johan Corveleyn
On Tue, May 17, 2011 at 5:02 PM, cmpil...@apache.org wrote: Author: cmpilato Date: Tue May 17 15:02:05 2011 New Revision: 1104309 URL: http://svn.apache.org/viewvc?rev=1104309view=rev Log: With rhuijben, avoid transmitting entry props for unmodified, locked files when the client-provided

Re: svn commit: r1104309 - in /subversion/trunk/subversion: libsvn_repos/reporter.c tests/cmdline/lock_tests.py tests/cmdline/update_tests.py

2011-05-18 Thread Johan Corveleyn
On Tue, May 17, 2011 at 7:13 PM, C. Michael Pilato cmpil...@collab.net wrote: On 05/17/2011 06:34 PM, Johan Corveleyn wrote: On Tue, May 17, 2011 at 5:02 PM,  cmpil...@apache.org wrote: URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/reporter.c?rev=1104309r1

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-18 Thread Johan Corveleyn
On Wed, May 18, 2011 at 1:56 AM, Morten Kloster mor...@gmail.com wrote: Log message: Speed-up of libsvn_diff using token counts By using indices, not node pointers, to refer to tokens, and counting the number of each token, the longest common subsequence (lcs) algorithm at the heart of

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-18 Thread Johan Corveleyn
On Wed, May 18, 2011 at 7:31 PM, Morten Kloster mor...@gmail.com wrote: Thanks, Daniel. Johan: I've found your notes trunk/notes/diff-optimizations.txt. As you may have realized, my patch is a slightly different approach to the problem you discuss in section I.5, Discarding non-matching

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-18 Thread Johan Corveleyn
On Wed, May 18, 2011 at 9:23 PM, Johan Corveleyn jcor...@gmail.com wrote: On Wed, May 18, 2011 at 7:31 PM, Morten Kloster mor...@gmail.com wrote: Thanks, Daniel. Johan: I've found your notes trunk/notes/diff-optimizations.txt. As you may have realized, my patch is a slightly different

'svn info' output on trunk differences from 1.6

2011-05-19 Thread Johan Corveleyn
I don't have an opinion on whether or not this is important/regression/..., but just wanted to note the following change in behavior of 'svn info', in relation to copying files in the working copy. Summarized: - on trunk, 'svn info' doesn't show Last Changed XXX, Text Last Updated and Checksum on

Re: WC format bump imminent - renaming pristines to SHA1.pristine

2011-05-19 Thread Johan Corveleyn
On Thu, May 19, 2011 at 11:36 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: On Thu, May 19, 2011 at 11:34 AM, Julian Foad julian.f...@wandisco.com wrote: Oh, it looks like the choice of name  'SHA1.pristine' was not discussed in that thread.  Two or three of us thought that seemed

Re: WC format bump imminent - renaming pristines to SHA1.pristine

2011-05-19 Thread Johan Corveleyn
On Thu, May 19, 2011 at 5:32 PM, Bob Archer bob.arc...@amsi.com wrote: On 05/19/2011 11:34 AM, Julian Foad wrote: On Thu, 2011-05-19 at 11:26 +0200, Julian Foad wrote: A WC format bump is imminent, in order to rename the pristine text files from 'SHA1' to 'SHA1.pristine', as discussed in

Re: svn commit: r1124436 - /subversion/trunk/subversion/tests/cmdline/copy_tests.py

2011-05-19 Thread Johan Corveleyn
On Thu, May 19, 2011 at 10:37 AM, Daniel Shahaf d...@daniel.shahaf.name wrote: Per discussion with jcorvel: jcor...@apache.org wrote on Wed, May 18, 2011 at 21:23:42 -: +# Regression test for issue #3865: 'svn' on Windows cannot address +# scheduled-for-delete file, if another file

[RFC] Final approach for issue #3702 (case-only renames on Windows)?

2011-05-24 Thread Johan Corveleyn
Hi, After issue #3865 [1] got fixed, and the client-layer parts of #3702 [2], there is one remaining hurdle to #3702: during argument parsing, the command line client 'svn' should detect the attempted 'case-only rename', and in that case pass the original destination path to the client layer,

Re: [RFC] Final approach for issue #3702 (case-only renames on Windows)?

2011-05-24 Thread Johan Corveleyn
2011/5/24 Branko Čibej br...@e-reka.si: On 24.05.2011 11:02, Johan Corveleyn wrote: Hi, After issue #3865 [1] got fixed, and the client-layer parts of #3702 [2], there is one remaining hurdle to #3702: during argument parsing, the command line client 'svn' should detect the attempted 'case

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-24 Thread Johan Corveleyn
On Tue, May 24, 2011 at 10:46 PM, Stefan Sperling s...@elego.de wrote: On Tue, May 24, 2011 at 10:22:58PM +0200, Morten Kloster wrote: Johan / Stefan - any progress on the reviewing part? I haven't had time to review this, sorry. It got a bit lost within the recent flurry of activity during

Re: [RFC] Final approach for issue #3702 (case-only renames on Windows)?

2011-05-25 Thread Johan Corveleyn
: On 24.05.2011 11:02, Johan Corveleyn wrote: [...] I'm fully agree with Bert that moving truepath conversion to libsvn_client as bad idea and would introduct gigantic slowdown for some Windows clients. Hmm ... I have a hard time imagining why this conversion would be so expensive, but I'll take

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-25 Thread Johan Corveleyn
On Thu, May 26, 2011 at 12:00 AM, Morten Kloster mor...@gmail.com wrote: [ snip ] I have, however, done some significant testing today: I downloaded the first 100 revisions of merge.c in libsvn_client (merge.c is the largest code file in the current HEAD revision, with almost 800 revisions),

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Johan Corveleyn
On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) stefan.fuhrm...@etas.com wrote: Morten Kloster wrote: [[[ Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. * subversion/libsvn_diff/lcs.c  (svn_diff__snake_t): Removed idx parameter (always 0)  

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-05-27 Thread Johan Corveleyn
On Fri, May 27, 2011 at 3:13 PM, Julian Foad julian.f...@wandisco.com wrote: On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: [snip] Maybe some of the performance improvement (and simplification) can be achieved simply by calculating idx0 and idx1 once, and then reusing those

Re: [RFC] Final approach for issue #3702 (case-only renames on Windows)?

2011-05-29 Thread Johan Corveleyn
On Tue, May 24, 2011 at 11:02 AM, Johan Corveleyn jcor...@gmail.com wrote: 1) Rev svn_client_args_to_target_array to take an argument is_move. That's really the only case where something special needs to happen. Something like this: if (is_move input_targets-nelts == 2 strcmp

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-30 Thread Johan Corveleyn
On Mon, May 30, 2011 at 8:50 PM, Morten Kloster mor...@gmail.com wrote: Johan, any progress on reviewing the code on your part? Things are a bit simpler now with the idx patch in: Since that patch settled the file (re)order issue, this patch now produces fully identical results to HEAD.

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-31 Thread Johan Corveleyn
On Tue, May 31, 2011 at 12:03 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Johan Corveleyn wrote on Tue, May 31, 2011 at 02:53:47 +0200: - Take a closer look at measuring the overhead of the token counting. Maybe you can also provide some numbers here? I think a good test for measuring

Re: [RFC] Final approach for issue #3702 (case-only renames on Windows)?

2011-05-31 Thread Johan Corveleyn
On Sun, May 29, 2011 at 9:42 AM, Stefan Küng tortoise...@gmail.com wrote: On 29.05.2011 08:43, Johan Corveleyn wrote: On Tue, May 24, 2011 at 11:02 AM, Johan Corveleynjcor...@gmail.com  wrote: 1) Rev svn_client_args_to_target_array to take an argument is_move. That's really the only case

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 1:11 AM, Stefan Sperling s...@elego.de wrote: On Tue, May 31, 2011 at 11:07:55PM -, jcor...@apache.org wrote: Author: jcorvel Date: Tue May 31 23:07:54 2011 New Revision: 1129957 URL: http://svn.apache.org/viewvc?rev=1129957view=rev Log: Add another knob, to make

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-05-31 Thread Johan Corveleyn
On Tue, May 31, 2011 at 12:44 PM, Johan Corveleyn jcor...@gmail.com wrote: ... Maybe a new 'knob' should be added for this? To make it easier to (stress) test the LCS ... sorry don't have time to do it myself now. Added the new 'knob' in r1129957 (with followup in r1129965). To disable

Re: svn commit: r1129957 - in /subversion/trunk: notes/knobs subversion/libsvn_diff/diff_file.c

2011-05-31 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 1:22 AM, Stefan Sperling s...@elego.de wrote: On Wed, Jun 01, 2011 at 01:15:56AM +0200, Johan Corveleyn wrote: [[[ The usual namespace rules apply: only names that begin with SVN_ and don't contain double underscores are considered part of the public API. Everything

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

2011-06-01 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 10:04 AM, Philip Martin philip.mar...@wandisco.com wrote: Stefan Fuhrmann eq...@web.de writes: Updated log message: [[[ Simpler/faster LCS algorithm in libsvn_diff by elimination of idx. * subversion/libsvn_diff/lcs.c   (svn_diff__snake): Removed idx parameter

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

2011-06-02 Thread Johan Corveleyn
On Thu, Jun 2, 2011 at 2:59 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Jun  2 12:59:59 2011 New Revision: 1130528 URL: http://svn.apache.org/viewvc?rev=1130528view=rev Log: Replace calls to svn_string_create_from_buf with the much cheaper svn_string_create_from_buf. This is

Re: How to get the message out

2011-06-03 Thread Johan Corveleyn
On Tue, Nov 9, 2010 at 4:35 PM, Hyrum K. Wright hyrum_wri...@mail.utexas.edu wrote: On Mon, Nov 8, 2010 at 9:39 AM, Bolstridge, Andrew andy.bolstri...@intergraph.com wrote: -Original Message- From: hy...@hyrumwright.org [mailto:hy...@hyrumwright.org] On Behalf Of Hyrum K. Wright

Re: svn commit: r1130528 - in /subversion/trunk/subversion: libsvn_client/patch.c libsvn_repos/hooks.c libsvn_subr/mergeinfo.c libsvn_subr/subst.c libsvn_subr/utf.c libsvn_wc/props.c svn/util.c

2011-06-03 Thread Johan Corveleyn
On Fri, Jun 3, 2011 at 10:56 AM, Julian Foad julian.f...@wandisco.com wrote: On Thu, 2011-06-02 at 23:18 +0200, Johan Corveleyn wrote: On Thu, Jun 2, 2011 at 2:59 PM,  stef...@apache.org wrote: Author: stefan2 Date: Thu Jun  2 12:59:59 2011 New Revision: 1130528 URL: http

Re: svn commit: r1131326 - in /subversion/trunk/subversion: include/ libsvn_client/ svn/ tests/cmdline/ tests/libsvn_client/

2011-06-04 Thread Johan Corveleyn
Oh, okay. Will remember that for next time. Johan On Sat, Jun 4, 2011 at 1:30 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: For future reference, we sometimes separate the Introduce a new API Use the new API Upgrade old callers steps into two commits, in the interest of more

Issue #3823 fixed but externals_tests.py#file_external_update_without_commit still XFail

2011-06-05 Thread Johan Corveleyn
externals_tests.py 29 'update a file external without committing target' is still marked as XFail, but the issue mentioned there (#3823 - 'update' update file external without commit is broken) is marked as Fixed. What's going on? Is the @Issue annotation wrong in externals_tests.py? Or is the

Re: [PATCH] Speed-up of libsvn_diff using token counts

2011-06-05 Thread Johan Corveleyn
On Wed, Jun 1, 2011 at 5:56 PM, Morten Kloster mor...@gmail.com wrote: On Wed, Jun 1, 2011 at 1:35 AM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, May 31, 2011 at 12:44 PM, Johan Corveleyn jcor...@gmail.com wrote: ... [] I'll get into some more testing and reviewing tomorrow or the day

Re: svn commit: r1133717 - /subversion/trunk/subversion/libsvn_client/externals.c

2011-06-09 Thread Johan Corveleyn
On Thu, Jun 9, 2011 at 10:41 AM, rhuij...@apache.org wrote: Author: rhuijben Date: Thu Jun  9 08:41:42 2011 New Revision: 1133717 URL: http://svn.apache.org/viewvc?rev=1133717view=rev Log: * subversion/libsvn_client/externals.c  (STMT_VERIFICATION_TRIGGERS): Update documentation of check

Re: [PATCH] Speed-up of libsvn_diff by restarts of LCS algorithm

2011-06-13 Thread Johan Corveleyn
On Tue, Jun 7, 2011 at 10:16 PM, Morten Kloster mor...@gmail.com wrote: On Fri, May 27, 2011 at 11:00 PM, Morten Kloster mor...@gmail.com wrote: [[[ Speeds up LCS algorithm for well-separated sections of change  By exploiting unique matches between the two files, it is possible to  restart

Re: [PATCH] Speed-up of libsvn_diff by restarts of LCS algorithm

2011-06-14 Thread Johan Corveleyn
On Tue, Jun 14, 2011 at 7:32 PM, Morten Kloster mor...@gmail.com wrote: On Tue, Jun 14, 2011 at 2:49 AM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, Jun 7, 2011 at 10:16 PM, Morten Kloster mor...@gmail.com wrote: [] Here's an updated patch based on the current HEAD, and with one or two

Re: Fresh checkout vs 'svn upgrade': How good is good enough?

2011-06-14 Thread Johan Corveleyn
On Tue, Jun 14, 2011 at 5:45 PM, Paul Burba ptbu...@gmail.com wrote: On Tue, Jun 14, 2011 at 3:41 AM, Philip Martin philip.mar...@wandisco.com wrote: Paul Burba ptbu...@gmail.com writes: No surprise that your checkouts are faster than mine given you are using a local mirror.  What's puzzling

Re: diff wish

2011-06-14 Thread Johan Corveleyn
On Tue, Jun 14, 2011 at 6:50 PM, Peter Samuelson pe...@p12n.org wrote: [Neels J Hofmeyr] it's been a while and I still haven't sent you my diff wish we briefly touched on the Subversion hackathon. While we're on the subject of 'diff wish', my wish is that diff3 could remove lines from the

Re: Fresh checkout vs 'svn upgrade': How good is good enough?

2011-06-14 Thread Johan Corveleyn
On Tue, Jun 14, 2011 at 11:56 PM, Mark Phippard markp...@gmail.com wrote: On Tue, Jun 14, 2011 at 5:48 PM, Johan Corveleyn jcor...@gmail.com wrote: Also, has anyone tested this on an NFS-working copy? Or CIFS? AFAIK, no one is doing any performance testing on NFS or CIFS.  I have repeatedly

Re: diff wish

2011-06-14 Thread Johan Corveleyn
On Tue, Jun 14, 2011 at 5:33 PM, Stefan Sperling s...@elego.de wrote: On Tue, Jun 14, 2011 at 05:21:27PM +0200, Neels J Hofmeyr wrote: Hi Johan, it's been a while and I still haven't sent you my diff wish we briefly touched on the Subversion hackathon. Hi Neels, thanks for pursuing this

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 12:53 PM, Stefan Sperling s...@elego.de wrote: On Wed, Jun 15, 2011 at 12:34:31PM +0200, Branko Čibej wrote: I'd say not to worry about --minimal and --nice and whatnot. Just make diff output the sanest, nicest diff it can find. I think it's a bad idea to give diff

Re: Fresh checkout vs 'svn upgrade': How good is good enough?

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 1:52 AM, Philip Martin philip.mar...@wandisco.com wrote: Philip Martin philip.mar...@wandisco.com writes: Johan Corveleyn jcor...@gmail.com writes: Also, has anyone tested this on an NFS-working copy? Or CIFS? Working copy on NFS, Linux client and server. Checkout

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 1:24 PM, Julian Foad julian.f...@wandisco.com wrote: On Wed, 2011-06-15 at 13:16 +0200, Johan Corveleyn wrote: On Wed, Jun 15, 2011 at 12:53 PM, Stefan Sperling s...@elego.de wrote: On Wed, Jun 15, 2011 at 12:34:31PM +0200, Branko Čibej wrote: I'd say not to worry

Re: diff wish

2011-06-15 Thread Johan Corveleyn
2011/6/15 Branko Čibej br...@e-reka.si: On 15.06.2011 14:11, Johan Corveleyn wrote: If you have a different definition of mis-synchronizes, please explain. No, I don't mean a broken diff. The diff should at all times be *correct*. That was indeed never questioned. I mean something like

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 5:15 PM, Greg Hudson ghud...@mit.edu wrote: On Wed, 2011-06-15 at 09:38 -0400, Johan Corveleyn wrote: But I don't like the hand-waving discussion that it will always be superior, period. That's just not true. And it would be a big mistake, IMHO, to only support

Re: diff wish

2011-06-15 Thread Johan Corveleyn
2011/6/15 Branko Čibej br...@e-reka.si: On 15.06.2011 15:38, Johan Corveleyn wrote: 2011/6/15 Branko Čibej br...@e-reka.si: On 15.06.2011 14:11, Johan Corveleyn wrote: If you have a different definition of mis-synchronizes, please explain. No, I don't mean a broken diff. The diff should

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 5:41 PM, Greg Hudson ghud...@mit.edu wrote: On Wed, 2011-06-15 at 11:30 -0400, Johan Corveleyn wrote: Okay, I guess we should then also rip out --ignore-space-change and --ignore-eol-style, and perhaps --show-c-function. Or, if it's preferred that ignore-space-change

Re: diff wish

2011-06-16 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 5:46 PM, Morten Kloster mor...@gmail.com wrote: On Wed, Jun 15, 2011 at 1:08 AM, Johan Corveleyn jcor...@gmail.com wrote: [] Intuitively, I'd say: let's look into patience diff (or a variation thereof), because it's already being used in several (D)VCS'es, so it has

Re: diff wish

2011-06-19 Thread Johan Corveleyn
On Thu, Jun 16, 2011 at 11:41 PM, Stefan Sperling s...@elego.de wrote: On Thu, Jun 16, 2011 at 10:38:12PM +0200, Johan Corveleyn wrote: Are you sure? Maybe there are different definitions of how patience diff works (it seems to be rather undocumented :-)). I'm not really into the details

Running benchmarks/suite1 on Windows

2011-06-21 Thread Johan Corveleyn
Hi, I managed to get the benchmark 'suite1' (tools/dev/benchmarks/suite1, which is used for the automated benchmarks [svnbench] on svn-qavm) running on Windows. I did that by translating the 'run' script (bash) to a Windows batch script (I'm not much of a batch programmer, but with some trial and

Re: svn bisect

2011-06-21 Thread Johan Corveleyn
On Tue, Jun 21, 2011 at 11:34 AM, Arwin Arni ar...@collab.net wrote: On Tuesday 21 June 2011 02:51 PM, Daniel Shahaf wrote: Please convince me why having svn_client_bisect() is needed. There are already THREE scripts out there that implement cmdline 'svn bisect': one on CPAN, one in Peter's

Re: Running benchmarks/suite1 on Windows

2011-06-21 Thread Johan Corveleyn
2011/6/21 Daniel Klíma dankl...@gmail.com: 2011/6/21 Johan Corveleyn jcor...@gmail.com: Hi, I managed to get the benchmark 'suite1' (tools/dev/benchmarks/suite1, which is used for the automated benchmarks [svnbench] on svn-qavm) running on Windows. I did that by translating the 'run' script

Re: Dropped attachments Fwd: [Gavin (JIRA): [jira] [Commented] (INFRA-3724) attachments sent get dropped without notification to either sender or receiving list]

2011-06-24 Thread Johan Corveleyn
On Fri, Jun 24, 2011 at 2:58 PM, Hyrum K Wright hy...@hyrumwright.org wrote: On Fri, Jun 24, 2011 at 6:49 AM, Ivan Zhakov i...@visualsvn.com wrote: On Fri, Jun 24, 2011 at 14:46, Daniel Shahaf danie...@apache.org wrote: Daniel Shahaf wrote on Fri, Jun 24, 2011 at 13:44:03 +0300: Rejecting to

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: XX\n, Expected: Cc\n\n

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: libsvn_diff/diff-diff3-test 2 fails for me: [[[ subversion/tests/libsvn_diff/diff-diff3-test.c:653: (apr_err=26) subversion/tests/libsvn_diff/diff-diff3-test.c:316: (apr_err=26)

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: XX\n, Expected: Cc\n\n

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 11:08 PM, Johan Corveleyn jcor...@gmail.com wrote: On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: libsvn_diff/diff-diff3-test 2 fails for me: [[[ subversion/tests/libsvn_diff/diff-diff3-test.c:653: (apr_err=26) subversion/tests

Re: [PATCH] Speed-up of libsvn_diff by restarts of LCS algorithm

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 11:23 AM, Morten Kloster mor...@gmail.com wrote: On Tue, Jun 14, 2011 at 11:12 PM, Johan Corveleyn jcor...@gmail.com wrote: On Tue, Jun 14, 2011 at 7:32 PM, Morten Kloster mor...@gmail.com wrote: On Tue, Jun 14, 2011 at 2:49 AM, Johan Corveleyn jcor...@gmail.com wrote

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: XX\n, Expected: Cc\n\n

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 11:32 PM, Johan Corveleyn jcor...@gmail.com wrote: On Sun, Jun 26, 2011 at 11:08 PM, Johan Corveleyn jcor...@gmail.com wrote: On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: libsvn_diff/diff-diff3-test 2 fails for me: [[[ subversion

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: XX\n, Expected: Cc\n\n

2011-06-27 Thread Johan Corveleyn
Yep, for me too :-). I've committed this in r1140388. Thanks. Johan On Mon, Jun 27, 2011 at 12:57 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Fixes the problem for me, thanks :-) Philip Martin wrote on Mon, Jun 27, 2011 at 09:40:53 +0100: Philip Martin philip.mar...@wandisco.com

Re: svn commit: r1140388 - /subversion/trunk/subversion/libsvn_diff/diff_file.c

2011-06-28 Thread Johan Corveleyn
On Tue, Jun 28, 2011 at 3:57 AM, Hyrum K Wright hy...@hyrumwright.org wrote: On Mon, Jun 27, 2011 at 7:25 PM,  jcor...@apache.org wrote: Author: jcorvel Date: Tue Jun 28 00:25:57 2011 New Revision: 1140388 URL: http://svn.apache.org/viewvc?rev=1140388view=rev Log: Fix a spurious failure of

wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Johan Corveleyn
Hi, Sometimes, a (part of a) working copy gets corrupted (errors like 'checksum mismatch ...' while running 'update'). Maybe it happened because a third-party tool has messed with the base files, or with the entries file, or ... or maybe it happened because of a bug in svn. This was/is deemed

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Johan Corveleyn
On Fri, Jul 1, 2011 at 11:32 AM, Noorul Islam K M noo...@collab.net wrote: Johan Corveleyn jcor...@gmail.com writes: Hi, Sometimes, a (part of a) working copy gets corrupted (errors like 'checksum mismatch ...' while running 'update'). Maybe it happened because a third-party tool has messed

Re: Significant checkout performance degradation between 1.6.1 and 1.7b2

2011-08-10 Thread Johan Corveleyn
On Wed, Aug 10, 2011 at 9:07 PM, Mark Phippard markp...@gmail.com wrote: On Wed, Aug 10, 2011 at 2:02 PM, Ketting, Michael michael.kett...@rubicon.eu wrote: Here're the test results for the basic merge repository: Subversion 1.7.0 Beta 3, binaries from collabnet Basic Tests: | 1.7.0-beta3

Re: concerns about svn:hold -- was: svn commit: r1159240 - in /subversion/branches/hold/subversion: include/private/svn_wc_private.h include/svn_props.h libsvn_client/commit_util.c libsvn_wc/node.c

2011-08-22 Thread Johan Corveleyn
On Mon, Aug 22, 2011 at 2:01 AM, Greg Stein gst...@gmail.com wrote: On Sat, Aug 20, 2011 at 19:48, Neels J Hofmeyr ne...@elego.de wrote: ... I have taken the occasion to write a comprehensive description of my current vision for svn:hold. I find the entire concept to be worrisome. All of a

Re: Resoving tree conflicts results in inconsistent state between two working copies of same branch

2011-08-23 Thread Johan Corveleyn
On Tue, Aug 23, 2011 at 5:13 AM, Neels J Hofmeyr ne...@elego.de wrote: I can reproduce the corrupted WC reported by David Wallace with 1.6.17. 1.7.x does not show this bug. I have attached a reproduction script that is roughly based on David's typescript, but is only a fraction of the size.

Re: Resoving tree conflicts results in inconsistent state between two working copies of same branch

2011-08-23 Thread Johan Corveleyn
On Tue, Aug 23, 2011 at 7:27 PM, Neels J Hofmeyr ne...@elego.de wrote: On 08/23/2011 09:07 AM, Johan Corveleyn wrote: On Tue, Aug 23, 2011 at 5:13 AM, Neels J Hofmeyr ne...@elego.de wrote: I can reproduce the corrupted WC reported by David Wallace with 1.6.17. 1.7.x does not show this bug. I

Re: [Issue 2685] Move + Merge = lose modifications

2011-08-26 Thread Johan Corveleyn
On Fri, Aug 26, 2011 at 2:02 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: jcor...@tigris.org wrote on Fri, Aug 26, 2011 at 04:38:07 -0700: http://subversion.tigris.org/issues/show_bug.cgi?id=2685 --- Additional comments from jcor...@tigris.org Fri Aug 26 04:38:06 -0700 2011 ---

Re: FSFS successor ID design draft

2011-08-28 Thread Johan Corveleyn
On Fri, Aug 26, 2011 at 1:14 PM, Stefan Sperling s...@elego.de wrote: Below is an initial draft of a design for successor-IDs in FSFS. It is a bit long, but I hope it covers all relevant points in sufficient detail. Nice! Interesting stuff :-). I'm not an expert in these matters, but I've

Failing test svnsync_tests.py 28: copy and reencode non-UTF-8 svn:* props

2011-08-28 Thread Johan Corveleyn
Hi, I get a test failure of svnsync_tests.py 28: copy and reencode non-UTF-8 svn:* props. The following error appears: svnsync: E720087: Can't convert string from 'ISO-8859-3' to 'UTF-8': svnsync: E720087: 2011-01-11T20:57:24.206641Z See also fails.log in attachment. This happens on 1.7.x as

Re: Recurse into same-repos externals at commit time.

2011-08-30 Thread Johan Corveleyn
On Tue, Aug 30, 2011 at 8:55 AM, Markus Schaber m.scha...@3s-software.com wrote: [...] Questions remain about passing externals explicitly: - when an external is passed as explicit target, still require --include- externals? IMHO: Do not require --include-externals. If I only want to

<    1   2   3   4   5   6   7   8   9   10   >