Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc2

2024-06-28 Thread Sam Firke
+1 binding The regressions I observed in RC1 have been addressed, thank you Michael and Justin and anyone else who worked on those! Note that the sort order will reverse for horizontal bar charts as a result of the fix in #29345. I agree that this is an overall improvement, and it's a single

Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc1

2024-06-26 Thread Sam Firke
s. The fixes are all ready so I will > generate RC2 right away. > > Michael > > > On Jun 24, 2024, at 9:34 AM, Sam Firke wrote: > > > > I am part way through testing and have found a couple of regressions from > > 4.0.0: > > https://github.com/apache/superse

Re: [VOTE] Release Apache Superset 4.0.2 based on Superset 4.0.2rc1

2024-06-24 Thread Sam Firke
I am part way through testing and have found a couple of regressions from 4.0.0: https://github.com/apache/superset/issues/29342 - folks have been posting this one in Slack https://github.com/apache/superset/issues/29331 - this is trivial on its surface but as I've only just found it, don't know

Re: Deployment

2024-05-21 Thread Sam Firke
Correct. You can set up WSL2 on the Windows PC, at which point you're running Linux. Then deploy with Linux. Does that count as running Superset on Windows? It's a philosophical question at that point  My org runs almost entirely Windows and looked into the above approach. We decided it was

Re: [VOTE] Release Apache Superset 4.0.1 based on Superset 4.0.1rc1

2024-05-03 Thread Sam Firke
+1 binding I deployed rc1 to my test environment. Authentication, alerts and reports, chart creation, existing dashboards all look good. I tried out some of the bug fixes and they look good too, e.g., enabling drill-by on a time series chart where there is no dimension (#27941). On Thu, May

Re: [VOTE][SIP-123] Proposal replacement of data table components with ag-grid

2024-04-16 Thread Sam Firke
This sounded dull because I was unfamiliar with the terms. Then I opened the SIP and it looks awesome! That's a nicely done SIP, thanks for the write-up. +1 binding On Tue, Apr 16, 2024, at 8:51 PM, Michael S. Molina wrote: > +1 (binding) > > Best regards, > Michael S. Molina > > > On 16 Apr

Re: [VOTE] Release Apache Superset 3.0.3 based on Superset 3.0.3rc3

2024-01-15 Thread Sam Firke
+1 I tested this with many of my production dashboards and verified that alerts & reports works with docker compose deployment and the -dev container image. The fix of #26034 introduced a new bug #26254. Both cannot currently be fixed simultaneously due to a limitation of ECharts. See the

Re: [VOTE] Release Apache Superset 3.0.3 based on Superset 3.0.3rc1

2023-12-13 Thread Sam Firke
-1 as this has cherries that break bar charts with a numeric x-axis. See discussion on the RC thread for 3.1.0rc2 for details as my understanding is that those cherries affect 3.0.3rc1: https://github.com/apache/superset/discussions/26240 On Mon, Dec 11, 2023, at 11:23 AM, Michael S. Molina

Re: [VOTE] Release Apache Superset 3.1.0 based on Superset 3.1.0rc2

2023-12-13 Thread Sam Firke
-1 due to the regressions associated with bar charts having a numeric x-axis. See discussion on the RC thread for details: https://github.com/apache/superset/discussions/26240 On Mon, Dec 11, 2023, at 2:57 PM, Michael S. Molina wrote: > Hello Superset Community, > > This is a call for the vote

Re: [VOTE][SIP-108] Superset Release Process

2023-12-04 Thread Sam Firke
+1 vote and ditto what Evan said. On Mon, Dec 4, 2023, at 5:12 PM, Evan Rusackas wrote: > +1 (binding) > > This discussion and document have been shaping up nicely for quite some time, > and I’m glad that we’re at the point where so many of us are in alignment. As > always, we can continue to

Re: [VOTE] Release Apache Superset 3.1.0 based on Superset 3.1.0rc1

2023-12-04 Thread Sam Firke
-1 due to the issues documented in the thread John linked. I encourage folks to test rc1 as long as the vote is open so that as many issues as possible are identified and we keep the number of release candidates to a minimum. Thanks to Michael for leading this release process! On Fri, Dec 1,

Re: [VOTE] Release Apache Superset 3.0.2 based on Superset 3.0.2rc2

2023-11-21 Thread Sam Firke
+1 The Azure SSO problem from rc1 is fixed (thanks Michael and Daniel!). I clicked around, did some light testing, everything looked good. Sam On Mon, Nov 20, 2023, at 3:41 PM, Michael S. Molina wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset

Re: [VOTE] Release Apache Superset 3.0.2 based on Superset 3.0.2rc1

2023-11-16 Thread Sam Firke
-1 My existing Azure SSO broke when I tried out 3.0.2rc1. I'm unable to log in. When I revert the image to 3.0.1 it works again. Perhaps related to a bump in the Flask App builder version? I've created a GitHub issue for this, #26007. On Thu, Nov 16, 2023, at 12:57 PM, Ville Brofeldt wrote:

Re: [VOTE] Release Apache Superset 3.0.0 based on Superset 3.0.0rc3

2023-08-29 Thread Sam Firke
I tested reports and my existing dashboards, all of that looked good. I commented in the #apache-releases channel re: some aesthetic changes that I think should be noted in the release notes. I'll vote -1 though because of bugs noted in the link John supplied below. On Tue, Aug 29, 2023, at

Re: [VOTE] Release Apache Superset 2.1.1 based on Superset 2.1.1rc3

2023-08-22 Thread Sam Firke
+1 On Tue, Aug 22, 2023, at 10:43 AM, Michael S. Molina wrote: > +1 (binding) > > Best regards, > Michael S. Molina > > > On 22 Aug 2023, at 11:38, Daniel Gaspar wrote: > > > > +1 (binding) > > > > Cheers, > > Daniel Gaspar / Superset PMC > > > > > >> On Fri, 18 Aug 2023 at 01:49,

Re: [ANNOUNCE] New Committer: Sam Firke

2023-07-31 Thread Sam Firke
or Apache Superset has invited Sam > Firke to become a committer and we are pleased to announce that he has > accepted. > > While I botched the templated part, the personalized part of the message is > still 100% sincere :) Again, welcome aboard, Sam! We’re lucky to have you o

Proposal: Tag docker images of official Apache releases as "official"

2023-06-27 Thread Sam Firke
There's been a little discussion about this on Github (https://github.com/apache/superset/discussions/22244) and in the #operational-model-release-strategy channel on Slack. I propose that the release process for an official Apache release include tagging the associated docker images with a

Re: [VOTE] Release Apache Superset 2.1.1 based on Superset 2.1.1rc1

2023-06-27 Thread Sam Firke
; > I think that a path forward would be to revert that PR on 2.1.1 and fixing > Alert & Reports auth issue on master and inclusion on 3.0.0 > > > On Mon, 26 Jun 2023 at 15:26, Sam Firke wrote: > > > The addition of strong session protection by default < > &

Re: [VOTE] Release Apache Superset 2.1.1 based on Superset 2.1.1rc1

2023-06-26 Thread Sam Firke
The addition of strong session protection by default meant that I could not log into Superset when I switched the image to 2.1.1rc1 – I was stuck in a redirect loop from the welcome screen to the login screen. I changed my config to

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-05-07 Thread Sam Firke
bout 2.1.0-dev I believe 2.1.0 and 2.1.0-dev are same. Ideally > shouldn’t the fix present in 2.1.0 itself. > > Get Outlook for Android<https://aka.ms/AAb9ysg> > > From: Sam Firke > Sent: Friday, May 5, 2023 9:41:05 PM > To: de

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-05-05 Thread Sam Firke
>> > > > > https://urldefense.com/v3/__https://github.com/apache/superset/blob/ > > > da > > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p > > > 9x z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ > > > [github[.]com] > > > >> a8b635e814/s

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc3

2023-03-21 Thread Sam Firke
+1 non binding Report emails are working for me with the dev image. Looks good all around. Thank you everyone who worked on this release! On Mon, Mar 20, 2023, at 6:38 PM, Elizabeth Thompson wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Sam Firke
ttps://github.com/apache/superset/blob/da > > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x > > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com] > > > >> a8b635e814/superset/config.py#L1307 > > > >&g

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-17 Thread Sam Firke
ttps://github.com/apache/superset/blob/da > > > 3791ad3daa209631a588394600d1__;!!LpKI!j4vMZKp0bgaggE6smVZkHUAuixG90p9x > > > z0Kpz_9RjgQsmyMq_TmVaf5Y0ZM0tZx08OF9YD4rmT63XwZHw3E$ [github[.]com] > > > >> a8b635e814/superset/config.py#L1307 > > > >&g

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-15 Thread Sam Firke
I'm also seeing errors with Alerts and Reports in rc2. Looking at the logs it appears to be this issue: https://github.com/apache/superset/issues/22326 On Wed, Mar 15, 2023, 5:27 AM Pankaj soni wrote: > Not able to send alerts, screenshot as alerts and reports as well. > > On Wed, 15 Mar, 2023,

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc2

2023-03-14 Thread Sam Firke
I've put my testing notes here: https://github.com/apache/superset/discussions/23357#discussioncomment-5314068 Would love to hear from others who are testing. Looking good, my thanks to those who worked on rc2 and patched bugs since rc1 ! On Mon, Mar 13, 2023, 9:36 PM Elizabeth Thompson wrote:

Re: [VOTE] Release Apache Superset 2.1.0 based on Superset 2.1.0rc1

2023-02-24 Thread Sam Firke
Same here, dashboards with filters out of scope fail to load. I've noted that on the discussion thread https://github.com/apache/superset/discussions/23164. I'll keep testing the release and will post my findings in that thread but IMO this is the biggest bug in Superset 2.0.1 and I would vote

Re: [VOTE] Release Apache Superset 2.0.1 based on Superset 2.0.1rc6

2022-12-20 Thread Sam Firke
+1 I looked at some of the new features/bug fixes and they looked good. I tried out some of my major existing dashboards and found no problems. On Tue, Dec 20, 2022, 11:18 AM Daniel Gaspar wrote: > +1 (binding) > > Daniel Gaspar / Superset PMC > > On 2022/12/16 01:48:07 Elizabeth Thompson

Re: [VOTE] Release Apache Superset 2.0.1 based on Superset 2.0.1rc5

2022-12-09 Thread Sam Firke
Would it be possible to push docker images for 2.01rc5 and 2.01rc5-dev to Docker Hub, as was done with 2.0.1rc4? That would make it easier for me to test out this release candidate next week. Thanks, Sam On Fri, Dec 9, 2022 at 5:11 PM Arash Afghahi wrote: > Hello Superset Community, > > This