[RESULT] [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-18 Thread elizabeth
Thanks to everyone that participated. The vote to release Apache Superset version 1.4.0 based on 1.4.0rc4 is now closed. The vote PASSED with 4 binding +1, 1 non binding +1 and 0 -1 votes: Binding votes: - Evan - Tai - Srini - Craig Non binding votes: - Hugh Link to vote thread: https://l

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-18 Thread Evan Rusackas
+1, binding! I went ahead and validated the cryptographic signatures. Instructions here for anyone else who wants to try that: https://www.apache.org/info/verification.html I also poked at examples, native filters, building a few charts, and other basic flows. Thank you Elizabeth, for all the

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-16 Thread Tai Dupree
My vote is still +1 as I would love to see this release go out, but I wanted to highlight this so others are aware. The fix is quite easy to apply if others are also running a version built from source. https://github.com/apache/superset/blob/d29f6614161f3faeced218232d9aa1d0a9422ddb/superset-front

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-15 Thread Elizabeth Thompson
Thank you for catching that, Tai. I’m going to keep the vote open a little longer, and please continue to vote for this rc based on this new information. A positive vote for rc4 will mean that this fix will go into 1.4.1. For anyone who has already voted, you can also change your vote if you nee

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Hugh Miles
+1 (non-binding) Checked: - Database Creation - Sqllab (running query, setting schema + table, creating dataset) - Creating a chart - Adding chart to dashboard - Dashboard to explore/chart view H. Miles On Fri, Jan 14, 2022 at 1:56 PM, Elizabeth Thompson wrote: > Hello Superset Community, > >

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Tai Dupree
An easy way to verify this is by comparing the commit on the rc branch vs the commit on master. On master the commit is essentially a 1 line change, while on the rc that commit is much larger and does not touch the same files. Master commit: https://github.com/apache/superset/commit/dad8c20af78f23

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Tai Dupree
Actually, I just noticed something. Looks like in the RC these two commits were cherry-picked in a reverse order: https://github.com/apache/superset/commit/4c00bd4332860912ddecfa9ca02927b514621e3d https://github.com/apache/superset/commit/ba6d5b97542cbe8cfad5fec1e1e08e1992a0b78e on the master bra

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-14 Thread Srinivasa Kadamati
+1 (binding) Stress tested & Checked all of the common user flows! Excited for this On Wed, Jan 12, 2022 at 8:28 PM wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 1.4.0. > > The release candidate: > https://dist.apache.org/repos/dist/dev/su

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-12 Thread Craig Rueda
+1 - Craig > On Jan 12, 2022, at 5:28 PM, elizab...@apache.org wrote: > > Hello Superset Community, > > This is a call for the vote to release Apache Superset version 1.4.0. > > The release candidate: > https://dist.apache.org/repos/dist/dev/superset/1.4.0rc4/ > > Git tag for the release: >

Re: [VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-12 Thread Tai Dupree
+1 (binding) Checked: - Dashboard, Chart, Database, Dataset, SQL Lab views load - Dashboard view - Chart view - Dashboard creation - Chart creation (time series line) On Wed, Jan 12, 2022 at 5:28 PM wrote: > Hello Superset Community, > > This is a call for the vote to release Apache Superset ve

[VOTE] Release Apache Superset 1.4.0 based on Superset 1.4.0rc4

2022-01-12 Thread elizabeth
Hello Superset Community, This is a call for the vote to release Apache Superset version 1.4.0. The release candidate: https://dist.apache.org/repos/dist/dev/superset/1.4.0rc4/ Git tag for the release: https://github.com/apache/superset/tree/1.4.0rc4 The Change Log for the release: https://gith