Update from the Superset X.0 working group

2022-03-10 Thread Aaron Suddjian
Hi folks, the group met today to discuss the ongoing changes for Superset 2.0. Key discussion points are noted below. - Decided to proceed with flipping the SQL_LAB_BACKEND_PERSISTENCE flag. - Reminder that all the breaking changes need an appropriate entry in Updating.md and that they get the app

Update from the Superset X.0 working group

2022-03-17 Thread Aaron Suddjian
Hi folks, the group met today to discuss the ongoing changes for Superset 2.0. Key discussion points are noted below. - Aaron: Removing the ENABLE_REACT_CRUD_VIEWS flag causes lots of tests to fail - assertions depend on text appearing in crud view html. Will skip tests for now, and collab with QA

Update from the Superset X.0 working group

2022-03-31 Thread Aaron Suddjian
Hi folks, the group met today to discuss the ongoing changes for Superset 2.0. Key discussion points are noted below. - All breaking changes have been merged, this looks good to go! 🎉 - Last task is for John/Srini/Aaron to make sure that all the breaking changes are described well in UPDATING.md.

Re: Update from the Superset X.0 working group

2022-03-17 Thread Tai Dupree
I think all the react crud view tests are mostly covered by js tests and api tests, so deleting those would probably be the path forward. Given that most users run superset with that feature flag enabled, there is little risk to removing that code. On Thu, Mar 17, 2022 at 11:01 AM Aaron Suddjian