[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot .And can

[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot . Any

[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu Thanks for the response . So will this feature be applicable even for the plain table other than pivot .

[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365845995 @xiaohanyu okay . So will this feature be applicable even for the plain table other than pivot .

[GitHub] xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
xiaohanyu commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365841957 @shyam2794 Hi, this PR is not merged yet, and if you would like to have a try, you have to cherry pick this PR manually by

[GitHub] XavierDeLapeyre commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )

2018-02-14 Thread GitBox
XavierDeLapeyre commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424#issuecomment-365839470 @raffas Thanks for the link and indepth background review. Basically, all I need

[GitHub] XavierDeLapeyre commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod

2018-02-14 Thread GitBox
XavierDeLapeyre commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod URL: https://github.com/apache/incubator-superset/issues/4425#issuecomment-365834219 Hi @xrmx , I'm not reporting a bug, I'm asking for some hints on how to debug this

[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

2018-02-14 Thread GitBox
shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables URL: https://github.com/apache/incubator-superset/issues/3416#issuecomment-365831198 @xiaohanyu I reinstalled superset to use this feature in my machine . But i could not find any row or column configuration

[GitHub] graceguo-supercat closed issue #2012: SQL LAb. Fetch results checks the perms

2018-02-14 Thread GitBox
graceguo-supercat closed issue #2012: SQL LAb. Fetch results checks the perms URL: https://github.com/apache/incubator-superset/issues/2012 This is an automated message from the Apache Git Service. To respond to the

[GitHub] hughhhh commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox
hug commented on a change in pull request #4432: Added check cache key util URL: https://github.com/apache/incubator-superset/pull/4432#discussion_r168362658 ## File path: superset/views/core.py ## @@ -2208,6 +2208,15 @@ def cached_key(self, key): return

[GitHub] timifasubaa commented on issue #4179: Summary line in table view visualization

2018-02-14 Thread GitBox
timifasubaa commented on issue #4179: Summary line in table view visualization URL: https://github.com/apache/incubator-superset/pull/4179#issuecomment-365799013 @hgeorg They failed due to your code modifications. You should click on the `Details` link beside Required, below "All checks

[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox
timifasubaa commented on a change in pull request #4432: Added check cache key util URL: https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613 ## File path: superset/views/core.py ## @@ -2208,6 +2208,15 @@ def cached_key(self, key):

[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox
timifasubaa commented on a change in pull request #4432: Added check cache key util URL: https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613 ## File path: superset/views/core.py ## @@ -2208,6 +2208,15 @@ def cached_key(self, key):

[GitHub] timifasubaa commented on a change in pull request #4432: Added check cache key util

2018-02-14 Thread GitBox
timifasubaa commented on a change in pull request #4432: Added check cache key util URL: https://github.com/apache/incubator-superset/pull/4432#discussion_r168360613 ## File path: superset/views/core.py ## @@ -2208,6 +2208,15 @@ def cached_key(self, key):

[GitHub] timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined

2018-02-14 Thread GitBox
timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined URL: https://github.com/apache/incubator-superset/issues/4433#issuecomment-365797082 Can you share a picture of the error or the stack trace and how to reproduce?

[GitHub] timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined

2018-02-14 Thread GitBox
timifasubaa commented on issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined URL: https://github.com/apache/incubator-superset/issues/4433#issuecomment-365797082 Can you share a picture of the error or the stack trace?

[GitHub] vylc opened a new issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined

2018-02-14 Thread GitBox
vylc opened a new issue #4433: [Filter Box] TypeError: Cannot read property 'region' of undefined URL: https://github.com/apache/incubator-superset/issues/4433 Postgres table with varchar(256) type throws this error when placed in the filter by box Make sure these boxes are checked

[GitHub] timifasubaa commented on issue #4416: [dashboard] more granular grid layout

2018-02-14 Thread GitBox
timifasubaa commented on issue #4416: [dashboard] more granular grid layout URL: https://github.com/apache/incubator-superset/pull/4416#issuecomment-365795046 https://github.com/apache/incubator-superset/issues/4014 This is

[GitHub] timifasubaa commented on issue #2012: SQL LAb. Fetch results checks the perms

2018-02-14 Thread GitBox
timifasubaa commented on issue #2012: SQL LAb. Fetch results checks the perms URL: https://github.com/apache/incubator-superset/issues/2012#issuecomment-365794404 This is no longer an issue. This is an automated message

[GitHub] hughhhh opened a new pull request #4432: Added check cache key util

2018-02-14 Thread GitBox
hug opened a new pull request #4432: Added check cache key util URL: https://github.com/apache/incubator-superset/pull/4432 Added cache_key_exist endpoint for debugging purpose and making sure cache keys are being registered properly. @mistercrunch

[GitHub] timifasubaa commented on issue #1389: [BUG] JSON and CSV download does not download the druid response

2018-02-14 Thread GitBox
timifasubaa commented on issue #1389: [BUG] JSON and CSV download does not download the druid response URL: https://github.com/apache/incubator-superset/issues/1389#issuecomment-365793971 @vera-liu If you still remember, can you flesh out what you meant here?

[GitHub] timifasubaa commented on issue #2798: [permissions] when a user creates a table from sql-lab, make them an owner

2018-02-14 Thread GitBox
timifasubaa commented on issue #2798: [permissions] when a user creates a table from sql-lab, make them an owner URL: https://github.com/apache/incubator-superset/issues/2798#issuecomment-365792652 Related https://github.com/apache/incubator-superset/issues/911

[GitHub] timifasubaa commented on issue #4352: Newly created datasource should be accessible be creator

2018-02-14 Thread GitBox
timifasubaa commented on issue #4352: Newly created datasource should be accessible be creator URL: https://github.com/apache/incubator-superset/issues/4352#issuecomment-365789913 see https://github.com/apache/incubator-superset/issues/2798

[GitHub] mistercrunch closed pull request #4418: Updated Italian Translation

2018-02-14 Thread GitBox
mistercrunch closed pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch closed pull request #4431: Add .1s option to D3 Format dropdown

2018-02-14 Thread GitBox
mistercrunch closed pull request #4431: Add .1s option to D3 Format dropdown URL: https://github.com/apache/incubator-superset/pull/4431 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] raffas commented on issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined

2018-02-14 Thread GitBox
raffas commented on issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/issues/4391#issuecomment-365788847 Resolved in latest version: GIT_SHA

[GitHub] raffas closed issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined

2018-02-14 Thread GitBox
raffas closed issue #4391: [Bug] FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/issues/4391 This is an

[GitHub] raffas closed pull request #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined

2018-02-14 Thread GitBox
raffas closed pull request #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/pull/4395 This is a PR merged from a forked repository. As GitHub hides

[GitHub] raffas commented on issue #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined

2018-02-14 Thread GitBox
raffas commented on issue #4395: [BugFix] #4391 FilterBox: An error occurred while rendering the visualization: TypeError: Cannot read property 'xxx' of undefined URL: https://github.com/apache/incubator-superset/pull/4395#issuecomment-365788362 Problem solved with latest release

[GitHub] timifasubaa commented on issue #4408: Add link on how to get permission to permission error

2018-02-14 Thread GitBox
timifasubaa commented on issue #4408: Add link on how to get permission to permission error URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365787814 Language abbreviated. This is an automated

[GitHub] raffas opened a new pull request #4431: Add .1s option to D3 Format dropdown

2018-02-14 Thread GitBox
raffas opened a new pull request #4431: Add .1s option to D3 Format dropdown URL: https://github.com/apache/incubator-superset/pull/4431 Add option .1s to D3_FORMAT_OPTIONS. This patch add the ability to display numbers like 12.0 as 12 where the dropdown is active. This is not

[GitHub] mistercrunch closed pull request #4405: Disable user access request

2018-02-14 Thread GitBox
mistercrunch closed pull request #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch commented on issue #4408: Add link on how to get permission to permission error

2018-02-14 Thread GitBox
mistercrunch commented on issue #4408: Add link on how to get permission to permission error URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365770984 Unrelated to this PR: we need padding on the `Panel.body` when showing alerts.

[GitHub] raffas commented on issue #4418: Updated Italian Translation

2018-02-14 Thread GitBox
raffas commented on issue #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#issuecomment-365770412 @xrmx Translation updated This is an automated message from the Apache Git

[GitHub] john-bodley commented on issue #4408: Add link on how to get permission to permission error.

2018-02-14 Thread GitBox
john-bodley commented on issue #4408: Add link on how to get permission to permission error. URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365766638 Pending https://github.com/apache/incubator-superset/pull/4405 I think this LGTM, my only comment was possibly

[GitHub] john-bodley commented on issue #4409: Add permissions decider for delegating access controls.

2018-02-14 Thread GitBox
john-bodley commented on issue #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#issuecomment-365766348 An alternative solution would be to refactor the datasource permissions to be handled by an abstract security

[GitHub] timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls.

2018-02-14 Thread GitBox
timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#discussion_r168007018 ## File path: superset/config.py ## @@ -364,6 +364,24 @@ class

[GitHub] john-bodley commented on a change in pull request #4408: Add link on how to get permission to permission error.

2018-02-14 Thread GitBox
john-bodley commented on a change in pull request #4408: Add link on how to get permission to permission error. URL: https://github.com/apache/incubator-superset/pull/4408#discussion_r168329983 ## File path: superset/views/core.py ## @@ -64,7 +64,14 @@

[GitHub] timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls.

2018-02-14 Thread GitBox
timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#discussion_r168307620 ## File path: superset/viz.py ## @@ -307,7 +307,12 @@ def

[GitHub] timifasubaa commented on issue #4405: Disable user access request

2018-02-14 Thread GitBox
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365737142 @maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change

[GitHub] timifasubaa commented on issue #4405: Disable user access request

2018-02-14 Thread GitBox
timifasubaa commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365737142 @maver1ck This PR only gives different deployments the the option to remove the ability to request access from users. It doesn't change

[GitHub] maver1ck commented on issue #4428: Proper error handling in Hive Queries

2018-02-14 Thread GitBox
maver1ck commented on issue #4428: Proper error handling in Hive Queries URL: https://github.com/apache/incubator-superset/pull/4428#issuecomment-365727748 Can we retest this ? Failed check has nothing to do with my patch.

[GitHub] maver1ck commented on issue #4405: Disable user access request

2018-02-14 Thread GitBox
maver1ck commented on issue #4405: Disable user access request URL: https://github.com/apache/incubator-superset/pull/4405#issuecomment-365717791 Do you have idea how does it join with https://github.com/apache/incubator-superset/issues/4352 ?

[GitHub] mistercrunch commented on a change in pull request #4422: [geoviz] lines made from locations in time (can be animated)

2018-02-14 Thread GitBox
mistercrunch commented on a change in pull request #4422: [geoviz] lines made from locations in time (can be animated) URL: https://github.com/apache/incubator-superset/pull/4422#discussion_r168283393 ## File path: superset/assets/visualizations/deckgl/DeckGLContainer.jsx

[GitHub] mistercrunch commented on issue #4382: Change current thumbnails to smaller ones.

2018-02-14 Thread GitBox
mistercrunch commented on issue #4382: Change current thumbnails to smaller ones. URL: https://github.com/apache/incubator-superset/pull/4382#issuecomment-365705967 https://github.com/apache/incubator-superset/pull/4430

[GitHub] mistercrunch closed pull request #4382: Change current thumbnails to smaller ones.

2018-02-14 Thread GitBox
mistercrunch closed pull request #4382: Change current thumbnails to smaller ones. URL: https://github.com/apache/incubator-superset/pull/4382 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] mistercrunch opened a new pull request #4430: Change current thumbnails to smaller ones.

2018-02-14 Thread GitBox
mistercrunch opened a new pull request #4430: Change current thumbnails to smaller ones. URL: https://github.com/apache/incubator-superset/pull/4430 Smaller thumbs, but preserving old ones, keeping them out of python package, but into the repo. Superseeds

[GitHub] timifasubaa commented on issue #4408: Add link on how to get permission.

2018-02-14 Thread GitBox
timifasubaa commented on issue #4408: Add link on how to get permission. URL: https://github.com/apache/incubator-superset/pull/4408#issuecomment-365698803 PING This is an automated message from the Apache Git Service. To

[GitHub] villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view

2018-02-14 Thread GitBox
villebro commented on issue #4413: Remove comments from queries in SQL Lab that break Explore view URL: https://github.com/apache/incubator-superset/pull/4413#issuecomment-365692257 @xrmx I would appreciate some guidance on what type of test case is requested, e.g. a similar case or

[GitHub] mistercrunch closed issue #4347: [Druid] Explore view throws error when group by is applied

2018-02-14 Thread GitBox
mistercrunch closed issue #4347: [Druid] Explore view throws error when group by is applied URL: https://github.com/apache/incubator-superset/issues/4347 This is an automated message from the Apache Git Service. To respond

[GitHub] mistercrunch commented on issue #4347: [Druid] Explore view throws error when group by is applied

2018-02-14 Thread GitBox
mistercrunch commented on issue #4347: [Druid] Explore view throws error when group by is applied URL: https://github.com/apache/incubator-superset/issues/4347#issuecomment-365689253 Should be fixed in master This is an

[GitHub] mistercrunch closed pull request #4427: Bump dependencies with security issues

2018-02-14 Thread GitBox
mistercrunch closed pull request #4427: Bump dependencies with security issues URL: https://github.com/apache/incubator-superset/pull/4427 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] SpyderRivera commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible

2018-02-14 Thread GitBox
SpyderRivera commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429#issuecomment-365686205 Bottom margin is available in the latest ? This

[GitHub] SpyderRivera closed issue #4429: [TimeSeries-BarChart] x axis dates are not visible

2018-02-14 Thread GitBox
SpyderRivera closed issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429 This is an automated message from the Apache Git Service. To respond to the

[GitHub] darylerwin commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible

2018-02-14 Thread GitBox
darylerwin commented on issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429#issuecomment-365681354 There is a chart option "Bottom Margin" that is available to tweak this.. just an FYI.

[GitHub] SpyderRivera opened a new issue #4429: [TimeSeries-BarChart] x axis dates are not visible

2018-02-14 Thread GitBox
SpyderRivera opened a new issue #4429: [TimeSeries-BarChart] x axis dates are not visible URL: https://github.com/apache/incubator-superset/issues/4429 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python

[GitHub] maver1ck opened a new pull request #4428: Proper error handling in Hive Queries

2018-02-14 Thread GitBox
maver1ck opened a new pull request #4428: Proper error handling in Hive Queries URL: https://github.com/apache/incubator-superset/pull/4428 Resolves: #4414 Fetch_many gives strange exception when hive query is in Error state. So we're reading status to get proper error message before

[GitHub] xrmx opened a new pull request #4427: Bump dependencies with security issues

2018-02-14 Thread GitBox
xrmx opened a new pull request #4427: Bump dependencies with security issues URL: https://github.com/apache/incubator-superset/pull/4427 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] xrmx opened a new issue #4426: yarn run prod fails on master

2018-02-14 Thread GitBox
xrmx opened a new issue #4426: yarn run prod fails on master URL: https://github.com/apache/incubator-superset/issues/4426 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here

[GitHub] xrmx commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod

2018-02-14 Thread GitBox
xrmx commented on issue #4425: Error on compiles the production / optimized js & css with npm run prod URL: https://github.com/apache/incubator-superset/issues/4425#issuecomment-365554280 Please report bugs against latest release and not old ones.

[GitHub] XavierDeLapeyre opened a new issue #4425: Error on compiles the production / optimized js & css with npm run prod

2018-02-14 Thread GitBox
XavierDeLapeyre opened a new issue #4425: Error on compiles the production / optimized js & css with npm run prod URL: https://github.com/apache/incubator-superset/issues/4425 ### Superset version {"GIT_SHA": "", "version": "0.21.1"} Background info : SuperSet v0.21.1

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168111611 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168117455 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168111611 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] vnnw commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
vnnw commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168116469 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] raffas commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )

2018-02-14 Thread GitBox
raffas commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424#issuecomment-365545144 You need to use the development version. Files in the assets folder are managed by webpack. You

[GitHub] xrmx commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )

2018-02-14 Thread GitBox
xrmx commented on issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424#issuecomment-365544974 You have to read the documentation on how to do your own build.

[GitHub] xrmx commented on issue #4418: Updated Italian Translation

2018-02-14 Thread GitBox
xrmx commented on issue #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#issuecomment-365543996 I've found a few more typos! With these fixed, looks good to me, thanks a lot!

[GitHub] xrmx commented on issue #4418: Updated Italian Translation

2018-02-14 Thread GitBox
xrmx commented on issue #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#issuecomment-365543996 Thanks a lot i've found a few more typos! With these fixed, looks good to me, thanks a lot!

[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168113761 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -391,83 +391,83 @@ msgstr "" #:

[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168113931 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -391,83 +391,83 @@ msgstr "" #:

[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168114174 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -391,83 +391,83 @@ msgstr "" #:

[GitHub] xrmx commented on a change in pull request #4418: Updated Italian Translation

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4418: Updated Italian Translation URL: https://github.com/apache/incubator-superset/pull/4418#discussion_r168114607 ## File path: superset/translations/it/LC_MESSAGES/messages.po ## @@ -2296,7 +2296,7 @@ msgstr "" #:

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168113031 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168113263 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r16832 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168111611 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] xrmx commented on a change in pull request #4421: Update core.py

2018-02-14 Thread GitBox
xrmx commented on a change in pull request #4421: Update core.py URL: https://github.com/apache/incubator-superset/pull/4421#discussion_r168113337 ## File path: superset/views/core.py ## @@ -1275,13 +1276,44 @@ def filter(self, datasource_type, datasource_id, column):

[GitHub] XavierDeLapeyre opened a new issue #4424: Pie Chart - format number display from .3s to .1s ( or other format )

2018-02-14 Thread GitBox
XavierDeLapeyre opened a new issue #4424: Pie Chart - format number display from .3s to .1s ( or other format ) URL: https://github.com/apache/incubator-superset/issues/4424 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset