[jira] [Created] (SYNCOPE-1302) New expression model in mapping for internal attributes to access user relationships

Matteo Alessandroni created SYNCOPE-1302: Summary: New expression model in mapping for internal attributes to access user relationships Key: SYNCOPE-1302 URL: https://issues.apache.org/jira/browse/SYNCOPE-

[jira] [Commented] (SYNCOPE-1299) Manual reconciliation

[ https://issues.apache.org/jira/browse/SYNCOPE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435328#comment-16435328 ] ASF subversion and git services commented on SYNCOPE-1299: -- Com

[jira] [Commented] (SYNCOPE-1299) Manual reconciliation

[ https://issues.apache.org/jira/browse/SYNCOPE-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435329#comment-16435329 ] ASF subversion and git services commented on SYNCOPE-1299: -- Com

[jira] [Commented] (SYNCOPE-1302) New expression model in mapping for internal attributes to access user relationships

[ https://issues.apache.org/jira/browse/SYNCOPE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435542#comment-16435542 ] ASF subversion and git services commented on SYNCOPE-1302: -- Com

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

GitHub user IsurangaPerera opened a pull request: https://github.com/apache/syncope/pull/70 [SYNCOPE-1301] fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/IsurangaPerera/syncope SYNCOPE-1301 Alternatively you can review an

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435567#comment-16435567 ] ASF GitHub Bot commented on SYNCOPE-1301: - GitHub user IsurangaPerera opened a p

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181086944 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java --- @@ -115,6 +115,16 @@ public AccessToken

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435575#comment-16435575 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181087221 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java --- @@ -115,6 +115,16 @@ public AccessToken

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435576#comment-16435576 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181087678 --- Diff: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java --- @@ -34,6 +34,8 @@ AccessTok

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435578#comment-16435578 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181088154 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435582#comment-16435582 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181088841 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181088731 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java --- @@ -44,7 +44,7 @@ @Temporal(Te

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435585#comment-16435585 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435584#comment-16435584 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181089295 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java --- @@ -44,7 +44,7 @@ @Tempo

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435588#comment-16435588 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181089640 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435590#comment-16435590 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181089858 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java --- @@ -44,7 +44,7 @@ @Temporal(Te

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435594#comment-16435594 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181090557 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435597#comment-16435597 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181091428 --- Diff: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java --- @@ -34,6 +34,8 @@ Acc

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435621#comment-16435621 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181091780 --- Diff: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java --- @@ -34,6 +34,8 @@ AccessTok

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435623#comment-16435623 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181093676 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java --- @@ -115,6 +115,16 @@ public AccessToken

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181093708 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435630#comment-16435630 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435631#comment-16435631 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435642#comment-16435642 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181094994 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181096467 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435645#comment-16435645 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181097338 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435650#comment-16435650 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181099396 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435663#comment-16435663 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181100023 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435665#comment-16435665 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181100663 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java --- @@ -115,6 +115,16 @@ public AccessToken

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435668#comment-16435668 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181100854 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPAAccessToken.java --- @@ -44,7 +44,7 @@ @Temporal(Te

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435671#comment-16435671 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181101464 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435673#comment-16435673 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181102107 --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java --- @@ -135,11 +135,7 @@

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435677#comment-16435677 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181103053 --- Diff: core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/dao/AccessTokenDAO.java --- @@ -34,6 +34,8 @@ AccessTok

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181103181 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java --- @@ -115,6 +115,16 @@ public AccessToken

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435684#comment-16435684 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435683#comment-16435683 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435686#comment-16435686 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on a d

[GitHub] syncope pull request #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on a diff in the pull request: https://github.com/apache/syncope/pull/70#discussion_r181103559 --- Diff: core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAAccessTokenDAO.java --- @@ -115,6 +115,16 @@ public AccessToken

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 @ilgrosso without enforcing the UNIQUE constraint on the owner as we discussed in the mail I can't see a valid reason for merge these changes ---

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435713#comment-16435713 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 @IsurangaPerera the point is that the existence of `replaceFlag` (I did not realize that at first) is what prevents to enforce the UNIQUE constraint. ---

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435715#comment-16435715 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[jira] [Commented] (SYNCOPE-1302) New expression model in mapping for internal attributes to access user relationships

[ https://issues.apache.org/jira/browse/SYNCOPE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435719#comment-16435719 ] ASF subversion and git services commented on SYNCOPE-1302: -- Com

[jira] [Resolved] (SYNCOPE-1302) New expression model in mapping for internal attributes to access user relationships

[ https://issues.apache.org/jira/browse/SYNCOPE-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matteo Alessandroni resolved SYNCOPE-1302. -- Resolution: Fixed > New expression model in mapping for internal attributes to

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 @ilgrosso Can I know the business rule associated with the access token. Can one user has more than one access token in an any given scenario? ---

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435728#comment-16435728 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 @IsurangaPerera I don't remember the details, but what I can see from the source three is that `AccessTokenDataBinderImpl#create` is invoked in two places: 1. https://github.com/apache/syn

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435743#comment-16435743 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435748#comment-16435748 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 Ok, let's try this way: please re-introduce the UNIQUE constraint but rework the whole `AccessTokenDataBinderImpl#create` to comply with the two invocation scenarios as reported above. Do y

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 @ilgrosso As I understand in SAML SP logic always replaced. So even when we logged, as usual, the access token may changed by SAML SP. So I can understand the importance of what replaceExisitn

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435756#comment-16435756 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 @IsurangaPerera the only effect of UNIQUE constraint will be that a validation error is raised whenever a second AccessToken is created with same owner of an existing one. Are you simply proposi

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435775#comment-16435775 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435792#comment-16435792 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 A validation error will be raised in the worst case(As I see the thread safe problem won't just affect the login as we discussed Saml as well. So Unique constraint will only prevent those scen

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 Ok so... > Are you simply proposing to add such constraint and leave the rest of the code as is? e.g. to change again this PR by reverting all changes and adding the UNIQUE constraint?

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435798#comment-16435798 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435795#comment-16435795 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 Yes, What if we revert it to the initial state? ---

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 I would stick with minimal changes, so this PR should only change `JPAAccessToken`. ---

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435801#comment-16435801 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 That way replace won't work since it saves first (2 tokens exist.violate UNIQUE constraint) and deletes next. That way it will only delete the existing one which results in no token at all.

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435808#comment-16435808 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user ilgrosso commented on the issue: https://github.com/apache/syncope/pull/70 > That way replace won't work since it saves first (2 tokens exist.violate UNIQUE constraint) and deletes next. That way it will only delete the existing one which results in no token at all.

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435813#comment-16435813 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user ilgrosso commented on the

[GitHub] syncope issue #70: [SYNCOPE-1301] fixed

Github user IsurangaPerera commented on the issue: https://github.com/apache/syncope/pull/70 Yes, that's why we have to see it from a different perspective. The initial state doesn't change the logic of replaceExisting == true But it partially affects replaceExisting == False (T

[jira] [Commented] (SYNCOPE-1301) Token creation is not threadsafe

[ https://issues.apache.org/jira/browse/SYNCOPE-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435830#comment-16435830 ] ASF GitHub Bot commented on SYNCOPE-1301: - Github user IsurangaPerera commented

Default 'User Workflow' issue

Hi,Executed the following: In 2.0.9-SNAPSHOT (no extensions), created some users, some in ldap and pulled, some in Syncope and pushed. All have status = 'Created' Rebuilt and installed 2.0.9-SNAPSHOT with '-P all' to include extensions Created a new user successfully in console, assuming wor

Re: Default 'User Workflow' issue

Hi, see my replies embedded below. Regards. On 12/04/2018 21:52, varontron wrote: Hi,Executed the following: In 2.0.9-SNAPSHOT (no extensions), created some users, some in ldap and pulled, some in Syncope and pushed. All have status = 'Created' Yes, when using the DefaultUserWorkflowAdapter