GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/28
EnumConverter works with null values
Previously, EnumConverter would throw an NPE if passed a null value, but
only because of an attempted .toUpperCase() which didn't get c
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-extensions/pull/19
TAMAYA-217 Spring bumps
This moves all of the asserts to AssertJ, as we're trying to do
everywhere. It also updates the version of Spring that we test against
to
Github user peculater closed the pull request at:
https://github.com/apache/incubator-tamaya-extensions/pull/12
---
Github user peculater commented on the issue:
https://github.com/apache/incubator-tamaya-extensions/pull/12
This got incorporated into bf0cd8b36a1a289f63911ac54305f5b91bff3dc7. :+1:
---
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-extensions/pull/16
Post big-merge compilation cleanup
This fixes the errors that we're discussing on the mailing list around
`evaluateExpression` in the injection standalone. It also fix
Github user peculater commented on the issue:
https://github.com/apache/incubator-tamaya-extensions/pull/12
For that use I'd go with
```
@Inject
@Config
private Optional myConfigVal;
```
The default config name is the name of the variable, and
"requ
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-extensions/pull/12
TAMAYA-358 Get CDI working with optional configvalues
There are two use cases in here, both related to injected config values
that are not required.
First, the
Github user peculater commented on the issue:
https://github.com/apache/incubator-tamaya-extensions/pull/9
Excellent. I think that cleans up the code nicely. Drop a license header
in that Testresource3.txt file to get the tests passing and this should be good
to merge. :+1:
---
Github user peculater commented on the issue:
https://github.com/apache/incubator-tamaya-extensions/pull/9
Newlines are notoriously complex, and I see that you're assuming Unix style
and not windows style. I'm comparing to the code in StringUtils in apache
commons. Any
Github user peculater commented on the issue:
https://github.com/apache/incubator-tamaya-sandbox/pull/8
I've seen the Vertex tests be flaky in my own work on jdk 8, but I don't
know much about what it's trying to do or why it's flaky.
---
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-sandbox/pull/9
TAMAYA-345 Associative array default separator to ':'
See the discussion at https://issues.apache.org/jira/browse/TAMAYA-345 .
The plurality of popular languages
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-sandbox/pull/7
TAMAYA-273 Fix infinite recursion in metamodel
With the lazily loaded configuration in metamodel, the logic is
susceptible to an infinite recursion if any part of the
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya-extensions/pull/5
TAMAYA-340 Environment properties vs PropertySourceChangeTest
On looking for the System property "java.home" in the Environment, we
are now also looking for
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/21
TAMAYA-340 Bugfix for regex "\\." vs literal "."
String.replaceAll(String, String) takes a regex as its first argument,
not a literal replaceable string. The re
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/15
TAMAYA-217: Convert test assertions to AssertJ
This seemingly-lengthy commit converts all of the assertions in tests
from a combination of JUnit, Hamcrest, and AssertJ to only AssertJ
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/14
TAMAYA-288: Additional test coverage
Looks huge and scary, but it's honestly just adding tests.
Things that this PR does:
* Significant increase in test coverage, espec
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/13
TAMAYA-329: mapBoxedType should work with boolean[]
Simple copy-and-paste miss. All the other primitives have both a simple
and array type check. Boolean has two simple checks and
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/12
TAMAYA-328: Let CharConverter parse a single apostrophe character
CharConverter uses paired apostrophes (') to delimit multi-character
strings and pulls the first into a Char
Github user peculater commented on the issue:
https://github.com/apache/incubator-tamaya/pull/11
I've refactored this to use LinkedHashSets instead of ArrayLists in the 2
places I was worried about. I think that covers what was discussed on the
mailing list?
---
Github user peculater commented on a diff in the pull request:
https://github.com/apache/incubator-tamaya/pull/11#discussion_r165699393
--- Diff:
code/api/src/main/java/org/apache/tamaya/spi/ConversionContext.java ---
@@ -145,7 +145,7 @@ public ConfigurationContext
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/11
TAMAYA-327: Consistent signature creating ConversionContexts
Comments in ConversionContext lead me to believe that supportedFormats
should have their order maintained after import
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/10
TAMAYA-326: Fix bug in ordinal comparison in ServiceContextManager
While adding some test coverage on the api, I found that
org.apache.tamaya.spi.ServiceContextManager has a bug as it
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/9
TAMAYA-325: Fake JSR API JAR with jitpack
Also get tests passing once the jar is in.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
23 matches
Mail list logo
