Re: Anyone looking at this PR?

2017-10-08 Thread Oliver B. Fischer
Am 08.10.17 um 22:40 schrieb John D. Ament: Thus I'd personally love the possibility to interact with ASF-repos via github, since it's much more convenient. Any other opinions on that? I'm of the opinion that it helps gives projects more visibility. Although, the cut over is a bit of a hard

Re: Anyone looking at this PR?

2017-10-08 Thread John D. Ament
On Sat, Oct 7, 2017 at 9:13 PM Werner Keil wrote: > Probably another reason why Java EE went to Eclipse. > > There fully Github based repos become the norm for most new projects. > Sigh. Its almost like you tried very hard to *not* read my email: > Now, back when Tamaya

Re: Anyone looking at this PR?

2017-10-08 Thread Oliver B. Fischer
You can merge an PR always manually via Git. The instructions to do this are always given in the PR. Look for something like "Merge manually". Github uses only the normal Git mechanisms. Oliver Am 01.10.17 um 23:02 schrieb P. Ottlinger: Am 30.09.2017 um 23:13 schrieb Anatole Tresch: I

Re: Anyone looking at this PR?

2017-10-07 Thread Werner Keil
Probably another reason why Java EE went to Eclipse. There fully Github based repos become the norm for most new projects. Am 07.10.2017 11:42 schrieb "P. Ottlinger" : > Hi, > > maybe we are still not really understanding each other. > I was of the impression that ASF

Re: Anyone looking at this PR?

2017-10-07 Thread P. Ottlinger
Hi, maybe we are still not really understanding each other. I was of the impression that ASF provides an interface similar to github to review, discuss, comment, change PRs if I understand your answer correctly this is not the case. Thus I'd personally love the possibility to interact with

Re: Anyone looking at this PR?

2017-10-05 Thread John D. Ament
On Thu, Oct 5, 2017 at 4:46 PM P. Ottlinger wrote: > Am 05.10.2017 um 01:56 schrieb John D. Ament: > > For Tamaya, the github repositories are read only mirrors. > > rofl - ok, let me rephrase my questions: > how can I deal with a github PR if I'm unable to accept it via

Re: Anyone looking at this PR?

2017-10-05 Thread P. Ottlinger
Am 05.10.2017 um 01:56 schrieb John D. Ament: > For Tamaya, the github repositories are read only mirrors. rofl - ok, let me rephrase my questions: how can I deal with a github PR if I'm unable to accept it via github. Is there a sync into the git-wip-us-repo? The UI doesn't seem to have a list

Re: Anyone looking at this PR?

2017-10-04 Thread John D. Ament
For Tamaya, the github repositories are read only mirrors. John On Wed, Oct 4, 2017 at 5:37 PM P. Ottlinger wrote: > Am 04.10.2017 um 03:38 schrieb John D. Ament: > > Anyone in the incubator group has write access, the repo is listed on > your > > sources page. > > >

Re: Anyone looking at this PR?

2017-10-04 Thread P. Ottlinger
Am 04.10.2017 um 03:38 schrieb John D. Ament: > Anyone in the incubator group has write access, the repo is listed on your > sources page. h - not sure howto find your PR under apache.org :-( https://git-wip-us.apache.org/repos/asf?p=incubator-tamaya-sandbox.git After being logged in I do

Re: Anyone looking at this PR?

2017-10-03 Thread John D. Ament
Anyone in the incubator group has write access, the repo is listed on your sources page. On Tue, Oct 3, 2017 at 4:23 PM P. Ottlinger wrote: > Am 03.10.2017 um 19:59 schrieb John D. Ament: > > It looks like some tests that were passing are now failing in the branch. > >

Re: Anyone looking at this PR?

2017-10-03 Thread P. Ottlinger
Am 03.10.2017 um 19:59 schrieb John D. Ament: > It looks like some tests that were passing are now failing in the branch. > Empty values are suddenly failing (they were passing last time). Also > looks like major API changes in Tamaya, Builder no longer supports setting > type, configuration no

Re: Anyone looking at this PR?

2017-10-03 Thread John D. Ament
It looks like some tests that were passing are now failing in the branch. Empty values are suddenly failing (they were passing last time). Also looks like major API changes in Tamaya, Builder no longer supports setting type, configuration no longer has getFromValue. On Tue, Oct 3, 2017 at 1:52

Re: Anyone looking at this PR?

2017-10-03 Thread John D. Ament
At this point the PR doesn't compile. So not sure what to do. It seems like Anatole's moved forward on it anyways. On Sun, Oct 1, 2017 at 5:02 PM P. Ottlinger wrote: > Am 30.09.2017 um 23:13 schrieb Anatole Tresch: > > I shortly looked at it. It makes sense, so +1

Re: Anyone looking at this PR?

2017-10-01 Thread P. Ottlinger
Am 30.09.2017 um 23:13 schrieb Anatole Tresch: > I shortly looked at it. It makes sense, so +1 to merge from my side... I'm unable to accept the PR not sure if it's a bug with the Github-integration, but +1 from me. Phil

Re: Anyone looking at this PR?

2017-09-30 Thread Anatole Tresch
Hi John I shortly looked at it. It makes sense, so +1 to merge from my side... J Anatole 2017-09-30 22:04 GMT+02:00 John D. Ament : > https://github.com/apache/incubator-tamaya-sandbox/pull/1 > > Let me know if I should just merge it. > > John > -- *Anatole Tresch*

Anyone looking at this PR?

2017-09-30 Thread John D. Ament
https://github.com/apache/incubator-tamaya-sandbox/pull/1 Let me know if I should just merge it. John