Re: Why log4j as a compile dep?

2011-01-19 Thread Massimo Lusetti
On Tue, Jan 18, 2011 at 7:19 PM, Robert Zeigler wrote: > Not a compile dependency, that I'm aware of.  How many users start with the > quickstart as a basis for new projects? If that's a large percentage, > couldn't we move the log4j dependency declaration into the generated pom? > Then it's e

Re: Why log4j as a compile dep?

2011-01-18 Thread Howard Lewis Ship
That's a good suggestion. On Tue, Jan 18, 2011 at 10:19 AM, Robert Zeigler wrote: > Not a compile dependency, that I'm aware of.  How many users start with the > quickstart as a basis for new projects? If that's a large percentage, > couldn't we move the log4j dependency declaration into the ge

Re: Why log4j as a compile dep?

2011-01-18 Thread Josh Canfield
I'm also running into two other compile dependencies in Hibernate-core: org.hibernate:hibernate-core:3.6.0.Final [compile,master,runtime] org.hibernate:hibernate-c3p0:3.6.0.Final [compile,master,runtime] These were mentioned previously in the list, but I just got bit by them. We shouldn't be de

Re: Why log4j as a compile dep?

2011-01-18 Thread Kalle Korhonen
Fully agree. Log4j should be in provided scope, or removed if it's not needed in the core at all. Adding it directly to the archetype pom makes sense. Kalle On Tue, Jan 18, 2011 at 10:19 AM, Robert Zeigler wrote: > Not a compile dependency, that I'm aware of.  How many users start with the > q

Re: Why log4j as a compile dep?

2011-01-18 Thread Robert Zeigler
Not a compile dependency, that I'm aware of. How many users start with the quickstart as a basis for new projects? If that's a large percentage, couldn't we move the log4j dependency declaration into the generated pom? Then it's even easier to change for people who want to change it, and remove

Re: Why log4j as a compile dep?

2011-01-18 Thread Josh Canfield
:) I'm also moving to gradle so it's a different kind of magic. compile("org.apache.tapestry:tapestry-core:$tapestryVersion") { exclude module: 'slf4j-log4j12' exclude module: 'log4j' } Making it a compile dependency saves end users from needing to include log4j in their poms (or other de

Re: Why log4j as a compile dep?

2011-01-18 Thread Howard Lewis Ship
Yes, but the vast majority will use Log4J, and those enlightened enough to prefer Logback will also be enlightened enough to know the Maven pom incantation to include logback and exclude log4j. On Tue, Jan 18, 2011 at 7:52 AM, Josh Canfield wrote: > Agreed. I'm moving to logback and have to exclu

Re: Why log4j as a compile dep?

2011-01-18 Thread Josh Canfield
Agreed. I'm moving to logback and have to exclude log4j. On Jan 18, 2011 7:32 AM, "Massimo Lusetti" wrote: > Why there's a log4j dep? ... Maybe I'm in the 0.1% of applications > (who) will need to override this dependency to not use Log4J but why > using slf4j then "force" a log implementation

Why log4j as a compile dep?

2011-01-18 Thread Massimo Lusetti
Why there's a log4j dep? ... Maybe I'm in the 0.1% of applications (who) will need to override this dependency to not use Log4J but why using slf4j then "force" a log implementation? Cheers -- Massimo http://meridio.blogspot.com ---