[jira] [Comment Edited] (THRIFT-1840) Thrift Generated Code Causes Global Variable Leaks

2013-01-23 Thread Russell Bradberry (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560784#comment-13560784 ] Russell Bradberry edited comment on THRIFT-1840 at 1/23/13 4:00 PM:

[jira] [Updated] (THRIFT-1840) Thrift Generated Code Causes Global Variable Leaks

2013-01-23 Thread Russell Bradberry (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russell Bradberry updated THRIFT-1840: -- Attachment: 0001-THRIFT-1840-fix-for-global-variable-leak.patch Fixes global variable

Re: Link a code generated server interface with a TServerEventHandler context?

2013-01-23 Thread Ben Craig
I have since figured out how to solve this use case, without writing anything new in the Thrift library itself. Beforehand, when I was creating my server, I was using one of the constructors that took a TProcessor. If I use the TProcessorFactory entry point, I have a way to make everything

Erlang Thrift Library and Rebar

2013-01-23 Thread Joel Meyer
[cross-posting to user and dev list] A while back Anthony made some changes to the thrift library to make it easier for rebar to pull it in as a dependency. Unfortunately, the move to Git rendered that approach unworkable. For now I'm using filter-branch[1] to trim the repo to just the erlang

[jira] [Resolved] (THRIFT-1805) Thrift should not swallow ALL exceptions

2013-01-23 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1805. - Resolution: Fixed Assignee: Diwaker Gupta (was: Jake Farrell) Thanks Gupta! committed.

[jira] [Commented] (THRIFT-1840) Thrift Generated Code Causes Global Variable Leaks

2013-01-23 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560982#comment-13560982 ] Roger Meier commented on THRIFT-1840: - I have the following issues with your patch:

[jira] [Commented] (THRIFT-1835) Compiler should fail when duplicate field names are present

2013-01-23 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560998#comment-13560998 ] Nicolas Trésegnie commented on THRIFT-1835: --- Thanks for the patch and the test

[jira] [Commented] (THRIFT-1842) Memory leak with Pipes

2013-01-23 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561006#comment-13561006 ] Roger Meier commented on THRIFT-1842: - +1 Memory leak with Pipes

[jira] [Commented] (THRIFT-1840) Thrift Generated Code Causes Global Variable Leaks

2013-01-23 Thread Russell Bradberry (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561008#comment-13561008 ] Russell Bradberry commented on THRIFT-1840: --- ah, sorry. I couldn't get the

[jira] [Commented] (THRIFT-1835) Compiler should fail when duplicate field names are present

2013-01-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561026#comment-13561026 ] Jens Geyer commented on THRIFT-1835: {quote} 1) Is it appropriate to put these (5)

[jira] [Resolved] (THRIFT-1842) Memory leak with Pipes

2013-01-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-1842. Resolution: Fixed Assignee: Jens Geyer Committed. Memory leak with Pipes

[jira] [Commented] (THRIFT-1805) Thrift should not swallow ALL exceptions

2013-01-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561073#comment-13561073 ] Hudson commented on THRIFT-1805: Integrated in Thrift #619 (See

[jira] [Commented] (THRIFT-1842) Memory leak with Pipes

2013-01-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561080#comment-13561080 ] Hudson commented on THRIFT-1842: Integrated in Thrift #620 (See

[jira] [Updated] (THRIFT-1835) Compiler should fail when duplicate field names are present

2013-01-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-1835: --- Attachment: THRIFT-1835_Compiler_should_fail_when_duplicate_field_names_are_present_v2.patch patch

[jira] [Updated] (THRIFT-1835) Compiler should fail when duplicate field names are present

2013-01-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-1835: --- Attachment: (was:

[jira] [Commented] (THRIFT-1835) Compiler should fail when duplicate field names are present

2013-01-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561326#comment-13561326 ] Jens Geyer commented on THRIFT-1835: (patch v2 removed, found another issue)

[jira] [Updated] (THRIFT-1835) Compiler should fail when duplicate field names are present

2013-01-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-1835: --- Attachment: THRIFT-1835_Compiler_should_fail_when_duplicate_field_names_are_present_v3.patch patch