[jira] [Created] (THRIFT-2233) Java compiler should defensively copy its binary inputs

2013-10-22 Thread Andrew Gaul (JIRA)
Andrew Gaul created THRIFT-2233: --- Summary: Java compiler should defensively copy its binary inputs Key: THRIFT-2233 URL: https://issues.apache.org/jira/browse/THRIFT-2233 Project: Thrift Issue

[jira] [Updated] (THRIFT-2233) Java compiler should defensively copy its binary inputs

2013-10-22 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated THRIFT-2233: Attachment: THRIFT-2233.patch Pull request available at:

[jira] [Commented] (THRIFT-2172) Java compiler allocates optionals array for every struct with an optional field

2013-10-22 Thread Andrew Gaul (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801524#comment-13801524 ] Andrew Gaul commented on THRIFT-2172: - Any comments on this issue? Java compiler

AW: [jira] [Created] (THRIFT-2232) IsSet* broken in Go

2013-10-22 Thread Jens Geyer
What would your proposal(s) be? Let's discuss it. Von: Ben Sigelman (JIRA) Gesendet: 21.10.2013 22:53 An: dev@thrift.apache.org Betreff: [jira] [Created] (THRIFT-2232) IsSet* broken in Go Ben Sigelman created THRIFT-2232:

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2013-10-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801558#comment-13801558 ] Jens Geyer commented on THRIFT-2232: Let's talk about it. What are your proposals?

[jira] [Updated] (THRIFT-2232) IsSet* broken in Go

2013-10-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2232: --- Fix Version/s: 0.9.2 IsSet* broken in Go --- Key: THRIFT-2232

[jira] [Updated] (THRIFT-2234) TTornadoStreamTransport: add optional io_loop param

2013-10-22 Thread Roey Berman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roey Berman updated THRIFT-2234: Priority: Minor (was: Major) Issue Type: Improvement (was: Bug) TTornadoStreamTransport:

[jira] [Created] (THRIFT-2234) TTornadoStreamTransport: add optional io_loop param

2013-10-22 Thread Roey Berman (JIRA)
Roey Berman created THRIFT-2234: --- Summary: TTornadoStreamTransport: add optional io_loop param Key: THRIFT-2234 URL: https://issues.apache.org/jira/browse/THRIFT-2234 Project: Thrift Issue

[jira] [Updated] (THRIFT-2231) Support tornado-3.x (Python)

2013-10-22 Thread Roey Berman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roey Berman updated THRIFT-2231: Attachment: thrift-2231-support-tornado-3.patch Support tornado-3.x (Python)

[jira] [Updated] (THRIFT-2231) Support tornado-3.x (Python)

2013-10-22 Thread Roey Berman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roey Berman updated THRIFT-2231: Attachment: (was: thrift-2231-support-tornado-3.patch) Support tornado-3.x (Python)

[jira] [Updated] (THRIFT-2234) TTornadoStreamTransport: add optional io_loop param

2013-10-22 Thread Roey Berman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roey Berman updated THRIFT-2234: Attachment: thrift-2234-TTornadoStreamTransport-add-optional-io_loop-param.patch

thrift pull request: Defensively copy binary fields (THRIFT-2233)

2013-10-22 Thread andrewgaul
GitHub user andrewgaul opened a pull request: https://github.com/apache/thrift/pull/60 Defensively copy binary fields (THRIFT-2233) This ensures that one consumer of a ByteBuffer does not interfere with another, e.g., MyStruct myStruct = ...; byte[] array = new

Re: thrift pull request: Defensively copy binary fields (THRIFT-2233)

2013-10-22 Thread Ben Craig
Thanks you for your interest Andrew. Unfortunately, we can't currently accept git pull requests. We only accept patches attached to JIRA tickets. For more information on how to get changes into Thrift, see the following page: http://thrift.apache.org/docs/HowToContribute/ andrewgaul

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2013-10-22 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801855#comment-13801855 ] Ben Sigelman commented on THRIFT-2232: -- Hi [~jensg], thanks for the quick response!

[jira] [Comment Edited] (THRIFT-2232) IsSet* broken in Go

2013-10-22 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801855#comment-13801855 ] Ben Sigelman edited comment on THRIFT-2232 at 10/22/13 4:29 PM:

[jira] [Created] (THRIFT-2235) TThreadPoolServer should have a NOP reject policy

2013-10-22 Thread Alejandro Abdelnur (JIRA)
Alejandro Abdelnur created THRIFT-2235: -- Summary: TThreadPoolServer should have a NOP reject policy Key: THRIFT-2235 URL: https://issues.apache.org/jira/browse/THRIFT-2235 Project: Thrift

[jira] [Commented] (THRIFT-1643) Denial of Service attack in TBinaryProtocol.readString

2013-10-22 Thread Valentin Mayamsin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802052#comment-13802052 ] Valentin Mayamsin commented on THRIFT-1643: --- The issue is still there, in

Re: thrift pull request: Defensively copy binary fields (THRIFT-2233)

2013-10-22 Thread Andrew Gaul
Ben, I have opened JIRA issues with attachments for all of my patches. I open the in GitHub pull request to allow for review comments and for my own tracking purposes. If the PR adds too much noise I will discontinue this practice. Let me know how to best contribute. (Inaccurate to say that

Re: thrift pull request: Defensively copy binary fields (THRIFT-2233)

2013-10-22 Thread Jake Farrell
Hi Andrew First I want to thank you for taking the time to contribute, your help is greatly appreciated. For pull requests from Github, we (Apache Thrift) do not accept them because there is no mechanism in place currently that grants use of that code to the ASF for that pull request. Also Github

Haskell Performance

2013-10-22 Thread Jens Geyer
Any Haskell devs around? There’s an interesting thread about the Haskell Thrift implementation on StackOverflow. http://stackoverflow.com/questions/19512952/haskell-300x-slower-than-c-in-performance-test I wonder if there something that can be done about this? Have fun, JensG

Re: Haskell Performance

2013-10-22 Thread Ben Craig
From: Jens Geyer jensge...@hotmail.com To: dev@thrift.apache.org, Date: 10/22/2013 03:45 PM Subject: Haskell Performance Any Haskell devs around? There’s an interesting thread about the Haskell Thrift implementation on StackOverflow.