[GitHub] thrift pull request: Update README.md

2014-05-02 Thread rayqiu
GitHub user rayqiu opened a pull request: https://github.com/apache/thrift/pull/115 Update README.md the path for go get does not work, updated You can merge this pull request into a Git repository by running: $ git pull https://github.com/rayqiu/thrift patch-1 Alternatively

[GitHub] thrift pull request: THRIFT-2505

2014-05-02 Thread apesternikov
GitHub user apesternikov opened a pull request: https://github.com/apache/thrift/pull/116 THRIFT-2505 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apesternikov/thrift go_struct Alternatively you can review and apply these

[jira] [Commented] (THRIFT-2505) struct should always be a pointer to avoid copying of potentially size-unbounded structs

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13987836#comment-13987836 ] ASF GitHub Bot commented on THRIFT-2505: GitHub user apesternikov opened a pull

[jira] [Created] (THRIFT-2505) struct should always be a pointer to avoid copying of potentially size-unbounded structs

2014-05-02 Thread Aleksey Pesternikov (JIRA)
Aleksey Pesternikov created THRIFT-2505: --- Summary: struct should always be a pointer to avoid copying of potentially size-unbounded structs Key: THRIFT-2505 URL:

[jira] [Updated] (THRIFT-2505) go: struct should always be a pointer to avoid copying of potentially size-unbounded structs

2014-05-02 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksey Pesternikov updated THRIFT-2505: Summary: go: struct should always be a pointer to avoid copying of potentially

[jira] [Assigned] (THRIFT-2505) go: struct should always be a pointer to avoid copying of potentially size-unbounded structs

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2505: -- Assignee: Jens Geyer go: struct should always be a pointer to avoid copying of potentially

[jira] [Commented] (THRIFT-2502) Optimize go implementations of binary and compact protocols for speed

2014-05-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988105#comment-13988105 ] Hudson commented on THRIFT-2502: SUCCESS: Integrated in Thrift #1145 (See

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

2014-05-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988104#comment-13988104 ] Hudson commented on THRIFT-2451: SUCCESS: Integrated in Thrift #1145 (See

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988119#comment-13988119 ] Roger Meier commented on THRIFT-2471: - +1 do you commit Jens? @all: doc updates are

[jira] [Commented] (THRIFT-2501) C# The test parameters from the TestServer and TestClient are different from the http://thrift.apache.org/test/

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988126#comment-13988126 ] Roger Meier commented on THRIFT-2501: - +1 ready to commit C# The test parameters

[GitHub] thrift pull request: THRIFT-2492 use tcxx instead of tr1 in test/c...

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2492) test/cpp does not compile on mac

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988127#comment-13988127 ] ASF GitHub Bot commented on THRIFT-2492: Github user asfgit closed the pull

[jira] [Resolved] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2471. Resolution: Fixed Committed. Make cpp.ref annotation language agnostic

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988139#comment-13988139 ] Roger Meier commented on THRIFT-2457: - [~jensg] A compiler supporting float will

[jira] [Assigned] (THRIFT-2401) Haskell tutorial compiles

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier reassigned THRIFT-2401: --- Assignee: Roger Meier Haskell tutorial compiles -

[jira] [Comment Edited] (THRIFT-2457) fbthrift float

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988148#comment-13988148 ] Jens Geyer edited comment on THRIFT-2457 at 5/2/14 7:46 PM:

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-05-02 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988152#comment-13988152 ] Randy Abernethy commented on THRIFT-2457: - I also think float would be a nice to

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-05-02 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988161#comment-13988161 ] Ben Craig commented on THRIFT-2457: --- I would argue for a warning like the following:

[jira] [Created] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-2506: -- Summary: Update TProtocolException error codes to be used consistently throughout the library Key: THRIFT-2506 URL: https://issues.apache.org/jira/browse/THRIFT-2506

[jira] [Updated] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2506: --- Attachment: thrift-2506-tprotocolexceptioncodes.patch Update TProtocolException error codes to be

[jira] [Created] (THRIFT-2507) Additional LUA TProtocolException error code needed?

2014-05-02 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-2507: -- Summary: Additional LUA TProtocolException error code needed? Key: THRIFT-2507 URL: https://issues.apache.org/jira/browse/THRIFT-2507 Project: Thrift Issue

[GitHub] thrift pull request: THRIFT-2471

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-2501 c# TestServer and TestClient: par...

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988185#comment-13988185 ] ASF GitHub Bot commented on THRIFT-2471: Github user asfgit closed the pull

[jira] [Commented] (THRIFT-2507) Additional LUA TProtocolException error code needed?

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988195#comment-13988195 ] Roger Meier commented on THRIFT-2507: - yes, I guess this can be removed Additional

[jira] [Commented] (THRIFT-2457) fbthrift float

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988196#comment-13988196 ] Jens Geyer commented on THRIFT-2457: @[~ben.craig]: +1 this way the warning _ensure

[jira] [Updated] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2506: --- Component/s: Lua - Library Update TProtocolException error codes to be used consistently

[jira] [Updated] (THRIFT-2507) Additional LUA TProtocolException error code needed?

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2507: --- Component/s: (was: D - Library) (was: Delphi - Library)

[jira] [Resolved] (THRIFT-2501) C# The test parameters from the TestServer and TestClient are different from the http://thrift.apache.org/test/

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2501. Resolution: Fixed Committed, thanks Beat Roger! C# The test parameters from the TestServer and

[jira] [Commented] (THRIFT-2501) C# The test parameters from the TestServer and TestClient are different from the http://thrift.apache.org/test/

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988186#comment-13988186 ] ASF GitHub Bot commented on THRIFT-2501: Github user asfgit closed the pull

[jira] [Commented] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988210#comment-13988210 ] Roger Meier commented on THRIFT-2506: - that's great! +1 What about a

[jira] [Closed] (THRIFT-2507) Additional LUA TProtocolException error code needed?

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2507. -- Resolution: Done Ok, I include that into THRIFT-2506. Additional LUA TProtocolException error code

[jira] [Updated] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2506: --- Attachment: (was: thrift-2506-tprotocolexceptioncodes.patch) Update TProtocolException error

[jira] [Updated] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2506: --- Attachment: thrift-2506-tprotocolexceptioncodes-v2.patch Patch included to cover THRIFT-2507 as

[jira] [Comment Edited] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988220#comment-13988220 ] Jens Geyer edited comment on THRIFT-2506 at 5/2/14 8:52 PM:

[jira] [Updated] (THRIFT-2491) unable to import generated ThriftTest service

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2491: --- Component/s: Go - Library unable to import generated ThriftTest service

[jira] [Resolved] (THRIFT-2491) unable to import generated ThriftTest service

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2491. Resolution: Fixed Fix Version/s: 0.9.2 Pull request #105 committed - thanks again,

[jira] [Assigned] (THRIFT-2499) Compiler: allow annotations without = value

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2499: -- Assignee: Jens Geyer Compiler: allow annotations without = value

[jira] [Commented] (THRIFT-2500) sending random data crashes thrift(golang) service

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988314#comment-13988314 ] ASF GitHub Bot commented on THRIFT-2500: GitHub user apesternikov opened a pull

[GitHub] thrift pull request: THRIFT-2500

2014-05-02 Thread apesternikov
GitHub user apesternikov opened a pull request: https://github.com/apache/thrift/pull/117 THRIFT-2500 I'm sorry, I have merged several uncommited branches here, so you might want to review this one last. You can merge this pull request into a Git repository by running: $ git

[jira] [Closed] (THRIFT-2499) Compiler: allow annotations without = value

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2499. -- Compiler: allow annotations without = value -

[jira] [Resolved] (THRIFT-2499) Compiler: allow annotations without = value

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2499. Resolution: Fixed Committed, thanks! Compiler: allow annotations without = value

[GitHub] thrift pull request: add _ to generated filename if it ends with _...

2014-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (THRIFT-2500) sending random data crashes thrift(golang) service

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2500: -- Assignee: Jens Geyer sending random data crashes thrift(golang) service

[jira] [Commented] (THRIFT-2491) unable to import generated ThriftTest service

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988353#comment-13988353 ] ASF GitHub Bot commented on THRIFT-2491: Github user asfgit closed the pull

[jira] [Commented] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988365#comment-13988365 ] Roger Meier commented on THRIFT-2506: - +1 Update TProtocolException error codes to

[jira] [Closed] (THRIFT-2506) Update TProtocolException error codes to be used consistently throughout the library

2014-05-02 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2506. -- Resolution: Fixed Thanks Roger. I tested it myself on two systems, but still may have overlooked

Re: svn commit: r1592094 - /thrift/cms-site/trunk/content/lib/php.md

2014-05-02 Thread Joe Schaefer
You're overlooking the Title header, which means the page doesn't display a proper title. On Friday, May 2, 2014 7:00 PM, ro...@apache.org ro...@apache.org wrote: Author: roger Date: Fri May  2 22:59:46 2014 New Revision: 1592094 URL: http://svn.apache.org/r1592094 Log: php Added:    

[GitHub] thrift pull request: THRIFT-1914 Python: Support for Multiplexing ...

2014-05-02 Thread haijunz
Github user haijunz commented on a diff in the pull request: https://github.com/apache/thrift/pull/82#discussion_r12252798 --- Diff: lib/py/src/protocol/TProtocolDecorator.py --- @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[jira] [Commented] (THRIFT-1914) Python: Support for Multiplexing Services on any Transport, Protocol and Server

2014-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988440#comment-13988440 ] ASF GitHub Bot commented on THRIFT-1914: Github user haijunz commented on a diff

[jira] [Commented] (THRIFT-1239) TupleProtocol- An extremely compact, temporary protocol

2014-05-02 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988527#comment-13988527 ] Aleksey Pesternikov commented on THRIFT-1239: - 8-[] Can anybody explain

[jira] [Commented] (THRIFT-1239) TupleProtocol- An extremely compact, temporary protocol

2014-05-02 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988546#comment-13988546 ] Bryan Duxbury commented on THRIFT-1239: --- A scheme is sorta like the grammar part of