[jira] [Commented] (THRIFT-2423) THeader

2015-01-26 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292594#comment-14292594 ] Jens Geyer commented on THRIFT-2423: Hi [~breerly], sure, feel free to add them. I w

[jira] [Commented] (THRIFT-2423) THeader

2015-01-26 Thread Grayson Koonce (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292552#comment-14292552 ] Grayson Koonce commented on THRIFT-2423: Can we create sub-tasks for each of the

[GitHub] thrift pull request: Facebook's THeader protocol and transport for...

2015-01-26 Thread ben-craig
Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/357#discussion_r23560447 --- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp --- @@ -0,0 +1,606 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] thrift pull request: Facebook's THeader protocol and transport for...

2015-01-26 Thread djwatson
Github user djwatson commented on a diff in the pull request: https://github.com/apache/thrift/pull/357#discussion_r23559637 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -547,12 +553,18 @@ void TNonblockingServer::TConnection::transition() { case APP_READ

[GitHub] thrift pull request: Facebook's THeader protocol and transport for...

2015-01-26 Thread djwatson
Github user djwatson commented on a diff in the pull request: https://github.com/apache/thrift/pull/357#discussion_r23559536 --- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp --- @@ -0,0 +1,606 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] thrift pull request: Facebook's THeader protocol and transport for...

2015-01-26 Thread djwatson
Github user djwatson commented on a diff in the pull request: https://github.com/apache/thrift/pull/357#discussion_r23559234 --- Diff: lib/cpp/src/thrift/transport/THeaderTransport.cpp --- @@ -0,0 +1,606 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one