[GitHub] thrift pull request: cmake // fixes for std/boost::thread detectio...

2015-09-04 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/598#discussion_r38807967 --- Diff: lib/cpp/test/qt/CMakeLists.txt --- @@ -18,11 +18,15 @@ # set(CMAKE_AUTOMOC ON) -find_package(Qt5 REQUIRED COMPONENTS Test)

AW: [jira] [Created] (THRIFT-3314) Dots in file names of includes causes dots in javascript variable names

2015-09-04 Thread Jens Geyer
This is part of a bigger problem. Spaces in filenames are valid too, to name only one. Von: Matt Fysh (JIRA) Gesendet: 04.09.2015 04:43 An: dev@thrift.apache.org Betreff: [jira] [Created] (THRIFT-3314) Dots in file names of includes causes dots in javascript