[
https://issues.apache.org/jira/browse/THRIFT-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976263#comment-14976263
]
Jonathan Heard commented on THRIFT-3397:
Please can I have some advice about how you like to do
[
https://issues.apache.org/jira/browse/THRIFT-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976263#comment-14976263
]
Jonathan Heard edited comment on THRIFT-3397 at 10/27/15 11:47 AM:
---
Hi Johnathan,
We try to avoid monster patches because they are hard to review. That said,
if everything is focused on adding and supplying tests for a single issue,
then one patch or pull request is probably appropriate.
Best,
Randy
On Tue, Oct 27, 2015 at 4:47 AM, Jonathan Heard (JIRA)
GitHub user JonathanH-UK opened a pull request:
https://github.com/apache/thrift/pull/663
Thrift 3397
2 Commits for consideration:
5cf0334 - Changes to C# Library Code (lib/csharp/src)
024c204 - Supporting changes to C# Test Code (lib/csharp/test)
You can merge this pull
Hi Jonathan,
It fails a lot recently and seemingly it is due to out of memory.
The other failure is a bit unusual.
https://travis-ci.org/apache/thrift/jobs/87701311#L6671
You can view the actual failure log by clicking "after_failure" at the
bottom.
Only csharp-py_json can possibly be related
Hi All,
Disappointingly - After submitting my first pull request, the Travis CI
build has failed the following job:
https://travis-ci.org/apache/thrift/jobs/87701328
I would have built this on Travis CI before creating a pull request, but
I'd already pushed the code to my branch and there seems
[
https://issues.apache.org/jira/browse/THRIFT-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977200#comment-14977200
]
Jens Geyer commented on THRIFT-3397:
As Randy pointed out, nobody really likes monster patches. Your
[
https://issues.apache.org/jira/browse/THRIFT-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977735#comment-14977735
]
Adam Beberg commented on THRIFT-3382:
-
This should be a clean patch now.
> TBase class for C++
