GitHub user aughr opened a pull request:
https://github.com/apache/thrift/pull/679
THRIFT-3408: correct emitted JSON types
https://issues.apache.org/jira/browse/THRIFT-3408
Currently this has no tests associated with it because the JSON generator
itself appears untested.
Andrew Bloomgarden created THRIFT-3408:
--
Summary: JSON generator emits incorrect types
Key: THRIFT-3408
URL: https://issues.apache.org/jira/browse/THRIFT-3408
Project: Thrift
Issue
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/675#issuecomment-153348137
b31f0900b57b7473a8f84c7b74f73381dcff2818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nsuke closed the pull request at:
https://github.com/apache/thrift/pull/675
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/676
THRIFT-3274 calling "make clean" twice in a row yields make error
Removing `gen-cpp/.deps` hidden directory broke the source tree where any
subsequent make command failed.
You can merge this pull
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987252#comment-14987252
]
ASF GitHub Bot commented on THRIFT-3274:
GitHub user nsuke opened a pull request:
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/357#issuecomment-153325696
@nsuke Yes, please do so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa resolved THRIFT-338.
-
Resolution: Fixed
committed
> Compact Protocol in Erlang
> --
>
>
[
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987241#comment-14987241
]
ASF GitHub Bot commented on THRIFT-338:
---
Github user nsuke closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987240#comment-14987240
]
ASF GitHub Bot commented on THRIFT-338:
---
Github user nsuke commented on the pull request:
[
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987124#comment-14987124
]
ASF GitHub Bot commented on THRIFT-2423:
Github user bufferoverflow commented on the pull
[
https://issues.apache.org/jira/browse/THRIFT-3408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987449#comment-14987449
]
ASF GitHub Bot commented on THRIFT-3408:
GitHub user aughr opened a pull request:
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/680
Thrift 1857 redux 2
Rational:
* No TType.UTF8 (don't break cross-lang compatibility)
* No six.BufferIO (don't break fastbinary)
* Don't make py2 read/writeString UTF8 (don't break backward
[
https://issues.apache.org/jira/browse/THRIFT-3200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa reassigned THRIFT-3200:
Assignee: Aki Sukegawa
> JS and nodejs do not encode JSON protocol binary fields as
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/213#issuecomment-153393441
I did some research on this.
TType.UTF8 was added years ago but currently not used by any language.
So using this now will result in incompatibility against any
[
https://issues.apache.org/jira/browse/THRIFT-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa reassigned THRIFT-3350:
Assignee: Aki Sukegawa
> Python JSON protocol does not encode binary as Base64
>
[
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987606#comment-14987606
]
Hudson commented on THRIFT-2423:
SUCCESS: Integrated in Thrift #1708 (See
Github user marshalium commented on the pull request:
https://github.com/apache/thrift/pull/512#issuecomment-153496623
Hey @jfarrell. Are things better with CI now? Should I rebase off of master
and try again? Thanks!
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/THRIFT-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988175#comment-14988175
]
ASF GitHub Bot commented on THRIFT-3182:
Github user marshalium commented on the pull request:
GitHub user i opened a pull request:
https://github.com/apache/thrift/pull/682
Allow context to be passed into NewTHttpPostClient
This provides a way to cancel outgoing requests which this library doesn't
currently support.
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3274.
-
Resolution: Fixed
tutorial fix is committed
> calling "make clean" twice in a row yields make
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988407#comment-14988407
]
Hudson commented on THRIFT-3274:
SUCCESS: Integrated in Thrift #1710 (See
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988017#comment-14988017
]
Jens Geyer commented on THRIFT-3274:
Better, but not perfect. The tutorial seems to suffer from the
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988017#comment-14988017
]
Jens Geyer edited comment on THRIFT-3274 at 11/3/15 8:09 PM:
-
Better, but not
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3274.
-
Resolution: Fixed
Assignee: Aki Sukegawa
Thanks Aki!
> calling "make clean" twice in a
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-3274:
> calling "make clean" twice in a row yields make error
>
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988135#comment-14988135
]
Roger Meier commented on THRIFT-3274:
-
[~jensg] fix for tutorial is in verification...
> calling
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/676
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988024#comment-14988024
]
ASF GitHub Bot commented on THRIFT-3274:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988006#comment-14988006
]
Roger Meier commented on THRIFT-3409:
-
great stuff!
+1
> NodeJS binary field issues
>
[
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987994#comment-14987994
]
Roger Meier commented on THRIFT-3407:
-
+1
> Refill buffer when JSON closing bracket is missing
>
[
https://issues.apache.org/jira/browse/THRIFT-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Beberg reopened THRIFT-3339:
-
Reopening to add support for optional enums.
> Support for database/sql
>
Github user Raynos commented on the pull request:
https://github.com/apache/thrift/pull/683#issuecomment-153534427
#legit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user breerly opened a pull request:
https://github.com/apache/thrift/pull/683
Deprecate this Apache Thrift Fork
We're finally to a place where we can deprecate this repo.
* Python & Node use
[thriftrw](https://github.com/search?utf8=%E2%9C%93=thriftrw).
* Go
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/680#issuecomment-153534017
:+1:
tested with autoconf running **make cross** and cmake **make** on Debian
Jessie amd64 with Python 2.7.9
-roger
---
If your project is set up for
Github user breerly closed the pull request at:
https://github.com/apache/thrift/pull/683
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kriskowal commented on the pull request:
https://github.com/apache/thrift/pull/683#issuecomment-153534454
:ok:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Raynos commented on the pull request:
https://github.com/apache/thrift/pull/683#issuecomment-153534582
#oops
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user bufferoverflow commented on the pull request:
https://github.com/apache/thrift/pull/672#issuecomment-153511243
Thanks for the PR!
We need a strong YES to according to the contribution guidelines as
mentioned here https://thrift.apache.org/docs/HowToContribute
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/678
THRIFT-3407 Refill buffer when JSON closing bracket is missing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3407
[
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987399#comment-14987399
]
ASF GitHub Bot commented on THRIFT-3407:
GitHub user nsuke opened a pull request:
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/681
THRIFT-3409 NodeJS binary field issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3409
Alternatively you can review and
[
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa closed THRIFT-338.
---
> Compact Protocol in Erlang
> --
>
> Key: THRIFT-338
>
Aki Sukegawa created THRIFT-3409:
Summary: NodeJS binary field issues
Key: THRIFT-3409
URL: https://issues.apache.org/jira/browse/THRIFT-3409
Project: Thrift
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/THRIFT-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987525#comment-14987525
]
ASF GitHub Bot commented on THRIFT-3409:
GitHub user nsuke opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987555#comment-14987555
]
ASF GitHub Bot commented on THRIFT-2423:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa resolved THRIFT-2423.
--
Resolution: Fixed
Assignee: Dave Watson
Committed, sorry for the delay. Thanks !
>
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/357#issuecomment-153356845
There were several build issues.
I'll commit the fixed version shortly after #677.
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/THRIFT-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987298#comment-14987298
]
Hudson commented on THRIFT-338:
---
SUCCESS: Integrated in Thrift #1707 (See
[
https://issues.apache.org/jira/browse/THRIFT-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987297#comment-14987297
]
ASF GitHub Bot commented on THRIFT-2423:
Github user nsuke commented on the pull request:
Aki Sukegawa created THRIFT-3407:
Summary: Refill buffer when JSON closing bracket is missing
Key: THRIFT-3407
URL: https://issues.apache.org/jira/browse/THRIFT-3407
Project: Thrift
Issue
[
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa updated THRIFT-3407:
-
Description:
NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller
[
https://issues.apache.org/jira/browse/THRIFT-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa updated THRIFT-3407:
-
Description:
NodeJS TJSONProtocol aborts reading when number of closing brackets is smaller
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/677
Thrift 2423 redux
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-2423-redux
Alternatively you can review and apply these
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/677
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
56 matches
Mail list logo
