[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148190#comment-15148190 ] ASF GitHub Bot commented on THRIFT-3636: Github user mygityf commented on the pull request:

[GitHub] thrift pull request: THRIFT-3636 The precision is 15 bits after do...

Github user mygityf commented on the pull request: https://github.com/apache/thrift/pull/870#issuecomment-184556899 @nsuke I replace the PI and golden ratio with float literals and use the same digits(17) in file lib/cpp/test/JSONProtoTest.cpp. The result looks OK in Jenkins

[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148179#comment-15148179 ] Hudson commented on THRIFT-3636: SUCCESS: Integrated in Thrift-precommit #160 (See

Jenkins build is back to normal : Thrift-precommit #160

See

Build failed in Jenkins: Thrift-precommit #159

See Changes: [voipman] THRIFT-3636 The precision is 15 bits after dot of casting from double to [voipman] THRIFT-3636 The precision is 15 bits after dot of casting from double to [voipman] THRIFT-3636 The precision is 15 bits after

[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148124#comment-15148124 ] Hudson commented on THRIFT-3636: FAILURE: Integrated in Thrift-precommit #159 (See

Re: [DISCUSSION] Patches and precommits

I am a big fan of the precommit as well (many thanks for that guys!). Creating a pull request is about the same friction as uploading a patch but the huge benefit at present is the build verification for pulls. If it leads to an ongoing stable build and a single CI solution I would +1 pull

Re: [DISCUSSION] Patches and precommits

We can attach jira to the precommit jenkins builds also, but would not be opposed to moving to all patches landing on github as long as the requirement of a jira being associated with each issue is maintained -Jake On Mon, Feb 15, 2016 at 4:53 PM, Jens Geyer wrote: > Hi

[jira] [Closed] (THRIFT-3419) thrift-maven-plugin property error

[ https://issues.apache.org/jira/browse/THRIFT-3419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chillon_m closed THRIFT-3419. - > thrift-maven-plugin property error > -- > > Key:

[jira] [Commented] (THRIFT-3630) Debian/Ubuntu install docs need an update

[ https://issues.apache.org/jira/browse/THRIFT-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148032#comment-15148032 ] Hudson commented on THRIFT-3630: FAILURE: Integrated in Thrift-precommit #158 (See

[jira] [Commented] (THRIFT-3638) Fix haxelib.json

[ https://issues.apache.org/jira/browse/THRIFT-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148033#comment-15148033 ] Hudson commented on THRIFT-3638: FAILURE: Integrated in Thrift-precommit #158 (See

Build failed in Jenkins: Thrift-precommit #158

See Changes: [ra] THRIFT-3630: Debian/Ubuntu Install doc update Client: Docs Patch: Randy [jensg] THRIFT-3638 Fix haxelib.json Client: Haxe Patch: Jens Geyer -- [...truncated 2884 lines...]

[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148019#comment-15148019 ] Hudson commented on THRIFT-3636: FAILURE: Integrated in Thrift-precommit #157 (See

Build failed in Jenkins: Thrift-precommit #157

See Changes: [voipman] THRIFT-3636 The precision is 15 bits after dot of casting from double to [voipman] THRIFT-3636 The precision is 15 bits after dot of casting from double to [voipman] THRIFT-3636 The precision is 15 bits after

[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148007#comment-15148007 ] ASF GitHub Bot commented on THRIFT-3636: Github user mygityf commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3636 The precision is 15 bits after do...

Github user mygityf commented on a diff in the pull request: https://github.com/apache/thrift/pull/870#discussion_r52961339 --- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp --- @@ -524,7 +524,8 @@ namespace { std::string doubleToString(double d) {

[jira] [Resolved] (THRIFT-3638) Fix haxelib.json

[ https://issues.apache.org/jira/browse/THRIFT-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3638. Resolution: Fixed Fix Version/s: 1.0 Committed. > Fix haxelib.json > > >

[jira] [Updated] (THRIFT-3638) Fix haxelib.json

[ https://issues.apache.org/jira/browse/THRIFT-3638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3638: --- Attachment: THRIFT-3638-Fix-haxelib.json.patch

[jira] [Created] (THRIFT-3637) Implement compact protocol for dart

Brian Shannan created THRIFT-3637: - Summary: Implement compact protocol for dart Key: THRIFT-3637 URL: https://issues.apache.org/jira/browse/THRIFT-3637 Project: Thrift Issue Type:

[jira] [Commented] (THRIFT-1667) Client side SASL transport for C++

[ https://issues.apache.org/jira/browse/THRIFT-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147823#comment-15147823 ] Jens Geyer commented on THRIFT-1667: [~prasadm], is this still valid? Do you mind rebasing your

Build failed in Jenkins: thrift #606

See Changes: [ra] THRIFT-3630: Debian/Ubuntu Install doc update Client: Docs Patch: Randy -- [...truncated 1675 lines...]

[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147623#comment-15147623 ] ASF GitHub Bot commented on THRIFT-3636: Github user hcorg commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3636 The precision is 15 bits after do...

Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/870#discussion_r52925705 --- Diff: lib/cpp/src/thrift/protocol/TJSONProtocol.cpp --- @@ -524,7 +524,8 @@ namespace { std::string doubleToString(double d) {

[jira] [Commented] (THRIFT-3636) The precision is 15 bits after dot of casting from double to string in Thrift-cpp-library- json-protocol.

[ https://issues.apache.org/jira/browse/THRIFT-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147576#comment-15147576 ] ASF GitHub Bot commented on THRIFT-3636: Github user nsuke commented on the pull request:

[GitHub] thrift pull request: THRIFT-3636 The precision is 15 bits after do...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/870#issuecomment-184295292 Actually test is failing quite badly. Your fix is fine but the test needs fix too. A possible fix is to replace the PI and golden ratio with float literals and use

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147564#comment-15147564 ] Aki Sukegawa commented on THRIFT-3620: -- Nice, adding CMake and make cross would become less than a

[jira] [Commented] (THRIFT-3620) Cleanup and consolidate Thrift* jenkins jobs.

[ https://issues.apache.org/jira/browse/THRIFT-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147394#comment-15147394 ] Jake Farrell commented on THRIFT-3620: -- the build should be in a docker container, not privileged.