[jira] [Updated] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3855: --- Priority: Minor (was: Major) > In the go simple server, if Stop() is called

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335346#comment-15335346 ] James E. King, III commented on THRIFT-3855: PR is out, was submitted without a Jira ticket:

[jira] [Created] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

James E. King, III created THRIFT-3855: -- Summary: In the go simple server, if Stop() is called multiple times it hangs Key: THRIFT-3855 URL: https://issues.apache.org/jira/browse/THRIFT-3855

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335344#comment-15335344 ] ASF GitHub Bot commented on THRIFT-3855: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1028#discussion_r67457396 --- Diff: lib/go/thrift/simple_server.go --- @@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error { } func (p *TSimpleServer) Stop()

[jira] [Commented] (THRIFT-1474) Not throw user defined exception when a defined method returns boolean result

[ https://issues.apache.org/jira/browse/THRIFT-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335334#comment-15335334 ] 朱孟柱 commented on THRIFT-1474: - I guess you mean the comment posted by jvines. I read it while I still think

[jira] [Commented] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions

[ https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335331#comment-15335331 ] James E. King, III commented on THRIFT-3831: I'd recommend you open a pull request for this.

[jira] [Commented] (THRIFT-3846) thriftClient connect some thriftServers cause IOException.

[ https://issues.apache.org/jira/browse/THRIFT-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335329#comment-15335329 ] James E. King, III commented on THRIFT-3846: I'm not aware of any limitations on the number

[jira] [Commented] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs

[ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335325#comment-15335325 ] James E. King, III commented on THRIFT-3784: I'd recommend that you rebase this against

[jira] [Updated] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs

[ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3784: --- Component/s: Java - Library > thrift-maven-plugin generates invalid include

[jira] [Updated] (THRIFT-3851) Golang thrift continually adds the x/thrift content type

[ https://issues.apache.org/jira/browse/THRIFT-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3851: --- Component/s: Go - Library > Golang thrift continually adds the x/thrift content type

[jira] [Commented] (THRIFT-3851) Golang thrift continually adds the x/thrift content type

[ https://issues.apache.org/jira/browse/THRIFT-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335321#comment-15335321 ] ASF GitHub Bot commented on THRIFT-3851: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1026: THRIFT-3851

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1026 We can ignore the failed apache jenkins build - as such this one looks okay from a build perspective. I would like someone with some go experience to code review it however. --- If your project

[jira] [Commented] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335318#comment-15335318 ] James E. King, III commented on THRIFT-3828: I would definitely recommend that you submit a

[jira] [Updated] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3828: --- Component/s: Build Process > cmake fails when Boost_INCLUDE_DIRS (and other

[jira] [Updated] (THRIFT-3835) Thrift generates javascript code for node js with error

[ https://issues.apache.org/jira/browse/THRIFT-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3835: --- Component/s: Node.js - Compiler > Thrift generates javascript code for node js with

[jira] [Updated] (THRIFT-3817) Redeclaration of std::tuple

[ https://issues.apache.org/jira/browse/THRIFT-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3817: --- Component/s: C++ - Library > Redeclaration of std::tuple >

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1028#discussion_r67456476 --- Diff: lib/go/thrift/simple_server.go --- @@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error { } func (p *TSimpleServer) Stop()

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

Github user huaiyun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1028#discussion_r67449308 --- Diff: lib/go/thrift/simple_server.go --- @@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error { } func (p *TSimpleServer) Stop()

[jira] [Comment Edited] (THRIFT-3826) Appveyor builds cannot download winflexbison properly

[ https://issues.apache.org/jira/browse/THRIFT-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335089#comment-15335089 ] James E. King, III edited comment on THRIFT-3826 at 6/17/16 12:35 AM:

[jira] [Commented] (THRIFT-3826) Appveyor builds cannot download winflexbison properly

[ https://issues.apache.org/jira/browse/THRIFT-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335089#comment-15335089 ] James E. King, III commented on THRIFT-3826: slproweb.com is not responsive right now, and it

[GitHub] thrift issue #1029: Use 'pre' HTML tag when generating non escaped documenta...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1029 This is for THRIFT-3823, you might want to change the pull request title. As for the Appveyor build failure, that's documented in THRIFT-3826 (related; I just added a comment). --- If your

[jira] [Commented] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335087#comment-15335087 ] ASF GitHub Bot commented on THRIFT-3823: Github user jeking3 commented on the issue:

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1028#discussion_r67445983 --- Diff: lib/go/thrift/simple_server.go --- @@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error { } func (p *TSimpleServer) Stop()

[GitHub] thrift issue #1028: MOD: fix the blocked bug when call Stop() twice or more

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1028 Is there an Apache Jira ticket for this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335068#comment-15335068 ] James E. King, III commented on THRIFT-3823: Was there something wrong with the change? >

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1028#discussion_r67445938 --- Diff: lib/go/thrift/simple_server.go --- @@ -22,11 +22,13 @@ package thrift import ( "log" "runtime/debug" + "sync/atomic"

[jira] [Commented] (THRIFT-1474) Not throw user defined exception when a defined method returns boolean result

[ https://issues.apache.org/jira/browse/THRIFT-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335058#comment-15335058 ] James E. King, III commented on THRIFT-1474: It looks like there's an open comment about the

[jira] [Commented] (THRIFT-3143) add typescript directory support

[ https://issues.apache.org/jira/browse/THRIFT-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335044#comment-15335044 ] ASF GitHub Bot commented on THRIFT-3143: Github user jeking3 commented on the issue:

[GitHub] thrift issue #488: THRIFT-3143

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/488 I'd recommend that you rebase your changes on the latest origin/master and push to make sure they are compatible with the development tip and pass all tests. --- If your project is set up for it,

[jira] [Updated] (THRIFT-3854) allow users to clear read buffers

[ https://issues.apache.org/jira/browse/THRIFT-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lockfort updated THRIFT-3854: --- Attachment: thrift-3854-clearable-read-buffers.patch > allow users to clear read buffers >

[jira] [Created] (THRIFT-3854) allow users to clear read buffers

Chris Lockfort created THRIFT-3854: -- Summary: allow users to clear read buffers Key: THRIFT-3854 URL: https://issues.apache.org/jira/browse/THRIFT-3854 Project: Thrift Issue Type:

[jira] [Resolved] (THRIFT-3750) NSCopying copyWithZone: implementation does not check isSet

[ https://issues.apache.org/jira/browse/THRIFT-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3750. Resolution: Fixed Assignee: Zach Howe Fix Version/s: (was: 1.0)

[jira] [Commented] (THRIFT-3750) NSCopying copyWithZone: implementation does not check isSet

[ https://issues.apache.org/jira/browse/THRIFT-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334598#comment-15334598 ] ASF GitHub Bot commented on THRIFT-3750: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #958: THRIFT-3750 Check isSet in copyWithZone to ensure ...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/958 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3753: --- Assignee: Ted Wang > TServerFramework::stop may fail to interrupt connected clients >

[jira] [Resolved] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3753. Resolution: Fixed Fix Version/s: 0.10.0 Committed, thanks! > TServerFramework::stop may

[jira] [Commented] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

[ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334590#comment-15334590 ] ASF GitHub Bot commented on THRIFT-3753: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #959: THRIFT-3753 Fixed a race condition in TServerFrame...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/959 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3768. Resolution: Fixed Fix Version/s: 0.10.0 Committed. That comment may be fixed later. >

[GitHub] thrift pull request #977: THRIFT-3768 fix TThreadedServer refactoring issues...

Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/977#discussion_r67414520 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.h --- @@ -20,19 +20,26 @@ #ifndef _THRIFT_SERVER_TTHREADEDSERVER_H_ #define

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334577#comment-15334577 ] ASF GitHub Bot commented on THRIFT-3768: Github user Jens-G commented on a diff in the pull

Re: Performance issue

Wow changed to TBinaryProtocolAccelerated and it went down to 1.5 seconds. Something very wrong with the default python implementation. On 16 June 2016 at 20:34, Glenn Pierce wrote: > The important profile lines are > >ncalls

Re: Performance issue

The important profile lines are ncalls tottime percall cumtime percall filename :lineno

Re: Performance issue

That code is only called once. All the time is spent after execution leaves my server function. So it is somewhere in the generated thrift code. Just to be certain I generated the test data at the start of the program like results = [('2016-05-20T14:01:01+', [2])] * 6 But I get the

Re: Performance issue

Hi Glenn, While two minutes is a little surprising, I suspect opening/closng the file every time the getData() method is called will be problematic. File open operations are usually an order of magnitude more expensive than file read or write operations. Try opening the file in the handler

Performance issue

Hi I wonder if someone could give advice on a performance issue I have. I have written a test case in Python The server is class TestServerThriftHandler(object): def getData(self): with open('data.json', 'r') as f: results = ujson.loads(f.read())

[jira] [Commented] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333788#comment-15333788 ] ASF GitHub Bot commented on THRIFT-3823: Github user hush-hush closed the pull request at:

[GitHub] thrift pull request #1029: Use 'pre' HTML tag when generating non escaped do...

GitHub user hush-hush opened a pull request: https://github.com/apache/thrift/pull/1029 Use 'pre' HTML tag when generating non escaped documentation. This allow clearer documentation and avoid adding HTML tag in the .thrift comments to generate readable HTML You can merge this

[GitHub] thrift pull request #1009: THRIFT-3823: Use 'pre' HTML tag when generating n...

Github user hush-hush closed the pull request at: https://github.com/apache/thrift/pull/1009 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1028: MOD: fix the blocked bug when call Stop() twice o...

GitHub user huaiyun opened a pull request: https://github.com/apache/thrift/pull/1028 MOD: fix the blocked bug when call Stop() twice or more When Stop() is called twice or more, and no new connection accepted from AcceptLoop(), the Stop() will be blocked because the quit channel