[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381003#comment-15381003 ] ASF GitHub Bot commented on THRIFT-3038: Github user jeking3 commented on the iss

[GitHub] thrift issue #981: THRIFT-3038: fix up some volatiles in cpp

2016-07-16 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/981 I am okay letting things default to something else here. I followed the boost examples and it passed the build with those settings. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380987#comment-15380987 ] ASF GitHub Bot commented on THRIFT-3038: Github user ben-craig commented on the i

[GitHub] thrift issue #981: THRIFT-3038: fix up some volatiles in cpp

2016-07-16 Thread ben-craig
Github user ben-craig commented on the issue: https://github.com/apache/thrift/pull/981 Unless you have extremely compelling profiling results, the only atomic memory order you should be using is memory_order_seq_cst. Even better, you get seq_cst for free as the default parameter of

[jira] [Created] (THRIFT-3882) Enable make cross tests that pass now

2016-07-16 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3882: -- Summary: Enable make cross tests that pass now Key: THRIFT-3882 URL: https://issues.apache.org/jira/browse/THRIFT-3882 Project: Thrift Issue Type

[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380799#comment-15380799 ] ASF GitHub Bot commented on THRIFT-3038: Github user jeking3 commented on the iss

[GitHub] thrift issue #981: THRIFT-3038: fix up some volatiles in cpp

2016-07-16 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/981 Quite interesting, the job that failed is related to the code changes but the error message comes from a version of boost before 1.53. It looks like that build job isn't making sure boost is at the

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380773#comment-15380773 ] ASF GitHub Bot commented on THRIFT-3876: Github user oprudkyi commented on a diff

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71066420 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport { }

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380767#comment-15380767 ] ASF GitHub Bot commented on THRIFT-3876: Github user oprudkyi commented on a diff

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71066333 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -39,12 +46,25 @@ class THttpClient extends TTransport { private var request

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71066191 --- Diff: test/haxe/src/Main.hx --- @@ -46,11 +46,14 @@ class Main if( args.printHelpOnly) return; +

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380760#comment-15380760 ] ASF GitHub Bot commented on THRIFT-3876: Github user oprudkyi commented on a diff

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380754#comment-15380754 ] ASF GitHub Bot commented on THRIFT-3876: Github user oprudkyi commented on a diff

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread oprudkyi
Github user oprudkyi commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71065930 --- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx --- @@ -24,6 +24,9 @@ import haxe.io.BytesBuffer; import haxe.io.Input; import ha

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380698#comment-15380698 ] ASF GitHub Bot commented on THRIFT-3876: Github user Jens-G commented on a diff i

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71064971 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -94,10 +114,241 @@ class THttpClient extends TTransport { }

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380696#comment-15380696 ] ASF GitHub Bot commented on THRIFT-3876: Github user Jens-G commented on a diff i

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71064942 --- Diff: lib/haxe/src/org/apache/thrift/transport/THttpClient.hx --- @@ -39,12 +46,25 @@ class THttpClient extends TTransport { private var requestBu

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380693#comment-15380693 ] ASF GitHub Bot commented on THRIFT-3876: Github user Jens-G commented on a diff i

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71064931 --- Diff: test/haxe/src/Main.hx --- @@ -46,11 +46,14 @@ class Main if( args.printHelpOnly) return; +

[jira] [Commented] (THRIFT-3876) haxe js/nodejs client

2016-07-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380692#comment-15380692 ] ASF GitHub Bot commented on THRIFT-3876: Github user Jens-G commented on a diff i

[GitHub] thrift pull request #1045: THRIFT-3876 haxe js/nodejs client

2016-07-16 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1045#discussion_r71064928 --- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx --- @@ -24,6 +24,9 @@ import haxe.io.BytesBuffer; import haxe.io.Input; import haxe