[jira] [Created] (THRIFT-3922) Cannot find symbol: class TSerializable when compiling generated java code

2016-09-07 Thread Chae Lee (JIRA)
Chae Lee created THRIFT-3922: Summary: Cannot find symbol: class TSerializable when compiling generated java code Key: THRIFT-3922 URL: https://issues.apache.org/jira/browse/THRIFT-3922 Project: Thrift

[jira] [Commented] (THRIFT-3163) Build failure due to ylwrap being called with wrong arguments

2016-09-07 Thread John Emmer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471943#comment-15471943 ] John Emmer commented on THRIFT-3163: I ran into the same issue with: Ubuntu 16.04.1 LTS (Kubuntu)

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471416#comment-15471416 ] ASF GitHub Bot commented on THRIFT-3921: Github user viveksjain commented on the issue:

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2016-09-07 Thread viveksjain
Github user viveksjain commented on the issue: https://github.com/apache/thrift/pull/1083 Yeah, as I mentioned on JIRA there may be backwards compatibility concerns. But from what I saw in the related [THRIFT-3336

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471380#comment-15471380 ] ASF GitHub Bot commented on THRIFT-3921: Github user viveksjain commented on a diff in the pull

[GitHub] thrift pull request #1083: THRIFT-3921 Add C++ ostream operator<< functions ...

2016-09-07 Thread viveksjain
Github user viveksjain commented on a diff in the pull request: https://github.com/apache/thrift/pull/1083#discussion_r77875285 --- Diff: compiler/cpp/src/generate/t_cpp_generator.cc --- @@ -541,6 +542,35 @@ void t_cpp_generator::generate_enum(t_enum* tenum) {

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471349#comment-15471349 ] ASF GitHub Bot commented on THRIFT-3921: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2016-09-07 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 I can see cases where someone relying on the enumeration's numeric output today would have a breaking change that they cannot easily avoid here. Changes like this one, for example the one that

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471337#comment-15471337 ] ASF GitHub Bot commented on THRIFT-3921: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1083: THRIFT-3921 Add C++ ostream operator<< functions ...

2016-09-07 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1083#discussion_r77873190 --- Diff: compiler/cpp/src/generate/t_cpp_generator.cc --- @@ -541,6 +542,35 @@ void t_cpp_generator::generate_enum(t_enum* tenum) { <<

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471280#comment-15471280 ] ASF GitHub Bot commented on THRIFT-3921: GitHub user viveksjain opened a pull request:

[GitHub] thrift pull request #1083: THRIFT-3921 Add C++ ostream operator<< functions ...

2016-09-07 Thread viveksjain
GitHub user viveksjain opened a pull request: https://github.com/apache/thrift/pull/1083 THRIFT-3921 Add C++ ostream operator<< functions for enums You can merge this pull request into a Git repository by running: $ git pull https://github.com/viveksjain/thrift THRIFT-3921

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread Vivek Jain (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471201#comment-15471201 ] Vivek Jain commented on THRIFT-3921: Yes, the idea is to use this just for human-readable printing.

[GitHub] thrift pull request #1082: THRIFT-3828 In cmake avoid use of both quoted pat...

2016-09-07 Thread jmesmon
GitHub user jmesmon opened a pull request: https://github.com/apache/thrift/pull/1082 THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with include_directories() This allows us to avoid issues where there are no paths to be added to the include path

[jira] [Commented] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

2016-09-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470983#comment-15470983 ] ASF GitHub Bot commented on THRIFT-3828: GitHub user jmesmon opened a pull request:

[jira] [Comment Edited] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470433#comment-15470433 ] James E. King, III edited comment on THRIFT-3921 at 9/7/16 12:15 PM: -

[jira] [Comment Edited] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470433#comment-15470433 ] James E. King, III edited comment on THRIFT-3921 at 9/7/16 12:13 PM: -

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2016-09-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470433#comment-15470433 ] James E. King, III commented on THRIFT-3921: Does THRIFT-3336 address your concern? > C++