[jira] [Commented] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions

2016-09-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478127#comment-15478127 ] ASF GitHub Bot commented on THRIFT-3831: GitHub user jmesmon opened a pull request:

[GitHub] thrift pull request #1085: THRIFT-3831 in test/cpp explicitly use `signed ch...

2016-09-09 Thread jmesmon
GitHub user jmesmon opened a pull request: https://github.com/apache/thrift/pull/1085 THRIFT-3831 in test/cpp explicitly use `signed char` `char`'s signed-ness is implimentation dependent, and in the case where `char` was not signed, we previously recieved errors like

[jira] [Commented] (THRIFT-3773) Swift Library

2016-09-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477946#comment-15477946 ] ASF GitHub Bot commented on THRIFT-3773: GitHub user apocolipse opened a pull request:

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-09-09 Thread apocolipse
GitHub user apocolipse opened a pull request: https://github.com/apache/thrift/pull/1084 THRIFT-3773 Swift 3 Native Library Here is my implementation of the Thrift library for Swift 3.0, pure swift. There is no Objective-C requirement here. For implementation and design