[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93389394 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

[jira] [Commented] (THRIFT-4004) ThreadManager deadlock when adding new task

2016-12-20 Thread Liu Lin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766327#comment-15766327 ] Liu Lin commented on THRIFT-4004: -- I have checked the lastest codes from github. The analysis still

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread guptanishank
Github user guptanishank commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93375825 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req =

[jira] [Commented] (THRIFT-3773) Swift Library

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765972#comment-15765972 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r93366730 --- Diff: lib/swift/Sources/TProtocolError.swift --- @@ -0,0 +1,146 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one +* or more

[jira] [Commented] (THRIFT-3773) Swift Library

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765971#comment-15765971 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on a diff in the pull

[jira] [Commented] (THRIFT-3773) Swift Library

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765970#comment-15765970 ] ASF GitHub Bot commented on THRIFT-3773: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r93367768 --- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc --- @@ -0,0 +1,2553 @@ +/* --- End diff -- Assigning simple "--gen swift" to

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93366270 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https) ?

Re: Update on Rust Thrift Generation

2016-12-20 Thread Jens Geyer
HI Allen, great to hear there's progress! I have to admit I haven't looked at the state of your code base. If at least binary is implemented working, plus framed transport, that would be Good Enough™ for a first merge, Compact and JSON would be really nice to have, but they can be integrated

[GitHub] thrift issue #1141: support for timeout in node http connection

2016-12-20 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1141 Thanks! Could you please file a JIRA ticket according to our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute)? @all: Anyone to comment on this? --- If your project is

Re: Releasing versioned client libraries as standalone git repos

2016-12-20 Thread Jens Geyer
+1 and adding Haxe to that list -Ursprüngliche Nachricht- From: Randy Abernethy Sent: Tuesday, December 20, 2016 12:59 AM To: Jake Farrell ; dev@thrift.apache.org Subject: Re: Releasing versioned client libraries as standalone git repos +1. !! On Dec 19, 2016 1:23 PM, "Jake Farrell"

[jira] [Commented] (THRIFT-4010) Q.fcall messing up with *this* pointer inside called function

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764231#comment-15764231 ] ASF GitHub Bot commented on THRIFT-4010: GitHub user brunomacf opened a pull request:

[GitHub] thrift pull request #1143: THRIFT-4010 Q.fcall messing up with *this* pointe...

2016-12-20 Thread brunomacf
GitHub user brunomacf opened a pull request: https://github.com/apache/thrift/pull/1143 THRIFT-4010 Q.fcall messing up with *this* pointer inside called func… Example: I define a basic service ``` namespace js Auth service AuthSrv { string signin(

[jira] [Created] (THRIFT-4010) Q.fcall messing up with *this* pointer inside called function

2016-12-20 Thread Bruno Fonseca (JIRA)
Bruno Fonseca created THRIFT-4010: - Summary: Q.fcall messing up with *this* pointer inside called function Key: THRIFT-4010 URL: https://issues.apache.org/jira/browse/THRIFT-4010 Project: Thrift

[jira] [Commented] (THRIFT-4009) Use @implementer instead of implements in TTwisted.py

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15764050#comment-15764050 ] ASF GitHub Bot commented on THRIFT-4009: GitHub user ciarancourtney opened a pull request:

[GitHub] thrift pull request #1142: THRIFT-4009: Use @implementer instead of implemen...

2016-12-20 Thread ciarancourtney
GitHub user ciarancourtney opened a pull request: https://github.com/apache/thrift/pull/1142 THRIFT-4009: Use @implementer instead of implements in TTwisted.py * As per zope.interface 4.0.0 changelog Deprecate the “class advice” APIs from zope.interface.declarations:

[jira] [Updated] (THRIFT-4009) Use @implementer instead of implements in TTwisted.py

2016-12-20 Thread Ciaran Courtney (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ciaran Courtney updated THRIFT-4009: Priority: Minor (was: Major) > Use @implementer instead of implements in TTwisted.py >

[jira] [Created] (THRIFT-4009) Use @implementer instead of implements in TTwisted.py

2016-12-20 Thread Ciaran Courtney (JIRA)
Ciaran Courtney created THRIFT-4009: --- Summary: Use @implementer instead of implements in TTwisted.py Key: THRIFT-4009 URL: https://issues.apache.org/jira/browse/THRIFT-4009 Project: Thrift